)]}'
{"devstack-vm-gate-wrap.sh":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"010bdc53b8e1c7393ca6d7b5f5053beb3e02be43","unresolved":false,"context_lines":[{"line_number":450,"context_line":"echo \"Setting up the hosts\""},{"line_number":451,"context_line":""},{"line_number":452,"context_line":"# little helper that runs anything passed in under tsfilter"},{"line_number":453,"context_line":"function run_command {"},{"line_number":454,"context_line":"    local fn\u003d\"$@\""},{"line_number":455,"context_line":"    local cmd\u003d\"\""},{"line_number":456,"context_line":""}],"source_content_type":"text/x-sh","patch_set":26,"id":"5ad0253b_2d4c8141","line":453,"updated":"2015-04-29 11:22:35.000000000","message":"so.... we\u0027ve got a lot of duplication on the ANSIBLE commands that remain, should we wrap more than just this inner part in a function?","commit_id":"f38ce9197ed8640d5738eba2efbb221f279c4f85"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"fcad9272c2ad5fcd35e4498a745fa6922803437f","unresolved":false,"context_lines":[{"line_number":450,"context_line":"echo \"Setting up the hosts\""},{"line_number":451,"context_line":""},{"line_number":452,"context_line":"# little helper that runs anything passed in under tsfilter"},{"line_number":453,"context_line":"function run_command {"},{"line_number":454,"context_line":"    local fn\u003d\"$@\""},{"line_number":455,"context_line":"    local cmd\u003d\"\""},{"line_number":456,"context_line":""}],"source_content_type":"text/x-sh","patch_set":26,"id":"3acd31a7_a61d5d68","line":453,"in_reply_to":"5ad0253b_2d4c8141","updated":"2015-04-30 02:38:32.000000000","message":"possibly, i\u0027d like to KISS for this and further changes can clean it up further","commit_id":"f38ce9197ed8640d5738eba2efbb221f279c4f85"}],"functions.sh":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"010bdc53b8e1c7393ca6d7b5f5053beb3e02be43","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        print"},{"line_number":72,"context_line":"        fflush()"},{"line_number":73,"context_line":"    }\u0027"},{"line_number":74,"context_line":"    return ${PIPESTATUS[0]}"},{"line_number":75,"context_line":"}"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"function _ping_check {"}],"source_content_type":"text/x-sh","patch_set":26,"id":"5ad0253b_227810c4","line":74,"updated":"2015-04-29 11:22:35.000000000","message":"I feel like this needs an inline comment, that\u0027s going to be considered magical later","commit_id":"f38ce9197ed8640d5738eba2efbb221f279c4f85"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"fcad9272c2ad5fcd35e4498a745fa6922803437f","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        print"},{"line_number":72,"context_line":"        fflush()"},{"line_number":73,"context_line":"    }\u0027"},{"line_number":74,"context_line":"    return ${PIPESTATUS[0]}"},{"line_number":75,"context_line":"}"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"function _ping_check {"}],"source_content_type":"text/x-sh","patch_set":26,"id":"3acd31a7_46044914","line":74,"in_reply_to":"5ad0253b_227810c4","updated":"2015-04-30 02:38:32.000000000","message":"Id5bd81f22678d23f72d5188267ff171d59e1a9ae","commit_id":"f38ce9197ed8640d5738eba2efbb221f279c4f85"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"010bdc53b8e1c7393ca6d7b5f5053beb3e02be43","unresolved":false,"context_lines":[{"line_number":257,"context_line":"            local swap\u003d${DEV}1"},{"line_number":258,"context_line":"            local lvmvol\u003d${DEV}2"},{"line_number":259,"context_line":"            local optdev\u003d${DEV}3"},{"line_number":260,"context_line":"            sudo umount ${DEV} || true"},{"line_number":261,"context_line":"            sudo parted ${DEV} --script -- mklabel msdos"},{"line_number":262,"context_line":"            sudo parted ${DEV} --script -- mkpart primary linux-swap 1 8192"},{"line_number":263,"context_line":"            sudo parted ${DEV} --script -- mkpart primary ext2 8192 32768"}],"source_content_type":"text/x-sh","patch_set":26,"id":"5ad0253b_025cf449","line":260,"updated":"2015-04-29 11:22:35.000000000","message":"a comment inline would be good.","commit_id":"f38ce9197ed8640d5738eba2efbb221f279c4f85"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"fcad9272c2ad5fcd35e4498a745fa6922803437f","unresolved":false,"context_lines":[{"line_number":257,"context_line":"            local swap\u003d${DEV}1"},{"line_number":258,"context_line":"            local lvmvol\u003d${DEV}2"},{"line_number":259,"context_line":"            local optdev\u003d${DEV}3"},{"line_number":260,"context_line":"            sudo umount ${DEV} || true"},{"line_number":261,"context_line":"            sudo parted ${DEV} --script -- mklabel msdos"},{"line_number":262,"context_line":"            sudo parted ${DEV} --script -- mkpart primary linux-swap 1 8192"},{"line_number":263,"context_line":"            sudo parted ${DEV} --script -- mkpart primary ext2 8192 32768"}],"source_content_type":"text/x-sh","patch_set":26,"id":"3acd31a7_66ff4502","line":260,"in_reply_to":"5ad0253b_025cf449","updated":"2015-04-30 02:38:32.000000000","message":"Id7d345130b751973d997940d7b62a4c253d265ed","commit_id":"f38ce9197ed8640d5738eba2efbb221f279c4f85"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"010bdc53b8e1c7393ca6d7b5f5053beb3e02be43","unresolved":false,"context_lines":[{"line_number":276,"context_line":"    # dump vm settings for reference (there is some sort of bug where"},{"line_number":277,"context_line":"    # sysctl gets bad reads on some parameters and exits with a"},{"line_number":278,"context_line":"    # failure, just ignore it, informational only)"},{"line_number":279,"context_line":"    sudo sysctl vm || true"},{"line_number":280,"context_line":"    # ensure a standard level of swappiness.  Some platforms"},{"line_number":281,"context_line":"    # (rax+centos7) come with swappiness of 0 (presumably because the"},{"line_number":282,"context_line":"    # vm doesn\u0027t come with swap setup ... but we just did that above),"}],"source_content_type":"text/x-sh","patch_set":26,"id":"5ad0253b_0223d4be","line":279,"updated":"2015-04-29 11:22:35.000000000","message":"I\u0027m confused why this can fail....","commit_id":"f38ce9197ed8640d5738eba2efbb221f279c4f85"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"fcad9272c2ad5fcd35e4498a745fa6922803437f","unresolved":false,"context_lines":[{"line_number":276,"context_line":"    # dump vm settings for reference (there is some sort of bug where"},{"line_number":277,"context_line":"    # sysctl gets bad reads on some parameters and exits with a"},{"line_number":278,"context_line":"    # failure, just ignore it, informational only)"},{"line_number":279,"context_line":"    sudo sysctl vm || true"},{"line_number":280,"context_line":"    # ensure a standard level of swappiness.  Some platforms"},{"line_number":281,"context_line":"    # (rax+centos7) come with swappiness of 0 (presumably because the"},{"line_number":282,"context_line":"    # vm doesn\u0027t come with swap setup ... but we just did that above),"}],"source_content_type":"text/x-sh","patch_set":26,"id":"3acd31a7_8303730f","line":279,"in_reply_to":"5ad0253b_0223d4be","updated":"2015-04-30 02:38:32.000000000","message":"I29385156a258bc604cf82f54ff98d81a22d38e5b","commit_id":"f38ce9197ed8640d5738eba2efbb221f279c4f85"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"010bdc53b8e1c7393ca6d7b5f5053beb3e02be43","unresolved":false,"context_lines":[{"line_number":445,"context_line":""},{"line_number":446,"context_line":"    # Move the PIP cache into position, if available"},{"line_number":447,"context_line":"    sudo mkdir -p /var/cache/pip"},{"line_number":448,"context_line":"    sudo mv ~/cache/pip/* /var/cache/pip || true"},{"line_number":449,"context_line":""},{"line_number":450,"context_line":"    # We set some home directories under $BASE, make sure it exists."},{"line_number":451,"context_line":"    sudo mkdir -p $BASE"}],"source_content_type":"text/x-sh","patch_set":26,"id":"5ad0253b_62128864","line":448,"updated":"2015-04-29 11:22:35.000000000","message":"I\u0027m confused why this can fail","commit_id":"f38ce9197ed8640d5738eba2efbb221f279c4f85"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"fcad9272c2ad5fcd35e4498a745fa6922803437f","unresolved":false,"context_lines":[{"line_number":445,"context_line":""},{"line_number":446,"context_line":"    # Move the PIP cache into position, if available"},{"line_number":447,"context_line":"    sudo mkdir -p /var/cache/pip"},{"line_number":448,"context_line":"    sudo mv ~/cache/pip/* /var/cache/pip || true"},{"line_number":449,"context_line":""},{"line_number":450,"context_line":"    # We set some home directories under $BASE, make sure it exists."},{"line_number":451,"context_line":"    sudo mkdir -p $BASE"}],"source_content_type":"text/x-sh","patch_set":26,"id":"3acd31a7_03176352","line":448,"in_reply_to":"5ad0253b_62128864","updated":"2015-04-30 02:38:32.000000000","message":"If444cf8fd495f495fc96e8b01cf11f3b311f46ca","commit_id":"f38ce9197ed8640d5738eba2efbb221f279c4f85"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"010bdc53b8e1c7393ca6d7b5f5053beb3e02be43","unresolved":false,"context_lines":[{"line_number":558,"context_line":""},{"line_number":559,"context_line":"function cleanup_host {"},{"line_number":560,"context_line":"    # TODO: clean this up to be errexit clean"},{"line_number":561,"context_line":"    set +o errexit"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":"    # Enabled detailed logging, since output of this function is redirected"},{"line_number":564,"context_line":"    local xtrace\u003d$(set +o | grep xtrace)"}],"source_content_type":"text/x-sh","patch_set":26,"id":"5ad0253b_ed1d6967","line":561,"updated":"2015-04-29 11:22:35.000000000","message":"this is going to globally turn off errexit for the rest of the run. It seems like we should set +o errexit at the caller instead of in the function to make that more clear.","commit_id":"f38ce9197ed8640d5738eba2efbb221f279c4f85"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"fcad9272c2ad5fcd35e4498a745fa6922803437f","unresolved":false,"context_lines":[{"line_number":558,"context_line":""},{"line_number":559,"context_line":"function cleanup_host {"},{"line_number":560,"context_line":"    # TODO: clean this up to be errexit clean"},{"line_number":561,"context_line":"    set +o errexit"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":"    # Enabled detailed logging, since output of this function is redirected"},{"line_number":564,"context_line":"    local xtrace\u003d$(set +o | grep xtrace)"}],"source_content_type":"text/x-sh","patch_set":26,"id":"3acd31a7_e613555b","line":561,"in_reply_to":"5ad0253b_ed1d6967","updated":"2015-04-30 02:38:32.000000000","message":"modified it to wrap the errexit.  not much happens after the cleanup_host so it doesn\u0027t make a big difference","commit_id":"f38ce9197ed8640d5738eba2efbb221f279c4f85"}]}