)]}'
{"id":"openstack%2Fdevstack-gate~183461","triplet_id":"openstack%2Fdevstack-gate~master~Ia6c890d2bda418a0d69f5ef4d0eb642afc50ca22","project":"openstack/devstack-gate","branch":"master","hashtags":[],"change_id":"Ia6c890d2bda418a0d69f5ef4d0eb642afc50ca22","subject":"Add a hook for job-dependent log collection.","status":"ABANDONED","created":"2015-05-15 10:08:43.000000000","updated":"2015-05-29 02:34:28.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"147faf667fa1abde523954e562fc809a72e500bb","_number":183461,"virtual_id_number":183461,"owner":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"value":1,"date":"2015-05-15 11:06:44.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"date":"2015-05-20 16:29:41.000000000","_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"recommended":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"disliked":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"all":[{"value":-1,"date":"2015-05-18 18:38:36.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2015-05-18 01:51:11.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-05-15 11:06:44.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2015-05-18 01:51:11.000000000","updated_by":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"reviewer":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"state":"REVIEWER"},{"updated":"2015-05-18 18:38:36.000000000","updated_by":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"reviewer":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"state":"REVIEWER"}],"messages":[{"id":"d8eee435141d8d75d888272857c48dbc50d7a59c","author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"date":"2015-05-15 10:08:43.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d6874d140a04703b62c13e1f5cbca52615a4a284","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-05-15 11:06:44.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- check-tempest-dsvm-full http://logs.openstack.org/61/183461/1/check/check-tempest-dsvm-full/8d71c2b/ : SUCCESS in 44m 49s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/61/183461/1/check/check-tempest-dsvm-postgres-full/84ede8f/ : SUCCESS in 44m 54s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/61/183461/1/check/check-tempest-dsvm-neutron-full/23e43c2/ : SUCCESS in 54m 21s\n- check-grenade-dsvm http://logs.openstack.org/61/183461/1/check/check-grenade-dsvm/a3f96b8/ : SUCCESS in 46m 18s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/61/183461/1/check/gate-tempest-dsvm-large-ops/04990c8/ : SUCCESS in 31m 03s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/61/183461/1/check/gate-tempest-dsvm-neutron-large-ops/f83338f/ : SUCCESS in 31m 11s\n- gate-devstack-gate-unittests http://logs.openstack.org/61/183461/1/check/gate-devstack-gate-unittests/5fb8773/ : SUCCESS in 18s\n- check-devstack-dsvm-cells http://logs.openstack.org/61/183461/1/check/check-devstack-dsvm-cells/f9c0fdd/ : SUCCESS in 25m 53s\n- check-dg-tempest-dsvm-full http://logs.openstack.org/61/183461/1/check/check-dg-tempest-dsvm-full/6603efe/ : SUCCESS in 43m 42s\n- check-dg-tempest-dsvm-full-reexec http://logs.openstack.org/61/183461/1/check/check-dg-tempest-dsvm-full-reexec/cfc150c/ : SUCCESS in 45m 29s\n- check-dg-hooks-dsvm http://logs.openstack.org/61/183461/1/check/check-dg-hooks-dsvm/a42562d/ : SUCCESS in 13m 18s\n- check-grenade-dsvm-partial-ncpu http://logs.openstack.org/61/183461/1/check/check-grenade-dsvm-partial-ncpu/1c1254e/ : SUCCESS in 43m 52s\n- check-neutron-dsvm-functional-nv http://logs.openstack.org/61/183461/1/check/check-neutron-dsvm-functional-nv/dd6dece/ : SUCCESS in 8m 49s (non-voting)\n- check-swift-dsvm-functional http://logs.openstack.org/61/183461/1/check/check-swift-dsvm-functional/d164b0b/ : SUCCESS in 26m 53s\n- check-tempest-dsvm-full-icehouse-nv http://logs.openstack.org/61/183461/1/check/check-tempest-dsvm-full-icehouse-nv/ba0d6fe/ : SUCCESS in 33m 23s (non-voting)\n- check-tempest-dsvm-neutron-icehouse-nv http://logs.openstack.org/61/183461/1/check/check-tempest-dsvm-neutron-icehouse-nv/56486f9/ : SUCCESS in 26m 01s (non-voting)\n- check-tempest-dsvm-postgres-full-icehouse-nv http://logs.openstack.org/61/183461/1/check/check-tempest-dsvm-postgres-full-icehouse-nv/2ba9b35/ : SUCCESS in 32m 27s (non-voting)\n- check-devstack-dsvm-cells-icehouse-nv http://logs.openstack.org/61/183461/1/check/check-devstack-dsvm-cells-icehouse-nv/c23605d/ : SUCCESS in 15m 17s (non-voting)\n- check-tempest-dsvm-full-juno-nv http://logs.openstack.org/61/183461/1/check/check-tempest-dsvm-full-juno-nv/8d6c25f/ : SUCCESS in 42m 55s (non-voting)\n- check-tempest-dsvm-neutron-full-juno-nv http://logs.openstack.org/61/183461/1/check/check-tempest-dsvm-neutron-full-juno-nv/78d3979/ : SUCCESS in 55m 50s (non-voting)\n- check-tempest-dsvm-postgres-full-juno-nv http://logs.openstack.org/61/183461/1/check/check-tempest-dsvm-postgres-full-juno-nv/707ce20/ : SUCCESS in 38m 58s (non-voting)\n- check-tempest-dsvm-full-kilo-nv http://logs.openstack.org/61/183461/1/check/check-tempest-dsvm-full-kilo-nv/edff3b2/ : SUCCESS in 46m 06s (non-voting)\n- check-tempest-dsvm-neutron-full-kilo-nv http://logs.openstack.org/61/183461/1/check/check-tempest-dsvm-neutron-full-kilo-nv/0dc43de/ : SUCCESS in 54m 39s (non-voting)\n- check-tempest-dsvm-postgres-full-kilo-nv http://logs.openstack.org/61/183461/1/check/check-tempest-dsvm-postgres-full-kilo-nv/4f85f8d/ : SUCCESS in 46m 20s (non-voting)\n- check-tempest-dsvm-ironic-pxe_ssh http://logs.openstack.org/61/183461/1/check/check-tempest-dsvm-ironic-pxe_ssh/3c7bdd6/ : SUCCESS in 37m 35s\n- check-tempest-dsvm-f21 http://logs.openstack.org/61/183461/1/check/check-tempest-dsvm-f21/8fe47e1/ : FAILURE in 43m 40s (non-voting)\n- check-tempest-dsvm-centos7 http://logs.openstack.org/61/183461/1/check/check-tempest-dsvm-centos7/0825e53/ : FAILURE in 46m 35s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"0b5b406c47240c5ae9741d66c237bb0e86e7e3ab","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2015-05-18 01:51:11.000000000","message":"Patch Set 1: Code-Review+1\n\ndocumentation on the hooks available would be nice; doesn\u0027t seem we have any","accounts_in_message":[],"_revision_number":1},{"id":"e718d10232711920e758d26dca96a6889a592414","author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"date":"2015-05-18 18:38:36.000000000","message":"Patch Set 1: Code-Review-1\n\nWe don\u0027t need a copy hook. You can just run code after d-g is done running to grab whatever logs you need. This can run regardless of job success or failure.","accounts_in_message":[],"_revision_number":1},{"id":"1d14c98ec71a35493454a66853575b0122ec6121","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2015-05-19 04:48:24.000000000","message":"Patch Set 1:\n\n@clark -- you can, but then you don\u0027t have access to the variables, have to do your own zipping, the output won\u0027t be logged automatically to a file like it is with the hook running function and everyone will choose to do it a little differently.\n\ni think this is a step in the right direction","accounts_in_message":[],"_revision_number":1},{"id":"c30d5aa682dd475aa1c10b83f066b00510849710","author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"date":"2015-05-20 16:29:41.000000000","message":"Patch Set 1:\n\nFor me the bigger question is the consistency; It seems that several job-specific copies have been added in here, which doesn\u0027t scale.  Rather than continuing to add job-specific copies here I think that having a hook to direct people to use would be more useful.","accounts_in_message":[],"_revision_number":1},{"id":"147faf667fa1abde523954e562fc809a72e500bb","author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"date":"2015-05-29 02:34:28.000000000","message":"Abandoned\n\nhttp://logs.openstack.xenproject.org/94/164494/19/check/dsvm-tempest-xen/735c6d0/logs/xen/index.html Added to the Xen CI","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"6bd3b9e863b6ab535708321a159096c00b12e0d1","revisions":{"6bd3b9e863b6ab535708321a159096c00b12e0d1":{"kind":"REWORK","_number":1,"created":"2015-05-15 10:08:43.000000000","uploader":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"ref":"refs/changes/61/183461/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack-gate","ref":"refs/changes/61/183461/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack-gate refs/changes/61/183461/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack-gate refs/changes/61/183461/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack-gate refs/changes/61/183461/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack-gate refs/changes/61/183461/1"}}},"commit":{"parents":[{"commit":"a84e6848e5c9c395f3f6b7a02c00008e5a52ec98","subject":"Replace ci.o.o links with docs.o.o/infra","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-gate/commit/a84e6848e5c9c395f3f6b7a02c00008e5a52ec98"}]}],"author":{"name":"Bob Ball","email":"bob.ball@citrix.com","date":"2015-05-15 10:06:20.000000000","tz":60},"committer":{"name":"Bob Ball","email":"bob.ball@citrix.com","date":"2015-05-15 10:06:20.000000000","tz":60},"subject":"Add a hook for job-dependent log collection.","message":"Add a hook for job-dependent log collection.\n\nAllows, for example, the libvirt+xen job to collect /var/log/xen\nwithout polluting the default set of logs collected\n\nChange-Id: Ia6c890d2bda418a0d69f5ef4d0eb642afc50ca22\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-gate/commit/6bd3b9e863b6ab535708321a159096c00b12e0d1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-gate/commit/6bd3b9e863b6ab535708321a159096c00b12e0d1"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}