)]}'
{"functions.sh":[{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"1b07d0b32483d8e80a6ef29ba305cb50c18ea6f3","unresolved":false,"context_lines":[{"line_number":359,"context_line":"        FALLBACK_ZUUL_REF\u003d$(echo $ZUUL_REF | sed -e \"s,$branch,master,\")"},{"line_number":360,"context_line":"    fi"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"    # If OVVERRIDE_ZUUL_REF doesn\u0027t exist, likely because ZUUL_BRACH isn\u0027t set"},{"line_number":363,"context_line":"    # just use the FALLBACK_ZUUL_REF and move on"},{"line_number":364,"context_line":"    if [[ -z OVERRIDE_ZUUL_REF ]] ; then"},{"line_number":365,"context_line":"        OVERRIDE_ZUUL_REF\u003d$FALLBACK_ZUUL_REF"}],"source_content_type":"text/x-sh","patch_set":1,"id":"fa32b979_83c46392","line":362,"updated":"2015-06-22 19:06:12.000000000","message":"typos in comment: OVVERRIDE_ZUUL_REF -\u003e OVERRIDE_ZUUL_REF;\nZUUL_BRACH -\u003e ZUUL_BRANCH\n\nadd comma at end EOL (after set)","commit_id":"a4953a63034e268365e28d5bdd5fd4b1989d232f"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"df3ed120de503df8f7bb2ba8cd6b300387ceeb1b","unresolved":false,"context_lines":[{"line_number":359,"context_line":"        FALLBACK_ZUUL_REF\u003d$(echo $ZUUL_REF | sed -e \"s,$branch,master,\")"},{"line_number":360,"context_line":"    fi"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"    # If OVVERRIDE_ZUUL_REF doesn\u0027t exist, likely because ZUUL_BRACH isn\u0027t set"},{"line_number":363,"context_line":"    # just use the FALLBACK_ZUUL_REF and move on"},{"line_number":364,"context_line":"    if [[ -z OVERRIDE_ZUUL_REF ]] ; then"},{"line_number":365,"context_line":"        OVERRIDE_ZUUL_REF\u003d$FALLBACK_ZUUL_REF"}],"source_content_type":"text/x-sh","patch_set":1,"id":"fa32b979_439f3b5f","line":362,"in_reply_to":"fa32b979_83c46392","updated":"2015-06-22 19:11:25.000000000","message":"Done","commit_id":"a4953a63034e268365e28d5bdd5fd4b1989d232f"},{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"71cf0a51466d0c2b1379bccb29629f43b06bae80","unresolved":false,"context_lines":[{"line_number":345,"context_line":"    fi"},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"    # Try the specified branch before the ZUUL_BRANCH."},{"line_number":348,"context_line":"    if [[ ! -z $ZUUL_BRANCH || \"$ZUUL_BRANCH\" !\u003d \"\" ]]; then"},{"line_number":349,"context_line":"        OVERRIDE_ZUUL_REF\u003d$(echo $ZUUL_REF | sed -e \"s,$ZUUL_BRANCH,$branch,\")"},{"line_number":350,"context_line":"    else"},{"line_number":351,"context_line":"        OVERRIDE_ZUUL_REF\u003d\"\""}],"source_content_type":"text/x-sh","patch_set":3,"id":"fa32b979_e97e3bae","line":348,"updated":"2015-06-23 18:33:53.000000000","message":"if [ -n \"$ZUUL_BRANCH\" ]; should be sufficient for this\n\n(notaminusone)","commit_id":"a96c5b4f77e8333d59d61b6d720508a385b12aaf"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"59cd5f1b6426b3b71a2c08dc17afeb278f6314ab","unresolved":false,"context_lines":[{"line_number":345,"context_line":"    fi"},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"    # Try the specified branch before the ZUUL_BRANCH."},{"line_number":348,"context_line":"    if [[ ! -z $ZUUL_BRANCH || \"$ZUUL_BRANCH\" !\u003d \"\" ]]; then"},{"line_number":349,"context_line":"        OVERRIDE_ZUUL_REF\u003d$(echo $ZUUL_REF | sed -e \"s,$ZUUL_BRANCH,$branch,\")"},{"line_number":350,"context_line":"    else"},{"line_number":351,"context_line":"        OVERRIDE_ZUUL_REF\u003d\"\""}],"source_content_type":"text/x-sh","patch_set":3,"id":"fa32b979_f4fdb2b1","line":348,"in_reply_to":"fa32b979_e97e3bae","updated":"2015-06-23 18:41:00.000000000","message":"Done","commit_id":"a96c5b4f77e8333d59d61b6d720508a385b12aaf"},{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"71cf0a51466d0c2b1379bccb29629f43b06bae80","unresolved":false,"context_lines":[{"line_number":364,"context_line":""},{"line_number":365,"context_line":"    # If OVERRIDE_ZUUL_REF doesn\u0027t exist, likely because ZUUL_BRANCH isn\u0027t set,"},{"line_number":366,"context_line":"    # just use the FALLBACK_ZUUL_REF and move on"},{"line_number":367,"context_line":"    if [[ \"$OVERRIDE_ZUUL_REF\" \u003d\u003d \"\" ]]; then"},{"line_number":368,"context_line":"        OVERRIDE_ZUUL_REF\u003d$FALLBACK_ZUUL_REF"},{"line_number":369,"context_line":"    fi"},{"line_number":370,"context_line":""}],"source_content_type":"text/x-sh","patch_set":3,"id":"fa32b979_a919138a","line":367,"updated":"2015-06-23 18:33:53.000000000","message":"This whole block can be replaced with OVERRIDE_ZUUL_REF\u003d${OVERRIDE_ZUUL_REF:-$FALLBACK_ZUUL_REF}\n\n(also notaminusone)","commit_id":"a96c5b4f77e8333d59d61b6d720508a385b12aaf"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"59cd5f1b6426b3b71a2c08dc17afeb278f6314ab","unresolved":false,"context_lines":[{"line_number":364,"context_line":""},{"line_number":365,"context_line":"    # If OVERRIDE_ZUUL_REF doesn\u0027t exist, likely because ZUUL_BRANCH isn\u0027t set,"},{"line_number":366,"context_line":"    # just use the FALLBACK_ZUUL_REF and move on"},{"line_number":367,"context_line":"    if [[ \"$OVERRIDE_ZUUL_REF\" \u003d\u003d \"\" ]]; then"},{"line_number":368,"context_line":"        OVERRIDE_ZUUL_REF\u003d$FALLBACK_ZUUL_REF"},{"line_number":369,"context_line":"    fi"},{"line_number":370,"context_line":""}],"source_content_type":"text/x-sh","patch_set":3,"id":"fa32b979_b432caa5","line":367,"in_reply_to":"fa32b979_a919138a","updated":"2015-06-23 18:41:00.000000000","message":"Done","commit_id":"a96c5b4f77e8333d59d61b6d720508a385b12aaf"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"8c38ae35148592833429f6e18c5ea66b69437622","unresolved":false,"context_lines":[{"line_number":345,"context_line":"    fi"},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"    # Try the specified branch before the ZUUL_BRANCH."},{"line_number":348,"context_line":"    if [[ ! -z $ZUUL_BRANCH ]]; then"},{"line_number":349,"context_line":"        OVERRIDE_ZUUL_REF\u003d$(echo $ZUUL_REF | sed -e \"s,$ZUUL_BRANCH,$branch,\")"},{"line_number":350,"context_line":"    else"},{"line_number":351,"context_line":"        OVERRIDE_ZUUL_REF\u003d\"\""}],"source_content_type":"text/x-sh","patch_set":4,"id":"fa32b979_9dea4673","line":348,"updated":"2015-06-23 21:50:37.000000000","message":"This test should likely be [[ -n \"$ZUUL_BRANCH\" ]], the quotes are important otherwise test will think there is a missing argument.\n\nIt isn\u0027t clear to me how this would pass tests unless the ! somehow magically unbreaks the broken -z test.","commit_id":"f1024957b315852d1dc79c51fed9ba0333d200e7"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"2ff7b8edd936dcb4879b332c860e3ca4cf7fac6f","unresolved":false,"context_lines":[{"line_number":345,"context_line":"    fi"},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"    # Try the specified branch before the ZUUL_BRANCH."},{"line_number":348,"context_line":"    if [[ ! -z $ZUUL_BRANCH ]]; then"},{"line_number":349,"context_line":"        OVERRIDE_ZUUL_REF\u003d$(echo $ZUUL_REF | sed -e \"s,$ZUUL_BRANCH,$branch,\")"},{"line_number":350,"context_line":"    else"},{"line_number":351,"context_line":"        OVERRIDE_ZUUL_REF\u003d\"\""}],"source_content_type":"text/x-sh","patch_set":4,"id":"fa32b979_606795e9","line":348,"in_reply_to":"fa32b979_9dea4673","updated":"2015-06-23 21:55:22.000000000","message":"Apparently test is smart here and does the correct thing with a non existent var when using -n and -z. This seems odd as other tests do not but maybe that is a difference between single param and multiple param tests?\n\nI do have a slight preference for -n over ! -z but not worth a new patchset for.","commit_id":"f1024957b315852d1dc79c51fed9ba0333d200e7"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"53ecc42ac9ad69cc534d22818ce4fd346a0bfcad","unresolved":false,"context_lines":[{"line_number":364,"context_line":""},{"line_number":365,"context_line":"    # If OVERRIDE_ZUUL_REF doesn\u0027t exist, likely because ZUUL_BRANCH isn\u0027t set,"},{"line_number":366,"context_line":"    # just use the FALLBACK_ZUUL_REF and move on"},{"line_number":367,"context_line":"    OVERRIDE_ZUUL_REF\u003d${OVERRIDE_ZUUL_REF:-$FALLBACK_ZUUL_REF}"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"    # See if Zuul prepared a ref for this project"},{"line_number":370,"context_line":"    if git_fetch_at_ref $project $OVERRIDE_ZUUL_REF || \\"}],"source_content_type":"text/x-sh","patch_set":4,"id":"fa32b979_31d32106","line":367,"updated":"2015-06-23 23:45:22.000000000","message":"I believe in the previous successful runs of this, both override and fallback were empty.  Even with this, I think we will often just be setting override to the empty string when fallback is.\n\nThis is probably harmless, but it adds uneeded logic to an already very confusing thing, and would prefer to avoid it so that we don\u0027t think it\u0027s necessary later.","commit_id":"f1024957b315852d1dc79c51fed9ba0333d200e7"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"c883743dbc7b8cfb78d2c9d1a3011c3297fcb366","unresolved":false,"context_lines":[{"line_number":364,"context_line":""},{"line_number":365,"context_line":"    # If OVERRIDE_ZUUL_REF doesn\u0027t exist, likely because ZUUL_BRANCH isn\u0027t set,"},{"line_number":366,"context_line":"    # just use the FALLBACK_ZUUL_REF and move on"},{"line_number":367,"context_line":"    OVERRIDE_ZUUL_REF\u003d${OVERRIDE_ZUUL_REF:-$FALLBACK_ZUUL_REF}"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"    # See if Zuul prepared a ref for this project"},{"line_number":370,"context_line":"    if git_fetch_at_ref $project $OVERRIDE_ZUUL_REF || \\"}],"source_content_type":"text/x-sh","patch_set":4,"id":"fa32b979_d10bd5d4","line":367,"updated":"2015-06-23 23:38:55.000000000","message":"This is a behavior change, why do this?","commit_id":"f1024957b315852d1dc79c51fed9ba0333d200e7"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"3943e9779692d3b749493b379c6338f53941ddd0","unresolved":false,"context_lines":[{"line_number":364,"context_line":""},{"line_number":365,"context_line":"    # If OVERRIDE_ZUUL_REF doesn\u0027t exist, likely because ZUUL_BRANCH isn\u0027t set,"},{"line_number":366,"context_line":"    # just use the FALLBACK_ZUUL_REF and move on"},{"line_number":367,"context_line":"    OVERRIDE_ZUUL_REF\u003d${OVERRIDE_ZUUL_REF:-$FALLBACK_ZUUL_REF}"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"    # See if Zuul prepared a ref for this project"},{"line_number":370,"context_line":"    if git_fetch_at_ref $project $OVERRIDE_ZUUL_REF || \\"}],"source_content_type":"text/x-sh","patch_set":4,"id":"fa32b979_d1951533","line":367,"in_reply_to":"fa32b979_d10bd5d4","updated":"2015-06-23 23:42:16.000000000","message":"So I don\u0027t think we ever had OVERRIDE_ZUUL_REF be empty before. Looking at the if below I just assumed that it would be better to just use the fallback up front then hoping doing a fetch on the project without specifying a specific ref did the right thing.","commit_id":"f1024957b315852d1dc79c51fed9ba0333d200e7"}]}