)]}'
{"devstack-vm-gate-wrap.sh":[{"author":{"_account_id":9453,"name":"James Polley","email":"jp@jamezpolley.com","username":"tchaypo"},"change_message_id":"5d8d4be1a2e318ce6dcfd65a74e6444ef10b598a","unresolved":false,"context_lines":[{"line_number":351,"context_line":"# Set to 1 if running the openstack/requirements integration test"},{"line_number":352,"context_line":"export DEVSTACK_GATE_REQS_INTEGRATION\u003d${DEVSTACK_GATE_REQS_INTEGRATION:-0}"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"# Set to soft if running the project is using libraries not specified in"},{"line_number":355,"context_line":"# global requirements, or strict to run the non-constraints"},{"line_number":356,"context_line":"# global-requirements code-path."},{"line_number":357,"context_line":"export REQUIREMENTS_MODE\u003d${REQUIREMENTS_MODE:-constraints}"}],"source_content_type":"text/x-sh","patch_set":2,"id":"fa32b979_8c00d267","line":354,"updated":"2015-06-24 00:39:10.000000000","message":"\u0027if running the project is using\u0027 doesn\u0027t make grammatical sense; I suspect this is meant to be \u0027if the project being run is using\u0027","commit_id":"64e747bf9f7884dd61eef16a6e8b70d88686d473"},{"author":{"_account_id":9453,"name":"James Polley","email":"jp@jamezpolley.com","username":"tchaypo"},"change_message_id":"5d8d4be1a2e318ce6dcfd65a74e6444ef10b598a","unresolved":false,"context_lines":[{"line_number":354,"context_line":"# Set to soft if running the project is using libraries not specified in"},{"line_number":355,"context_line":"# global requirements, or strict to run the non-constraints"},{"line_number":356,"context_line":"# global-requirements code-path."},{"line_number":357,"context_line":"export REQUIREMENTS_MODE\u003d${REQUIREMENTS_MODE:-constraints}"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"# Set to 0 to disable clean logs enforcement (3rd party CI might want to do this"},{"line_number":360,"context_line":"# until they get their driver cleaned up)"}],"source_content_type":"text/x-sh","patch_set":2,"id":"fa32b979_8ce9b2b9","line":357,"updated":"2015-06-24 00:39:10.000000000","message":"This value is neither \u0027soft\u0027 nor \u0027strict\u0027 so I\u0027m not sure what it\u0027s meant to do.\n\nPerhaps this is a tri-valued argument, where \u0027soft\u0027 does one thing, \u0027strict\u0027 another, and \u0027constraints\u0027 a third thing?","commit_id":"64e747bf9f7884dd61eef16a6e8b70d88686d473"},{"author":{"_account_id":9453,"name":"James Polley","email":"jp@jamezpolley.com","username":"tchaypo"},"change_message_id":"9771402dfd63d1cc851e5cdee2c71e4cae14a526","unresolved":false,"context_lines":[{"line_number":354,"context_line":"# Set to soft if running the project is using libraries not specified in"},{"line_number":355,"context_line":"# global requirements, or strict to run the non-constraints"},{"line_number":356,"context_line":"# global-requirements code-path."},{"line_number":357,"context_line":"export REQUIREMENTS_MODE\u003d${REQUIREMENTS_MODE:-constraints}"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"# Set to 0 to disable clean logs enforcement (3rd party CI might want to do this"},{"line_number":360,"context_line":"# until they get their driver cleaned up)"}],"source_content_type":"text/x-sh","patch_set":2,"id":"fa32b979_ac32760e","line":357,"in_reply_to":"fa32b979_8ce9b2b9","updated":"2015-06-24 00:48:54.000000000","message":"I see now that strict/soft/constraints are the values documented in stackrc in the change on which this one depends; Rather than duplicating docs perhaps it would be simpler to just add a pointer suggesting the reader look up the values documented in the sample stackrc?\n\nRegardless, since this is intended to be read with knowledge of those docs I think it\u0027s okay to let this land.","commit_id":"64e747bf9f7884dd61eef16a6e8b70d88686d473"}]}