)]}'
{"id":"openstack%2Fdevstack-gate~202745","triplet_id":"openstack%2Fdevstack-gate~master~I1c27e6728cccd13aaa03d782a7f6c27065e3447b","project":"openstack/devstack-gate","branch":"master","topic":"umount-ephemeral-drive","hashtags":[],"change_id":"I1c27e6728cccd13aaa03d782a7f6c27065e3447b","subject":"Unmount the ephemeral drive before formatting it","status":"MERGED","created":"2015-07-16 18:53:36.000000000","updated":"2015-07-17 01:35:29.000000000","submitted":"2015-07-17 01:35:28.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"93d070ce22082c0eaf874093223c907be1e47e89","_number":202745,"virtual_id_number":202745,"owner":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},{"value":0,"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":0,"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"value":2,"date":"2015-07-17 01:35:28.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"all":[{"value":2,"date":"2015-07-16 22:56:18.000000000","_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},{"value":2,"date":"2015-07-16 23:25:32.000000000","_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":0,"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2015-07-16 23:23:47.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"all":[{"value":0,"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},{"value":0,"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":1,"date":"2015-07-16 23:44:32.000000000","_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-07-16 22:56:18.000000000","updated_by":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"reviewer":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"state":"REVIEWER"},{"updated":"2015-07-16 23:23:47.000000000","updated_by":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"reviewer":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"state":"REVIEWER"},{"updated":"2015-07-16 23:25:32.000000000","updated_by":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"reviewer":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"state":"REVIEWER"},{"updated":"2015-07-17 01:35:28.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"ba4eece7a2ef82500341ec05f02a3c273f4163f1","author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"date":"2015-07-16 18:53:36.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2ad877c24767ca4a3ba4fd2f000e26e7fc3b305c","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2015-07-16 21:00:46.000000000","message":"Patch Set 1: Code-Review-1\n\nsomething must be going wrong, because i merged I3787d0f7e5139e891686ffbb2970e65d09f112b1 for this issue.\n\nwe should be removing the mount from fstab, and then the next stanza should stop the images from using meta-data.  so i think we should debug what\u0027s gone wrong in that path...","accounts_in_message":[],"_revision_number":1},{"id":"eef67193ccb7e53cbcc1a65f67c3d606d831d7ab","author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"date":"2015-07-16 22:46:51.000000000","message":"Patch Set 1: Workflow-1\n\nThere appears to be a preference to have nodepool\u0027s ready script do this instead (change number 202754.","accounts_in_message":[],"_revision_number":1},{"id":"237cd701b0a9c8672ddde1bad433b4de09382d03","author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"date":"2015-07-16 22:56:18.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"044166edd1f6b1f09cabc02745916864a4b0c5cb","author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"date":"2015-07-16 22:59:07.000000000","message":"Patch Set 1:\n\nI prefer this to the nodepool change in https://review.openstack.org/202754 because it is simpler, applies faster, and is more self-testing.","accounts_in_message":[],"_revision_number":1},{"id":"dcab0d31e629e3232ec50394efd44ffc35e66171","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2015-07-16 23:23:47.000000000","message":"Patch Set 1: -Code-Review\n\nwhat i missed is that configdrive is giving the data to get this mounted.\n\nmy preference is to leave this check in devstack-gate, because it catches when something has gone wrong with our assumptions around node setup.","accounts_in_message":[],"_revision_number":1},{"id":"c42c55ef23c0568596de62c199115867fff51016","author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"date":"2015-07-16 23:25:32.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"b82c2912997ce9d603764fd2036bbdff794d038b","author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"date":"2015-07-16 23:37:41.000000000","message":"Patch Set 1:\n\nFWIW I think we know when our nodes are misconfigured, its whenever cloud-init is used. Mordred has done work to move us away from cloud-init and it is close but needs some refinement around the edges. When we do make the switch to glean we can add a lot more strict checking around what our nodes look like before putting them into use.\n\nThe only other thing to consider with that is it is likely other groups/individuals will want to use d-g and may not wish to use glean, but we figure that out when it becomes a problem.","accounts_in_message":[],"_revision_number":1},{"id":"09c81fc901277153a6adce2d220370d4602bdcee","author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"date":"2015-07-16 23:44:32.000000000","message":"Patch Set 1: Workflow+1\n\nTurns out we prefer this change to 202754 approving it instead.","accounts_in_message":[],"_revision_number":1},{"id":"0f9fd76c3186364329ecf110eaad72a98714fe99","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-07-17 00:03:41.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-tempest-dsvm-full http://logs.openstack.org/45/202745/1/check/gate-tempest-dsvm-full/991821e/ : SUCCESS in 48m 26s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/45/202745/1/check/gate-tempest-dsvm-postgres-full/a619d35/ : SUCCESS in 52m 59s\n- gate-tempest-dsvm-neutron http://logs.openstack.org/45/202745/1/check/gate-tempest-dsvm-neutron/d7ddd7f/ : SUCCESS in 34m 44s\n- gate-tempest-dsvm-neutron-full http://logs.openstack.org/45/202745/1/check/gate-tempest-dsvm-neutron-full/88df30b/ : SUCCESS in 51m 57s\n- gate-grenade-dsvm http://logs.openstack.org/45/202745/1/check/gate-grenade-dsvm/cdb3736/ : SUCCESS in 47m 19s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/45/202745/1/check/gate-tempest-dsvm-large-ops/27905c0/ : SUCCESS in 36m 22s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/45/202745/1/check/gate-tempest-dsvm-neutron-large-ops/adeba3e/ : SUCCESS in 34m 16s\n- gate-devstack-gate-unittests http://logs.openstack.org/45/202745/1/check/gate-devstack-gate-unittests/49d4f54/ : SUCCESS in 18s\n- gate-devstack-dsvm-cells http://logs.openstack.org/45/202745/1/check/gate-devstack-dsvm-cells/68d8812/ : SUCCESS in 28m 09s\n- gate-dg-tempest-dsvm-full http://logs.openstack.org/45/202745/1/check/gate-dg-tempest-dsvm-full/fc4a14c/ : SUCCESS in 52m 53s\n- gate-dg-tempest-dsvm-full-reexec http://logs.openstack.org/45/202745/1/check/gate-dg-tempest-dsvm-full-reexec/64f1dc9/ : SUCCESS in 54m 06s\n- gate-dg-hooks-dsvm http://logs.openstack.org/45/202745/1/check/gate-dg-hooks-dsvm/b35a81d/ : SUCCESS in 8m 24s\n- gate-grenade-dsvm-partial-ncpu http://logs.openstack.org/45/202745/1/check/gate-grenade-dsvm-partial-ncpu/2a5ae83/ : SUCCESS in 50m 24s\n- gate-neutron-dsvm-functional-nv http://logs.openstack.org/45/202745/1/check/gate-neutron-dsvm-functional-nv/a83a828/ : SUCCESS in 9m 16s (non-voting)\n- gate-swift-dsvm-functional-nv http://logs.openstack.org/45/202745/1/check/gate-swift-dsvm-functional-nv/a3c0a80/ : SUCCESS in 33m 23s (non-voting)\n- gate-tempest-dsvm-full-juno-nv http://logs.openstack.org/45/202745/1/check/gate-tempest-dsvm-full-juno-nv/9596e14/ : SUCCESS in 37m 30s (non-voting)\n- gate-tempest-dsvm-neutron-full-juno-nv http://logs.openstack.org/45/202745/1/check/gate-tempest-dsvm-neutron-full-juno-nv/b1ea823/ : SUCCESS in 51m 30s (non-voting)\n- gate-tempest-dsvm-postgres-full-juno-nv http://logs.openstack.org/45/202745/1/check/gate-tempest-dsvm-postgres-full-juno-nv/aed766d/ : SUCCESS in 36m 51s (non-voting)\n- gate-tempest-dsvm-full-kilo-nv http://logs.openstack.org/45/202745/1/check/gate-tempest-dsvm-full-kilo-nv/1ce5892/ : SUCCESS in 47m 06s (non-voting)\n- gate-tempest-dsvm-neutron-full-kilo-nv http://logs.openstack.org/45/202745/1/check/gate-tempest-dsvm-neutron-full-kilo-nv/4740078/ : SUCCESS in 56m 42s (non-voting)\n- gate-tempest-dsvm-postgres-full-kilo-nv http://logs.openstack.org/45/202745/1/check/gate-tempest-dsvm-postgres-full-kilo-nv/1013473/ : SUCCESS in 48m 24s (non-voting)\n- gate-tempest-dsvm-ironic-pxe_ssh http://logs.openstack.org/45/202745/1/check/gate-tempest-dsvm-ironic-pxe_ssh/a971a4a/ : SUCCESS in 46m 52s\n- gate-tempest-dsvm-f21 http://logs.openstack.org/45/202745/1/check/gate-tempest-dsvm-f21/be3fd34/ : FAILURE in 58m 30s (non-voting)\n- gate-tempest-dsvm-centos7 http://logs.openstack.org/45/202745/1/check/gate-tempest-dsvm-centos7/d5be930/ : SUCCESS in 30m 43s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"9aeea76f88eccb4e03c457445112a55c664dbeff","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-07-17 00:03:47.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"e18fd43c15e4572d20bee122b5aac82e3c1e8863","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-07-17 01:35:28.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-tempest-dsvm-full http://logs.openstack.org/45/202745/1/gate/gate-tempest-dsvm-full/ca05abb/ : SUCCESS in 53m 51s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/45/202745/1/gate/gate-tempest-dsvm-postgres-full/229de8e/ : SUCCESS in 49m 24s\n- gate-tempest-dsvm-neutron http://logs.openstack.org/45/202745/1/gate/gate-tempest-dsvm-neutron/a879495/ : SUCCESS in 40m 40s\n- gate-tempest-dsvm-neutron-full http://logs.openstack.org/45/202745/1/gate/gate-tempest-dsvm-neutron-full/087a35d/ : SUCCESS in 1h 03m 17s\n- gate-grenade-dsvm http://logs.openstack.org/45/202745/1/gate/gate-grenade-dsvm/9b39458/ : SUCCESS in 46m 25s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/45/202745/1/gate/gate-tempest-dsvm-large-ops/95d5f13/ : SUCCESS in 37m 22s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/45/202745/1/gate/gate-tempest-dsvm-neutron-large-ops/47471c2/ : SUCCESS in 37m 06s\n- gate-devstack-gate-unittests http://logs.openstack.org/45/202745/1/gate/gate-devstack-gate-unittests/ceef949/ : SUCCESS in 11s\n- gate-devstack-dsvm-cells http://logs.openstack.org/45/202745/1/gate/gate-devstack-dsvm-cells/0cf6fb9/ : SUCCESS in 27m 22s\n- gate-grenade-dsvm-partial-ncpu http://logs.openstack.org/45/202745/1/gate/gate-grenade-dsvm-partial-ncpu/53501ab/ : SUCCESS in 48m 11s","accounts_in_message":[],"_revision_number":1},{"id":"fb4500eb5925a8158776b4724201a48126a6cfc3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-07-17 01:35:29.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"5a9565c8f746f4d514a2127860c79f5485a2c1bd","revisions":{"5a9565c8f746f4d514a2127860c79f5485a2c1bd":{"kind":"REWORK","_number":1,"created":"2015-07-16 18:53:36.000000000","uploader":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"ref":"refs/changes/45/202745/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack-gate","ref":"refs/changes/45/202745/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack-gate refs/changes/45/202745/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack-gate refs/changes/45/202745/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack-gate refs/changes/45/202745/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack-gate refs/changes/45/202745/1"}}},"commit":{"parents":[{"commit":"a63d4764ddc451680c222016be4a5394bbffe17b","subject":"Use blkid to find ephemeral disk on HP","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-gate/commit/a63d4764ddc451680c222016be4a5394bbffe17b"}]}],"author":{"name":"Clark Boylan","email":"clark.boylan@gmail.com","date":"2015-07-16 18:52:09.000000000","tz":-420},"committer":{"name":"Clark Boylan","email":"clark.boylan@gmail.com","date":"2015-07-16 18:52:09.000000000","tz":-420},"subject":"Unmount the ephemeral drive before formatting it","message":"Unmount the ephemeral drive before formatting it\n\nHPCloud is instructing cloud-init to mount the ephemeral drives now via\nmetadata. This means that the disk will be mounted by the time d-g runs\npreviously resulting in a failed job due to the return 1. Instead of\nerroring write a warning then unmount the ephemeral drive and format it.\n\nChange-Id: I1c27e6728cccd13aaa03d782a7f6c27065e3447b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-gate/commit/5a9565c8f746f4d514a2127860c79f5485a2c1bd"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-gate/commit/5a9565c8f746f4d514a2127860c79f5485a2c1bd"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}