)]}'
{"id":"openstack%2Fdevstack-gate~213028","triplet_id":"openstack%2Fdevstack-gate~master~I051944c5d410860c6d2fbb0a6ddf40dbcc95f3d1","project":"openstack/devstack-gate","branch":"master","topic":"api-workers","hashtags":[],"change_id":"I051944c5d410860c6d2fbb0a6ddf40dbcc95f3d1","subject":"Avoid using 0 as API_WORKERS","status":"ABANDONED","created":"2015-08-14 08:20:09.000000000","updated":"2015-08-19 03:20:33.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"07bf22b0b31184686600d757a5e9a8887be5c068","_number":213028,"virtual_id_number":213028,"owner":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"date":"2015-08-17 01:35:01.000000000","_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"value":1,"date":"2015-08-14 09:33:02.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},{"value":-1,"date":"2015-08-14 17:19:20.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-08-14 09:33:02.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2015-08-14 17:19:20.000000000","updated_by":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"reviewer":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"state":"REVIEWER"}],"messages":[{"id":"1ac25d6caed92c898d085f0dcb9a86a0bcc06536","author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"date":"2015-08-14 08:20:09.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8655540037e8d0c96ba8584780553ebe7bfa1f57","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-14 09:33:02.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-tempest-dsvm-full http://logs.openstack.org/28/213028/1/check/gate-tempest-dsvm-full/852bf3b/ : SUCCESS in 50m 29s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/28/213028/1/check/gate-tempest-dsvm-postgres-full/feb6119/ : SUCCESS in 45m 03s\n- gate-tempest-dsvm-neutron-full http://logs.openstack.org/28/213028/1/check/gate-tempest-dsvm-neutron-full/92a6f23/ : SUCCESS in 1h 10m 19s\n- gate-grenade-dsvm http://logs.openstack.org/28/213028/1/check/gate-grenade-dsvm/07e41d0/ : SUCCESS in 47m 17s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/28/213028/1/check/gate-tempest-dsvm-large-ops/ddc281e/ : SUCCESS in 34m 44s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/28/213028/1/check/gate-tempest-dsvm-neutron-large-ops/fbeff94/ : SUCCESS in 33m 20s\n- gate-devstack-gate-unittests http://logs.openstack.org/28/213028/1/check/gate-devstack-gate-unittests/73dc8c1/ : SUCCESS in 14s\n- gate-devstack-dsvm-cells http://logs.openstack.org/28/213028/1/check/gate-devstack-dsvm-cells/784f49b/ : SUCCESS in 28m 22s\n- gate-dg-hooks-dsvm http://logs.openstack.org/28/213028/1/check/gate-dg-hooks-dsvm/7573dfb/ : SUCCESS in 8m 47s\n- gate-grenade-dsvm-partial-ncpu http://logs.openstack.org/28/213028/1/check/gate-grenade-dsvm-partial-ncpu/5bd1ef8/ : SUCCESS in 56m 55s\n- gate-neutron-dsvm-functional-nv http://logs.openstack.org/28/213028/1/check/gate-neutron-dsvm-functional-nv/739d538/ : SUCCESS in 9m 38s (non-voting)\n- gate-swift-dsvm-functional-nv http://logs.openstack.org/28/213028/1/check/gate-swift-dsvm-functional-nv/7df3848/ : SUCCESS in 27m 25s (non-voting)\n- gate-tempest-dsvm-full-juno-nv http://logs.openstack.org/28/213028/1/check/gate-tempest-dsvm-full-juno-nv/7ed0720/ : SUCCESS in 42m 44s (non-voting)\n- gate-tempest-dsvm-neutron-full-juno-nv http://logs.openstack.org/28/213028/1/check/gate-tempest-dsvm-neutron-full-juno-nv/ce5b037/ : FAILURE in 1h 04m 03s (non-voting)\n- gate-tempest-dsvm-postgres-full-juno-nv http://logs.openstack.org/28/213028/1/check/gate-tempest-dsvm-postgres-full-juno-nv/d11b6d8/ : SUCCESS in 32m 21s (non-voting)\n- gate-tempest-dsvm-full-kilo-nv http://logs.openstack.org/28/213028/1/check/gate-tempest-dsvm-full-kilo-nv/ccfdb4e/ : SUCCESS in 49m 56s (non-voting)\n- gate-tempest-dsvm-neutron-full-kilo-nv http://logs.openstack.org/28/213028/1/check/gate-tempest-dsvm-neutron-full-kilo-nv/b51925e/ : SUCCESS in 46m 34s (non-voting)\n- gate-tempest-dsvm-postgres-full-kilo-nv http://logs.openstack.org/28/213028/1/check/gate-tempest-dsvm-postgres-full-kilo-nv/c2cb83e/ : SUCCESS in 39m 44s (non-voting)\n- gate-tempest-dsvm-ironic-pxe_ssh http://logs.openstack.org/28/213028/1/check/gate-tempest-dsvm-ironic-pxe_ssh/251b365/ : SUCCESS in 39m 11s\n- gate-tempest-dsvm-f21 http://logs.openstack.org/28/213028/1/check/gate-tempest-dsvm-f21/bc8da50/ : FAILURE in 35m 33s (non-voting)\n- gate-tempest-dsvm-centos7 http://logs.openstack.org/28/213028/1/check/gate-tempest-dsvm-centos7/708bf4b/ : SUCCESS in 31m 57s (non-voting)\n- gate-tempest-dsvm-multinode-full http://logs.openstack.org/28/213028/1/check/gate-tempest-dsvm-multinode-full/4b6b91d/ : SUCCESS in 58m 36s (non-voting)\n- gate-tempest-dsvm-neutron-multinode-full http://logs.openstack.org/28/213028/1/check/gate-tempest-dsvm-neutron-multinode-full/0a8b6eb/ : SUCCESS in 1h 04m 12s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"e2700120385ee27d91ca5ab93beb23737338ac1d","author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"date":"2015-08-14 17:19:20.000000000","message":"Patch Set 1: Code-Review-1\n\nWhile the todo says we can clean this up we just tried and it broke neutron advanced services. So we need to wait until neutron is actually ready to clean this up prior to moving forward.\n\nAs for what API WORKERS means I think that is a devstack/$project bug. It should mean the same thing across the board or devstack should understand what to do with it when they don\u0027t (but really why would it have different meanings).","accounts_in_message":[],"_revision_number":1},{"id":"751dfbe67f69e36ab52b9ec9e244cd2308e7d8ea","author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"date":"2015-08-17 01:35:01.000000000","message":"Patch Set 1:\n\nHi Clark Boylan, thanks for review, As the TODO said, the related bugs have been fixed, shouldn\u0027t this be removed ?\n\nThe 0 of API_WORKERS in some projects is in a wrong way of indicating the cpu number. like this:\n\n    CONF.xxx.workers or utils.cpu_count()\n\njust because the 0 is boolean False. well, some of these configure option has a min value of 1 ...","accounts_in_message":[],"_revision_number":1},{"id":"e86a778b6d9604c7b1b0d07b0a3cc245c512b61d","author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"date":"2015-08-17 02:09:08.000000000","message":"Patch Set 1:\n\nhow about change the 0 to 1 ?","accounts_in_message":[],"_revision_number":1},{"id":"a9b355340c29125cd54e4299839f16363abae0f4","author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"date":"2015-08-19 03:20:33.000000000","message":"Abandoned\n\nhttps://review.openstack.org/#/c/199672/","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"c3e6769da2c2e74200aa07051105afe8cfe60476","revisions":{"c3e6769da2c2e74200aa07051105afe8cfe60476":{"kind":"REWORK","_number":1,"created":"2015-08-14 08:20:09.000000000","uploader":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"ref":"refs/changes/28/213028/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack-gate","ref":"refs/changes/28/213028/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack-gate refs/changes/28/213028/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack-gate refs/changes/28/213028/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack-gate refs/changes/28/213028/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack-gate refs/changes/28/213028/1"}}},"commit":{"parents":[{"commit":"581689ff61d2a0425d7bd5262281abf23c488173","subject":"Merge \"Revert \"Temporarily add trove plugin configuration\"\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-gate/commit/581689ff61d2a0425d7bd5262281abf23c488173"}]}],"author":{"name":"liu-sheng","email":"liusheng@huawei.com","date":"2015-08-14 08:04:34.000000000","tz":480},"committer":{"name":"liu-sheng","email":"liusheng@huawei.com","date":"2015-08-14 08:18:55.000000000","tz":480},"subject":"Avoid using 0 as API_WORKERS","message":"Avoid using 0 as API_WORKERS\n\nThe 0 value of workers option will indicate different meaning in different\nprojects, In some case, min value of workers options is limited to 1.\n\nAnd also, according to the TODO item of this related change, the two\nrelated bug has been resolved. So we can remove the previous change.\n\nChange-Id: I051944c5d410860c6d2fbb0a6ddf40dbcc95f3d1\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-gate/commit/c3e6769da2c2e74200aa07051105afe8cfe60476"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-gate/commit/c3e6769da2c2e74200aa07051105afe8cfe60476"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}