)]}'
{"devstack-vm-gate-wrap.sh":[{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"7091d9475d25f08947258edda11d1c3540277371","unresolved":false,"context_lines":[{"line_number":227,"context_line":"export DEVSTACK_PROJECT_FROM_GIT\u003d${DEVSTACK_PROJECT_FROM_GIT:-}"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"# we run this script on other rhel-based OS unsupported in upstream,"},{"line_number":230,"context_line":"# define it as a Fedora by setting this var to non-zero"},{"line_number":231,"context_line":"export DEVSTACK_GATE_IS_FEDORA\u003d${DEVSTACK_GATE_IS_FEDORA:-0}"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"# The following variable is set for different directions of Grenade updating"}],"source_content_type":"text/x-sh","patch_set":2,"id":"da20952f_d31e476f","line":230,"updated":"2015-08-31 15:39:33.000000000","message":"Comment should be simplified to e.g. \"Set to \u00271\u0027 for force recognition of Fedora OS.\"\n\nBTW, the code looks for eq 1, not non-zero as the comment here states.","commit_id":"f49e5c13de22404db586f61ea57c3015c5076bce"},{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"39fee18678f423aa022fde1433c8e83dd019c9d5","unresolved":false,"context_lines":[{"line_number":226,"context_line":"# are we pulling any libraries from git"},{"line_number":227,"context_line":"export DEVSTACK_PROJECT_FROM_GIT\u003d${DEVSTACK_PROJECT_FROM_GIT:-}"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"# Set to non-zero to force recognition of Fedora OS"},{"line_number":230,"context_line":"export DEVSTACK_GATE_IS_FEDORA\u003d${DEVSTACK_GATE_IS_FEDORA:-}"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"# The following variable is set for different directions of Grenade updating"}],"source_content_type":"text/x-sh","patch_set":3,"id":"da20952f_ce62e83d","line":229,"updated":"2015-09-01 13:28:30.000000000","message":"To be consistent with the rest of the script, it would be better to set the default to zero and check for non-zero.","commit_id":"849873bb402f84243998635599823c82f204e4a0"}],"functions.sh":[{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"a6c4c4f09f1fae560c167c714445c45551bc1631","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    # note we consider CentOS 7 as fedora for now"},{"line_number":24,"context_line":"    lsb_release -i 2\u003e/dev/null | grep -iq \"fedora\" || \\"},{"line_number":25,"context_line":"        lsb_release -i 2\u003e/dev/null | grep -iq \"CentOS\" || \\"},{"line_number":26,"context_line":"        [[ -n \"$DEVSTACK_GATE_IS_FEDORA\" ]]"},{"line_number":27,"context_line":"}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"function is_ubuntu {"}],"source_content_type":"text/x-sh","patch_set":4,"id":"da20952f_472e7afb","line":26,"updated":"2015-09-02 15:56:20.000000000","message":"You didn\u0027t change this to look for non-zero","commit_id":"8447b64eb538c0a5edf1666e6ac9a26b1a46e309"},{"author":{"_account_id":13431,"name":"Evgeny Antyshev","email":"eantyshev@gmail.com","username":"eantyshev"},"change_message_id":"4751f6dd428095edeecff78782247a36ceedeebb","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    # note we consider CentOS 7 as fedora for now"},{"line_number":24,"context_line":"    lsb_release -i 2\u003e/dev/null | grep -iq \"fedora\" || \\"},{"line_number":25,"context_line":"        lsb_release -i 2\u003e/dev/null | grep -iq \"CentOS\" || \\"},{"line_number":26,"context_line":"        [[ -n \"$DEVSTACK_GATE_IS_FEDORA\" ]]"},{"line_number":27,"context_line":"}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"function is_ubuntu {"}],"source_content_type":"text/x-sh","patch_set":4,"id":"da20952f_9144b074","line":26,"in_reply_to":"da20952f_472e7afb","updated":"2015-09-03 08:26:42.000000000","message":"Indeed.\n\nBut I propose to leave DEVSTACK_GATE_IS_FEDORA a \u0027boolean\u0027 kind of variable: it is either defined to something then it\u0027s true, or not.\nLike these: DEVSTACK_PROJECT_FROM_GIT, DEVSTACK_GATE_GRENADE, etc.\n\nStrong reason for it is that I want is_fedora() to work properly even if DEVSTACK_GATE_IS_FEDORA is undefined. IMHO, this is more clearer logic than relying on it being 0 or 1, and keeping in mind it could be undefined if is_fedora() is called outside devstack-gate","commit_id":"8447b64eb538c0a5edf1666e6ac9a26b1a46e309"}]}