)]}'
{"id":"openstack%2Fdevstack-gate~232132","triplet_id":"openstack%2Fdevstack-gate~master~I541a66d81fab5be65bb9cd6684e00aa85c3283a9","project":"openstack/devstack-gate","branch":"master","hashtags":[],"change_id":"I541a66d81fab5be65bb9cd6684e00aa85c3283a9","subject":"Revert \"create partition for lvm volume\"","status":"MERGED","created":"2015-10-07 17:54:36.000000000","updated":"2015-10-19 16:55:55.000000000","submitted":"2015-10-19 16:55:51.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"37814a1a25689d86acdab9ae0324a25e263edc6b","_number":232132,"virtual_id_number":232132,"owner":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":2,"date":"2015-10-19 16:55:51.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2015-10-07 18:52:32.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"recommended":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"all":[{"value":1,"date":"2015-10-13 22:00:25.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2015-10-19 15:43:09.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":2,"date":"2015-10-07 19:08:54.000000000","_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"all":[{"value":0,"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2015-10-19 15:43:09.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-10-07 19:08:54.000000000","updated_by":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"reviewer":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"state":"REVIEWER"},{"updated":"2015-10-13 22:00:25.000000000","updated_by":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"reviewer":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"state":"REVIEWER"},{"updated":"2015-10-19 15:43:09.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"},{"updated":"2015-10-19 16:55:51.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"803ba80bd190a874662aa59e071267af456934ac","author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"date":"2015-10-07 17:54:36.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"deac5ec0ad519c9ba5373b0dee4802d71c2b0d25","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2015-10-07 18:52:32.000000000","message":"Patch Set 1:\n\nthe reason for this change was that doing block devices on top of loopbacks adds another layer in the block io in Linux. IIRC the data at the time seemed statistically significant that our volumes base failures went down after this.\n\nIt was long enough ago that I don\u0027t have those bits any more.","accounts_in_message":[],"_revision_number":1},{"id":"59914a253f4330c8637b316c575e2327068df582","author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"date":"2015-10-07 19:08:54.000000000","message":"Patch Set 1: Code-Review+2\n\nThis might be reasonable now that we\u0027re at the end of the cycle, and can collect some stats to see whether this is still a problem. Keeping the raw volume access means we can\u0027t use service providers who only provide a single device/partition for a root filesystem (at least not without some ugly new hacks to repartition the root device).","accounts_in_message":[],"_revision_number":1},{"id":"5b0cb357630809613cccaaafd72243c5d6f32c47","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-07 19:37:39.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-tempest-dsvm-full http://logs.openstack.org/32/232132/1/check/gate-tempest-dsvm-full/7802b05/ : SUCCESS in 45m 52s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/32/232132/1/check/gate-tempest-dsvm-postgres-full/7ba36b7/ : SUCCESS in 57m 50s\n- gate-tempest-dsvm-neutron-full http://logs.openstack.org/32/232132/1/check/gate-tempest-dsvm-neutron-full/8756282/ : SUCCESS in 1h 04m 35s\n- gate-grenade-dsvm http://logs.openstack.org/32/232132/1/check/gate-grenade-dsvm/47c1024/ : SUCCESS in 56m 23s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/32/232132/1/check/gate-tempest-dsvm-large-ops/747f733/ : SUCCESS in 31m 30s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/32/232132/1/check/gate-tempest-dsvm-neutron-large-ops/ddfc174/ : SUCCESS in 30m 34s\n- gate-devstack-gate-unittests http://logs.openstack.org/32/232132/1/check/gate-devstack-gate-unittests/3654915/ : SUCCESS in 7s\n- gate-dg-hooks-dsvm http://logs.openstack.org/32/232132/1/check/gate-dg-hooks-dsvm/3b0fbba/ : SUCCESS in 8m 29s\n- gate-grenade-dsvm-partial-ncpu http://logs.openstack.org/32/232132/1/check/gate-grenade-dsvm-partial-ncpu/7dd637a/ : SUCCESS in 1h 04m 48s\n- gate-neutron-dsvm-functional-nv http://logs.openstack.org/32/232132/1/check/gate-neutron-dsvm-functional-nv/d3043f1/ : SUCCESS in 14m 09s (non-voting)\n- gate-swift-dsvm-functional-nv http://logs.openstack.org/32/232132/1/check/gate-swift-dsvm-functional-nv/7899440/ : SUCCESS in 31m 10s (non-voting)\n- gate-tempest-dsvm-full-juno-nv http://logs.openstack.org/32/232132/1/check/gate-tempest-dsvm-full-juno-nv/e959e32/ : SUCCESS in 38m 09s (non-voting)\n- gate-tempest-dsvm-neutron-full-juno-nv http://logs.openstack.org/32/232132/1/check/gate-tempest-dsvm-neutron-full-juno-nv/54384c4/ : SUCCESS in 1h 15m 39s (non-voting)\n- gate-tempest-dsvm-postgres-full-juno-nv http://logs.openstack.org/32/232132/1/check/gate-tempest-dsvm-postgres-full-juno-nv/ee8d01f/ : SUCCESS in 42m 57s (non-voting)\n- gate-tempest-dsvm-full-kilo-nv http://logs.openstack.org/32/232132/1/check/gate-tempest-dsvm-full-kilo-nv/125cdf7/ : SUCCESS in 43m 30s (non-voting)\n- gate-tempest-dsvm-neutron-full-kilo-nv http://logs.openstack.org/32/232132/1/check/gate-tempest-dsvm-neutron-full-kilo-nv/9ef0819/ : SUCCESS in 1h 07m 41s (non-voting)\n- gate-tempest-dsvm-postgres-full-kilo-nv http://logs.openstack.org/32/232132/1/check/gate-tempest-dsvm-postgres-full-kilo-nv/fb5762a/ : SUCCESS in 50m 41s (non-voting)\n- gate-tempest-dsvm-full-liberty-nv http://logs.openstack.org/32/232132/1/check/gate-tempest-dsvm-full-liberty-nv/0e0c4da/ : SUCCESS in 44m 30s (non-voting)\n- gate-tempest-dsvm-neutron-full-liberty-nv http://logs.openstack.org/32/232132/1/check/gate-tempest-dsvm-neutron-full-liberty-nv/d5851d9/ : FAILURE in 1h 18m 23s (non-voting)\n- gate-tempest-dsvm-postgres-full-liberty-nv http://logs.openstack.org/32/232132/1/check/gate-tempest-dsvm-postgres-full-liberty-nv/ab38e0a/ : SUCCESS in 43m 00s (non-voting)\n- gate-tempest-dsvm-ironic-agent_ssh http://logs.openstack.org/32/232132/1/check/gate-tempest-dsvm-ironic-agent_ssh/aeb4de9/ : SUCCESS in 53m 27s\n- gate-tempest-dsvm-f21 http://logs.openstack.org/32/232132/1/check/gate-tempest-dsvm-f21/9905ab7/ : SUCCESS in 44m 00s (non-voting)\n- gate-tempest-dsvm-centos7 http://logs.openstack.org/32/232132/1/check/gate-tempest-dsvm-centos7/3775ef1/ : SUCCESS in 38m 19s (non-voting)\n- gate-tempest-dsvm-multinode-full http://logs.openstack.org/32/232132/1/check/gate-tempest-dsvm-multinode-full/2a97641/ : FAILURE in 1h 01m 39s (non-voting)\n- gate-tempest-dsvm-neutron-multinode-full http://logs.openstack.org/32/232132/1/check/gate-tempest-dsvm-neutron-multinode-full/b61e0cd/ : SUCCESS in 1h 03m 40s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"ba9678fc9cd3248eaaecccdb7a8951789f6a5132","author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"date":"2015-10-13 22:00:25.000000000","message":"Patch Set 1: Code-Review+1\n\nWhen we did this it was around the time we were having all sorts of LVM scan timeouts.  I believe that in the end what actually took care of that problem was the LVM filters, so as I result I think this is ok to remove.  \n\nWe may have to look at our devstack scripts and how the filters are setup to make sure everything still works, but IIRC I had accounted for both cases.","accounts_in_message":[],"_revision_number":1},{"id":"c8769b8d492baa98e40134f01939123ec739af6f","author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"date":"2015-10-13 22:20:25.000000000","message":"Patch Set 1:\n\nLGTM","accounts_in_message":[],"_revision_number":1},{"id":"43e86d66874f29a6ead35ec941b1a255a88a6cc7","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2015-10-19 15:43:09.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\ngood for giving this a spin and see what happens","accounts_in_message":[],"_revision_number":1},{"id":"e8a96772f0fcbd2263b44236d6b3247edf190c7a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-19 15:43:14.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"223ddd33a9b24087b748437fbe04c63ac919b400","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-19 16:55:51.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-tempest-dsvm-full http://logs.openstack.org/32/232132/1/gate/gate-tempest-dsvm-full/5812e15/ : SUCCESS in 41m 25s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/32/232132/1/gate/gate-tempest-dsvm-postgres-full/7324956/ : SUCCESS in 43m 37s\n- gate-tempest-dsvm-neutron-full http://logs.openstack.org/32/232132/1/gate/gate-tempest-dsvm-neutron-full/0390752/ : SUCCESS in 1h 11m 27s\n- gate-grenade-dsvm http://logs.openstack.org/32/232132/1/gate/gate-grenade-dsvm/de47f6a/ : SUCCESS in 1h 04m 57s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/32/232132/1/gate/gate-tempest-dsvm-large-ops/e0408dd/ : SUCCESS in 34m 41s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/32/232132/1/gate/gate-tempest-dsvm-neutron-large-ops/3d001c8/ : SUCCESS in 33m 58s\n- gate-devstack-gate-unittests http://logs.openstack.org/32/232132/1/gate/gate-devstack-gate-unittests/a95c2e7/ : SUCCESS in 10s\n- gate-grenade-dsvm-partial-ncpu http://logs.openstack.org/32/232132/1/gate/gate-grenade-dsvm-partial-ncpu/dc2f615/ : SUCCESS in 55m 17s","accounts_in_message":[],"_revision_number":1},{"id":"37814a1a25689d86acdab9ae0324a25e263edc6b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-19 16:55:55.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"b46a635c7531ba8a71663791e3f51ed8a44cb13f","revisions":{"b46a635c7531ba8a71663791e3f51ed8a44cb13f":{"kind":"REWORK","_number":1,"created":"2015-10-07 17:54:36.000000000","uploader":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"ref":"refs/changes/32/232132/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack-gate","ref":"refs/changes/32/232132/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack-gate refs/changes/32/232132/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack-gate refs/changes/32/232132/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack-gate refs/changes/32/232132/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack-gate refs/changes/32/232132/1"}}},"commit":{"parents":[{"commit":"fbbefeaba91f7d5ccf3c99ad5feeb50a9e62f554","subject":"Expand multinode network documentation.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-gate/commit/fbbefeaba91f7d5ccf3c99ad5feeb50a9e62f554"}]}],"author":{"name":"James E. Blair","email":"jeblair@linux.vnet.ibm.com","date":"2015-10-07 17:51:44.000000000","tz":-420},"committer":{"name":"James E. Blair","email":"jeblair@linux.vnet.ibm.com","date":"2015-10-07 17:52:15.000000000","tz":-420},"subject":"Revert \"create partition for lvm volume\"","message":"Revert \"create partition for lvm volume\"\n\nThis reverts commit 034189ec041aca5740c1689f3034f9b2e9d4418e.\n\nThis change was made with the justification that it would make\ncinder use \"a bit more optimized\" and that it \"may impact reliability\nfor good\".  There was a link in a review comment to a bug that did\nnot appear to have any relevance.\n\nIn short, this change added both complexity and essentially a test\nenvironment requirement for a second volume.  Perhaps we need that,\nbut if we are going to establish that as a requirement, we should\nhave some evidence to back up the performance claims.\n\nChange-Id: I541a66d81fab5be65bb9cd6684e00aa85c3283a9\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-gate/commit/b46a635c7531ba8a71663791e3f51ed8a44cb13f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-gate/commit/b46a635c7531ba8a71663791e3f51ed8a44cb13f"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
