)]}'
{"devstack-vm-gate.sh":[{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"825fd88ef6b7948ddc8036909c552a860ad1af8a","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    # by default."},{"line_number":71,"context_line":"    # TODO (clarkb): figure out how to make bridge setup sane with ansible."},{"line_number":72,"context_line":"    local br_pub_exists\u003d$(ifconfig | grep br_pub | awk \u0027{print $1}\u0027 2\u003e/dev/null | grep -iq \"br_pub\")"},{"line_number":73,"context_line":"    local br_flat_exists\u003d$(ifconfig | grep br_flat | awk \u0027{print $1}\u0027 2\u003e/dev/null | grep -iq \"br_flat\")"},{"line_number":74,"context_line":"    if ! $br_pub_exists ; then"},{"line_number":75,"context_line":"    \tovs_gre_bridge \"br_pub\" $primary_node \"True\" 1 \\"},{"line_number":76,"context_line":"                   \t$FLOATING_HOST_PREFIX $FLOATING_HOST_MASK \\"}],"source_content_type":"text/x-sh","patch_set":1,"id":"7a2fa921_52da1518","line":73,"updated":"2015-10-09 20:44:22.000000000","message":"I would suggest \"ip link show dev br_pub\" and \"ip link show dev br_flat\" instead of \"ifconfig\" since you can check the exit status of the command instead of all these awk and greps","commit_id":"62c19dfd648b45c5ae2114353c14122c4efca1c7"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"35256637077d08b2b97da0e694bd27bfd6fc6e11","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    # by default."},{"line_number":71,"context_line":"    # TODO (clarkb): figure out how to make bridge setup sane with ansible."},{"line_number":72,"context_line":"    local br_pub_exists\u003d$(ip link show dev br_pub 1\u003e/dev/null 2\u003e\u00261)"},{"line_number":73,"context_line":"    if ! $br_pub_exists ; then"},{"line_number":74,"context_line":"        ovs_gre_bridge \"br_pub\" $primary_node \"True\" 1 \\"},{"line_number":75,"context_line":"                       $FLOATING_HOST_PREFIX $FLOATING_HOST_MASK \\"},{"line_number":76,"context_line":"                       $sub_nodes"}],"source_content_type":"text/x-sh","patch_set":3,"id":"7a2fa921_e1f55fcb","line":73,"updated":"2015-10-12 15:08:36.000000000","message":"The problem with this approach is that we only fix nova net and not neutron. I think we should make ovs_gre_bridge smarter and handle this instead so that any user of the function gets functioning tunnels without error.","commit_id":"00ff9403e0d2af20730be9313d4988363a131227"}],"functions.sh":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"35256637077d08b2b97da0e694bd27bfd6fc6e11","unresolved":false,"context_lines":[{"line_number":969,"context_line":"    sudo ovs-vsctl --may-exist add-br $bridge_name"},{"line_number":970,"context_line":"    # as for the mtu, look for notes on lp#1301958 in devstack-vm-gate.sh"},{"line_number":971,"context_line":"    sudo ip link set mtu $mtu dev $bridge_name"},{"line_number":972,"context_line":"    if [[ \"$set_ips\" \u003d\u003d \"True\" ]] ; then"},{"line_number":973,"context_line":"        sudo ip addr add ${pub_addr_prefix}.${offset}/${pub_addr_mask} dev ${bridge_name}"},{"line_number":974,"context_line":"    fi"},{"line_number":975,"context_line":"    for node_ip in $peer_ips; do"}],"source_content_type":"text/x-sh","patch_set":3,"id":"7a2fa921_e1c0ff7e","line":972,"updated":"2015-10-12 15:08:36.000000000","message":"If this is the command causing problems we should update the conditional here to:\n\n  if [[ \"$set_ips\" \u003d\u003d \"True\" ]] \u0026\u0026 ip addr show dev $bridge_name | grep -qv ${pub_addr_prefix}.${offset}/${pub_addr_mask} ; then\n      # add IP here.\n\nThis way the function itself can determine if it needs to do any work.","commit_id":"00ff9403e0d2af20730be9313d4988363a131227"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"35256637077d08b2b97da0e694bd27bfd6fc6e11","unresolved":false,"context_lines":[{"line_number":999,"context_line":"            -- set interface ${bridge_name}_${host_ip} type\u003dgre \\"},{"line_number":1000,"context_line":"            options:remote_ip\u003d${host_ip} \\"},{"line_number":1001,"context_line":"            options:key\u003d${offset} \\"},{"line_number":1002,"context_line":"            options:local_ip\u003d${node_ip}"},{"line_number":1003,"context_line":"        if [[ \"$set_ips\" \u003d\u003d \"True\" ]] ; then"},{"line_number":1004,"context_line":"            remote_command $node_ip \\"},{"line_number":1005,"context_line":"                sudo ip addr add ${pub_addr_prefix}.${offset}/${pub_addr_mask} \\"}],"source_content_type":"text/x-sh","patch_set":3,"id":"7a2fa921_613b8f9d","line":1002,"updated":"2015-10-12 15:08:36.000000000","message":"See above.","commit_id":"00ff9403e0d2af20730be9313d4988363a131227"}]}