)]}'
{"devstack-vm-gate-wrap.sh":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"9f48cffae396107b5e2edca6448bd79b60a7c8f6","unresolved":false,"context_lines":[{"line_number":351,"context_line":""},{"line_number":352,"context_line":"# Run pre-devstack hook if we have one"},{"line_number":353,"context_line":"if [ \"$DEVSTACK_GATE_PRE_DEVSTACK_HOOK\" -eq 1 ]; then"},{"line_number":354,"context_line":"  run_pre_devstack_hook"},{"line_number":355,"context_line":"fi"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"# Run the test"}],"source_content_type":"text/x-sh","patch_set":2,"id":"AAAAN3%2F%2F0GM%3D","line":354,"updated":"2013-03-11 17:27:18.000000000","message":"Where is this hook set?","commit_id":"0157c623912e26ad42a58040613eff9a75b8ab02"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"9f48cffae396107b5e2edca6448bd79b60a7c8f6","unresolved":false,"context_lines":[{"line_number":360,"context_line":""},{"line_number":361,"context_line":"# Run post-devstack hook if we have one"},{"line_number":362,"context_line":"if [ $RETVAL -eq 0 -a \"$DEVSTACK_GATE_POST_DEVSTACK_HOOK\" -e 1 ]; then"},{"line_number":363,"context_line":"  run_post_devstack_hook"},{"line_number":364,"context_line":"  RETVAL\u003d$?"},{"line_number":365,"context_line":"fi"},{"line_number":366,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"AAAAN3%2F%2F0GA%3D","line":363,"updated":"2013-03-11 17:27:18.000000000","message":"Where is this hook set?","commit_id":"0157c623912e26ad42a58040613eff9a75b8ab02"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"de31727bf9a1b163b0d28d7ef61ddb197391a97c","unresolved":false,"context_lines":[{"line_number":392,"context_line":""},{"line_number":393,"context_line":"# Run pre-devstack hook if we have one"},{"line_number":394,"context_line":"if [ \"$DEVSTACK_GATE_PRE_DEVSTACK_HOOK\" -eq 1 ]; then"},{"line_number":395,"context_line":"  run_pre_devstack_hook"},{"line_number":396,"context_line":"fi"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"# Run the test"}],"source_content_type":"text/x-sh","patch_set":3,"id":"AAAAPH%2F%2Fzss%3D","line":395,"updated":"2013-05-22 16:04:35.000000000","message":"I think it would be better to:\n\n  if run_pre_test_hook is a defined function:\n    run_pre_test_hook \u0026\u003e\u003e $WORKSPACE/logs/devstack-gate-setup-host.txt","commit_id":"6075625265540e5d57f8579180893aa540b372bf"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"de31727bf9a1b163b0d28d7ef61ddb197391a97c","unresolved":false,"context_lines":[{"line_number":396,"context_line":"fi"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"# Run the test"},{"line_number":399,"context_line":"$DEVSTACK_GATE_GATE_COMMAND"},{"line_number":400,"context_line":"RETVAL\u003d$?"},{"line_number":401,"context_line":""},{"line_number":402,"context_line":"# Run post-devstack hook if we have one"}],"source_content_type":"text/x-sh","patch_set":3,"id":"AAAAPH%2F%2Fzsc%3D","line":399,"updated":"2013-05-22 16:04:35.000000000","message":"I think it would be better if the 3 hook points were all functions, so if a \"run_test_hook\" function is defined, run it here, otherwise run the default.","commit_id":"6075625265540e5d57f8579180893aa540b372bf"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"de31727bf9a1b163b0d28d7ef61ddb197391a97c","unresolved":false,"context_lines":[{"line_number":402,"context_line":"# Run post-devstack hook if we have one"},{"line_number":403,"context_line":"if [ $RETVAL -eq 0 -a \"$DEVSTACK_GATE_POST_DEVSTACK_HOOK\" -e 1 ]; then"},{"line_number":404,"context_line":"  run_post_devstack_hook"},{"line_number":405,"context_line":"  RETVAL\u003d$?"},{"line_number":406,"context_line":"fi"},{"line_number":407,"context_line":""},{"line_number":408,"context_line":"cleanup_host \u0026\u003e $WORKSPACE/logs/devstack-gate-cleanup-host.txt"}],"source_content_type":"text/x-sh","patch_set":3,"id":"AAAAPH%2F%2FzsQ%3D","line":405,"updated":"2013-05-22 16:04:35.000000000","message":"same as pre.","commit_id":"6075625265540e5d57f8579180893aa540b372bf"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"5cd94435280d6066f5c65a5c8d6b9e6c3e226cf2","unresolved":false,"context_lines":[{"line_number":402,"context_line":"RETVAL\u003d$?"},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"# Run post test hook if we have one"},{"line_number":405,"context_line":"if [ $RETVAL -eq 0 \u0026\u0026 function_exists \"post_test_hook\" ]; then"},{"line_number":406,"context_line":"  post_test_hook"},{"line_number":407,"context_line":"  RETVAL\u003d$?"},{"line_number":408,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":5,"id":"AAAAPH%2F%2FpsI%3D","line":405,"updated":"2013-05-28 15:28:15.000000000","message":"The test output says:\n\n  2013-05-24 18:40:16.072 | /opt/stack/new/devstack-gate/devstack-vm-gate-wrap.sh: line 405: [: missing `]\u0027","commit_id":"387cc4c5d31e6698f992a2babd3f49d66c5e29dd"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"b5991412cd2428cc3e7cfa17c312fad18b703fff","unresolved":false,"context_lines":[{"line_number":402,"context_line":"RETVAL\u003d$?"},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"# Run post test hook if we have one"},{"line_number":405,"context_line":"if [ $RETVAL -eq 0 \u0026\u0026 function_exists \"post_test_hook\" ]; then"},{"line_number":406,"context_line":"  post_test_hook"},{"line_number":407,"context_line":"  RETVAL\u003d$?"},{"line_number":408,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":5,"id":"AAAAPH%2F%2FpkY%3D","line":405,"in_reply_to":"AAAAPH%2F%2FpsI%3D","updated":"2013-05-28 16:02:24.000000000","message":"Should be fixed in patchset 6.","commit_id":"387cc4c5d31e6698f992a2babd3f49d66c5e29dd"}]}