)]}'
{"devstack-vm-gate.sh":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"a5818951baaf50077287ce06485570518cd123cb","unresolved":false,"context_lines":[{"line_number":721,"context_line":"    fi"},{"line_number":722,"context_line":""},{"line_number":723,"context_line":"    # in future we might want to force higher numbers here, but this"},{"line_number":724,"context_line":"    # ensures the multinode tests at least touch 2 nodes."},{"line_number":725,"context_line":"    if [[ \"$DEVSTACK_GATE_TOPOLOGY\" \u003d\u003d \"multinode\" ]]; then"},{"line_number":726,"context_line":"        iniset -sudo $BASE/new/tempest/etc/tempest.conf compute min_compute_nodes 2"},{"line_number":727,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":2,"id":"ba8a016a_0e6df597","line":724,"updated":"2015-11-17 15:45:31.000000000","message":"I feel like we should also add a comment here that this has to be run before NOTESTS check so that multinode functional tests that use parts of tempest are right.","commit_id":"aa952215bfd5927d7b3124df74213bfe7a95c219"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"af188665c9157f2debbdb9d827cf5ef4731f9e7f","unresolved":false,"context_lines":[{"line_number":721,"context_line":"    fi"},{"line_number":722,"context_line":""},{"line_number":723,"context_line":"    # in future we might want to force higher numbers here, but this"},{"line_number":724,"context_line":"    # ensures the multinode tests at least touch 2 nodes."},{"line_number":725,"context_line":"    if [[ \"$DEVSTACK_GATE_TOPOLOGY\" \u003d\u003d \"multinode\" ]]; then"},{"line_number":726,"context_line":"        iniset -sudo $BASE/new/tempest/etc/tempest.conf compute min_compute_nodes 2"},{"line_number":727,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":2,"id":"ba8a016a_4eb1bd8e","line":724,"in_reply_to":"ba8a016a_0e6df597","updated":"2015-11-17 15:56:34.000000000","message":"Done","commit_id":"aa952215bfd5927d7b3124df74213bfe7a95c219"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"68be5bf50bf25e24c9078ec593dbf07eee6ba448","unresolved":false,"context_lines":[{"line_number":720,"context_line":"        sudo chmod -R o+rx $BASE/new/devstack/files"},{"line_number":721,"context_line":"    fi"},{"line_number":722,"context_line":""},{"line_number":723,"context_line":"    # in future we might want to force higher numbers here, but this"},{"line_number":724,"context_line":"    # ensures the multinode tests at least touch 2 nodes."},{"line_number":725,"context_line":"    # This is a part of tempest configuration. It should be executed"},{"line_number":726,"context_line":"    # before DEVSTACK_GATE_TEMPEST_NOTESTS check as DEVSTACK_GATE_TEMPEST"}],"source_content_type":"text/x-sh","patch_set":3,"id":"ba8a016a_da856007","line":723,"updated":"2015-11-17 17:41:13.000000000","message":"In the future we might want to increase the number of compute nodes","commit_id":"08e8dc9ef5f5fded9d66d9551fc3fdd494eb2315"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"deb1a35c248f5e4d91e2056bd9b402c370ccfda6","unresolved":false,"context_lines":[{"line_number":720,"context_line":"        sudo chmod -R o+rx $BASE/new/devstack/files"},{"line_number":721,"context_line":"    fi"},{"line_number":722,"context_line":""},{"line_number":723,"context_line":"    # in future we might want to force higher numbers here, but this"},{"line_number":724,"context_line":"    # ensures the multinode tests at least touch 2 nodes."},{"line_number":725,"context_line":"    # This is a part of tempest configuration. It should be executed"},{"line_number":726,"context_line":"    # before DEVSTACK_GATE_TEMPEST_NOTESTS check as DEVSTACK_GATE_TEMPEST"}],"source_content_type":"text/x-sh","patch_set":3,"id":"ba8a016a_b57c2d73","line":723,"in_reply_to":"ba8a016a_da856007","updated":"2015-11-17 17:48:20.000000000","message":"Done","commit_id":"08e8dc9ef5f5fded9d66d9551fc3fdd494eb2315"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"68be5bf50bf25e24c9078ec593dbf07eee6ba448","unresolved":false,"context_lines":[{"line_number":721,"context_line":"    fi"},{"line_number":722,"context_line":""},{"line_number":723,"context_line":"    # in future we might want to force higher numbers here, but this"},{"line_number":724,"context_line":"    # ensures the multinode tests at least touch 2 nodes."},{"line_number":725,"context_line":"    # This is a part of tempest configuration. It should be executed"},{"line_number":726,"context_line":"    # before DEVSTACK_GATE_TEMPEST_NOTESTS check as DEVSTACK_GATE_TEMPEST"},{"line_number":727,"context_line":"    # guarantees that tempest should be configured, no matter should"}],"source_content_type":"text/x-sh","patch_set":3,"id":"ba8a016a_da9c805f","line":724,"updated":"2015-11-17 17:41:13.000000000","message":"This will ensure that multinode jobs consist of 2 nodes","commit_id":"08e8dc9ef5f5fded9d66d9551fc3fdd494eb2315"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"deb1a35c248f5e4d91e2056bd9b402c370ccfda6","unresolved":false,"context_lines":[{"line_number":721,"context_line":"    fi"},{"line_number":722,"context_line":""},{"line_number":723,"context_line":"    # in future we might want to force higher numbers here, but this"},{"line_number":724,"context_line":"    # ensures the multinode tests at least touch 2 nodes."},{"line_number":725,"context_line":"    # This is a part of tempest configuration. It should be executed"},{"line_number":726,"context_line":"    # before DEVSTACK_GATE_TEMPEST_NOTESTS check as DEVSTACK_GATE_TEMPEST"},{"line_number":727,"context_line":"    # guarantees that tempest should be configured, no matter should"}],"source_content_type":"text/x-sh","patch_set":3,"id":"ba8a016a_15865965","line":724,"in_reply_to":"ba8a016a_da9c805f","updated":"2015-11-17 17:48:20.000000000","message":"Done","commit_id":"08e8dc9ef5f5fded9d66d9551fc3fdd494eb2315"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"68be5bf50bf25e24c9078ec593dbf07eee6ba448","unresolved":false,"context_lines":[{"line_number":723,"context_line":"    # in future we might want to force higher numbers here, but this"},{"line_number":724,"context_line":"    # ensures the multinode tests at least touch 2 nodes."},{"line_number":725,"context_line":"    # This is a part of tempest configuration. It should be executed"},{"line_number":726,"context_line":"    # before DEVSTACK_GATE_TEMPEST_NOTESTS check as DEVSTACK_GATE_TEMPEST"},{"line_number":727,"context_line":"    # guarantees that tempest should be configured, no matter should"},{"line_number":728,"context_line":"    # tests be executed or not."},{"line_number":729,"context_line":"    if [[ \"$DEVSTACK_GATE_TOPOLOGY\" \u003d\u003d \"multinode\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":3,"id":"ba8a016a_dab320e8","line":726,"updated":"2015-11-17 17:41:13.000000000","message":"before the DEVSTACK_GATE_TEMPEST_NOTESTS check","commit_id":"08e8dc9ef5f5fded9d66d9551fc3fdd494eb2315"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"deb1a35c248f5e4d91e2056bd9b402c370ccfda6","unresolved":false,"context_lines":[{"line_number":723,"context_line":"    # in future we might want to force higher numbers here, but this"},{"line_number":724,"context_line":"    # ensures the multinode tests at least touch 2 nodes."},{"line_number":725,"context_line":"    # This is a part of tempest configuration. It should be executed"},{"line_number":726,"context_line":"    # before DEVSTACK_GATE_TEMPEST_NOTESTS check as DEVSTACK_GATE_TEMPEST"},{"line_number":727,"context_line":"    # guarantees that tempest should be configured, no matter should"},{"line_number":728,"context_line":"    # tests be executed or not."},{"line_number":729,"context_line":"    if [[ \"$DEVSTACK_GATE_TOPOLOGY\" \u003d\u003d \"multinode\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":3,"id":"ba8a016a_f582b551","line":726,"in_reply_to":"ba8a016a_dab320e8","updated":"2015-11-17 17:48:20.000000000","message":"Done","commit_id":"08e8dc9ef5f5fded9d66d9551fc3fdd494eb2315"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"68be5bf50bf25e24c9078ec593dbf07eee6ba448","unresolved":false,"context_lines":[{"line_number":725,"context_line":"    # This is a part of tempest configuration. It should be executed"},{"line_number":726,"context_line":"    # before DEVSTACK_GATE_TEMPEST_NOTESTS check as DEVSTACK_GATE_TEMPEST"},{"line_number":727,"context_line":"    # guarantees that tempest should be configured, no matter should"},{"line_number":728,"context_line":"    # tests be executed or not."},{"line_number":729,"context_line":"    if [[ \"$DEVSTACK_GATE_TOPOLOGY\" \u003d\u003d \"multinode\" ]]; then"},{"line_number":730,"context_line":"        iniset -sudo $BASE/new/tempest/etc/tempest.conf compute min_compute_nodes 2"},{"line_number":731,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":3,"id":"ba8a016a_da380040","line":728,"updated":"2015-11-17 17:41:13.000000000","message":"I\u0027d discard L727 through 728, I couldn\u0027t really make sense of it.","commit_id":"08e8dc9ef5f5fded9d66d9551fc3fdd494eb2315"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"deb1a35c248f5e4d91e2056bd9b402c370ccfda6","unresolved":false,"context_lines":[{"line_number":725,"context_line":"    # This is a part of tempest configuration. It should be executed"},{"line_number":726,"context_line":"    # before DEVSTACK_GATE_TEMPEST_NOTESTS check as DEVSTACK_GATE_TEMPEST"},{"line_number":727,"context_line":"    # guarantees that tempest should be configured, no matter should"},{"line_number":728,"context_line":"    # tests be executed or not."},{"line_number":729,"context_line":"    if [[ \"$DEVSTACK_GATE_TOPOLOGY\" \u003d\u003d \"multinode\" ]]; then"},{"line_number":730,"context_line":"        iniset -sudo $BASE/new/tempest/etc/tempest.conf compute min_compute_nodes 2"},{"line_number":731,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":3,"id":"ba8a016a_35911d9a","line":728,"in_reply_to":"ba8a016a_da380040","updated":"2015-11-17 17:48:20.000000000","message":"I think it\u0027s important to highlight this.","commit_id":"08e8dc9ef5f5fded9d66d9551fc3fdd494eb2315"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"015e10fb514839e93ddc758320aa4620d8e3b8e3","unresolved":false,"context_lines":[{"line_number":720,"context_line":"        sudo chmod -R o+rx $BASE/new/devstack/files"},{"line_number":721,"context_line":"    fi"},{"line_number":722,"context_line":""},{"line_number":723,"context_line":"    # In the future we might want to increase the number of compute nodes. "},{"line_number":724,"context_line":"    # This will ensure that multinode jobs consist of 2 nodes."},{"line_number":725,"context_line":"    # As a part of tempest configuration, it should be executed"},{"line_number":726,"context_line":"    # before the DEVSTACK_GATE_TEMPEST_NOTESTS check, because the DEVSTACK_GATE_TEMPEST"}],"source_content_type":"text/x-sh","patch_set":4,"id":"ba8a016a_79831705","line":723,"updated":"2015-11-17 21:38:04.000000000","message":"If we end up making a new patchset can you remove the trailing whitespace?","commit_id":"0a3e3b8ad55cec7cb3300ffc9127e620aed56054"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"015e10fb514839e93ddc758320aa4620d8e3b8e3","unresolved":false,"context_lines":[{"line_number":727,"context_line":"    # guarantees that tempest should be configured, no matter should"},{"line_number":728,"context_line":"    # tests be executed or not."},{"line_number":729,"context_line":"    if [[ \"$DEVSTACK_GATE_TOPOLOGY\" \u003d\u003d \"multinode\" ]]; then"},{"line_number":730,"context_line":"        iniset -sudo $BASE/new/tempest/etc/tempest.conf compute min_compute_nodes 2"},{"line_number":731,"context_line":"    fi"},{"line_number":732,"context_line":""},{"line_number":733,"context_line":"    # if set, we don\u0027t need to run Tempest at all"}],"source_content_type":"text/x-sh","patch_set":4,"id":"ba8a016a_5923b305","line":730,"updated":"2015-11-17 21:38:04.000000000","message":"For a follow up change we should consider setting the value to $(wc -l /etc/nodeool/subnodes) +1 or some other dynamically sorted out value based on how many compute hosts we want.","commit_id":"0a3e3b8ad55cec7cb3300ffc9127e620aed56054"}]}
