)]}'
{"id":"openstack%2Fdevstack-gate~28650","triplet_id":"openstack%2Fdevstack-gate~master~Id1e18c8c26b7791fd8d82fc5adaf2f9e7713abd4","project":"openstack/devstack-gate","branch":"master","topic":"bp/add-basic-heat-tests","hashtags":[],"change_id":"Id1e18c8c26b7791fd8d82fc5adaf2f9e7713abd4","subject":"DEVSTACK_GATE_HEAT conditional for enabling heat","status":"MERGED","created":"2013-05-09 03:07:33.000000000","updated":"2013-05-20 18:10:29.000000000","submitted":"2013-05-20 18:10:29.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"aadf79d407f9db240ed1e014b695970e4a2ef6c6","_number":28650,"virtual_id_number":28650,"owner":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},{"value":0,"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"value":0,"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":2,"date":"2013-05-20 18:10:29.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"all":[{"value":2,"date":"2013-05-20 16:37:21.000000000","_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},{"value":2,"date":"2013-05-17 17:49:33.000000000","_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"value":0,"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"all":[{"value":1,"date":"2013-05-20 16:37:21.000000000","_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},{"value":0,"date":"2013-05-17 17:49:33.000000000","_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"value":0,"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-05-15 01:20:24.000000000","updated_by":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"reviewer":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"state":"REVIEWER"},{"updated":"2013-05-17 17:49:33.000000000","updated_by":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"reviewer":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"state":"REVIEWER"},{"updated":"2013-05-20 16:37:21.000000000","updated_by":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"reviewer":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"state":"REVIEWER"},{"updated":"2013-05-20 18:10:29.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"4f6ea63585010b7a9c07bc56a166923c1125cbc6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-09 03:59:50.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/28650/1/check/gate-tempest-devstack-vm-full/15165 : SUCCESS in 00:52:06\n- http://logs.openstack.org/28650/1/check/gate-tempest-devstack-vm-postgres-full/14880 : FAILURE in 00:44:56 (non-voting)\n- http://logs.openstack.org/28650/1/check/gate-tempest-devstack-vm-quantum/21415 : SUCCESS in 00:21:34\n- http://logs.openstack.org/28650/1/check/gate-grenade-devstack-vm/2910 : SUCCESS in 00:19:42 (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"c67d31057c42f1ccd0e51f2f40db615b88c97bc8","author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"date":"2013-05-10 16:53:29.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\n(1 inline comment)\n\nOne small whitespace change (see inline commnet). Otherwise this looks good to me.","accounts_in_message":[],"_revision_number":1},{"id":"6522685484b52801a635ccd91b787f678dc3cdb6","author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"date":"2013-05-10 21:17:37.000000000","message":"Patch Set 1:\n\nCan you elaborate on:\n\n  #TODO sbaker install an image from jenkins.tripleo.org:8080","accounts_in_message":[],"_revision_number":1},{"id":"32062ad35fec18c511edcc0f4677f78fc9566507","author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"date":"2013-05-15 01:19:52.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"902d3641f4f800127aa9d56135772e862fcb1d79","author":{"_account_id":7556,"name":"Zuul (dev)","email":"zuul-dev@openstack.org","username":"zuul-dev"},"date":"2013-05-15 01:19:54.000000000","message":"Patch Set 2:\n\nBuild failed.\n\n- http://logs.openstack.org/28650/2/check/gate-tempest-devstack-vm-full/None : LOST\n- http://logs.openstack.org/28650/2/check/gate-tempest-devstack-vm-postgres-full/None : LOST (non-voting)\n- http://logs.openstack.org/28650/2/check/gate-tempest-devstack-vm-quantum/None : LOST\n- http://logs.openstack.org/28650/2/check/gate-grenade-devstack-vm/None : LOST (non-voting)\n","accounts_in_message":[],"_revision_number":2},{"id":"54323e7cddcb3937fd66bdfe131f1918c4820f54","author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"date":"2013-05-15 01:31:14.000000000","message":"Patch Set 2:\n\nSome heat tests will spawn full ubuntu or fedora servers for integration and functional testing. The images that are spawned need to already have our in-instance tools (heat-cfntools) installed on them. So we need custom built images available to run our tests.\n\njenkins.tripleo.org has some diskimage-builder jobs which build these custom images, specifically:\nhttp://jenkins.tripleo.org:8080/job/autobuilt-images/elements\u003dubuntu%20vm%20heat-cfntools/\nhttp://jenkins.tripleo.org:8080/job/autobuilt-images/elements\u003dfedora%20vm%20heat-cfntools/\n\nI\u0027m not sure of the best way to get these images into devstack-gate, but options might be:\n1. download latest built images for every run (could be slow, and a broken image could cause heat test failures)\n2. download known good images for every run (could be slow but maybe not, its all in hpcloud)\n3. bake known good images into the zuul images\n\nI\u0027ve added monty into this review to get an opinion.\n\nSince the IMAGE_URLS part is commented out I\u0027m hoping this change can get in before an images strategy is decided on - there will be heat tests which do not spawn servers, and the ones that do will be disabled until images are available.","accounts_in_message":[],"_revision_number":2},{"id":"6e9ce52ca52cd0ee83b4956c8c778d967829e90c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-15 02:05:50.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/28650/2/check/gate-tempest-devstack-vm-full/15997 : SUCCESS in 45m 35s\n- http://logs.openstack.org/28650/2/check/gate-tempest-devstack-vm-postgres-full/15713 : FAILURE in 45m 45s (non-voting)\n- http://logs.openstack.org/28650/2/check/gate-tempest-devstack-vm-quantum/22465 : SUCCESS in 25m 35s\n- http://logs.openstack.org/28650/2/check/gate-grenade-devstack-vm/3632 : FAILURE in 10m 20s (non-voting)\n","accounts_in_message":[],"_revision_number":2},{"id":"121d60034e38ccd9f638ad5cb99ed8e1cee76c1a","author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"date":"2013-05-15 17:14:04.000000000","message":"Patch Set 2: I would prefer that you didn\u0027t merge this\n\nOkay, makes sense.  My understanding after speaking with Monty is that the tripleo folks will get DiB running in the OpenStack CI infrastructure, optionally incorporating it into the devstack-gate so that changes to it which would break heat tests can\u0027t land.  Then it can publish images to static.openstack.org, which is a reliable, infra-team managed source from which we can fetch images.\n\nI believe we\u0027ll want all that to happen before we start gating on tests involving those images, as we\u0027d rather not be responsible for infrastructure we can\u0027t fix.\n\nSo all that is to say this change looks good, except one small thing:\n\nWould you mind adding a default value setting for the new env variable into devstack-vm-gate-wrap.sh?  That\u0027s more or less the de-facto documentation for those parameters, plus we also might want to do some branch-specific settings with it later as well.","accounts_in_message":[],"_revision_number":2},{"id":"a5e52fb4fea9fb381355a29a0ee349f6eab02244","author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"date":"2013-05-16 05:02:39.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"38a94c72db872fe554954487bda99a234fe7f9da","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-16 05:46:38.000000000","message":"Patch Set 3: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/28650/3/check/gate-tempest-devstack-vm-full/16240 : SUCCESS in 41m 23s\n- http://logs.openstack.org/28650/3/check/gate-tempest-devstack-vm-postgres-full/15956 : FAILURE in 43m 29s (non-voting)\n- http://logs.openstack.org/28650/3/check/gate-tempest-devstack-vm-quantum/22745 : SUCCESS in 23m 21s\n- http://logs.openstack.org/28650/3/check/gate-grenade-devstack-vm/3850 : FAILURE in 10m 33s (non-voting)\n","accounts_in_message":[],"_revision_number":3},{"id":"04cfbf38b4039ee2dc3190b18a240d70cc982898","author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"date":"2013-05-17 17:49:33.000000000","message":"Patch Set 3: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":3},{"id":"cefa02ac30ee4a806b445247c1eedc4f403df553","author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"date":"2013-05-20 16:37:21.000000000","message":"Patch Set 3: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":3},{"id":"35521b55ea38ac25710c02a8c4fc5507daac533e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-20 16:37:22.000000000","message":"Patch Set 3: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"df0f4c4636fcf7a0a7611346e56bda83c116147f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-20 18:10:29.000000000","message":"Patch Set 3: Verified\n\nBuild succeeded.\n\n- http://logs.openstack.org/28650/3/gate/gate-tempest-devstack-vm-full/16962 : SUCCESS in 46m 23s\n- http://logs.openstack.org/28650/3/gate/gate-tempest-devstack-vm-postgres-full/16677 : FAILURE in 53m 49s (non-voting)\n- http://logs.openstack.org/28650/3/gate/gate-tempest-devstack-vm-quantum/23578 : SUCCESS in 24m 47s\n- http://logs.openstack.org/28650/3/gate/gate-grenade-devstack-vm/4516 : FAILURE in 13m 40s (non-voting)\n","accounts_in_message":[],"_revision_number":3},{"id":"b8ec311f3bef95d7dc113fdf7cebaeedf7ff41f6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-20 18:10:29.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"5cbb0b4343807e9399e5161e8a547cf31308d931","revisions":{"a704b189148197bb2e60700813ecfee0fa87c936":{"kind":"REWORK","_number":1,"created":"2013-05-09 03:07:33.000000000","uploader":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"ref":"refs/changes/50/28650/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack-gate","ref":"refs/changes/50/28650/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack-gate refs/changes/50/28650/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack-gate refs/changes/50/28650/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack-gate refs/changes/50/28650/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack-gate refs/changes/50/28650/1"}}},"commit":{"parents":[{"commit":"cb8508b1480257a5a359723e0aec81162058d786","subject":"add database run check","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-gate/commit/cb8508b1480257a5a359723e0aec81162058d786"}]}],"author":{"name":"Steve Baker","email":"sbaker@redhat.com","date":"2013-05-09 03:05:05.000000000","tz":720},"committer":{"name":"Steve Baker","email":"sbaker@redhat.com","date":"2013-05-09 03:07:18.000000000","tz":720},"subject":"DEVSTACK_GATE_HEAT conditional for enabling heat","message":"DEVSTACK_GATE_HEAT conditional for enabling heat\n\nDisabled by default, will need to be enabled for heat tempest tests\n\nChange-Id: Id1e18c8c26b7791fd8d82fc5adaf2f9e7713abd4\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-gate/commit/a704b189148197bb2e60700813ecfee0fa87c936"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-gate/commit/a704b189148197bb2e60700813ecfee0fa87c936"}]},"branch":"refs/heads/master"},"f860eac166520b044152313098f740e95ac1116c":{"kind":"REWORK","_number":2,"created":"2013-05-15 01:19:52.000000000","uploader":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"ref":"refs/changes/50/28650/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack-gate","ref":"refs/changes/50/28650/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack-gate refs/changes/50/28650/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack-gate refs/changes/50/28650/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack-gate refs/changes/50/28650/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack-gate refs/changes/50/28650/2"}}},"commit":{"parents":[{"commit":"051b48df419b6d6d457a6ef7520d88d646be9cb7","subject":"Merge \"convert test runner to tox\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-gate/commit/051b48df419b6d6d457a6ef7520d88d646be9cb7"}]}],"author":{"name":"Steve Baker","email":"sbaker@redhat.com","date":"2013-05-15 01:18:58.000000000","tz":720},"committer":{"name":"Steve Baker","email":"sbaker@redhat.com","date":"2013-05-15 01:18:58.000000000","tz":720},"subject":"DEVSTACK_GATE_HEAT conditional for enabling heat","message":"DEVSTACK_GATE_HEAT conditional for enabling heat\n\nDisabled by default, will need to be enabled for heat tempest tests\n\nChange-Id: Id1e18c8c26b7791fd8d82fc5adaf2f9e7713abd4\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-gate/commit/f860eac166520b044152313098f740e95ac1116c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-gate/commit/f860eac166520b044152313098f740e95ac1116c"}]},"branch":"refs/heads/master"},"5cbb0b4343807e9399e5161e8a547cf31308d931":{"kind":"REWORK","_number":3,"created":"2013-05-16 05:02:39.000000000","uploader":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"ref":"refs/changes/50/28650/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack-gate","ref":"refs/changes/50/28650/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack-gate refs/changes/50/28650/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack-gate refs/changes/50/28650/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack-gate refs/changes/50/28650/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack-gate refs/changes/50/28650/3"}}},"commit":{"parents":[{"commit":"051b48df419b6d6d457a6ef7520d88d646be9cb7","subject":"Merge \"convert test runner to tox\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-gate/commit/051b48df419b6d6d457a6ef7520d88d646be9cb7"}]}],"author":{"name":"Steve Baker","email":"sbaker@redhat.com","date":"2013-05-15 01:18:58.000000000","tz":720},"committer":{"name":"Steve Baker","email":"sbaker@redhat.com","date":"2013-05-16 04:56:08.000000000","tz":720},"subject":"DEVSTACK_GATE_HEAT conditional for enabling heat","message":"DEVSTACK_GATE_HEAT conditional for enabling heat\n\nDisabled by default, will need to be enabled for heat tempest tests\n\nChange-Id: Id1e18c8c26b7791fd8d82fc5adaf2f9e7713abd4\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-gate/commit/5cbb0b4343807e9399e5161e8a547cf31308d931"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-gate/commit/5cbb0b4343807e9399e5161e8a547cf31308d931"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}