)]}'
{"devstack-vm-gate-wrap.sh":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"385f2bab88b3d43f97c89bde72fdaaf75a231151","unresolved":false,"context_lines":[{"line_number":567,"context_line":"    echo \"    please look at the relevant log files to determine the root cause\""},{"line_number":568,"context_line":"    echo \"Running devstack worlddump.py\""},{"line_number":569,"context_line":"    sudo $BASE/new/devstack/tools/worlddump.py -d $BASE/logs"},{"line_number":570,"context_line":"fi"},{"line_number":571,"context_line":""},{"line_number":572,"context_line":"# Run post test hook if we have one"},{"line_number":573,"context_line":"if [ $GATE_RETVAL -eq 0 ]; then"}],"source_content_type":"text/x-sh","patch_set":1,"id":"ba0121b8_7dc9e125","line":570,"updated":"2016-03-30 20:48:14.000000000","message":"The log we would output on pre_test_hook failure is that the main setup script failed which may be confusing when it is actually the pre_test_hook failing.\n\nWe should check the pre_test_hook return code directly and output an error specific to it if necessary rather than falling through to this block.","commit_id":"4d9f5b869d3b46b384a52fc900d733b531dee7f0"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"1bf80d39e8a456dd982a5fba1cd809cebf089120","unresolved":false,"context_lines":[{"line_number":567,"context_line":"    echo \"    please look at the relevant log files to determine the root cause\""},{"line_number":568,"context_line":"    echo \"Running devstack worlddump.py\""},{"line_number":569,"context_line":"    sudo $BASE/new/devstack/tools/worlddump.py -d $BASE/logs"},{"line_number":570,"context_line":"fi"},{"line_number":571,"context_line":""},{"line_number":572,"context_line":"# Run post test hook if we have one"},{"line_number":573,"context_line":"if [ $GATE_RETVAL -eq 0 ]; then"}],"source_content_type":"text/x-sh","patch_set":1,"id":"ba0121b8_66063721","line":570,"in_reply_to":"ba0121b8_7dc9e125","updated":"2016-03-31 20:17:35.000000000","message":"Done","commit_id":"4d9f5b869d3b46b384a52fc900d733b531dee7f0"},{"author":{"_account_id":1106,"name":"Ricardo Carrillo Cruz","email":"ricardo.carrillo.cruz@gmail.com","username":"rcc"},"change_message_id":"063e8e0d961cc3bb67e092617a3288c5c38dc375","unresolved":false,"context_lines":[{"line_number":554,"context_line":"with_timeout call_hook_if_defined \"pre_test_hook\""},{"line_number":555,"context_line":"GATE_RETVAL\u003d$?"},{"line_number":556,"context_line":"if [ $GATE_RETVAL -ne 0 ]; then"},{"line_number":557,"context_line":"    echo \"ERROR: the pre-test setup script run by this job failed - exit code: $GATE_RETVAL\""},{"line_number":558,"context_line":"fi"},{"line_number":559,"context_line":""},{"line_number":560,"context_line":"# Run the gate function"}],"source_content_type":"text/x-sh","patch_set":3,"id":"9a061dce_2e1aec6e","line":557,"updated":"2016-04-09 11:21:34.000000000","message":"This is confusing.\nIn the commit you are stating devstack-gate should fail if pre-test hook fails, but you are just echo logging it.\nYou don\u0027t do an exit call or call worlddump (which implicitly does an exit syscall).\n\nIf your intent is to just log, you should change the commit message, otherwise do an exit or call worlddump here?","commit_id":"3254d688df01e23cd56786b8f5b783e3980c1129"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"f0c84c6efe269ae6d36903eac4971b9391a4b3e3","unresolved":false,"context_lines":[{"line_number":554,"context_line":"with_timeout call_hook_if_defined \"pre_test_hook\""},{"line_number":555,"context_line":"GATE_RETVAL\u003d$?"},{"line_number":556,"context_line":"if [ $GATE_RETVAL -ne 0 ]; then"},{"line_number":557,"context_line":"    echo \"ERROR: the pre-test setup script run by this job failed - exit code: $GATE_RETVAL\""},{"line_number":558,"context_line":"fi"},{"line_number":559,"context_line":""},{"line_number":560,"context_line":"# Run the gate function"}],"source_content_type":"text/x-sh","patch_set":3,"id":"9a061dce_e7913754","line":557,"in_reply_to":"9a061dce_2e1aec6e","updated":"2016-04-09 18:51:15.000000000","message":"If you look at the way this flows it falls through to the error handling below. This is how the existing gate hook fail stuff works too.","commit_id":"3254d688df01e23cd56786b8f5b783e3980c1129"},{"author":{"_account_id":1106,"name":"Ricardo Carrillo Cruz","email":"ricardo.carrillo.cruz@gmail.com","username":"rcc"},"change_message_id":"34c05740d79c79c3414f846b8480736a62335cb8","unresolved":false,"context_lines":[{"line_number":554,"context_line":"with_timeout call_hook_if_defined \"pre_test_hook\""},{"line_number":555,"context_line":"GATE_RETVAL\u003d$?"},{"line_number":556,"context_line":"if [ $GATE_RETVAL -ne 0 ]; then"},{"line_number":557,"context_line":"    echo \"ERROR: the pre-test setup script run by this job failed - exit code: $GATE_RETVAL\""},{"line_number":558,"context_line":"fi"},{"line_number":559,"context_line":""},{"line_number":560,"context_line":"# Run the gate function"}],"source_content_type":"text/x-sh","patch_set":3,"id":"9a061dce_22695d8c","line":557,"in_reply_to":"9a061dce_e7913754","updated":"2016-04-09 20:36:12.000000000","message":"You are right, I missed the subsequent if block, thanks","commit_id":"3254d688df01e23cd56786b8f5b783e3980c1129"}]}