)]}'
{"functions.sh":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"3f3007a2395570a011caf80ed5234492ffefd5e0","unresolved":false,"context_lines":[{"line_number":181,"context_line":"    # first get all keys that match our filter and then output the whole line"},{"line_number":182,"context_line":"    # that will ensure that multi-line env vars are set properly"},{"line_number":183,"context_line":"    REPRODUCE_ENV\u003d$(printenv | grep \u0027\\(DEVSTACK\\|ZUUL\\)\u0027 | sed \u0027s/\\(.*\\)\u003d.*/\\1/\u0027)"},{"line_number":184,"context_line":"    REPRODUCE_VARS\u003d(${REPRODUCE_ENV// / })"},{"line_number":185,"context_line":"    for KEY in \"${REPRODUCE_VARS[@]}\"; do"},{"line_number":186,"context_line":"        echo \"declare -x ${KEY}\u003d\\\"${!KEY}\\\"\" \u003e\u003e $WORKSPACE/logs/reproduce.sh"},{"line_number":187,"context_line":"    done"}],"source_content_type":"text/x-sh","patch_set":2,"id":"1af94dfe_ffeefbea","line":184,"updated":"2016-03-15 19:37:39.000000000","message":"what is this line doing?  replacing a space with a space?","commit_id":"29f897b4c3155c27ee35fdcfedfe4423a7d1218e"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"a93128bc28c2978e231699e9b3843de205f1d8cb","unresolved":false,"context_lines":[{"line_number":181,"context_line":"    # first get all keys that match our filter and then output the whole line"},{"line_number":182,"context_line":"    # that will ensure that multi-line env vars are set properly"},{"line_number":183,"context_line":"    REPRODUCE_ENV\u003d$(printenv | grep \u0027\\(DEVSTACK\\|ZUUL\\)\u0027 | sed \u0027s/\\(.*\\)\u003d.*/\\1/\u0027)"},{"line_number":184,"context_line":"    REPRODUCE_VARS\u003d(${REPRODUCE_ENV// / })"},{"line_number":185,"context_line":"    for KEY in \"${REPRODUCE_VARS[@]}\"; do"},{"line_number":186,"context_line":"        echo \"declare -x ${KEY}\u003d\\\"${!KEY}\\\"\" \u003e\u003e $WORKSPACE/logs/reproduce.sh"},{"line_number":187,"context_line":"    done"}],"source_content_type":"text/x-sh","patch_set":2,"id":"1af94dfe_82ede08d","line":184,"in_reply_to":"1af94dfe_026a7080","updated":"2016-03-15 20:05:03.000000000","message":"right, so\n\n echo \"$REPRODUCE_ENV\"\n\nwill show that is separated by newlines\n\nbut either way, the \"// / \" bit when you setup the array doesn\u0027t seem to be doing anything?\n\nand so there really doesn\u0027t seem to be any reason for these two steps\n\ngiven this, i\u0027d really like to see it just use the loop directly as i suggested below, as that\u0027s much clearer IMO (and avoids future code readers wondering what\u0027s going on like me :)","commit_id":"29f897b4c3155c27ee35fdcfedfe4423a7d1218e"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"556c2f3244016bb7ebf60449ead056be68300a20","unresolved":false,"context_lines":[{"line_number":181,"context_line":"    # first get all keys that match our filter and then output the whole line"},{"line_number":182,"context_line":"    # that will ensure that multi-line env vars are set properly"},{"line_number":183,"context_line":"    REPRODUCE_ENV\u003d$(printenv | grep \u0027\\(DEVSTACK\\|ZUUL\\)\u0027 | sed \u0027s/\\(.*\\)\u003d.*/\\1/\u0027)"},{"line_number":184,"context_line":"    REPRODUCE_VARS\u003d(${REPRODUCE_ENV// / })"},{"line_number":185,"context_line":"    for KEY in \"${REPRODUCE_VARS[@]}\"; do"},{"line_number":186,"context_line":"        echo \"declare -x ${KEY}\u003d\\\"${!KEY}\\\"\" \u003e\u003e $WORKSPACE/logs/reproduce.sh"},{"line_number":187,"context_line":"    done"}],"source_content_type":"text/x-sh","patch_set":2,"id":"1af94dfe_6226d4bb","line":184,"in_reply_to":"1af94dfe_1f2127fc","updated":"2016-03-15 19:51:16.000000000","message":"REPRODUCE_ENV will be a string separated by newlines?\n\nif you do \n \n echo \"${REPRODUCE_ENV}\"\n\n(with the quotes) you\u0027d see it go over multiple lines.\n\nSo i\u0027m still not sure what the \"// / } is doing?","commit_id":"29f897b4c3155c27ee35fdcfedfe4423a7d1218e"},{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"5b836b48f6e9e36e49af536e54d09cd7edbe40ff","unresolved":false,"context_lines":[{"line_number":181,"context_line":"    # first get all keys that match our filter and then output the whole line"},{"line_number":182,"context_line":"    # that will ensure that multi-line env vars are set properly"},{"line_number":183,"context_line":"    REPRODUCE_ENV\u003d$(printenv | grep \u0027\\(DEVSTACK\\|ZUUL\\)\u0027 | sed \u0027s/\\(.*\\)\u003d.*/\\1/\u0027)"},{"line_number":184,"context_line":"    REPRODUCE_VARS\u003d(${REPRODUCE_ENV// / })"},{"line_number":185,"context_line":"    for KEY in \"${REPRODUCE_VARS[@]}\"; do"},{"line_number":186,"context_line":"        echo \"declare -x ${KEY}\u003d\\\"${!KEY}\\\"\" \u003e\u003e $WORKSPACE/logs/reproduce.sh"},{"line_number":187,"context_line":"    done"}],"source_content_type":"text/x-sh","patch_set":2,"id":"1af94dfe_026a7080","line":184,"in_reply_to":"1af94dfe_6226d4bb","updated":"2016-03-15 19:56:08.000000000","message":"Pasting the results of my tests...\n\nexport DEVSTACK\u003dabc\nexport DEVSTACK1\u003ddef\nREPRODUCE_ENV\u003d$(printenv | grep \u0027\\(DEVSTACK\\|ZUUL\\)\u0027 | sed \u0027s/\\(.*\\)\u003d.*/\\1/\u0027)\necho $REPRODUCE_ENV\nDEVSTACK DEVSTACK1\necho ${REPRODUCE_ENV[0]}\nDEVSTACK DEVSTACK1\n\nREPRODUCE_VARS\u003d(${REPRODUCE_ENV// / })\necho ${REPRODUCE_VARS[0]}\nDEVSTACK\necho ${REPRODUCE_VARS[1]}\nDEVSTACK1","commit_id":"29f897b4c3155c27ee35fdcfedfe4423a7d1218e"},{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"0f6aa4e00f6f85bf4c28f602f1c6a2e935707f51","unresolved":false,"context_lines":[{"line_number":181,"context_line":"    # first get all keys that match our filter and then output the whole line"},{"line_number":182,"context_line":"    # that will ensure that multi-line env vars are set properly"},{"line_number":183,"context_line":"    REPRODUCE_ENV\u003d$(printenv | grep \u0027\\(DEVSTACK\\|ZUUL\\)\u0027 | sed \u0027s/\\(.*\\)\u003d.*/\\1/\u0027)"},{"line_number":184,"context_line":"    REPRODUCE_VARS\u003d(${REPRODUCE_ENV// / })"},{"line_number":185,"context_line":"    for KEY in \"${REPRODUCE_VARS[@]}\"; do"},{"line_number":186,"context_line":"        echo \"declare -x ${KEY}\u003d\\\"${!KEY}\\\"\" \u003e\u003e $WORKSPACE/logs/reproduce.sh"},{"line_number":187,"context_line":"    done"}],"source_content_type":"text/x-sh","patch_set":2,"id":"1af94dfe_1f2127fc","line":184,"in_reply_to":"1af94dfe_ffeefbea","updated":"2016-03-15 19:42:31.000000000","message":"When i tested, taht REPRODUCE_ENV was a string separated by spaces. This line converts that into an array so i can iterate properly.","commit_id":"29f897b4c3155c27ee35fdcfedfe4423a7d1218e"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"3f3007a2395570a011caf80ed5234492ffefd5e0","unresolved":false,"context_lines":[{"line_number":182,"context_line":"    # that will ensure that multi-line env vars are set properly"},{"line_number":183,"context_line":"    REPRODUCE_ENV\u003d$(printenv | grep \u0027\\(DEVSTACK\\|ZUUL\\)\u0027 | sed \u0027s/\\(.*\\)\u003d.*/\\1/\u0027)"},{"line_number":184,"context_line":"    REPRODUCE_VARS\u003d(${REPRODUCE_ENV// / })"},{"line_number":185,"context_line":"    for KEY in \"${REPRODUCE_VARS[@]}\"; do"},{"line_number":186,"context_line":"        echo \"declare -x ${KEY}\u003d\\\"${!KEY}\\\"\" \u003e\u003e $WORKSPACE/logs/reproduce.sh"},{"line_number":187,"context_line":"    done"},{"line_number":188,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"1af94dfe_3fa6a3c1","line":185,"updated":"2016-03-15 19:37:39.000000000","message":"for simplicity, i\u0027d probably just do\n\n for KEY in $(printenv ...); do\n   ...\n done\n\nthat seems like it would work just as well","commit_id":"29f897b4c3155c27ee35fdcfedfe4423a7d1218e"}]}
