)]}'
{"devstack-vm-gate.sh":[{"author":{"_account_id":14039,"name":"watanabe isao","email":"watanabe.isao.openstack@gmail.com","username":"watanabe.isao"},"change_message_id":"be77d1e7fe50943b712fdd3dd074834f1ebe3e82","unresolved":false,"context_lines":[{"line_number":337,"context_line":""},{"line_number":338,"context_line":"    if [[ \"$DEVSTACK_GATE_VIRT_DRIVER\" \u003d\u003d \"ironic\" ]]; then"},{"line_number":339,"context_line":"        export TEMPEST_OS_TEST_TIMEOUT\u003d900"},{"line_number":340,"context_line":"        export BUILD_TIMEOUT\u003d${BUILD_TIMEOUT:-600}"},{"line_number":341,"context_line":"        echo \"IRONIC_DEPLOY_DRIVER\u003d$DEVSTACK_GATE_IRONIC_DRIVER\" \u003e\u003e\"$localrc_file\""},{"line_number":342,"context_line":"        echo \"VIRT_DRIVER\u003dironic\" \u003e\u003e\"$localrc_file\""},{"line_number":343,"context_line":"        echo \"IRONIC_BAREMETAL_BASIC_OPS\u003dTrue\" \u003e\u003e\"$localrc_file\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"da0c15f0_442602cf","line":340,"updated":"2016-03-28 01:09:26.000000000","message":"I also noticed this line affects nothing, so will remove this line in next patch set.","commit_id":"bfb15c1269015d5c3e811249ac9cd8f10c69a34a"},{"author":{"_account_id":1106,"name":"Ricardo Carrillo Cruz","email":"ricardo.carrillo.cruz@gmail.com","username":"rcc"},"change_message_id":"fb9536acb99eb0f0c1375b5102ba6d8981587072","unresolved":false,"context_lines":[{"line_number":343,"context_line":"        echo \"IRONIC_BAREMETAL_BASIC_OPS\u003dTrue\" \u003e\u003e\"$localrc_file\""},{"line_number":344,"context_line":"        echo \"IRONIC_VM_LOG_DIR\u003d$BASE/$localrc_oldnew/ironic-bm-logs\" \u003e\u003e\"$localrc_file\""},{"line_number":345,"context_line":"        echo \"DEFAULT_INSTANCE_TYPE\u003dbaremetal\" \u003e\u003e\"$localrc_file\""},{"line_number":346,"context_line":"        echo $BUILD_TIMEOUT \u003e\u003e\"$localrc_file\""},{"line_number":347,"context_line":"        echo \"IRONIC_CALLBACK_TIMEOUT\u003d600\" \u003e\u003e\"$localrc_file\""},{"line_number":348,"context_line":"        echo \"Q_AGENT\u003dopenvswitch\" \u003e\u003e\"$localrc_file\""},{"line_number":349,"context_line":"        echo \"Q_ML2_TENANT_NETWORK_TYPE\u003dvxlan\" \u003e\u003e\"$localrc_file\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"da0c15f0_de269515","line":346,"updated":"2016-03-25 11:32:08.000000000","message":"I think this should be:\n\necho \"BUILD_TIMEOUT\u003d$BUILD_TIMEOUT\" \u003e\u003e \"$localrc_file\n\nOtherwise, you\u0027re just appending to localrc the value of variable, which would be 600 in case is not set earlier.","commit_id":"bfb15c1269015d5c3e811249ac9cd8f10c69a34a"},{"author":{"_account_id":14039,"name":"watanabe isao","email":"watanabe.isao.openstack@gmail.com","username":"watanabe.isao"},"change_message_id":"be77d1e7fe50943b712fdd3dd074834f1ebe3e82","unresolved":false,"context_lines":[{"line_number":343,"context_line":"        echo \"IRONIC_BAREMETAL_BASIC_OPS\u003dTrue\" \u003e\u003e\"$localrc_file\""},{"line_number":344,"context_line":"        echo \"IRONIC_VM_LOG_DIR\u003d$BASE/$localrc_oldnew/ironic-bm-logs\" \u003e\u003e\"$localrc_file\""},{"line_number":345,"context_line":"        echo \"DEFAULT_INSTANCE_TYPE\u003dbaremetal\" \u003e\u003e\"$localrc_file\""},{"line_number":346,"context_line":"        echo $BUILD_TIMEOUT \u003e\u003e\"$localrc_file\""},{"line_number":347,"context_line":"        echo \"IRONIC_CALLBACK_TIMEOUT\u003d600\" \u003e\u003e\"$localrc_file\""},{"line_number":348,"context_line":"        echo \"Q_AGENT\u003dopenvswitch\" \u003e\u003e\"$localrc_file\""},{"line_number":349,"context_line":"        echo \"Q_ML2_TENANT_NETWORK_TYPE\u003dvxlan\" \u003e\u003e\"$localrc_file\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"da0c15f0_84593a5d","line":346,"in_reply_to":"da0c15f0_de269515","updated":"2016-03-28 01:09:26.000000000","message":"Yes, your are correct, I missed it. Thank you.","commit_id":"bfb15c1269015d5c3e811249ac9cd8f10c69a34a"}]}
