)]}'
{"devstack-vm-gate.sh":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"d86aebd7a3d2722c1ffaf745544b00e1669d006f","unresolved":false,"context_lines":[{"line_number":363,"context_line":"            echo \"IRONIC_VM_EPHEMERAL_DISK\u003d1\" \u003e\u003e\"$localrc_file\""},{"line_number":364,"context_line":"            echo \"IRONIC_VM_COUNT\u003d3\" \u003e\u003e\"$localrc_file\""},{"line_number":365,"context_line":"        else"},{"line_number":366,"context_line":"            echo \"IRONIC_ENABLED_DRIVERS\u003d$IRONIC_ENABLED_DRIVERS\" \u003e\u003e\"$localrc_file\""},{"line_number":367,"context_line":"        fi"},{"line_number":368,"context_line":"    fi"},{"line_number":369,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"ba0121b8_239bca73","line":366,"updated":"2016-03-30 21:30:55.000000000","message":"I would not include this else and other drivers not directly supported here can use the DEVSTACK_LOCAL_CONFIG var to plumb their settings through.\n\nThe more specific if cases above are fine though to avoid setting things that other drivers do not want.","commit_id":"7cb6fbceee6b3450065d398a3ba1e1b53c9d4e12"},{"author":{"_account_id":14039,"name":"watanabe isao","email":"watanabe.isao.openstack@gmail.com","username":"watanabe.isao"},"change_message_id":"0323b9aad15f8b5bb6f862f75af534c097fd8bbc","unresolved":false,"context_lines":[{"line_number":363,"context_line":"            echo \"IRONIC_VM_EPHEMERAL_DISK\u003d1\" \u003e\u003e\"$localrc_file\""},{"line_number":364,"context_line":"            echo \"IRONIC_VM_COUNT\u003d3\" \u003e\u003e\"$localrc_file\""},{"line_number":365,"context_line":"        else"},{"line_number":366,"context_line":"            echo \"IRONIC_ENABLED_DRIVERS\u003d$IRONIC_ENABLED_DRIVERS\" \u003e\u003e\"$localrc_file\""},{"line_number":367,"context_line":"        fi"},{"line_number":368,"context_line":"    fi"},{"line_number":369,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"9a061dce_33085a2c","line":366,"in_reply_to":"ba0121b8_239bca73","updated":"2016-04-06 02:32:46.000000000","message":"Hello, Clark.\nThank you for your time and review.\n\nYes, using DEVSTACK_LOCAL_CONFIG is the best solution for me currently. Even the if cases in origin code set something I don\u0027t want to use, I can still use DEVSTACK_LOCAL_CONFIG to reset them.\n\nBut the issue is, when I\u0027m using gate job to built my 3rd party ci for Ironic, this code disturbed me a lot before I noticed DEVSTACK_LOCAL_CONFIG.","commit_id":"7cb6fbceee6b3450065d398a3ba1e1b53c9d4e12"}]}