)]}'
{"functions.sh":[{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"155d12685916566d2af876fc04fe32787d4a10dc","unresolved":false,"context_lines":[{"line_number":848,"context_line":"    fi"},{"line_number":849,"context_line":""},{"line_number":850,"context_line":"    # Copy the nova instance console logs if they exist"},{"line_number":851,"context_line":"    if [ -d $BASE/data/nova/instances ] ; then"},{"line_number":852,"context_line":"        sudo mkdir -p $BASE/logs/nova-logs"},{"line_number":853,"context_line":"        for dir_item in $BASE/data/nova/instances/* ; do"},{"line_number":854,"context_line":"            if [[ \"${dir_item##*/}\" \u003d~ ^[0-9a-fA-F]{8}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{12}$ ]] ; then"}],"source_content_type":"text/x-sh","patch_set":1,"id":"ba0121b8_07309d9d","line":851,"updated":"2016-03-29 19:30:13.000000000","message":"Confirming that this is meant to be $BASE/data and not $BASE/new/data ?","commit_id":"77bf959f22d74c30a4fa81fc2bf1a436daf98303"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"0fa556f07eae92594c79edbb4ee63690fd1e9850","unresolved":false,"context_lines":[{"line_number":848,"context_line":"    fi"},{"line_number":849,"context_line":""},{"line_number":850,"context_line":"    # Copy the nova instance console logs if they exist"},{"line_number":851,"context_line":"    if [ -d $BASE/data/nova/instances ] ; then"},{"line_number":852,"context_line":"        sudo mkdir -p $BASE/logs/nova-logs"},{"line_number":853,"context_line":"        for dir_item in $BASE/data/nova/instances/* ; do"},{"line_number":854,"context_line":"            if [[ \"${dir_item##*/}\" \u003d~ ^[0-9a-fA-F]{8}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{12}$ ]] ; then"}],"source_content_type":"text/x-sh","patch_set":1,"id":"ba0121b8_8ad95486","line":851,"in_reply_to":"ba0121b8_07309d9d","updated":"2016-03-29 19:48:45.000000000","message":"Good question.  My answer is I\u0027m not 100% sure.  I modeled this after the \"failure files\" block above starting on line 838.  These logs are in /opt/stack/data as opposed to /opt/stack/logs.  From the research I could do it *appears* that the old/ and new/ issue is for the logs directory.\nI would appreciate feedback on this.\nIf this is incorrect, the the \"failures\" block probably needs to be updated as well.","commit_id":"77bf959f22d74c30a4fa81fc2bf1a436daf98303"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"155d12685916566d2af876fc04fe32787d4a10dc","unresolved":false,"context_lines":[{"line_number":851,"context_line":"    if [ -d $BASE/data/nova/instances ] ; then"},{"line_number":852,"context_line":"        sudo mkdir -p $BASE/logs/nova-logs"},{"line_number":853,"context_line":"        for dir_item in $BASE/data/nova/instances/* ; do"},{"line_number":854,"context_line":"            if [[ \"${dir_item##*/}\" \u003d~ ^[0-9a-fA-F]{8}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{12}$ ]] ; then"},{"line_number":855,"context_line":"                if [ -f $dir_item/console.log ] ; then"},{"line_number":856,"context_line":"                    sudo cp $dir_item/console.log $BASE/logs/nova-logs/console-${dir_item##*/}.log"},{"line_number":857,"context_line":"                fi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"ba0121b8_871cad14","line":854,"updated":"2016-03-29 19:30:13.000000000","message":"this line deserves a comment as to what it\u0027s doing.","commit_id":"77bf959f22d74c30a4fa81fc2bf1a436daf98303"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"0fa556f07eae92594c79edbb4ee63690fd1e9850","unresolved":false,"context_lines":[{"line_number":851,"context_line":"    if [ -d $BASE/data/nova/instances ] ; then"},{"line_number":852,"context_line":"        sudo mkdir -p $BASE/logs/nova-logs"},{"line_number":853,"context_line":"        for dir_item in $BASE/data/nova/instances/* ; do"},{"line_number":854,"context_line":"            if [[ \"${dir_item##*/}\" \u003d~ ^[0-9a-fA-F]{8}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{12}$ ]] ; then"},{"line_number":855,"context_line":"                if [ -f $dir_item/console.log ] ; then"},{"line_number":856,"context_line":"                    sudo cp $dir_item/console.log $BASE/logs/nova-logs/console-${dir_item##*/}.log"},{"line_number":857,"context_line":"                fi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"ba0121b8_2ad12858","line":854,"in_reply_to":"ba0121b8_871cad14","updated":"2016-03-29 19:48:45.000000000","message":"I will push a new patch with a comment here.","commit_id":"77bf959f22d74c30a4fa81fc2bf1a436daf98303"},{"author":{"_account_id":7979,"name":"Mikhail S Medvedev","email":"mihailmed@gmail.com","username":"msmedved"},"change_message_id":"1636c2a07c4eb32ad3443e547a5efe6baeda336d","unresolved":false,"context_lines":[{"line_number":850,"context_line":"    # Copy the nova instance console logs if they exist"},{"line_number":851,"context_line":"    if [ -d $BASE/data/nova/instances ] ; then"},{"line_number":852,"context_line":"        sudo mkdir -p $BASE/logs/nova-logs"},{"line_number":853,"context_line":"        for dir_item in $BASE/data/nova/instances/* ; do"},{"line_number":854,"context_line":"            # The nova instance console logs are stored in directories"},{"line_number":855,"context_line":"            # named with the instance UUID.  This looks for directories"},{"line_number":856,"context_line":"            # named with a UUID to check for console.log."},{"line_number":857,"context_line":"            # The regex matches UUID formatting against the last"},{"line_number":858,"context_line":"            # path section in the directory listing."},{"line_number":859,"context_line":"            if [[ \"${dir_item##*/}\" \u003d~ ^[0-9a-fA-F]{8}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{12}$ ]] ; then"},{"line_number":860,"context_line":"                if [ -f $dir_item/console.log ] ; then"},{"line_number":861,"context_line":"                    sudo cp $dir_item/console.log $BASE/logs/nova-logs/console-${dir_item##*/}.log"},{"line_number":862,"context_line":"                fi"},{"line_number":863,"context_line":"            fi"},{"line_number":864,"context_line":"        done"},{"line_number":865,"context_line":"    fi"},{"line_number":866,"context_line":""},{"line_number":867,"context_line":"    # Copy tempest config file"}],"source_content_type":"text/x-sh","patch_set":2,"id":"ba0121b8_f14f1fbb","line":864,"range":{"start_line":853,"start_character":0,"end_line":864,"end_character":12},"updated":"2016-03-29 22:19:01.000000000","message":"another way to implement it without regex (this way it would not break in case uuid schema changes, and less trouble having to maintain the regex)\n\n  for dir_item in $BASE/data/nova/instances/*/console.log; do\n      if [ -f $dir_item ]; then\n          id\u003d${dir_item%/console.log}\n          id\u003d${id##*/}\n          sudo cp $dir_item $BASE/logs/nova-logs/console-${id}.log\n      fi\n  done","commit_id":"b6b464f25834204061b3014d273b3246f38a8df6"}]}
