)]}'
{"devstack-vm-gate.sh":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"aec257d9eda0b702c09009b495bd661d42671247","unresolved":false,"context_lines":[{"line_number":70,"context_line":"}"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"function setup_nova_net_networking {"},{"line_number":73,"context_line":"    local localrc\u003d$1"},{"line_number":74,"context_line":"    local primary_node\u003d$2"},{"line_number":75,"context_line":"    shift 2"},{"line_number":76,"context_line":"    local sub_nodes\u003d$@"}],"source_content_type":"text/x-sh","patch_set":12,"id":"3aaa91ec_206c27cd","line":73,"updated":"2016-06-24 20:32:33.000000000","message":"Can we rename this var to localconf so that it is clear we are setting localrc in the localconf file? It is sort of confusing reading through and seeing this used in different ways in this file.","commit_id":"78c3e44940a894c019d69c8f51b4da08dfc90368"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"aec257d9eda0b702c09009b495bd661d42671247","unresolved":false,"context_lines":[{"line_number":180,"context_line":""},{"line_number":181,"context_line":"function setup_localrc {"},{"line_number":182,"context_line":"    local localrc_oldnew\u003d$1;"},{"line_number":183,"context_line":"    local localrc_file\u003d$2"},{"line_number":184,"context_line":"    local role\u003d$3"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    # The branch we use to compute the feature matrix is pretty"}],"source_content_type":"text/x-sh","patch_set":12,"id":"3aaa91ec_00676be9","line":183,"updated":"2016-06-24 20:32:33.000000000","message":"See above comment.","commit_id":"78c3e44940a894c019d69c8f51b4da08dfc90368"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"6eb285a10e75175925e5ddb96f00d4b3fb542769","unresolved":false,"context_lines":[{"line_number":20,"context_line":"# limitations under the License."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"set -o errexit"},{"line_number":23,"context_line":"set -o xtrace"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# Keep track of the devstack directory"},{"line_number":26,"context_line":"TOP_DIR\u003d$(cd $(dirname \"$0\") \u0026\u0026 pwd)"}],"source_content_type":"text/x-sh","patch_set":18,"id":"fa31d9ce_1ef93dc9","line":23,"updated":"2017-02-09 23:00:16.000000000","message":"Is intent to leave this in place for final mergeable patchset or to remove it before then?","commit_id":"18905622d9b005e8e62f9b1428bf23e863379fe3"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"885b05baa98e59e4d729b394df9a335802a23ce4","unresolved":false,"context_lines":[{"line_number":20,"context_line":"# limitations under the License."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"set -o errexit"},{"line_number":23,"context_line":"set -o xtrace"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# Keep track of the devstack directory"},{"line_number":26,"context_line":"TOP_DIR\u003d$(cd $(dirname \"$0\") \u0026\u0026 pwd)"}],"source_content_type":"text/x-sh","patch_set":18,"id":"fa31d9ce_881dc175","line":23,"in_reply_to":"fa31d9ce_1ef93dc9","updated":"2017-02-10 20:23:29.000000000","message":"This is just to help during transition, the intent is to remove at the end.","commit_id":"18905622d9b005e8e62f9b1428bf23e863379fe3"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"6eb285a10e75175925e5ddb96f00d4b3fb542769","unresolved":false,"context_lines":[{"line_number":31,"context_line":"# Import common functions"},{"line_number":32,"context_line":"source $TOP_DIR/functions.sh"},{"line_number":33,"context_line":"# Get access to iniset and friends"},{"line_number":34,"context_line":"source $BASE/new/devstack/inc/ini-config"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"echo $PPID \u003e $WORKSPACE/gate.pid"},{"line_number":37,"context_line":"source `dirname \"$(readlink -f \"$0\")\"`/functions.sh"}],"source_content_type":"text/x-sh","patch_set":18,"id":"fa31d9ce_3ee4410c","line":34,"updated":"2017-02-09 23:00:16.000000000","message":"How stable is this? eg does devstack know that it is being consumed externally? I guess using it here along with the existing cogating will prevent it from breaking too badly.","commit_id":"18905622d9b005e8e62f9b1428bf23e863379fe3"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"885b05baa98e59e4d729b394df9a335802a23ce4","unresolved":false,"context_lines":[{"line_number":31,"context_line":"# Import common functions"},{"line_number":32,"context_line":"source $TOP_DIR/functions.sh"},{"line_number":33,"context_line":"# Get access to iniset and friends"},{"line_number":34,"context_line":"source $BASE/new/devstack/inc/ini-config"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"echo $PPID \u003e $WORKSPACE/gate.pid"},{"line_number":37,"context_line":"source `dirname \"$(readlink -f \"$0\")\"`/functions.sh"}],"source_content_type":"text/x-sh","patch_set":18,"id":"fa31d9ce_68188d85","line":34,"in_reply_to":"fa31d9ce_3ee4410c","updated":"2017-02-10 20:23:29.000000000","message":"The inc/ path is designed for export. The reality is that the localrc_set is going to be a transitional thing, eventually once we get dsconf into play, we\u0027ll redefine localrc_set here to use that instead, and drop this include.","commit_id":"18905622d9b005e8e62f9b1428bf23e863379fe3"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"6eb285a10e75175925e5ddb96f00d4b3fb542769","unresolved":false,"context_lines":[{"line_number":192,"context_line":"        cp $sub_localconf /tmp/tmp_sub_localconf"},{"line_number":193,"context_line":"        localrc_set /tmp/tmp_sub_localconf \"HOST_IP\" \"$NODE\""},{"line_number":194,"context_line":"        remote_copy_file /tmp/tmp_sub_localconf $NODE:$devstack_dir/local.conf"},{"line_number":195,"context_line":"        # remote_copy_file $localconf $NODE:$localconf"},{"line_number":196,"context_line":"    done"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    # NOTE(vsaienko) we need to have ssh connection among nodes to manage"}],"source_content_type":"text/x-sh","patch_set":18,"id":"fa31d9ce_de98856d","line":195,"updated":"2017-02-09 23:00:16.000000000","message":"Can this line be removed? I think it can be.","commit_id":"18905622d9b005e8e62f9b1428bf23e863379fe3"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"885b05baa98e59e4d729b394df9a335802a23ce4","unresolved":false,"context_lines":[{"line_number":192,"context_line":"        cp $sub_localconf /tmp/tmp_sub_localconf"},{"line_number":193,"context_line":"        localrc_set /tmp/tmp_sub_localconf \"HOST_IP\" \"$NODE\""},{"line_number":194,"context_line":"        remote_copy_file /tmp/tmp_sub_localconf $NODE:$devstack_dir/local.conf"},{"line_number":195,"context_line":"        # remote_copy_file $localconf $NODE:$localconf"},{"line_number":196,"context_line":"    done"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    # NOTE(vsaienko) we need to have ssh connection among nodes to manage"}],"source_content_type":"text/x-sh","patch_set":18,"id":"fa31d9ce_6326eebb","line":195,"in_reply_to":"fa31d9ce_de98856d","updated":"2017-02-10 20:23:29.000000000","message":"yes, I think it can.","commit_id":"18905622d9b005e8e62f9b1428bf23e863379fe3"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"6eb285a10e75175925e5ddb96f00d4b3fb542769","unresolved":false,"context_lines":[{"line_number":214,"context_line":"        [[ \"$DEVSTACK_GATE_NEUTRON\" -ne \u00271\u0027 ]]; then"},{"line_number":215,"context_line":"        if [[ \"$mode\" \u003d\u003d \"grenade\" ]]; then"},{"line_number":216,"context_line":"            setup_nova_net_networking \"$BASE/new/grenade/devstack.local.conf.base\" \"127.0.0.1\""},{"line_number":217,"context_line":"            setup_nova_net_networking \"$BASE/new/grenade/devstack.local.conf.target\" \"127.0.0.1\""},{"line_number":218,"context_line":"        else"},{"line_number":219,"context_line":"            setup_nova_net_networking \"$BASE/new/devstack/local.conf\" \"127.0.0.1\""},{"line_number":220,"context_line":"        fi"}],"source_content_type":"text/x-sh","patch_set":18,"id":"fa31d9ce_5ec4953f","line":217,"updated":"2017-02-09 23:00:16.000000000","message":"Note this will double \"set\" the overlay networking, which should be fine (its actually something we have had to fix for third party CIs). But its not as efficient as it could be though likely not a huge cost.","commit_id":"18905622d9b005e8e62f9b1428bf23e863379fe3"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"885b05baa98e59e4d729b394df9a335802a23ce4","unresolved":false,"context_lines":[{"line_number":214,"context_line":"        [[ \"$DEVSTACK_GATE_NEUTRON\" -ne \u00271\u0027 ]]; then"},{"line_number":215,"context_line":"        if [[ \"$mode\" \u003d\u003d \"grenade\" ]]; then"},{"line_number":216,"context_line":"            setup_nova_net_networking \"$BASE/new/grenade/devstack.local.conf.base\" \"127.0.0.1\""},{"line_number":217,"context_line":"            setup_nova_net_networking \"$BASE/new/grenade/devstack.local.conf.target\" \"127.0.0.1\""},{"line_number":218,"context_line":"        else"},{"line_number":219,"context_line":"            setup_nova_net_networking \"$BASE/new/devstack/local.conf\" \"127.0.0.1\""},{"line_number":220,"context_line":"        fi"}],"source_content_type":"text/x-sh","patch_set":18,"id":"fa31d9ce_43bc8a05","line":217,"in_reply_to":"fa31d9ce_5ec4953f","updated":"2017-02-10 20:23:29.000000000","message":"ah, right. Well there isn\u0027t quite the same shared common section for grenade with local.conf, so we kind of need to call both here.\n\nFortunately this code block is going to be pretty rarely executed because neutron is the default now.","commit_id":"18905622d9b005e8e62f9b1428bf23e863379fe3"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"6eb285a10e75175925e5ddb96f00d4b3fb542769","unresolved":false,"context_lines":[{"line_number":294,"context_line":"    if [[ \"$DEVSTACK_GATE_CEPH\" \u003d\u003d \"1\" ]]; then"},{"line_number":295,"context_line":"        localrc_set $localrc_file \"CINDER_ENABLED_BACKENDS\" \"ceph:ceph\""},{"line_number":296,"context_line":"        localrc_set $localrc_file \"TEMPEST_STORAGE_PROTOCOL\" \"ceph\""},{"line_number":297,"context_line":"        localrc_set $localrc_file \"CEPH_LOOPBACK_DISK_SIZE\" \"8G\""},{"line_number":298,"context_line":"    fi"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"    # the exercises we *don\u0027t* want to test on for devstack"}],"source_content_type":"text/x-sh","patch_set":18,"id":"fa31d9ce_defde56f","line":297,"updated":"2017-02-09 23:00:16.000000000","message":"This is a new setting is that intentional?","commit_id":"18905622d9b005e8e62f9b1428bf23e863379fe3"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"885b05baa98e59e4d729b394df9a335802a23ce4","unresolved":false,"context_lines":[{"line_number":294,"context_line":"    if [[ \"$DEVSTACK_GATE_CEPH\" \u003d\u003d \"1\" ]]; then"},{"line_number":295,"context_line":"        localrc_set $localrc_file \"CINDER_ENABLED_BACKENDS\" \"ceph:ceph\""},{"line_number":296,"context_line":"        localrc_set $localrc_file \"TEMPEST_STORAGE_PROTOCOL\" \"ceph\""},{"line_number":297,"context_line":"        localrc_set $localrc_file \"CEPH_LOOPBACK_DISK_SIZE\" \"8G\""},{"line_number":298,"context_line":"    fi"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"    # the exercises we *don\u0027t* want to test on for devstack"}],"source_content_type":"text/x-sh","patch_set":18,"id":"fa31d9ce_e80c7d44","line":297,"in_reply_to":"fa31d9ce_defde56f","updated":"2017-02-10 20:23:29.000000000","message":"nope, this was merge issue, I can delete that.","commit_id":"18905622d9b005e8e62f9b1428bf23e863379fe3"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"6eb285a10e75175925e5ddb96f00d4b3fb542769","unresolved":false,"context_lines":[{"line_number":315,"context_line":"        fi"},{"line_number":316,"context_line":"    fi"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"    localrc_set \"$localrc_file\" \"USE_SCREEN\" \"False\""},{"line_number":319,"context_line":"    localrc_set \"$localrc_file\" \"DEST\" \"$BASE/$localrc_oldnew\""},{"line_number":320,"context_line":"    # move DATA_DIR outside of DEST to keep DEST a bit cleaner"},{"line_number":321,"context_line":"    localrc_set \"$localrc_file\" \"DATA_DIR\" \"$BASE/data\""}],"source_content_type":"text/x-sh","patch_set":18,"id":"fa31d9ce_9e2a8de6","line":318,"updated":"2017-02-09 23:00:16.000000000","message":"I like how this \"fixes\" indentation compared to the heredoc.","commit_id":"18905622d9b005e8e62f9b1428bf23e863379fe3"},{"author":{"_account_id":7979,"name":"Mikhail S Medvedev","email":"mihailmed@gmail.com","username":"msmedved"},"change_message_id":"08124a829acb2f479746b1634e0e19d369674f5b","unresolved":false,"context_lines":[{"line_number":568,"context_line":"        if [[ -n \"$DEVSTACK_SUBNODE_CONFIG\" ]]; then"},{"line_number":569,"context_line":"            localrc_set \"$localrc_file\" \"$DEVSTACK_SUBNODE_CONFIG\" \u003e\u003e\"$localrc_file\""},{"line_number":570,"context_line":"        else"},{"line_number":571,"context_line":"            if [[ -n \"$DEVSTACK_LOCAL_CONFIG\" ]]; then"},{"line_number":572,"context_line":"                echo \"$DEVSTACK_LOCAL_CONFIG\" \u003e\u003e\"$localrc_file\""},{"line_number":573,"context_line":"            fi"},{"line_number":574,"context_line":"        fi"},{"line_number":575,"context_line":"    else"},{"line_number":576,"context_line":"        if [[ -n \"$DEVSTACK_LOCAL_CONFIG\" ]]; then"},{"line_number":577,"context_line":"            echo \"$DEVSTACK_LOCAL_CONFIG\" \u003e\u003e\"$localrc_file\""},{"line_number":578,"context_line":"        fi"},{"line_number":579,"context_line":"    fi"},{"line_number":580,"context_line":""}],"source_content_type":"text/x-sh","patch_set":19,"id":"da36d5c6_e3c92eae","line":577,"range":{"start_line":571,"start_character":0,"end_line":577,"end_character":59},"updated":"2017-02-18 00:00:44.000000000","message":"Now that localrc_file \u003d local.conf this would not work as expected. E.g. if local.conf contains another section after [[local|localrc]], DEVSTACK_LOCAL_CONFIG would get added into whatever section happens to be the last one.","commit_id":"09ac98ba3a4f28ccd65223bb6e569a60b2797a8a"},{"author":{"_account_id":7979,"name":"Mikhail S Medvedev","email":"mihailmed@gmail.com","username":"msmedved"},"change_message_id":"9eb11037f1f42668a8155f423c93aa3085fc50b6","unresolved":false,"context_lines":[{"line_number":568,"context_line":"        if [[ -n \"$DEVSTACK_SUBNODE_CONFIG\" ]]; then"},{"line_number":569,"context_line":"            localrc_set \"$localrc_file\" \"$DEVSTACK_SUBNODE_CONFIG\" \u003e\u003e\"$localrc_file\""},{"line_number":570,"context_line":"        else"},{"line_number":571,"context_line":"            if [[ -n \"$DEVSTACK_LOCAL_CONFIG\" ]]; then"},{"line_number":572,"context_line":"                echo \"$DEVSTACK_LOCAL_CONFIG\" \u003e\u003e\"$localrc_file\""},{"line_number":573,"context_line":"            fi"},{"line_number":574,"context_line":"        fi"},{"line_number":575,"context_line":"    else"},{"line_number":576,"context_line":"        if [[ -n \"$DEVSTACK_LOCAL_CONFIG\" ]]; then"},{"line_number":577,"context_line":"            echo \"$DEVSTACK_LOCAL_CONFIG\" \u003e\u003e\"$localrc_file\""},{"line_number":578,"context_line":"        fi"},{"line_number":579,"context_line":"    fi"},{"line_number":580,"context_line":""}],"source_content_type":"text/x-sh","patch_set":19,"id":"da36d5c6_7c2bee82","line":577,"range":{"start_line":571,"start_character":0,"end_line":577,"end_character":59},"in_reply_to":"da36d5c6_bac49992","updated":"2017-02-21 00:36:19.000000000","message":"The workaround I suggested would not work in case of grenade. Grenade uses dsconf, and when dsconf sees several localrc sections it creates duplicate settings.","commit_id":"09ac98ba3a4f28ccd65223bb6e569a60b2797a8a"},{"author":{"_account_id":7979,"name":"Mikhail S Medvedev","email":"mihailmed@gmail.com","username":"msmedved"},"change_message_id":"747b696697abd2f60f79e7ca840196b7df7bea01","unresolved":false,"context_lines":[{"line_number":568,"context_line":"        if [[ -n \"$DEVSTACK_SUBNODE_CONFIG\" ]]; then"},{"line_number":569,"context_line":"            localrc_set \"$localrc_file\" \"$DEVSTACK_SUBNODE_CONFIG\" \u003e\u003e\"$localrc_file\""},{"line_number":570,"context_line":"        else"},{"line_number":571,"context_line":"            if [[ -n \"$DEVSTACK_LOCAL_CONFIG\" ]]; then"},{"line_number":572,"context_line":"                echo \"$DEVSTACK_LOCAL_CONFIG\" \u003e\u003e\"$localrc_file\""},{"line_number":573,"context_line":"            fi"},{"line_number":574,"context_line":"        fi"},{"line_number":575,"context_line":"    else"},{"line_number":576,"context_line":"        if [[ -n \"$DEVSTACK_LOCAL_CONFIG\" ]]; then"},{"line_number":577,"context_line":"            echo \"$DEVSTACK_LOCAL_CONFIG\" \u003e\u003e\"$localrc_file\""},{"line_number":578,"context_line":"        fi"},{"line_number":579,"context_line":"    fi"},{"line_number":580,"context_line":""}],"source_content_type":"text/x-sh","patch_set":19,"id":"da36d5c6_bac49992","line":577,"range":{"start_line":571,"start_character":0,"end_line":577,"end_character":59},"in_reply_to":"da36d5c6_e3c92eae","updated":"2017-02-20 15:12:05.000000000","message":"A solution could be to have\n  echo -e \u0027\\n[[local|localrc]]\\n\u0027\"$DEVSTACK_LOCAL_CONFIG\" \u003e\u003e\"$localrc_file\"\n\nThe localrc fragments would get properly concatenated.","commit_id":"09ac98ba3a4f28ccd65223bb6e569a60b2797a8a"}]}