)]}'
{"devstack-vm-gate.sh":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"38e6e7baa70039669832475369161868f9ec081f","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        ovs_vxlan_bridge \"br-ex\" $primary_node \"True\" 1 \\"},{"line_number":131,"context_line":"                        $FLOATING_HOST_PREFIX $FLOATING_HOST_MASK \\"},{"line_number":132,"context_line":"                        $sub_nodes"},{"line_number":133,"context_line":"    elif [[ \"$DEVSTACK_GATE_IRONIC\" -eq \u00271\u0027 ]]; then"},{"line_number":134,"context_line":"        ovs_vxlan_bridge \"br_flat\" $primary_node \"True\" 1 \\"},{"line_number":135,"context_line":"                        $FLOATING_HOST_PREFIX $FLOATING_HOST_MASK \\"},{"line_number":136,"context_line":"                        $sub_nodes"},{"line_number":137,"context_line":"    fi"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    echo \"Preparing cross node connectivity\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"dada55a8_c8dd1544","line":136,"range":{"start_line":133,"start_character":0,"end_line":136,"end_character":34},"updated":"2016-07-18 20:56:53.000000000","message":"A few things.\n\n1) Why not just reuse the existing neutron br-int tunnel?\n2) This means you cannot use DVR with ironic because the code\nabove will fire instead of this\n3) If you can\u0027t use br-int then it would be preferable to use a consistent L2 overlay name so that docs are kept up to date and it is easier to understand that they behave the same instead of optionally creating two identical overlays that share everything except their names.\n\nMy suggestion would be to use br-int if possible. If not possible then rework this to configure br-ex in the DVR and Ironic cases and have a single setup for them instead of two.","commit_id":"e6dfde1441b3439ffa320626de6a98affa418a11"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"cd11173965cebfa821dbcf580ac360e270fae620","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        ovs_vxlan_bridge \"br-ex\" $primary_node \"True\" 1 \\"},{"line_number":131,"context_line":"                        $FLOATING_HOST_PREFIX $FLOATING_HOST_MASK \\"},{"line_number":132,"context_line":"                        $sub_nodes"},{"line_number":133,"context_line":"    elif [[ \"$DEVSTACK_GATE_IRONIC\" -eq \u00271\u0027 ]]; then"},{"line_number":134,"context_line":"        ovs_vxlan_bridge \"br_flat\" $primary_node \"True\" 1 \\"},{"line_number":135,"context_line":"                        $FLOATING_HOST_PREFIX $FLOATING_HOST_MASK \\"},{"line_number":136,"context_line":"                        $sub_nodes"},{"line_number":137,"context_line":"    fi"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    echo \"Preparing cross node connectivity\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"dada55a8_6ca306b3","line":136,"range":{"start_line":133,"start_character":0,"end_line":136,"end_character":34},"in_reply_to":"dada55a8_c8dd1544","updated":"2016-07-20 10:31:59.000000000","message":"Clark thanks for review. I doubt that we can use br-int, since we are going to map Neutron physnet to this bridge, not sure how it will work.\nI will be clearer to have a separate bridge for this.","commit_id":"e6dfde1441b3439ffa320626de6a98affa418a11"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"b2b5424b3ece4ce5bf5df699c8b7e9f2e585e247","unresolved":false,"context_lines":[{"line_number":135,"context_line":"                        $sub_nodes"},{"line_number":136,"context_line":"    fi"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    if [[ \"$DEVSTACK_GATE_IRONIC\" -eq \u00271\u0027 ]]; then"},{"line_number":139,"context_line":"        cat \u003c\u003cEOF \u003e\u003e\"$sub_localrc\""},{"line_number":140,"context_line":"MULTI_HOST\u003dTrue"},{"line_number":141,"context_line":"MULTI_HOST_ROLE\u003d\"subnode\""}],"source_content_type":"text/x-sh","patch_set":4,"id":"fa7ab95a_ace7fae2","line":138,"updated":"2016-08-26 16:03:19.000000000","message":"You should merge this if block with the one above. Also it would probably be best to handle DVR more directly to avoid confusion in the future if/when someone tries to run neutron + dvr + ironic.","commit_id":"09089233c7ec7f828b7b24daf58471b012f096d3"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"b666db67c517dc436751ac568e982831b9b4d3bd","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        # in order to have access to VMs on another nodes."},{"line_number":138,"context_line":"        ovs_vxlan_bridge \"br_ironic_vxlan\" $primary_node \"False\" 128 \\"},{"line_number":139,"context_line":"            $sub_nodes"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    fi"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    echo \"Preparing cross node connectivity\""}],"source_content_type":"text/x-sh","patch_set":6,"id":"7a8ec9b2_b6e11c01","line":140,"updated":"2016-09-20 00:36:30.000000000","message":"nit: extra space","commit_id":"856bd7da9c5c97cb094e06022bdc299d51bfb7e4"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"7a8589ceea5b856c85c12d1f80df8a414a239169","unresolved":false,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    if [[ \"$DEVSTACK_GATE_IRONIC\" -eq \u00271\u0027 ]]; then"},{"line_number":136,"context_line":"        # NOTE(vsaienko) Ironic VMs will be connected to this bridge"},{"line_number":137,"context_line":"        # in order to have access to VMs on another nodes."},{"line_number":138,"context_line":"        ovs_vxlan_bridge \"br_ironic_vxlan\" $primary_node \"False\" 128 \\"},{"line_number":139,"context_line":"            $sub_nodes"},{"line_number":140,"context_line":""}],"source_content_type":"text/x-sh","patch_set":7,"id":"3a98d1f4_2ef3fe74","line":137,"updated":"2016-09-28 19:10:47.000000000","message":"Can we update this commetn in a followup change to explain that ironic is also configuring IPs on these L2 network itself. This is why we don\u0027t need to have devstack-gate configure addresses here.","commit_id":"562325eaf5de64a57040274724bf1ccb3fe98239"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"d90ba213a563364495ec8e76c952374fd0dc2d5e","unresolved":false,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    if [[ \"$DEVSTACK_GATE_IRONIC\" -eq \u00271\u0027 ]]; then"},{"line_number":136,"context_line":"        # NOTE(vsaienko) Ironic VMs will be connected to this bridge"},{"line_number":137,"context_line":"        # in order to have access to VMs on another nodes."},{"line_number":138,"context_line":"        ovs_vxlan_bridge \"br_ironic_vxlan\" $primary_node \"False\" 128 \\"},{"line_number":139,"context_line":"            $sub_nodes"},{"line_number":140,"context_line":""}],"source_content_type":"text/x-sh","patch_set":7,"id":"3a98d1f4_09ff1c02","line":137,"in_reply_to":"3a98d1f4_2ef3fe74","updated":"2016-09-28 19:13:56.000000000","message":"will add as follow-up, thanks!","commit_id":"562325eaf5de64a57040274724bf1ccb3fe98239"}]}