)]}'
{"devstack-vm-gate.sh":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"1d89746f438151a2a7be7c22c37ef8c4b08c4bc9","unresolved":false,"context_lines":[{"line_number":249,"context_line":"    if [[ \"$DEVSTACK_GATE_NEUTRON\" -eq \"1\" ]]; then"},{"line_number":250,"context_line":"        echo \"Q_USE_DEBUG_COMMAND\u003dTrue\" \u003e\u003e\"$localrc_file\""},{"line_number":251,"context_line":"        echo \"NETWORK_GATEWAY\u003d10.1.0.1\" \u003e\u003e\"$localrc_file\""},{"line_number":252,"context_line":"        echo \"Q_USE_PROVIDERNET_FOR_PUBLIC\u003dTrue\" \u003e\u003e\"$localrc_file\""},{"line_number":253,"context_line":"    fi"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    if [[ \"$DEVSTACK_GATE_NEUTRON_DVR\" -eq \"1\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":1,"id":"fad55976_c44b5958","line":252,"updated":"2016-07-15 22:37:16.000000000","message":"A pedantic reader may ask why we need to set anything here if the option is deprecated. That could be a cool story to describe in commit message. Cool long sad wicked story.","commit_id":"504f135a7b86a17e929f2816b10525c434bf2951"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f181bc050fd52b8c95616d3661f39b984c5853ef","unresolved":false,"context_lines":[{"line_number":249,"context_line":"    if [[ \"$DEVSTACK_GATE_NEUTRON\" -eq \"1\" ]]; then"},{"line_number":250,"context_line":"        echo \"Q_USE_DEBUG_COMMAND\u003dTrue\" \u003e\u003e\"$localrc_file\""},{"line_number":251,"context_line":"        echo \"NETWORK_GATEWAY\u003d10.1.0.1\" \u003e\u003e\"$localrc_file\""},{"line_number":252,"context_line":"        echo \"Q_USE_PROVIDERNET_FOR_PUBLIC\u003dTrue\" \u003e\u003e\"$localrc_file\""},{"line_number":253,"context_line":"    fi"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    if [[ \"$DEVSTACK_GATE_NEUTRON_DVR\" -eq \"1\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":1,"id":"fad55976_c3b13791","line":252,"in_reply_to":"fad55976_20c97a79","updated":"2016-07-16 22:27:15.000000000","message":"Yeah, but when you deprecate something in upstream, you usually provide a path from the deprecated thing to a new shiny one. In that case, it\u0027s not what happened, meaning that the deployment tool cannot proceed with deprecation process on its part.","commit_id":"504f135a7b86a17e929f2816b10525c434bf2951"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"0519aab2595cb6e33c3e4421cf59410fdaa4211c","unresolved":false,"context_lines":[{"line_number":249,"context_line":"    if [[ \"$DEVSTACK_GATE_NEUTRON\" -eq \"1\" ]]; then"},{"line_number":250,"context_line":"        echo \"Q_USE_DEBUG_COMMAND\u003dTrue\" \u003e\u003e\"$localrc_file\""},{"line_number":251,"context_line":"        echo \"NETWORK_GATEWAY\u003d10.1.0.1\" \u003e\u003e\"$localrc_file\""},{"line_number":252,"context_line":"        echo \"Q_USE_PROVIDERNET_FOR_PUBLIC\u003dTrue\" \u003e\u003e\"$localrc_file\""},{"line_number":253,"context_line":"    fi"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    if [[ \"$DEVSTACK_GATE_NEUTRON_DVR\" -eq \"1\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":1,"id":"fad55976_f590c6ee","line":252,"in_reply_to":"fad55976_b5f5ae84","updated":"2016-07-15 23:31:07.000000000","message":"Right. But it\u0027s weird that something is deprecated in neutron but not its usage in a deployment tool. The dependency graph suggests not everything was done in neutron to claim its deprecation.","commit_id":"504f135a7b86a17e929f2816b10525c434bf2951"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"26186b3c8be007d88c512b9020a2cbc002c72619","unresolved":false,"context_lines":[{"line_number":249,"context_line":"    if [[ \"$DEVSTACK_GATE_NEUTRON\" -eq \"1\" ]]; then"},{"line_number":250,"context_line":"        echo \"Q_USE_DEBUG_COMMAND\u003dTrue\" \u003e\u003e\"$localrc_file\""},{"line_number":251,"context_line":"        echo \"NETWORK_GATEWAY\u003d10.1.0.1\" \u003e\u003e\"$localrc_file\""},{"line_number":252,"context_line":"        echo \"Q_USE_PROVIDERNET_FOR_PUBLIC\u003dTrue\" \u003e\u003e\"$localrc_file\""},{"line_number":253,"context_line":"    fi"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    if [[ \"$DEVSTACK_GATE_NEUTRON_DVR\" -eq \"1\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":1,"id":"fad55976_b5f5ae84","line":252,"in_reply_to":"fad55976_c44b5958","updated":"2016-07-15 23:29:24.000000000","message":"Well this option itself may not be deprecated in devstack. It affects several things. The deprecated part is in Neutron.","commit_id":"504f135a7b86a17e929f2816b10525c434bf2951"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"70e07d0a342549aa595c246cd5e9a107281a1311","unresolved":false,"context_lines":[{"line_number":249,"context_line":"    if [[ \"$DEVSTACK_GATE_NEUTRON\" -eq \"1\" ]]; then"},{"line_number":250,"context_line":"        echo \"Q_USE_DEBUG_COMMAND\u003dTrue\" \u003e\u003e\"$localrc_file\""},{"line_number":251,"context_line":"        echo \"NETWORK_GATEWAY\u003d10.1.0.1\" \u003e\u003e\"$localrc_file\""},{"line_number":252,"context_line":"        echo \"Q_USE_PROVIDERNET_FOR_PUBLIC\u003dTrue\" \u003e\u003e\"$localrc_file\""},{"line_number":253,"context_line":"    fi"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    if [[ \"$DEVSTACK_GATE_NEUTRON_DVR\" -eq \"1\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":1,"id":"fad55976_20c97a79","line":252,"in_reply_to":"fad55976_f590c6ee","updated":"2016-07-15 23:36:23.000000000","message":"\u003eBut it\u0027s weird that something is deprecated in neutron but not its usage in a deployment tool\n\nIsn\u0027t that what happens whenever you deprecate something? It gets deprecated upstream and then propagated down. The opposite would suggest that the deployment tool would know to deprecate things before they were deprecated in the actual project. Or did I misunderstand what you are saying?","commit_id":"504f135a7b86a17e929f2816b10525c434bf2951"}]}