)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"c3d7a71d2333e388a19d947b7926d9be0cdce7e7","unresolved":false,"context_lines":[{"line_number":13,"context_line":"as the flat interface otherwise the devstack VM has no access"},{"line_number":14,"context_line":"to the guest instances. So we shouldn\u0027t apply that workaround"},{"line_number":15,"context_line":"for XenServer. And we currently don\u0027t use multi-hosts for"},{"line_number":16,"context_line":"XenServer CI. So let\u0027s skipt it."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Ie6a00d138c9f7f08e3d39e426b0ebb82b901286d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ffe62b97_7f551dfa","line":16,"range":{"start_line":16,"start_character":23,"end_line":16,"end_character":28},"updated":"2017-05-12 16:24:15.000000000","message":"nit: Typo","commit_id":"b51e9047be428eef46243254058788d59e367a6f"}],"devstack-vm-gate.sh":[{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"3910061a71e8ac499beeda897ff63285224c8e8f","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    # issue with nova net configuring br100 to take over eth0"},{"line_number":76,"context_line":"    # by default."},{"line_number":77,"context_line":"    # TODO (clarkb): figure out how to make bridge setup sane with ansible."},{"line_number":78,"context_line":"    if [[ \"$DEVSTACK_GATE_VIRT_DRIVER\" !\u003d \"xenapi\" ]]; then"},{"line_number":79,"context_line":"        # The following work around shouldn\u0027t be applied on xenapi, as xenserver"},{"line_number":80,"context_line":"        # has vmnet connected on eth3."},{"line_number":81,"context_line":"        ovs_vxlan_bridge \"br_pub\" $primary_node \"True\" 1 \\"}],"source_content_type":"text/x-sh","patch_set":1,"id":"9ad45d7e_fcd0cdcb","line":78,"updated":"2016-08-08 11:14:22.000000000","message":"Should this check be around the call to setup_nova_net_networking instead of in the code here?","commit_id":"40be3445c6cc33f53caf7ed590dc29f70f9f195b"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"155d23009012612288953b89f721c959977312c6","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    # issue with nova net configuring br100 to take over eth0"},{"line_number":76,"context_line":"    # by default."},{"line_number":77,"context_line":"    # TODO (clarkb): figure out how to make bridge setup sane with ansible."},{"line_number":78,"context_line":"    if [[ \"$DEVSTACK_GATE_VIRT_DRIVER\" !\u003d \"xenapi\" ]]; then"},{"line_number":79,"context_line":"        # The following work around shouldn\u0027t be applied on xenapi, as xenserver"},{"line_number":80,"context_line":"        # has vmnet connected on eth3."},{"line_number":81,"context_line":"        ovs_vxlan_bridge \"br_pub\" $primary_node \"True\" 1 \\"}],"source_content_type":"text/x-sh","patch_set":1,"id":"9ad45d7e_ab85ac5a","line":78,"in_reply_to":"9ad45d7e_04971e91","updated":"2016-08-17 14:17:07.000000000","message":"OK.\nI\u0027m also wondering if actually this should be if DEVSTACK_GATE_VIRT_DRIVER \u003d\u003d libvirt then do do it.\nWhat\u0027s needed with other virt drivers? (added some for input","commit_id":"40be3445c6cc33f53caf7ed590dc29f70f9f195b"},{"author":{"_account_id":17920,"name":"Jianghua Wang","email":"jianghua.wang@citrix.com","username":"wjhfresh"},"change_message_id":"38d963a496bc106c7a9f68e69a25750f8785b659","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    # issue with nova net configuring br100 to take over eth0"},{"line_number":76,"context_line":"    # by default."},{"line_number":77,"context_line":"    # TODO (clarkb): figure out how to make bridge setup sane with ansible."},{"line_number":78,"context_line":"    if [[ \"$DEVSTACK_GATE_VIRT_DRIVER\" !\u003d \"xenapi\" ]]; then"},{"line_number":79,"context_line":"        # The following work around shouldn\u0027t be applied on xenapi, as xenserver"},{"line_number":80,"context_line":"        # has vmnet connected on eth3."},{"line_number":81,"context_line":"        ovs_vxlan_bridge \"br_pub\" $primary_node \"True\" 1 \\"}],"source_content_type":"text/x-sh","patch_set":1,"id":"9ad45d7e_04971e91","line":78,"in_reply_to":"9ad45d7e_fcd0cdcb","updated":"2016-08-09 05:16:27.000000000","message":"Thanks Bob. Understood that this function currently only contains this workaround which always setup multinode connectivity. But per this function\u0027s name, it\u0027s to setup network for nova. I think it\u0027s possible to add more into this function for nova network setup. With the xenapi check at here, it\u0027s easier for developer/reviewers to notice this check is only to skip the multinode workaround. So I prefer to put this check at the same place where has the workaround.","commit_id":"40be3445c6cc33f53caf7ed590dc29f70f9f195b"}]}