)]}'
{"id":"openstack%2Fdevstack-gate~352621","triplet_id":"openstack%2Fdevstack-gate~master~Id71ecbe9e15fe36d73f53135b3ca04fa01f87425","project":"openstack/devstack-gate","branch":"master","topic":"wip","hashtags":[],"change_id":"Id71ecbe9e15fe36d73f53135b3ca04fa01f87425","subject":"WIP: restart ntpd to sync time","status":"ABANDONED","created":"2016-08-08 22:33:11.000000000","updated":"2016-08-09 19:13:38.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"be9355c073ca30c08c0e87950ba6a56f5526795e","_number":352621,"virtual_id_number":352621,"owner":{"_account_id":6671,"name":"Jerry Zhao","email":"xyzjerry@gmail.com","username":"zhaoxinyu"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":1,"date":"2016-08-09 01:02:51.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"date":"2016-08-09 00:34:24.000000000","_account_id":6671,"name":"Jerry Zhao","email":"xyzjerry@gmail.com","username":"zhaoxinyu"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":-1,"date":"2016-08-08 23:15:58.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6671,"name":"Jerry Zhao","email":"xyzjerry@gmail.com","username":"zhaoxinyu"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":6671,"name":"Jerry Zhao","email":"xyzjerry@gmail.com","username":"zhaoxinyu"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6671,"name":"Jerry Zhao","email":"xyzjerry@gmail.com","username":"zhaoxinyu"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-08-08 23:15:58.000000000","updated_by":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"reviewer":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"state":"REVIEWER"},{"updated":"2016-08-09 01:02:51.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"4e1a726c452d2ec2dbece137fef028f2ffb2dd04","author":{"_account_id":6671,"name":"Jerry Zhao","email":"xyzjerry@gmail.com","username":"zhaoxinyu"},"date":"2016-08-08 22:33:11.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a9c963e176d3234a4ae4d35e5eed56c0c9f3767f","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2016-08-08 23:15:58.000000000","message":"Patch Set 1: Code-Review-1\n\nntp-wait is part of the ntp-perl packages\n\nthe short story is you want to enable the ntpdate service on fedora as it syncs the time before the ntp daemon starts.  for full details, see [1]\n\n[1] https://bugzilla.redhat.com/show_bug.cgi?id\u003d1361382#c3","accounts_in_message":[],"_revision_number":1},{"id":"27021525d90cf26d626fcc5e94e6a30ae1718468","author":{"_account_id":6671,"name":"Jerry Zhao","email":"xyzjerry@gmail.com","username":"zhaoxinyu"},"date":"2016-08-09 00:34:24.000000000","message":"Patch Set 1:\n\nthanks for the pointer, which helps me understand the underlying issue.\nbut ntpdate service is still actually calling ntpdate by using ntpdate-wrapper.\n\n grep ntpdate /usr/libexec/ntpdate-wrapper\n[ -x /usr/sbin/ntpdate ] || exit 5\n[ -f /etc/sysconfig/ntpdate ] || exit 6\n. /etc/sysconfig/ntpdate\n\t/usr/sbin/ntpdate -U ntp -s -b $OPTIONS $tickers \u0026\u003e /dev/null\n\nI also have another issue on ubuntu platform. my ci servers restore to earlier snapshot after each build. running ntp-wait alone doesn\u0027t seem to update the time immediately even though it returned OK right away, so d-g script would fail due to build step duration check. after a service nptd restart, however, will trigger an update of the system time, but ntp-wait will hang for a very long period of time. i understand from your link that it can be resolved by running ntpdate but this still goes back to the use of ntpdate.\ni suspect ntp-wait alone won\u0027t guarantee the time is in sync even if it says it is.","accounts_in_message":[],"_revision_number":1},{"id":"baee5a78260b5c5d25b8baee4e11beb138811b13","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2016-08-09 00:40:24.000000000","message":"Patch Set 1:\n\non the ntpdate service ... yes; everything says that ntpdate is deprecated in the manual etc, but the maintainer seems to say that this is the best way to get time in sync before starting ntpd.  Who\u0027s right?  I don\u0027t know :)\n\nAs to the ubuntu issue -- interesting.  ntp-wait just polls the status of ntpd which gives back a status word.  Is ntp-wait timing out for you in this case?  it might be a similar thing, where the time is wrong and ntp has gone into it\u0027s 10-minute resync loop","accounts_in_message":[],"_revision_number":1},{"id":"08831836869619dfe19591e93857896c944175b8","author":{"_account_id":6671,"name":"Jerry Zhao","email":"xyzjerry@gmail.com","username":"zhaoxinyu"},"date":"2016-08-09 00:51:40.000000000","message":"Patch Set 1:\n\njenkins@jerryz-devstack-vm-aio:~$ sudo ntp-wait -v -n 10\nWaiting for ntpd to synchronize... OK!\njenkins@jerryz-devstack-vm-aio:~$ date\nThu Jul  7 11:31:07 PDT 2016\njenkins@jerryz-devstack-vm-aio:~$ \njenkins@jerryz-devstack-vm-aio:~$ sudo ntp-wait -v -n 10\nWaiting for ntpd to synchronize... OK!\njenkins@jerryz-devstack-vm-aio:~$ date\nThu Jul  7 11:31:22 PDT 2016\njenkins@jerryz-devstack-vm-aio:~$ \n\nThis what i did on my ubuntu server just now. the time is still Thu Jul  7 11:31:22 PDT 2016 when the snapshot was taken even after ntp-wait.","accounts_in_message":[],"_revision_number":1},{"id":"af3e4ca0fbd05734361a4d719277b2c119a5bdb7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-08-09 01:02:51.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-tempest-dsvm-full-ubuntu-xenial http://logs.openstack.org/21/352621/1/check/gate-tempest-dsvm-full-ubuntu-xenial/c55043f/ : SUCCESS in 1h 14m 05s\n- gate-tempest-dsvm-postgres-full-ubuntu-xenial http://logs.openstack.org/21/352621/1/check/gate-tempest-dsvm-postgres-full-ubuntu-xenial/00d5455/ : SUCCESS in 1h 12m 12s\n- gate-tempest-dsvm-neutron-full-ubuntu-xenial http://logs.openstack.org/21/352621/1/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/58dcca7/ : SUCCESS in 1h 27m 03s\n- gate-grenade-dsvm-ubuntu-trusty http://logs.openstack.org/21/352621/1/check/gate-grenade-dsvm-ubuntu-trusty/efd1326/ : SUCCESS in 41m 15s\n- gate-devstack-gate-unittests http://logs.openstack.org/21/352621/1/check/gate-devstack-gate-unittests/06e4025/ : SUCCESS in 3m 26s\n- gate-devstack-gate-bashate http://logs.openstack.org/21/352621/1/check/gate-devstack-gate-bashate/fb30fa4/ : SUCCESS in 3m 44s\n- gate-dg-hooks-dsvm http://logs.openstack.org/21/352621/1/check/gate-dg-hooks-dsvm/b015262/ : SUCCESS in 12m 21s\n- gate-grenade-dsvm-multinode http://logs.openstack.org/21/352621/1/check/gate-grenade-dsvm-multinode/50099fa/ : SUCCESS in 47m 13s\n- gate-grenade-dsvm-neutron-multinode http://logs.openstack.org/21/352621/1/check/gate-grenade-dsvm-neutron-multinode/0317c37/ : SUCCESS in 1h 00m 56s\n- gate-neutron-dsvm-functional-nv http://logs.openstack.org/21/352621/1/check/gate-neutron-dsvm-functional-nv/9ff5ecb/ : SUCCESS in 16m 38s (non-voting)\n- gate-swift-dsvm-functional-nv http://logs.openstack.org/21/352621/1/check/gate-swift-dsvm-functional-nv/ecf1c7a/ : SUCCESS in 33m 42s (non-voting)\n- gate-tempest-dsvm-full-ubuntu-trusty-liberty-nv http://logs.openstack.org/21/352621/1/check/gate-tempest-dsvm-full-ubuntu-trusty-liberty-nv/94557d5/ : SUCCESS in 1h 11m 19s (non-voting)\n- gate-tempest-dsvm-neutron-full-ubuntu-trusty-liberty-nv http://logs.openstack.org/21/352621/1/check/gate-tempest-dsvm-neutron-full-ubuntu-trusty-liberty-nv/37b2db1/ : SUCCESS in 59m 19s (non-voting)\n- gate-tempest-dsvm-postgres-full-ubuntu-trusty-liberty-nv http://logs.openstack.org/21/352621/1/check/gate-tempest-dsvm-postgres-full-ubuntu-trusty-liberty-nv/4e07504/ : SUCCESS in 43m 56s (non-voting)\n- gate-tempest-dsvm-full-ubuntu-trusty-mitaka-nv http://logs.openstack.org/21/352621/1/check/gate-tempest-dsvm-full-ubuntu-trusty-mitaka-nv/353f72b/ : SUCCESS in 44m 18s (non-voting)\n- gate-tempest-dsvm-neutron-full-ubuntu-trusty-mitaka-nv http://logs.openstack.org/21/352621/1/check/gate-tempest-dsvm-neutron-full-ubuntu-trusty-mitaka-nv/d56f6f4/ : SUCCESS in 1h 03m 11s (non-voting)\n- gate-tempest-dsvm-postgres-full-ubuntu-trusty-mitaka-nv http://logs.openstack.org/21/352621/1/check/gate-tempest-dsvm-postgres-full-ubuntu-trusty-mitaka-nv/a79d1d1/ : SUCCESS in 53m 41s (non-voting)\n- gate-tempest-dsvm-platform-centos7-nv http://logs.openstack.org/21/352621/1/check/gate-tempest-dsvm-platform-centos7-nv/cbab503/ : SUCCESS in 52m 14s (non-voting)\n- gate-tempest-dsvm-multinode-full http://logs.openstack.org/21/352621/1/check/gate-tempest-dsvm-multinode-full/bca4d17/ : FAILURE in 42m 51s (non-voting)\n- gate-tempest-dsvm-neutron-multinode-full http://logs.openstack.org/21/352621/1/check/gate-tempest-dsvm-neutron-multinode-full/40ac9f9/ : SUCCESS in 1h 30m 14s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"841e60eae399d05a11d0259940bb86ec334f545c","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2016-08-09 04:10:17.000000000","message":"Patch Set 1:\n\nI *think*, and it\u0027s just a guess, is that maybe you\u0027ve restored the snapshot and ntp hasn\u0027t actually realised its out of sync yet?  \n\nor, the time is so out of sync, that ntpd doesn\u0027t do anything.  either way nothing happens i guess\n\nSee I4d827bd6761ac7e9359a0ec2a9f803c52becc859 and I5e524588417c37691b9c1f6a2d3dccdb1f2340c8 ; i think chrony might just work better for us, especially with things like snapshot restore","accounts_in_message":[],"_revision_number":1},{"id":"f2f4180b8debd57d8ff0497d736d68175319785b","author":{"_account_id":6671,"name":"Jerry Zhao","email":"xyzjerry@gmail.com","username":"zhaoxinyu"},"date":"2016-08-09 19:13:38.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"3a98f81bcf71b371e233f59a965fc91dcba80e21","revisions":{"3a98f81bcf71b371e233f59a965fc91dcba80e21":{"kind":"REWORK","_number":1,"created":"2016-08-08 22:33:11.000000000","uploader":{"_account_id":6671,"name":"Jerry Zhao","email":"xyzjerry@gmail.com","username":"zhaoxinyu"},"ref":"refs/changes/21/352621/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack-gate","ref":"refs/changes/21/352621/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack-gate refs/changes/21/352621/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack-gate refs/changes/21/352621/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack-gate refs/changes/21/352621/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack-gate refs/changes/21/352621/1"}}},"commit":{"parents":[{"commit":"54b30a1b6a87baeb3a9bcf99624baca51fd1523b","subject":"Use ntp wait time as 10 min instead of 100","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-gate/commit/54b30a1b6a87baeb3a9bcf99624baca51fd1523b"}]}],"author":{"name":"Jerry Zhao","email":"xyzjerry@gmail.com","date":"2016-08-08 22:31:24.000000000","tz":-420},"committer":{"name":"Jerry Zhao","email":"xyzjerry@gmail.com","date":"2016-08-08 22:33:10.000000000","tz":-420},"subject":"WIP: restart ntpd to sync time","message":"WIP: restart ntpd to sync time\n\nntp-wait doesn\u0027t exist on fedora platforms.\n\nChange-Id: Id71ecbe9e15fe36d73f53135b3ca04fa01f87425\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-gate/commit/3a98f81bcf71b371e233f59a965fc91dcba80e21"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-gate/commit/3a98f81bcf71b371e233f59a965fc91dcba80e21"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}