)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"f842b46fbf3670eb6f082b2eaeb69ebb9324b291","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     John L. Villalovos \u003cjohn.l.villalovos@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-18 13:58:59 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Do not add c-api,c-bak on subnode with Ironic"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Cinder is not installed on primary node in Ironic jobs. When c-api,c-bak were"},{"line_number":10,"context_line":"added to MY_ENABLED_SERVICES on subnode it caused ironic multinode job to failure."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1ac06dbe_601b501d","line":7,"range":{"start_line":7,"start_character":11,"end_line":7,"end_character":16},"updated":"2016-08-25 09:22:28.000000000","message":"c-vol","commit_id":"32c4b0a2f46b16e0e3268159668717cacd29aa6d"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"880b8295efa3477e23df6443e42a62c682d2d8dc","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     John L. Villalovos \u003cjohn.l.villalovos@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-18 13:58:59 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Do not add c-api,c-bak on subnode with Ironic"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Cinder is not installed on primary node in Ironic jobs. When c-api,c-bak were"},{"line_number":10,"context_line":"added to MY_ENABLED_SERVICES on subnode it caused ironic multinode job to failure."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa7ab95a_0afa9442","line":7,"range":{"start_line":7,"start_character":11,"end_line":7,"end_character":16},"in_reply_to":"1ac06dbe_601b501d","updated":"2016-08-26 13:48:44.000000000","message":"Done","commit_id":"32c4b0a2f46b16e0e3268159668717cacd29aa6d"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"f842b46fbf3670eb6f082b2eaeb69ebb9324b291","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Do not add c-api,c-bak on subnode with Ironic"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Cinder is not installed on primary node in Ironic jobs. When c-api,c-bak were"},{"line_number":10,"context_line":"added to MY_ENABLED_SERVICES on subnode it caused ironic multinode job to failure."},{"line_number":11,"context_line":"This patch adds c-api,c-bak to enabled_services only when Ironic is not used."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1ac06dbe_c01a0417","line":9,"range":{"start_line":9,"start_character":61,"end_line":9,"end_character":66},"updated":"2016-08-25 09:22:28.000000000","message":"c-vol","commit_id":"32c4b0a2f46b16e0e3268159668717cacd29aa6d"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"880b8295efa3477e23df6443e42a62c682d2d8dc","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Do not add c-api,c-bak on subnode with Ironic"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Cinder is not installed on primary node in Ironic jobs. When c-api,c-bak were"},{"line_number":10,"context_line":"added to MY_ENABLED_SERVICES on subnode it caused ironic multinode job to failure."},{"line_number":11,"context_line":"This patch adds c-api,c-bak to enabled_services only when Ironic is not used."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa7ab95a_2a9598e3","line":9,"range":{"start_line":9,"start_character":61,"end_line":9,"end_character":66},"in_reply_to":"1ac06dbe_c01a0417","updated":"2016-08-26 13:48:44.000000000","message":"Done","commit_id":"32c4b0a2f46b16e0e3268159668717cacd29aa6d"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"d00de00f0657449b37976b5fe7771f52bbaa1b04","unresolved":false,"context_lines":[{"line_number":12,"context_line":"primary node."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Reference:"},{"line_number":15,"context_line":"[0] https://review.openstack.org/#/c/352909/"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Co-Authored-By: Vladyslav Drok \u003cvdrok@mirantis.com\u003e"},{"line_number":18,"context_line":"Change-Id: I7807fe5f76d9fa8b778371299d177cb0bfafc78b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7a8ec9b2_f6d9e484","line":15,"updated":"2016-09-20 00:26:09.000000000","message":"? this refers to itself?","commit_id":"f6d17f31b2ac93bf06acdacc0d49cb84a46a1fd2"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"4b9256701d76b41d15442801da7f238db640dccc","unresolved":false,"context_lines":[{"line_number":12,"context_line":"primary node."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Reference:"},{"line_number":15,"context_line":"[0] https://review.openstack.org/#/c/352909/"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Co-Authored-By: Vladyslav Drok \u003cvdrok@mirantis.com\u003e"},{"line_number":18,"context_line":"Change-Id: I7807fe5f76d9fa8b778371299d177cb0bfafc78b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7a8ec9b2_38625217","line":15,"in_reply_to":"7a8ec9b2_f6d9e484","updated":"2016-09-20 06:53:01.000000000","message":"here should be https://review.openstack.org/#/c/327619/","commit_id":"f6d17f31b2ac93bf06acdacc0d49cb84a46a1fd2"}],"devstack-vm-gate.sh":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"d20e7f919c3c381bc98c39493e42fd6faa2eb414","unresolved":false,"context_lines":[{"line_number":217,"context_line":"        if [[ $role \u003d sub ]]; then"},{"line_number":218,"context_line":"            MY_ENABLED_SERVICES\u003d\"n-cpu,ceilometer-acompute,dstat\""},{"line_number":219,"context_line":"            # NOTE(vsaienko) Ironic jobs do not install cinder on primary node"},{"line_number":220,"context_line":"            if [[ \"$DEVSTACK_GATE_IRONIC\" -eq \u00270\u0027 ]]; then"},{"line_number":221,"context_line":"                MY_ENABLED_SERVICES+\u003d\",c-vol,c-bak\""},{"line_number":222,"context_line":"            fi"},{"line_number":223,"context_line":"            if [[ \"$DEVSTACK_GATE_NEUTRON\" -eq \"1\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":2,"id":"9ad45d7e_1da6f152","line":220,"updated":"2016-08-10 15:23:04.000000000","message":"I don\u0027t think this is a good idea. As usually it is not even set.\n\nNow maybe:\n\n ${DEVSTACK_GATE_IRONIC:-0}\n\nOr check that it is not 1. I also have a similar patch :)\nhttps://review.openstack.org/#/c/353191/2/devstack-vm-gate.sh\n\nMaybe do:\n if [ \"${DEVSTACK_GATE_IRONIC}\" !\u003d \"1\" ]; then\n\nThis will handle the case of an uset variable.\n\n \u0027-ne\u0027 and \u0027-eq\u0027 assume that there will be an integer value and an empty value is not an integer.","commit_id":"e083d0b2b0eb7937a9b7ef0f88aaa7e83ca4b398"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"b61153a9d6ab58f76390d96aa36c9b442cee491f","unresolved":false,"context_lines":[{"line_number":217,"context_line":"        if [[ $role \u003d sub ]]; then"},{"line_number":218,"context_line":"            MY_ENABLED_SERVICES\u003d\"n-cpu,ceilometer-acompute,dstat\""},{"line_number":219,"context_line":"            # NOTE(vsaienko) Ironic jobs do not install cinder on primary node"},{"line_number":220,"context_line":"            if [[ \"$DEVSTACK_GATE_IRONIC\" -eq \u00270\u0027 ]]; then"},{"line_number":221,"context_line":"                MY_ENABLED_SERVICES+\u003d\",c-vol,c-bak\""},{"line_number":222,"context_line":"            fi"},{"line_number":223,"context_line":"            if [[ \"$DEVSTACK_GATE_NEUTRON\" -eq \"1\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":2,"id":"9ad45d7e_9f7915cb","line":220,"in_reply_to":"9ad45d7e_1da6f152","updated":"2016-08-11 07:26:39.000000000","message":"I\u0027ve already thought about adding ir-api and ir-cond on subnode, but it is only cosmetic change since they added when we enabling ironic plugin by default. Lets add them here apparently to have better understanding. https://github.com/openstack/ironic/blob/master/devstack/settings","commit_id":"e083d0b2b0eb7937a9b7ef0f88aaa7e83ca4b398"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"f842b46fbf3670eb6f082b2eaeb69ebb9324b291","unresolved":false,"context_lines":[{"line_number":216,"context_line":"        # TODO(afazekas): Move to the feature grid"},{"line_number":217,"context_line":"        if [[ $role \u003d sub ]]; then"},{"line_number":218,"context_line":"            MY_ENABLED_SERVICES\u003d\"n-cpu,ceilometer-acompute,dstat\""},{"line_number":219,"context_line":"            # NOTE(vsaienko) Ironic jobs do not install cinder on primary node"},{"line_number":220,"context_line":"            if [[ \"$DEVSTACK_GATE_IRONIC\" -eq \u00271\u0027 ]]; then"},{"line_number":221,"context_line":"                MY_ENABLED_SERVICES+\u003d\",ir-api,ir-cond\""},{"line_number":222,"context_line":"            else"},{"line_number":223,"context_line":"                MY_ENABLED_SERVICES+\u003d\",c-vol,c-bak\""},{"line_number":224,"context_line":"            fi"},{"line_number":225,"context_line":"            if [[ \"$DEVSTACK_GATE_NEUTRON\" -eq \"1\" ]]; then"},{"line_number":226,"context_line":"                MY_ENABLED_SERVICES+\u003d\",q-agt\""},{"line_number":227,"context_line":"                if [[ \"$DEVSTACK_GATE_NEUTRON_DVR\" -eq \"1\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":4,"id":"1ac06dbe_40abb489","line":224,"range":{"start_line":219,"start_character":0,"end_line":224,"end_character":14},"updated":"2016-08-25 09:22:28.000000000","message":"It would be better to base this logic on the fact if c-api is enabled on primary node. From what I see here you can check if it\u0027s in MY_ENABLED_SERVICES set in 213.","commit_id":"32c4b0a2f46b16e0e3268159668717cacd29aa6d"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"880b8295efa3477e23df6443e42a62c682d2d8dc","unresolved":false,"context_lines":[{"line_number":216,"context_line":"        # TODO(afazekas): Move to the feature grid"},{"line_number":217,"context_line":"        if [[ $role \u003d sub ]]; then"},{"line_number":218,"context_line":"            MY_ENABLED_SERVICES\u003d\"n-cpu,ceilometer-acompute,dstat\""},{"line_number":219,"context_line":"            # NOTE(vsaienko) Ironic jobs do not install cinder on primary node"},{"line_number":220,"context_line":"            if [[ \"$DEVSTACK_GATE_IRONIC\" -eq \u00271\u0027 ]]; then"},{"line_number":221,"context_line":"                MY_ENABLED_SERVICES+\u003d\",ir-api,ir-cond\""},{"line_number":222,"context_line":"            else"},{"line_number":223,"context_line":"                MY_ENABLED_SERVICES+\u003d\",c-vol,c-bak\""},{"line_number":224,"context_line":"            fi"},{"line_number":225,"context_line":"            if [[ \"$DEVSTACK_GATE_NEUTRON\" -eq \"1\" ]]; then"},{"line_number":226,"context_line":"                MY_ENABLED_SERVICES+\u003d\",q-agt\""},{"line_number":227,"context_line":"                if [[ \"$DEVSTACK_GATE_NEUTRON_DVR\" -eq \"1\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":4,"id":"fa7ab95a_2ccf7557","line":224,"range":{"start_line":219,"start_character":0,"end_line":224,"end_character":14},"in_reply_to":"1ac06dbe_40abb489","updated":"2016-08-26 13:48:44.000000000","message":"Done","commit_id":"32c4b0a2f46b16e0e3268159668717cacd29aa6d"}]}