)]}'
{"id":"openstack%2Fdevstack-gate~362696","triplet_id":"openstack%2Fdevstack-gate~master~Ibf656ef063ac15593ee277518132c1ec60b69383","project":"openstack/devstack-gate","branch":"master","topic":"always-keep-localrc","hashtags":[],"change_id":"Ibf656ef063ac15593ee277518132c1ec60b69383","subject":"Always keep the local.conf file","status":"ABANDONED","created":"2016-08-30 08:24:02.000000000","updated":"2017-02-21 22:38:58.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"09c3d2507a25db60d0ecd87fb4b30292506db011","_number":362696,"virtual_id_number":362696,"owner":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":1,"date":"2016-08-30 10:08:24.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":22312,"name":"Andrei","email":"andrei.perepiolkin@open-e.com","username":"andrei.perepiolkin"},{"_account_id":7979,"name":"Mikhail S Medvedev","email":"mihailmed@gmail.com","username":"msmedved"},{"date":"2016-11-28 17:08:39.000000000","_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"rejected":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"recommended":{"_account_id":7979,"name":"Mikhail S Medvedev","email":"mihailmed@gmail.com","username":"msmedved"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-12-09 15:28:50.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":22312,"name":"Andrei","email":"andrei.perepiolkin@open-e.com","username":"andrei.perepiolkin"},{"value":1,"date":"2016-11-28 20:10:09.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":7979,"name":"Mikhail S Medvedev","email":"mihailmed@gmail.com","username":"msmedved"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},{"value":-2,"date":"2017-01-19 18:27:52.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":2,"date":"2016-09-06 05:36:32.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":22312,"name":"Andrei","email":"andrei.perepiolkin@open-e.com","username":"andrei.perepiolkin"},{"_account_id":7979,"name":"Mikhail S Medvedev","email":"mihailmed@gmail.com","username":"msmedved"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":7979,"name":"Mikhail S Medvedev","email":"mihailmed@gmail.com","username":"msmedved"},{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},{"_account_id":22312,"name":"Andrei","email":"andrei.perepiolkin@open-e.com","username":"andrei.perepiolkin"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-08-30 10:08:24.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2016-09-06 05:36:32.000000000","updated_by":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"reviewer":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"state":"REVIEWER"},{"updated":"2016-11-28 20:10:09.000000000","updated_by":{"_account_id":7979,"name":"Mikhail S Medvedev","email":"mihailmed@gmail.com","username":"msmedved"},"reviewer":{"_account_id":7979,"name":"Mikhail S Medvedev","email":"mihailmed@gmail.com","username":"msmedved"},"state":"REVIEWER"},{"updated":"2016-12-09 15:28:50.000000000","updated_by":{"_account_id":22312,"name":"Andrei","email":"andrei.perepiolkin@open-e.com","username":"andrei.perepiolkin"},"reviewer":{"_account_id":22312,"name":"Andrei","email":"andrei.perepiolkin@open-e.com","username":"andrei.perepiolkin"},"state":"REVIEWER"},{"updated":"2017-01-19 18:27:52.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"}],"messages":[{"id":"575b833d6be8ba7e1d9b191460403331ee542f56","author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"date":"2016-08-30 08:24:02.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f14889a26f1a0b111a8212ac1ffd9617dc470beb","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-08-30 10:08:24.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-grenade-dsvm-neutron-ubuntu-trusty http://logs.openstack.org/96/362696/1/check/gate-grenade-dsvm-neutron-ubuntu-trusty/1759d00/ : SUCCESS in 35m 34s\n- gate-tempest-dsvm-neutron-full-ubuntu-xenial http://logs.openstack.org/96/362696/1/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/6388f02/ : SUCCESS in 1h 01m 28s\n- gate-tempest-dsvm-full-ubuntu-xenial http://logs.openstack.org/96/362696/1/check/gate-tempest-dsvm-full-ubuntu-xenial/fa76744/ : SUCCESS in 48m 21s\n- gate-grenade-dsvm-ubuntu-trusty http://logs.openstack.org/96/362696/1/check/gate-grenade-dsvm-ubuntu-trusty/1a07600/ : SUCCESS in 27m 37s\n- gate-devstack-gate-unittests http://logs.openstack.org/96/362696/1/check/gate-devstack-gate-unittests/df283b4/ : SUCCESS in 1m 47s\n- gate-devstack-gate-bashate http://logs.openstack.org/96/362696/1/check/gate-devstack-gate-bashate/adf4306/ : SUCCESS in 2m 31s\n- gate-dg-hooks-dsvm http://logs.openstack.org/96/362696/1/check/gate-dg-hooks-dsvm/b095a73/ : SUCCESS in 3m 23s\n- gate-grenade-dsvm-multinode http://logs.openstack.org/96/362696/1/check/gate-grenade-dsvm-multinode/f6b3071/ : SUCCESS in 50m 27s\n- gate-grenade-dsvm-neutron-multinode http://logs.openstack.org/96/362696/1/check/gate-grenade-dsvm-neutron-multinode/95ff581/ : SUCCESS in 1h 01m 11s\n- gate-neutron-dsvm-functional-nv http://logs.openstack.org/96/362696/1/check/gate-neutron-dsvm-functional-nv/f44fc33/ : SUCCESS in 18m 50s (non-voting)\n- gate-swift-dsvm-functional-nv http://logs.openstack.org/96/362696/1/check/gate-swift-dsvm-functional-nv/a30b8d0/ : SUCCESS in 31m 49s (non-voting)\n- gate-tempest-dsvm-full-ubuntu-trusty-liberty-nv http://logs.openstack.org/96/362696/1/check/gate-tempest-dsvm-full-ubuntu-trusty-liberty-nv/844f033/ : SUCCESS in 45m 00s (non-voting)\n- gate-tempest-dsvm-neutron-full-ubuntu-trusty-liberty-nv http://logs.openstack.org/96/362696/1/check/gate-tempest-dsvm-neutron-full-ubuntu-trusty-liberty-nv/667975b/ : SUCCESS in 54m 25s (non-voting)\n- gate-tempest-dsvm-full-ubuntu-trusty-mitaka-nv http://logs.openstack.org/96/362696/1/check/gate-tempest-dsvm-full-ubuntu-trusty-mitaka-nv/53a9688/ : SUCCESS in 43m 59s (non-voting)\n- gate-tempest-dsvm-neutron-full-ubuntu-trusty-mitaka-nv http://logs.openstack.org/96/362696/1/check/gate-tempest-dsvm-neutron-full-ubuntu-trusty-mitaka-nv/c377459/ : SUCCESS in 1h 01m 05s (non-voting)\n- gate-tempest-dsvm-platform-centos7-nv http://logs.openstack.org/96/362696/1/check/gate-tempest-dsvm-platform-centos7-nv/f2f70ff/ : SUCCESS in 46m 39s (non-voting)\n- gate-tempest-dsvm-multinode-full http://logs.openstack.org/96/362696/1/check/gate-tempest-dsvm-multinode-full/05005d3/ : SUCCESS in 52m 46s (non-voting)\n- gate-tempest-dsvm-neutron-multinode-full http://logs.openstack.org/96/362696/1/check/gate-tempest-dsvm-neutron-multinode-full/5df2fff/ : SUCCESS in 1h 35m 27s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"05af1e9912bf1e0a474f1987f2a42142321f4018","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2016-09-06 05:36:32.000000000","message":"Patch Set 1: Code-Review+2\n\nWhy is this rm even here?  From what I can tell it was added in I8560ddad5981741e1bc35557616fe2a1808199e6 maybe because the \u003e for writing localrc was being changed to a \u003e\u003e for quantum support.\n\nI\u0027m not sure it was ever really necessary to clear the file out in a CI environment where you\u0027re starting fresh?  Maybe this was done at the time because people were running d-g manually in a non-fresh environment and picking up an old localrc, so they wanted to be sure it used the latest?\n\nin the years since, we\u0027ve developed hooks and plugins and then this workaround for the rm which I guess nobody looked deeply at\n\nThis LGTM, i can\u0027t see why we want to clear this out \u0026 it simplifies things (although I\u0027m sure the value will continue to be cargo-culted for many years to come)","accounts_in_message":[],"_revision_number":1},{"id":"f97091a07a95105bd8cf492a5b9d940bd24c4cdf","author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"date":"2016-11-28 17:08:39.000000000","message":"Patch Set 1:\n\nAnyone else would like to comment this?","accounts_in_message":[],"_revision_number":1},{"id":"473d33ba44e58f3840a1bfb5a7563db5addecfb5","author":{"_account_id":7979,"name":"Mikhail S Medvedev","email":"mihailmed@gmail.com","username":"msmedved"},"date":"2016-11-28 20:10:09.000000000","message":"Patch Set 1: Code-Review+1\n\nAs a third party CI maintainer, big +1.","accounts_in_message":[],"_revision_number":1},{"id":"78490d07f945a981ba9cf6091f9d062107050391","author":{"_account_id":22312,"name":"Andrei","email":"andrei.perepiolkin@open-e.com","username":"andrei.perepiolkin"},"date":"2016-12-09 15:28:50.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"3e826889401c4543328936b10bd7c8e2b6bcc87d","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2017-01-19 18:27:52.000000000","message":"Patch Set 1: Code-Review-2\n\nChanging this default is actually going to ruin a ton of 3rd party CI systems that reuse nodes.","accounts_in_message":[],"_revision_number":1},{"id":"a988aaafa2293597268119e1d37189ec3dc34d87","author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"date":"2017-01-19 18:31:59.000000000","message":"Patch Set 1:\n\nHow are they not broken already when KEEP_LOCALRC is set?","accounts_in_message":[],"_revision_number":1},{"id":"8a35c6460577640ffd5aff56c83485065c322b1e","author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"date":"2017-02-21 22:38:58.000000000","message":"Abandoned\n\nSee the comments: opt-in as it is now is less risky (unfortunately :/ ).","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"6c587b015b0a4dcd2d711892e9316f106eb87184","revisions":{"6c587b015b0a4dcd2d711892e9316f106eb87184":{"kind":"REWORK","_number":1,"created":"2016-08-30 08:24:02.000000000","uploader":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"ref":"refs/changes/96/362696/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack-gate","ref":"refs/changes/96/362696/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack-gate refs/changes/96/362696/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack-gate refs/changes/96/362696/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack-gate refs/changes/96/362696/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack-gate refs/changes/96/362696/1"}}},"commit":{"parents":[{"commit":"b397a91b5617bc33e4dacee959dae2a2112eeb38","subject":"Merge \"set up stable/newton\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-gate/commit/b397a91b5617bc33e4dacee959dae2a2112eeb38"}]}],"author":{"name":"Luigi Toscano","email":"ltoscano@redhat.com","date":"2016-08-30 08:17:51.000000000","tz":120},"committer":{"name":"Luigi Toscano","email":"ltoscano@redhat.com","date":"2016-08-30 08:24:00.000000000","tz":120},"subject":"Always keep the local.conf file","message":"Always keep the local.conf file\n\nWhen the KEEP_LOCALRC variable was introduced it was intended for\nnon-core projects to inject values into devstack configuration\nwithout changing devstack-infra. But the definition of non-core\nproject changes and now those are the majority, which means\nthat many of them would probably need to enable this option.\n\nAlso, it\u0027s worth nothing that jobs can already change PROJECTS and\nENABLED_SERVICES. Allowing changes to local.conf by default seems\nto be more in line with the expected behavior.\n\nChange-Id: Ibf656ef063ac15593ee277518132c1ec60b69383\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-gate/commit/6c587b015b0a4dcd2d711892e9316f106eb87184"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-gate/commit/6c587b015b0a4dcd2d711892e9316f106eb87184"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}