)]}'
{"id":"openstack%2Fdevstack-gate~38171","triplet_id":"openstack%2Fdevstack-gate~master~Icd6a6eb6e6896f88e06ff0c8e9d53b6b34092ad8","project":"openstack/devstack-gate","branch":"master","hashtags":[],"change_id":"Icd6a6eb6e6896f88e06ff0c8e9d53b6b34092ad8","subject":"Set state to deleted when deleting","status":"MERGED","created":"2013-07-22 16:34:59.000000000","updated":"2013-07-23 23:10:20.000000000","submitted":"2013-07-23 23:10:20.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"ed22a3b2c3ecaa9b567cf4bb22b0460494ef05b3","_number":38171,"virtual_id_number":38171,"owner":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},{"value":0,"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":0,"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"value":2,"date":"2013-07-23 23:10:20.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"all":[{"value":0,"date":"2013-07-22 19:13:14.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},{"value":2,"date":"2013-07-23 00:08:58.000000000","_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":2,"date":"2013-07-23 22:12:07.000000000","_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"all":[{"value":0,"date":"2013-07-22 19:13:14.000000000","_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},{"value":0,"date":"2013-07-23 00:08:58.000000000","_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":1,"date":"2013-07-23 22:12:07.000000000","_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-07-22 16:39:24.000000000","updated_by":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"reviewer":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"state":"REVIEWER"},{"updated":"2013-07-23 00:08:58.000000000","updated_by":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"reviewer":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"state":"REVIEWER"},{"updated":"2013-07-23 22:12:07.000000000","updated_by":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"reviewer":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"state":"REVIEWER"},{"updated":"2013-07-23 23:10:20.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"372f22c2fe7beb64872be0f210d13664d78e3d6a","author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"date":"2013-07-22 16:37:56.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"146f5be702a423463e17525400017402a5679163","author":{"_account_id":5494,"name":"Trivial Rebase","email":"trivial-rebase@review.openstack.org","username":"trivial-rebase"},"date":"2013-07-22 16:38:00.000000000","message":"Patch Set 2:\n\nNew patchset patch-id matches previous patchset, but commit message has changed.","accounts_in_message":[],"_revision_number":2},{"id":"74b0e87bf1ed2bc1f17502d934554236b5c12392","author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"date":"2013-07-22 16:38:26.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"79e8b2c1e2683e719baa48f991fd2be466ff1971","author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"date":"2013-07-22 16:39:24.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"c4c884478433d78ad36774e85218a3b74ad1f568","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-22 18:12:14.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/71/38171/2/check/gate-tempest-devstack-vm-full/34439 : SUCCESS in 57m 44s\n- http://logs.openstack.org/71/38171/2/check/gate-tempest-devstack-vm-cells-full/2012 : FAILURE in 16m 04s (non-voting)\n- http://logs.openstack.org/71/38171/2/check/gate-tempest-devstack-vm-testr-full/858 : SUCCESS in 31m 57s (non-voting)\n- http://logs.openstack.org/71/38171/2/check/gate-tempest-devstack-vm-postgres-full/34129 : SUCCESS in 47m 28s\n- http://logs.openstack.org/71/38171/2/check/gate-tempest-devstack-vm-neutron/6255 : FAILURE in 24m 19s (non-voting)\n- http://logs.openstack.org/71/38171/2/check/gate-grenade-devstack-vm/20124 : SUCCESS in 27m 52s\n","accounts_in_message":[],"_revision_number":2},{"id":"fb61db1b6ff05db7c94fd0b6110f1b1e5f69e3a7","author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"date":"2013-07-22 19:11:32.000000000","message":"Patch Set 2: I would prefer that you didn\u0027t merge this\n\nI feel like this should not be in the delete_image function.","accounts_in_message":[],"_revision_number":2},{"id":"e2fada8bf1d36359c0e3b6c0c745eb64fa80c596","author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"date":"2013-07-22 19:12:47.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"4afda980c1ab894a2fb1480d1dc8c935f4bbf0c2","author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"date":"2013-07-22 19:13:14.000000000","message":"Patch Set 3:\n\nGolly gee those functions look a lot alike.","accounts_in_message":[],"_revision_number":3},{"id":"62da440cff28eb20edf909a88fe377a883fe8b42","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-22 20:04:36.000000000","message":"Patch Set 3: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/71/38171/3/check/gate-tempest-devstack-vm-full/34474 : SUCCESS in 46m 21s\n- http://logs.openstack.org/71/38171/3/check/gate-tempest-devstack-vm-cells-full/2041 : FAILURE in 15m 10s (non-voting)\n- http://logs.openstack.org/71/38171/3/check/gate-tempest-devstack-vm-testr-full/887 : UNSTABLE in 31m 40s (non-voting)\n- http://logs.openstack.org/71/38171/3/check/gate-tempest-devstack-vm-postgres-full/34164 : SUCCESS in 51m 39s\n- http://logs.openstack.org/71/38171/3/check/gate-tempest-devstack-vm-neutron/6293 : SUCCESS in 23m 15s (non-voting)\n- http://logs.openstack.org/71/38171/3/check/gate-grenade-devstack-vm/20157 : SUCCESS in 22m 46s\n","accounts_in_message":[],"_revision_number":3},{"id":"519abf9d0fca309744aa7e1d3daabadb4bfa5f9c","author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"date":"2013-07-23 00:08:58.000000000","message":"Patch Set 3: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":3},{"id":"f1cfe19f12a02ceeec84f70aba8dcbacb38f8202","author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"date":"2013-07-23 22:12:07.000000000","message":"Patch Set 3: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":3},{"id":"6684b6d533322e5b28f5f3774fdfc5695e0d2ea5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-23 22:12:08.000000000","message":"Patch Set 3: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"48bf599343aacb7acbcc87525d63402f98f015bc","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-23 23:10:20.000000000","message":"Patch Set 3: Verified\n\nBuild succeeded.\n\n- http://logs.openstack.org/71/38171/3/gate/gate-tempest-devstack-vm-full/34906 : SUCCESS in 58m 09s\n- http://logs.openstack.org/71/38171/3/gate/gate-tempest-devstack-vm-postgres-full/34596 : SUCCESS in 49m 19s\n- http://logs.openstack.org/71/38171/3/gate/gate-tempest-devstack-vm-neutron/6788 : SUCCESS in 20m 02s (non-voting)\n- http://logs.openstack.org/71/38171/3/gate/gate-grenade-devstack-vm/20559 : SUCCESS in 27m 53s\n","accounts_in_message":[],"_revision_number":3},{"id":"ed22a3b2c3ecaa9b567cf4bb22b0460494ef05b3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-23 23:10:20.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"54cb13ead23a427e156af23f4c33ed1dd96a9807","revisions":{"530cc6ea6e80ba7f664594120a71ce1c6dea0e63":{"kind":"REWORK","_number":1,"created":"2013-07-22 16:34:59.000000000","uploader":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"ref":"refs/changes/71/38171/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack-gate","ref":"refs/changes/71/38171/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack-gate refs/changes/71/38171/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack-gate refs/changes/71/38171/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack-gate refs/changes/71/38171/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack-gate refs/changes/71/38171/1"}}},"commit":{"parents":[{"commit":"7cb7093b2ef33cc593083e9dca72746975a0f01f","subject":"Grab testr logs even when testr fails.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-gate/commit/7cb7093b2ef33cc593083e9dca72746975a0f01f"}]}],"author":{"name":"James E. Blair","email":"jeblair@openstack.org","date":"2013-07-22 16:33:35.000000000","tz":-420},"committer":{"name":"James E. Blair","email":"jeblair@openstack.org","date":"2013-07-22 16:33:35.000000000","tz":-420},"subject":"Set state to deleted when deleting","message":"Set state to deleted when deleting\n\nIn some cases (eg when all servers are deleted), a machine may be\ndeleted even if the current db state is not DELETE (or ERROR).\nIn all cases, if the db state is not DELETE when a machine is\ndeleted, set it to DELETE, so that it will be removed from the\ndb during the next pass.\n\nChange-Id: Icd6a6eb6e6896f88e06ff0c8e9d53b6b34092ad8\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-gate/commit/530cc6ea6e80ba7f664594120a71ce1c6dea0e63"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-gate/commit/530cc6ea6e80ba7f664594120a71ce1c6dea0e63"}]},"branch":"refs/heads/master"},"f4bf56172ee3f1255baf867254e9bd13b274ed8d":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2013-07-22 16:37:56.000000000","uploader":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"ref":"refs/changes/71/38171/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack-gate","ref":"refs/changes/71/38171/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack-gate refs/changes/71/38171/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack-gate refs/changes/71/38171/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack-gate refs/changes/71/38171/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack-gate refs/changes/71/38171/2"}}},"commit":{"parents":[{"commit":"7cb7093b2ef33cc593083e9dca72746975a0f01f","subject":"Grab testr logs even when testr fails.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-gate/commit/7cb7093b2ef33cc593083e9dca72746975a0f01f"}]}],"author":{"name":"James E. Blair","email":"jeblair@openstack.org","date":"2013-07-22 16:33:35.000000000","tz":-420},"committer":{"name":"James E. Blair","email":"jeblair@openstack.org","date":"2013-07-22 16:37:37.000000000","tz":-420},"subject":"Set state to deleted when deleting","message":"Set state to deleted when deleting\n\nIn some cases (e.g. when all servers are deleted), a machine may be\ndeleted even if the current db state is not DELETE (or ERROR).\nIn all cases, if the db state is not DELETE when a machine is\ndeleted, set it to DELETE, so that it will be removed from the\ndb during the next pass.\n\nChange-Id: Icd6a6eb6e6896f88e06ff0c8e9d53b6b34092ad8\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-gate/commit/f4bf56172ee3f1255baf867254e9bd13b274ed8d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-gate/commit/f4bf56172ee3f1255baf867254e9bd13b274ed8d"}]},"branch":"refs/heads/master"},"54cb13ead23a427e156af23f4c33ed1dd96a9807":{"kind":"REWORK","_number":3,"created":"2013-07-22 19:12:47.000000000","uploader":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"ref":"refs/changes/71/38171/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack-gate","ref":"refs/changes/71/38171/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack-gate refs/changes/71/38171/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack-gate refs/changes/71/38171/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack-gate refs/changes/71/38171/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack-gate refs/changes/71/38171/3"}}},"commit":{"parents":[{"commit":"7cb7093b2ef33cc593083e9dca72746975a0f01f","subject":"Grab testr logs even when testr fails.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-gate/commit/7cb7093b2ef33cc593083e9dca72746975a0f01f"}]}],"author":{"name":"James E. Blair","email":"jeblair@openstack.org","date":"2013-07-22 16:33:35.000000000","tz":-420},"committer":{"name":"James E. Blair","email":"jeblair@openstack.org","date":"2013-07-22 19:12:40.000000000","tz":-420},"subject":"Set state to deleted when deleting","message":"Set state to deleted when deleting\n\nIn some cases (e.g. when all servers are deleted), a machine may be\ndeleted even if the current db state is not DELETE (or ERROR).\nIn all cases, if the db state is not DELETE when a machine is\ndeleted, set it to DELETE, so that it will be removed from the\ndb during the next pass.\n\nChange-Id: Icd6a6eb6e6896f88e06ff0c8e9d53b6b34092ad8\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-gate/commit/54cb13ead23a427e156af23f4c33ed1dd96a9807"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-gate/commit/54cb13ead23a427e156af23f4c33ed1dd96a9807"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
