)]}'
{"id":"openstack%2Fdevstack-gate~383939","triplet_id":"openstack%2Fdevstack-gate~master~Iae6191dfc2dab81e7ca172762728ede2946f5f62","project":"openstack/devstack-gate","branch":"master","topic":"reproduce-hooks","hashtags":[],"change_id":"Iae6191dfc2dab81e7ca172762728ede2946f5f62","subject":"Make sure the d-g hooks end up in reproduce.sh","status":"MERGED","created":"2016-10-07 21:10:33.000000000","updated":"2016-10-14 00:46:04.000000000","submitted":"2016-10-14 00:46:04.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"1bb2f673cba75ed6ce3b21fab44b082a9c39f6ad","_number":383939,"virtual_id_number":383939,"owner":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},{"value":2,"date":"2016-10-14 00:46:04.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6554,"name":"Spencer Krum","email":"nibz@spencerkrum.com","username":"krum-spencer"},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"recommended":{"_account_id":6554,"name":"Spencer Krum","email":"nibz@spencerkrum.com","username":"krum-spencer"},"all":[{"value":0,"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-10-07 22:18:07.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":6554,"name":"Spencer Krum","email":"nibz@spencerkrum.com","username":"krum-spencer"},{"value":2,"date":"2016-10-13 23:45:15.000000000","_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"all":[{"value":0,"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6554,"name":"Spencer Krum","email":"nibz@spencerkrum.com","username":"krum-spencer"},{"value":1,"date":"2016-10-13 23:45:15.000000000","_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6554,"name":"Spencer Krum","email":"nibz@spencerkrum.com","username":"krum-spencer"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-10-07 21:17:19.000000000","updated_by":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"reviewer":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"state":"REVIEWER"},{"updated":"2016-10-07 22:18:07.000000000","updated_by":{"_account_id":6554,"name":"Spencer Krum","email":"nibz@spencerkrum.com","username":"krum-spencer"},"reviewer":{"_account_id":6554,"name":"Spencer Krum","email":"nibz@spencerkrum.com","username":"krum-spencer"},"state":"REVIEWER"},{"updated":"2016-10-13 23:45:15.000000000","updated_by":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"reviewer":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"state":"REVIEWER"},{"updated":"2016-10-14 00:46:04.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"5351b8bbc1d4b0036a2c64af9b81f78c14af6051","author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"date":"2016-10-07 21:10:33.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e1f9480a3fe8d9d292ad7eda825ea943bf81449d","author":{"_account_id":6554,"name":"Spencer Krum","email":"nibz@spencerkrum.com","username":"krum-spencer"},"date":"2016-10-07 21:14:22.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"5368c8066a3e04dddab3be82dd80d9a5f1e4fb12","author":{"_account_id":6554,"name":"Spencer Krum","email":"nibz@spencerkrum.com","username":"krum-spencer"},"date":"2016-10-07 21:16:07.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"280117919f1e6ab49fc41f0d0ea0f6ea9839ea78","author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"date":"2016-10-07 21:17:19.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"6039bda3a837f6495980e890b03ca3b9072fbca3","author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"date":"2016-10-07 21:27:15.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"d01d3d494e2ec3c81da81d516bd59d15110aa534","author":{"_account_id":6554,"name":"Spencer Krum","email":"nibz@spencerkrum.com","username":"krum-spencer"},"date":"2016-10-07 22:18:07.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"247dec374cb26f6d40920a1b124da757a9af1df1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-10-07 22:55:59.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-tempest-dsvm-neutron-full-ubuntu-xenial http://logs.openstack.org/39/383939/2/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/f54fd52/ : SUCCESS in 1h 00m 04s\n- gate-grenade-dsvm-neutron-ubuntu-xenial http://logs.openstack.org/39/383939/2/check/gate-grenade-dsvm-neutron-ubuntu-xenial/f8dfe08/ : SUCCESS in 46m 26s\n- gate-tempest-dsvm-full-ubuntu-xenial http://logs.openstack.org/39/383939/2/check/gate-tempest-dsvm-full-ubuntu-xenial/9b37252/ : SUCCESS in 50m 58s\n- gate-grenade-dsvm-ubuntu-xenial http://logs.openstack.org/39/383939/2/check/gate-grenade-dsvm-ubuntu-xenial/16466f4/ : SUCCESS in 50m 35s\n- gate-devstack-gate-unittests http://logs.openstack.org/39/383939/2/check/gate-devstack-gate-unittests/51559ae/ : SUCCESS in 2m 06s\n- gate-devstack-gate-bashate http://logs.openstack.org/39/383939/2/check/gate-devstack-gate-bashate/c9f2d62/ : SUCCESS in 1m 55s\n- gate-dg-hooks-dsvm http://logs.openstack.org/39/383939/2/check/gate-dg-hooks-dsvm/a979365/ : SUCCESS in 5m 43s\n- gate-grenade-dsvm-multinode http://logs.openstack.org/39/383939/2/check/gate-grenade-dsvm-multinode/0c3cd1a/ : SUCCESS in 46m 58s\n- gate-grenade-dsvm-neutron-multinode http://logs.openstack.org/39/383939/2/check/gate-grenade-dsvm-neutron-multinode/7114655/ : SUCCESS in 58m 18s\n- gate-neutron-dsvm-functional-ubuntu-trusty-nv http://logs.openstack.org/39/383939/2/check/gate-neutron-dsvm-functional-ubuntu-trusty-nv/ceb4b27/ : SUCCESS in 14m 43s (non-voting)\n- gate-swift-dsvm-functional-ubuntu-xenial-nv http://logs.openstack.org/39/383939/2/check/gate-swift-dsvm-functional-ubuntu-xenial-nv/0b2be1e/ : SUCCESS in 17m 35s (non-voting)\n- gate-tempest-dsvm-full-ubuntu-trusty-liberty-nv http://logs.openstack.org/39/383939/2/check/gate-tempest-dsvm-full-ubuntu-trusty-liberty-nv/571487d/ : SUCCESS in 53m 09s (non-voting)\n- gate-tempest-dsvm-neutron-full-ubuntu-trusty-liberty-nv http://logs.openstack.org/39/383939/2/check/gate-tempest-dsvm-neutron-full-ubuntu-trusty-liberty-nv/c6bfc28/ : SUCCESS in 53m 03s (non-voting)\n- gate-tempest-dsvm-full-ubuntu-trusty-mitaka-nv http://logs.openstack.org/39/383939/2/check/gate-tempest-dsvm-full-ubuntu-trusty-mitaka-nv/6ab4514/ : SUCCESS in 38m 18s (non-voting)\n- gate-tempest-dsvm-neutron-full-ubuntu-trusty-mitaka-nv http://logs.openstack.org/39/383939/2/check/gate-tempest-dsvm-neutron-full-ubuntu-trusty-mitaka-nv/b3e7f33/ : SUCCESS in 52m 42s (non-voting)\n- gate-tempest-dsvm-full-ubuntu-xenial-newton-nv http://logs.openstack.org/39/383939/2/check/gate-tempest-dsvm-full-ubuntu-xenial-newton-nv/f97a28a/ : SUCCESS in 50m 42s (non-voting)\n- gate-tempest-dsvm-neutron-full-ubuntu-xenial-newton-nv http://logs.openstack.org/39/383939/2/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial-newton-nv/ce41bfe/ : SUCCESS in 1h 16m 50s (non-voting)\n- gate-tempest-dsvm-platform-centos7-nv http://logs.openstack.org/39/383939/2/check/gate-tempest-dsvm-platform-centos7-nv/94eae2c/ : SUCCESS in 1h 06m 59s (non-voting)\n- gate-tempest-dsvm-multinode-full-ubuntu-xenial http://logs.openstack.org/39/383939/2/check/gate-tempest-dsvm-multinode-full-ubuntu-xenial/8f3a7ee/ : SUCCESS in 50m 39s (non-voting)\n- gate-tempest-dsvm-neutron-multinode-full-ubuntu-xenial http://logs.openstack.org/39/383939/2/check/gate-tempest-dsvm-neutron-multinode-full-ubuntu-xenial/c9c2a1f/ : SUCCESS in 1h 24m 27s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"dfd1b6c780db889dee75cdee7cb6c75bd593a5b8","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2016-10-13 23:45:15.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nSo this puts in the default gate_hook (see [1] for a random example) which strictly speaking doesn\u0027t need to be there and looks a bit odd because it uses things like $BASE without them being defined, since it all comes from devstack-gate.\n\ni\u0027m not sure i see any way around this, however, without ridiculous hacks like flagging the default fn.  so LGTM\n\n[1] http://logs.openstack.org/39/383939/2/check/gate-tempest-dsvm-full-ubuntu-trusty-mitaka-nv/6ab4514/logs/reproduce.sh","accounts_in_message":[],"_revision_number":2},{"id":"c8dc8bb77db333a2bcb87a6da3651706f9fb983b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-10-13 23:45:26.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"03a1ad663644f591d7bd5051c4747aa061b75194","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2016-10-13 23:47:27.000000000","message":"Patch Set 2:\n\noops, i thought this already had another +2.  anyway, nibz\u0027s is as good as","accounts_in_message":[],"_revision_number":2},{"id":"fee35e261cb1a26a8677960150d925efec2b71fc","date":"2016-10-14 00:46:04.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"d7c2a7eef214ecd16b8c028ec48967e9efa6cf12","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-10-14 00:46:04.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-tempest-dsvm-neutron-full-ubuntu-xenial http://logs.openstack.org/39/383939/2/gate/gate-tempest-dsvm-neutron-full-ubuntu-xenial/ece8c7a/ : SUCCESS in 44m 53s\n- gate-grenade-dsvm-neutron-ubuntu-xenial http://logs.openstack.org/39/383939/2/gate/gate-grenade-dsvm-neutron-ubuntu-xenial/941dcbe/ : SUCCESS in 49m 56s\n- gate-tempest-dsvm-full-ubuntu-xenial http://logs.openstack.org/39/383939/2/gate/gate-tempest-dsvm-full-ubuntu-xenial/09f249e/ : SUCCESS in 1h 00m 36s\n- gate-grenade-dsvm-ubuntu-xenial http://logs.openstack.org/39/383939/2/gate/gate-grenade-dsvm-ubuntu-xenial/d82bc02/ : SUCCESS in 25m 01s\n- gate-devstack-gate-unittests http://logs.openstack.org/39/383939/2/gate/gate-devstack-gate-unittests/4bb084c/ : SUCCESS in 2m 06s\n- gate-grenade-dsvm-multinode http://logs.openstack.org/39/383939/2/gate/gate-grenade-dsvm-multinode/e55f01e/ : SUCCESS in 27m 40s\n- gate-grenade-dsvm-neutron-multinode http://logs.openstack.org/39/383939/2/gate/gate-grenade-dsvm-neutron-multinode/fd4e64f/ : SUCCESS in 35m 39s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"4b70a096360f3983f76d26660b74ba234ce0556c","revisions":{"3d9eac05970d75178a80fe796ca6e8622eac1faa":{"kind":"REWORK","_number":1,"created":"2016-10-07 21:10:33.000000000","uploader":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"ref":"refs/changes/39/383939/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack-gate","ref":"refs/changes/39/383939/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack-gate refs/changes/39/383939/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack-gate refs/changes/39/383939/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack-gate refs/changes/39/383939/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack-gate refs/changes/39/383939/1"}}},"commit":{"parents":[{"commit":"8e6edce98dfa5e83281ca2ad0075b0e7ffa76c42","subject":"Enable tls-proxy on subnode if enabled on primary","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-gate/commit/8e6edce98dfa5e83281ca2ad0075b0e7ffa76c42"}]}],"author":{"name":"Clark Boylan","email":"clark.boylan@gmail.com","date":"2016-10-07 21:09:40.000000000","tz":-420},"committer":{"name":"Clark Boylan","email":"clark.boylan@gmail.com","date":"2016-10-07 21:09:40.000000000","tz":-420},"subject":"Make sure the d-g hooks end up in reproduce.sh","message":"Make sure the d-g hooks end up in reproduce.sh\n\nCurrently we don\u0027t have any handling for devstack-gate hooks in the\nreproduce.sh script so jobs that rely on them don\u0027t generate accurate\nreproduce.sh scripts. Fix this by explicitly adding each of the three\nhooks to the reproduce.sh script if they are defined.\n\nChange-Id: Iae6191dfc2dab81e7ca172762728ede2946f5f62\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-gate/commit/3d9eac05970d75178a80fe796ca6e8622eac1faa"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-gate/commit/3d9eac05970d75178a80fe796ca6e8622eac1faa"}]},"branch":"refs/heads/master"},"4b70a096360f3983f76d26660b74ba234ce0556c":{"kind":"REWORK","_number":2,"created":"2016-10-07 21:27:15.000000000","uploader":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"ref":"refs/changes/39/383939/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack-gate","ref":"refs/changes/39/383939/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack-gate refs/changes/39/383939/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack-gate refs/changes/39/383939/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack-gate refs/changes/39/383939/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack-gate refs/changes/39/383939/2"}}},"commit":{"parents":[{"commit":"8e6edce98dfa5e83281ca2ad0075b0e7ffa76c42","subject":"Enable tls-proxy on subnode if enabled on primary","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-gate/commit/8e6edce98dfa5e83281ca2ad0075b0e7ffa76c42"}]}],"author":{"name":"Clark Boylan","email":"clark.boylan@gmail.com","date":"2016-10-07 21:09:40.000000000","tz":-420},"committer":{"name":"Clark Boylan","email":"clark.boylan@gmail.com","date":"2016-10-07 21:27:10.000000000","tz":-420},"subject":"Make sure the d-g hooks end up in reproduce.sh","message":"Make sure the d-g hooks end up in reproduce.sh\n\nCurrently we don\u0027t have any handling for devstack-gate hooks in the\nreproduce.sh script so jobs that rely on them don\u0027t generate accurate\nreproduce.sh scripts. Fix this by explicitly adding each of the three\nhooks to the reproduce.sh script if they are defined.\n\nChange-Id: Iae6191dfc2dab81e7ca172762728ede2946f5f62\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-gate/commit/4b70a096360f3983f76d26660b74ba234ce0556c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-gate/commit/4b70a096360f3983f76d26660b74ba234ce0556c"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}