)]}'
{"functions.sh":[{"author":{"_account_id":6589,"name":"Jesse Keating","email":"jkeating@j2solutions.net","username":"jesse-keating"},"change_message_id":"c576dd33cd0e9984b6068cc0ffcd6ea41e265fe7","unresolved":false,"context_lines":[{"line_number":583,"context_line":"    # If we will be testing OpenVZ, make sure stack is a member of the vz group"},{"line_number":584,"context_line":"    if [ \"$DEVSTACK_GATE_VIRT_DRIVER\" \u003d\u003d \"openvz\" ]; then"},{"line_number":585,"context_line":"        sudo usermod -a -G vz stack"},{"line_number":586,"context_line":"    fi"},{"line_number":587,"context_line":""},{"line_number":588,"context_line":"    # Ensure that all of the users have the openstack mirror config"},{"line_number":589,"context_line":"    copy_mirror_config"}],"source_content_type":"text/x-sh","patch_set":9,"id":"1a6eadb0_ffed3d26","side":"PARENT","line":586,"updated":"2016-12-13 00:00:35.000000000","message":"Seems like this block is unrelated to copy_mirror_config. Should it get removed as part of a different commit?","commit_id":"bfbb8375153ca1d74894f56e55b9594dd55b3b0e"}],"playbooks/roles/copy_mirror_config/tasks/main.yaml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"e3bdb4a1772f8e42b2c00ff522bc7950d06d4dc3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- name: Get status of pydistutils.cfg file"},{"line_number":2,"context_line":"  stat: path\u003d.pydistutils.cfg"},{"line_number":3,"context_line":"  register: st"},{"line_number":4,"context_line":"- block:"},{"line_number":5,"context_line":"    - name: Install .pydistutils on root home folder"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1a6eadb0_f5da9de8","line":2,"updated":"2016-12-19 19:52:24.000000000","message":"Note that this isn\u0027t the same as what the old code did, it explicitly checked roots homedir. I believe become is like sudo -H, but last time I looked that isn\u0027t documented and so I\u0027d worry ansible could change that in the next release. Maybe we can be more explicit about it here?","commit_id":"9561c4958ca4bb7834aef978d046d0bf08597899"},{"author":{"_account_id":16068,"name":"Tobias Henkel","email":"tobias.henkel@bmw.de","username":"tobias.henkel"},"change_message_id":"0470e4f5cf9f89719dc0b01f326c6f7c12557404","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    - name: Install .pydistutils on tempest home folder"},{"line_number":10,"context_line":"      command: install -D -m0644 -o tempest -g tempest ~/.pydistutils.cfg ~tempest/.pydistutils.cfg"},{"line_number":11,"context_line":"  when: st.stat.exists"},{"line_number":12,"context_line":"  become: yes"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1a6eadb0_fdfe2004","line":12,"updated":"2016-12-13 04:54:17.000000000","message":"I would use one task with with_items instead of three tasks\n\n - name: Install .pydistutils on {{item}} home folder\n   command: install ... -o {{item}} -g {{item}} ... {{item}}/.pydistutils\n   with_items:\n     - root\n     - stack\n     - tempest","commit_id":"9561c4958ca4bb7834aef978d046d0bf08597899"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"a7399f7f782859aec5527b498c17a6655ad695b6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- name: Get status of pydistutils.cfg file"},{"line_number":2,"context_line":"  stat: path\u003d/home/jenkins/.pydistutils.cfg"},{"line_number":3,"context_line":"  register: st"},{"line_number":4,"context_line":"- block:"},{"line_number":5,"context_line":"    - name: Install /home/jenkins/.pydistutils on root home folder"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1a6eadb0_5015df98","line":2,"updated":"2017-01-10 17:49:19.000000000","message":"Thinking about this and the idea of setting a var that named the user (that we briefly discussed in #zuul) the old code relied on ~/.pydistutils.cfg as the path. Essentially it just assumed the current user has the file in its homedir.\n\nMaybe we can just continue that assumption here and check what user is running ansible and treat it as the source?\n\nThe nice thing about that is it means anyone running devstack-gate locally to reproduce a failure (or any other reason) doesn\u0027t necessarily have to have a Jenkins/Zuul user to get .pydistutils.cfg properly copied everywhere.","commit_id":"363bb0b4cef38e5c0224a17272eb6c0f466b0c10"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"56ae6c811638158460c7c06d170122e988fff80e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- name: Get status of pydistutils.cfg file"},{"line_number":2,"context_line":"  stat: path\u003d/home/{{ CI_USER }}/.pydistutils.cfg"},{"line_number":3,"context_line":"  register: st"},{"line_number":4,"context_line":"- block:"},{"line_number":5,"context_line":"    - name: Install /home/{{ CI_USER }}/.pydistutils on root home folder"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"1a430d35_55bb33e5","line":2,"updated":"2017-02-06 18:45:01.000000000","message":"The only problem with this is it assumes the homedir is located in /home/$user which isn\u0027t always the case.\n\nSomething like ~$CI_USER would be nice but I don\u0027t think ansible knows how to expand something like that and we would have to construct it ourselves.","commit_id":"fa349004c593eea330da2fe03b8175c96613dce7"}]}