)]}'
{"devstack-vm-gate.sh":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0e39cda6efbd3a3f262c1b9b24ac2aa010dac34d","unresolved":false,"context_lines":[{"line_number":230,"context_line":"    # We have to run this on the primary node AFTER the subnodes have been"},{"line_number":231,"context_line":"    # setup."},{"line_number":232,"context_line":"    $ANSIBLE primary -f 5 -i \"$WORKSPACE/inventory\" -m shell \\"},{"line_number":233,"context_line":"        -a \"sudo -H -u stack stdbuf -oL -eL nova-manage cell_v2 discover_hosts --verbose\" \\"},{"line_number":234,"context_line":"        \u0026\u003e \"$WORKSPACE/logs/discover-hosts.txt\""},{"line_number":235,"context_line":"}"},{"line_number":236,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"5a3905b3_c9f79df3","line":233,"range":{"start_line":233,"start_character":44,"end_line":233,"end_character":88},"updated":"2017-01-20 13:42:25.000000000","message":"Maybe we should throw this into a script in devstack itself and then in d-g we just check to see if the script exists and if so run it, else we don\u0027t do anything. Then we could avoid branch logic in d-g.","commit_id":"2eb7e1e3438e9d0120a3581c92475694e17a413c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3cae97df0be069cf8da5936ce8572217fa1dd55d","unresolved":false,"context_lines":[{"line_number":231,"context_line":"    # setup."},{"line_number":232,"context_line":"    $ANSIBLE primary -f 5 -i \"$WORKSPACE/inventory\" -m shell \\"},{"line_number":233,"context_line":"        -a \"sudo -H -u stack stdbuf -oL -eL nova-manage cell_v2 discover_hosts --verbose\" \\"},{"line_number":234,"context_line":"        \u0026\u003e \"$WORKSPACE/logs/discover-hosts.txt\""},{"line_number":235,"context_line":"}"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"function setup_localrc {"}],"source_content_type":"text/x-sh","patch_set":2,"id":"5a3905b3_61c96378","line":234,"range":{"start_line":234,"start_character":28,"end_line":234,"end_character":42},"updated":"2017-01-20 13:30:50.000000000","message":"Should probably name this devstack-gate-discover-hosts.txt to be consistent with the other logs for stuff like this.","commit_id":"2eb7e1e3438e9d0120a3581c92475694e17a413c"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"905deb4e41493a24b687bb2ed0f7240423f00315","unresolved":false,"context_lines":[{"line_number":231,"context_line":"    # to see if the script exists in the devstack installation first."},{"line_number":232,"context_line":"    $ANSIBLE primary -f 5 -i \"$WORKSPACE/inventory\" -m shell \\"},{"line_number":233,"context_line":"        -a \"cd $BASE/new/devstack/ \u0026\u0026 test -f discover_hosts.sh \u0026\u0026 sudo -H -u stack stdbuf -oL -eL ./discover_hosts.sh executable\u003d/bin/bash\" \\"},{"line_number":234,"context_line":"        \u0026\u003e \"$WORKSPACE/logs/devstack-gate-discover-hosts.txt\""},{"line_number":235,"context_line":"}"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"function setup_localrc {"}],"source_content_type":"text/x-sh","patch_set":3,"id":"5a3905b3_37e4ef39","line":234,"updated":"2017-01-20 18:03:47.000000000","message":"I think you probably need to add DSTOOLS to this because of https://review.openstack.org/#/c/422227/ recently","commit_id":"423358cec7b7d42973eb7c74f1aacc0b23aff886"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"71d8e758d41d8b7f583dbfee5f837e1901dffb21","unresolved":false,"context_lines":[{"line_number":231,"context_line":"    # to see if the script exists in the devstack installation first."},{"line_number":232,"context_line":"    $ANSIBLE primary -f 5 -i \"$WORKSPACE/inventory\" -m shell \\"},{"line_number":233,"context_line":"        -a \"cd $BASE/new/devstack/ \u0026\u0026 test -f discover_hosts.sh \u0026\u0026 sudo -H -u stack stdbuf -oL -eL ./discover_hosts.sh executable\u003d/bin/bash\" \\"},{"line_number":234,"context_line":"        \u0026\u003e \"$WORKSPACE/logs/devstack-gate-discover-hosts.txt\""},{"line_number":235,"context_line":"}"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"function setup_localrc {"}],"source_content_type":"text/x-sh","patch_set":3,"id":"5a3905b3_1aa71750","line":234,"in_reply_to":"5a3905b3_37e4ef39","updated":"2017-01-20 19:04:13.000000000","message":"s/DSTOOLS/DSTOOL_VERSION/","commit_id":"423358cec7b7d42973eb7c74f1aacc0b23aff886"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"71d8e758d41d8b7f583dbfee5f837e1901dffb21","unresolved":false,"context_lines":[{"line_number":667,"context_line":"    # It is not clear if the ansible file module can do this for us"},{"line_number":668,"context_line":"    $ANSIBLE all --sudo -f 5 -i \"$WORKSPACE/inventory\" -m shell \\"},{"line_number":669,"context_line":"        -a \"chown -R stack:stack \u0027$BASE\u0027\""},{"line_number":670,"context_line":"    # allow us to add logs"},{"line_number":671,"context_line":"    $ANSIBLE all --sudo -f 5 -i \"$WORKSPACE/inventory\" -m shell \\"},{"line_number":672,"context_line":"        -a \"chmod 777 \u0027$WORKSPACE/logs\u0027\""},{"line_number":673,"context_line":""},{"line_number":674,"context_line":"    echo \"Running devstack\""},{"line_number":675,"context_line":"    echo \"... this takes 10 - 15 minutes (logs in logs/devstacklog.txt.gz)\""}],"source_content_type":"text/x-sh","patch_set":3,"id":"5a3905b3_1a55571c","line":672,"range":{"start_line":670,"start_character":3,"end_line":672,"end_character":40},"updated":"2017-01-20 19:04:13.000000000","message":"I think this might be what you need before you run discover_hosts. The error looks like it couldn\u0027t write the log to the /logs dir","commit_id":"423358cec7b7d42973eb7c74f1aacc0b23aff886"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9c549068d9e09c74e27cef1e8869d786ac7a53cf","unresolved":false,"context_lines":[{"line_number":667,"context_line":"    # It is not clear if the ansible file module can do this for us"},{"line_number":668,"context_line":"    $ANSIBLE all --sudo -f 5 -i \"$WORKSPACE/inventory\" -m shell \\"},{"line_number":669,"context_line":"        -a \"chown -R stack:stack \u0027$BASE\u0027\""},{"line_number":670,"context_line":"    # allow us to add logs"},{"line_number":671,"context_line":"    $ANSIBLE all --sudo -f 5 -i \"$WORKSPACE/inventory\" -m shell \\"},{"line_number":672,"context_line":"        -a \"chmod 777 \u0027$WORKSPACE/logs\u0027\""},{"line_number":673,"context_line":""},{"line_number":674,"context_line":"    echo \"Running devstack\""},{"line_number":675,"context_line":"    echo \"... this takes 10 - 15 minutes (logs in logs/devstacklog.txt.gz)\""}],"source_content_type":"text/x-sh","patch_set":3,"id":"5a3905b3_fd4c0572","line":672,"range":{"start_line":670,"start_character":3,"end_line":672,"end_character":40},"in_reply_to":"5a3905b3_1a55571c","updated":"2017-01-20 19:08:08.000000000","message":"Hmm, but we call discover_hosts *after* this so I\u0027d think things would be fine as long as this happens before discover_hosts.","commit_id":"423358cec7b7d42973eb7c74f1aacc0b23aff886"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"372cc0fff4d64a883ef286650d32d367e5190227","unresolved":false,"context_lines":[{"line_number":231,"context_line":"    # to see if the script exists in the devstack installation first."},{"line_number":232,"context_line":"    # TODO(mriedem): Would be nice to do this with wrapped lines."},{"line_number":233,"context_line":"    $ANSIBLE primary -f 5 -i \"$WORKSPACE/inventory\" -m shell \\"},{"line_number":234,"context_line":"        -a \"cd $BASE/new/devstack/ \u0026\u0026 test -f discover_hosts.sh \u0026\u0026 sudo -H -u stack DSTOOLS_VERSION\u003d$DSTOOLS_VERSION stdbuf -oL -eL ./discover_hosts.sh executable\u003d/bin/bash\" \\"},{"line_number":235,"context_line":"        \u0026\u003e \"$WORKSPACE/logs/devstack-gate-discover-hosts.txt\""},{"line_number":236,"context_line":"}"},{"line_number":237,"context_line":""}],"source_content_type":"text/x-sh","patch_set":6,"id":"5a3905b3_600dc58f","line":234,"range":{"start_line":234,"start_character":38,"end_line":234,"end_character":63},"updated":"2017-01-20 21:40:01.000000000","message":"This is failing on the stable branches because this exits with a 1. I reproduced with something similar locally:\n\nuser@xubuntu:~/git/devstack$ cd ~/git/devstack \u0026\u0026 test -f discover_hosts1.sh \u0026\u0026 sudo -H -u user stdbuf -oL -eL cat discover_hosts.sh\nuser@xubuntu:~/git/devstack$ echo $?\n1","commit_id":"954e6e83804b90ec9b8d0a64973c1684ea172f50"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"5e51a04843638a221f6921ffe1d5ed528294af9c","unresolved":false,"context_lines":[{"line_number":648,"context_line":"set -x"},{"line_number":649,"context_line":""},{"line_number":650,"context_line":"$ANSIBLE subnodes -f 5 -i \"$WORKSPACE/inventory\" -m shell \\"},{"line_number":651,"context_line":"        -a \"cd \u0027$BASE/old/devstack\u0027 \u0026\u0026 stdbuf -oL -eL ./stack.sh\""},{"line_number":652,"context_line":"EOF"},{"line_number":653,"context_line":"        sudo chmod a+x $BASE/new/grenade/post-stack.sh"},{"line_number":654,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":8,"id":"5a3905b3_431613a8","line":651,"updated":"2017-01-20 22:08:36.000000000","message":"for grenade, you can put the discover_hosts call directly in here, which will make it run on the old side before the upgrade process, which is what I think you want.","commit_id":"447bde8bb0ea4fae6b17b8def80b1dce3e6e1f35"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5dfa600bedf06c42f15feed6c5e665174a77eb14","unresolved":false,"context_lines":[{"line_number":648,"context_line":"set -x"},{"line_number":649,"context_line":""},{"line_number":650,"context_line":"$ANSIBLE subnodes -f 5 -i \"$WORKSPACE/inventory\" -m shell \\"},{"line_number":651,"context_line":"        -a \"cd \u0027$BASE/old/devstack\u0027 \u0026\u0026 stdbuf -oL -eL ./stack.sh\""},{"line_number":652,"context_line":"EOF"},{"line_number":653,"context_line":"        sudo chmod a+x $BASE/new/grenade/post-stack.sh"},{"line_number":654,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":8,"id":"5a3905b3_16060bce","line":651,"in_reply_to":"5a3905b3_431613a8","updated":"2017-01-20 22:27:33.000000000","message":"For single-node grenade we don\u0027t need discover_hosts as simple_cell_setup will handle it for us.\n\nIt\u0027s the multi-node case that we really need discover_hosts, and I\u0027m not entirely sure how this fits into the multi-node grenade case. I thought in multi-node grenade, the subnode was left behind (n-1), which I think means it would have already been discovered, and when we run simple_cell_setup on the new side (ocata), simple_cell_setup will discover the subnode if it wasn\u0027t discovered on the old side.\n\nWe won\u0027t probably know though until we test that all out.","commit_id":"447bde8bb0ea4fae6b17b8def80b1dce3e6e1f35"}]}