)]}'
{"devstack-vm-gate.sh":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d17e9f2f45459faed1ff9b9a942839d8a841a057","unresolved":false,"context_lines":[{"line_number":648,"context_line":"set -x"},{"line_number":649,"context_line":""},{"line_number":650,"context_line":"$ANSIBLE subnodes -f 5 -i \"$WORKSPACE/inventory\" -m shell \\"},{"line_number":651,"context_line":"        -a \"cd \u0027$BASE/old/devstack\u0027 \u0026\u0026 stdbuf -oL -eL ./stack.sh\""},{"line_number":652,"context_line":"EOF"},{"line_number":653,"context_line":"        sudo chmod a+x $BASE/new/grenade/post-stack.sh"},{"line_number":654,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"5a3905b3_5e3a219a","line":651,"updated":"2017-01-23 17:29:55.000000000","message":"Still need to deal with this comment from the earlier patch:\n\nhttps://review.openstack.org/#/c/423005/8/devstack-vm-gate.sh@651","commit_id":"c50b32eb43528dacba7d397901046ea65bb9e583"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"5aa4be253529e415f92365cd07dcc65a226818ab","unresolved":false,"context_lines":[{"line_number":236,"context_line":"    # the run."},{"line_number":237,"context_line":"    # TODO(mriedem): Would be nice to do this with wrapped lines."},{"line_number":238,"context_line":"    $ANSIBLE primary -f 5 -i \"$WORKSPACE/inventory\" -m shell \\"},{"line_number":239,"context_line":"        -a \"cd $BASE/new/devstack/ \u0026\u0026 (test -f discover_hosts.sh \u0026\u0026 sudo -H -u stack DSTOOLS_VERSION\u003d$DSTOOLS_VERSION stdbuf -oL -eL ./discover_hosts.sh) || true executable\u003d/bin/bash\" \\"},{"line_number":240,"context_line":"        \u0026\u003e \"$WORKSPACE/logs/devstack-gate-discover-hosts.txt\""},{"line_number":241,"context_line":"}"},{"line_number":242,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"5a3905b3_7668a688","line":239,"updated":"2017-01-24 18:14:47.000000000","message":"Due to the trailing || true I think you can just drop the test -f entirely. If it fails because discovery failed we still return true, if it fails because discover script doesn\u0027t exist we return true.\n\nAn alternative that is more robust may be:\n\n  (test -f file \u0026\u0026 execute file) || (!test -f file)\n\nIf I have sorted out the logic on that properly it will execute the file if it exists and return true if it succeeds. If the script ran and failed then !test -f file will return non zero, if the script file did not exist it will return true.","commit_id":"1a42fcde3a35d3f50567cd0af852c7f3a4217fdc"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d49c83d0f81b301a563f83f7c965a8157d16ca7c","unresolved":false,"context_lines":[{"line_number":236,"context_line":"    # the run."},{"line_number":237,"context_line":"    # TODO(mriedem): Would be nice to do this with wrapped lines."},{"line_number":238,"context_line":"    $ANSIBLE primary -f 5 -i \"$WORKSPACE/inventory\" -m shell \\"},{"line_number":239,"context_line":"        -a \"cd $BASE/new/devstack/ \u0026\u0026 (test -f discover_hosts.sh \u0026\u0026 sudo -H -u stack DSTOOLS_VERSION\u003d$DSTOOLS_VERSION stdbuf -oL -eL ./discover_hosts.sh) || true executable\u003d/bin/bash\" \\"},{"line_number":240,"context_line":"        \u0026\u003e \"$WORKSPACE/logs/devstack-gate-discover-hosts.txt\""},{"line_number":241,"context_line":"}"},{"line_number":242,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"5a3905b3_e1568ecd","line":239,"in_reply_to":"5a3905b3_7668a688","updated":"2017-01-24 18:33:29.000000000","message":"Yep, tested yours locally and it does what we want (fails if we actually fail, otherwise success regardless)","commit_id":"1a42fcde3a35d3f50567cd0af852c7f3a4217fdc"}]}