)]}'
{"devstack-vm-gate.sh":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"33b8db3f5fce2f1705950a26d545dcb66ef82e09","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    $ANSIBLE_PLAYBOOK -f 5 -i \"$WORKSPACE/inventory\" \"$WORKSPACE/devstack-gate/playbooks/ovs_vxlan_bridge.yaml\" \\"},{"line_number":101,"context_line":"        -e \"bridge_name\u003dbr_pub host_ip\u003d$primary_node set_ips\u003dTrue offset\u003d1 pub_addr_prefix\u003d$FLOATING_HOST_PREFIX pub_addr_mask\u003d$FLOATING_HOST_MASK peer_ips\u003d$sub_nodes\""},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    ovs_vxlan_bridge \"br_flat\" $primary_node \"False\" 128 \\"},{"line_number":104,"context_line":"                    $sub_nodes"},{"line_number":105,"context_line":"    localrc_set $localrc \"FLAT_INTERFACE\" \"br_flat\""},{"line_number":106,"context_line":"    localrc_set $localrc \"PUBLIC_INTERFACE\" \"br_pub\""},{"line_number":107,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":29,"id":"7a25e98e_21ec15c7","line":104,"range":{"start_line":103,"start_character":4,"end_line":104,"end_character":30},"updated":"2017-03-13 23:23:59.000000000","message":"This overlay network will need conversion too.","commit_id":"ae1aca45c09e46b900ea4a643bce3b4b9ff37176"},{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"5e566577e1918849136dc774480e9522dfaebc84","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    $ANSIBLE_PLAYBOOK -f 5 -i \"$WORKSPACE/inventory\" \"$WORKSPACE/devstack-gate/playbooks/ovs_vxlan_bridge.yaml\" \\"},{"line_number":101,"context_line":"        -e \"bridge_name\u003dbr_pub host_ip\u003d$primary_node set_ips\u003dTrue offset\u003d1 pub_addr_prefix\u003d$FLOATING_HOST_PREFIX pub_addr_mask\u003d$FLOATING_HOST_MASK peer_ips\u003d$sub_nodes\""},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    ovs_vxlan_bridge \"br_flat\" $primary_node \"False\" 128 \\"},{"line_number":104,"context_line":"                    $sub_nodes"},{"line_number":105,"context_line":"    localrc_set $localrc \"FLAT_INTERFACE\" \"br_flat\""},{"line_number":106,"context_line":"    localrc_set $localrc \"PUBLIC_INTERFACE\" \"br_pub\""},{"line_number":107,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":29,"id":"7f287b81_562c9646","line":104,"range":{"start_line":103,"start_character":4,"end_line":104,"end_character":30},"in_reply_to":"7a25e98e_21ec15c7","updated":"2017-08-22 21:13:55.000000000","message":"Done","commit_id":"ae1aca45c09e46b900ea4a643bce3b4b9ff37176"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"1962c12958c988d0c5b6d4fb97db7b6f63b0c5be","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        localrc_set $localconf \"MULTI_HOST\" \"True\""},{"line_number":160,"context_line":"    elif [[ \"$DEVSTACK_GATE_NET_OVERLAY\" -eq \u00271\u0027 ]]; then"},{"line_number":161,"context_line":"        $ANSIBLE_PLAYBOOK -f 5 -i \"$WORKSPACE/inventory\" \"$WORKSPACE/devstack-gate/playbooks/ovs_vxlan_bridge.yaml\" \\"},{"line_number":162,"context_line":"            -e \"bridge_name\u003dbr_ex\" \\"},{"line_number":163,"context_line":"            -e \"host_ip\u003d$primary_node\" \\"},{"line_number":164,"context_line":"            -e \"set_ips\u003dTrue\" \\"},{"line_number":165,"context_line":"            -e \"ovs_starting_offset\u003d1\" \\"}],"source_content_type":"text/x-sh","patch_set":48,"id":"7f287b81_fc973939","line":162,"range":{"start_line":162,"start_character":30,"end_line":162,"end_character":31},"updated":"2017-08-29 17:37:24.000000000","message":"This name is actually important to neutron. Should remain br-ex.","commit_id":"0525913ead24abaea7664fb644646961e5a16591"},{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"8a6a23aa3c6667c73d1a993bf9f780ea98cd18f3","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        localrc_set $localconf \"MULTI_HOST\" \"True\""},{"line_number":160,"context_line":"    elif [[ \"$DEVSTACK_GATE_NET_OVERLAY\" -eq \u00271\u0027 ]]; then"},{"line_number":161,"context_line":"        $ANSIBLE_PLAYBOOK -f 5 -i \"$WORKSPACE/inventory\" \"$WORKSPACE/devstack-gate/playbooks/ovs_vxlan_bridge.yaml\" \\"},{"line_number":162,"context_line":"            -e \"bridge_name\u003dbr_ex\" \\"},{"line_number":163,"context_line":"            -e \"host_ip\u003d$primary_node\" \\"},{"line_number":164,"context_line":"            -e \"set_ips\u003dTrue\" \\"},{"line_number":165,"context_line":"            -e \"ovs_starting_offset\u003d1\" \\"}],"source_content_type":"text/x-sh","patch_set":48,"id":"7f287b81_ca9a6bb7","line":162,"range":{"start_line":162,"start_character":30,"end_line":162,"end_character":31},"in_reply_to":"7f287b81_fc973939","updated":"2017-08-29 18:48:35.000000000","message":"Done","commit_id":"0525913ead24abaea7664fb644646961e5a16591"}],"functions.sh":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"33b8db3f5fce2f1705950a26d545dcb66ef82e09","unresolved":false,"context_lines":[{"line_number":1004,"context_line":"# For OVS troubleshooting needs:"},{"line_number":1005,"context_line":"#   http://www.yet.org/2014/09/openvswitch-troubleshooting/"},{"line_number":1006,"context_line":"#"},{"line_number":1007,"context_line":"function ovs_vxlan_bridge {"},{"line_number":1008,"context_line":"    local mtu\u003d1450"},{"line_number":1009,"context_line":"    local bridge_name\u003d$1"},{"line_number":1010,"context_line":"    local host_ip\u003d$2"}],"source_content_type":"text/x-sh","patch_set":29,"id":"7a25e98e_21033575","line":1007,"updated":"2017-03-13 23:23:59.000000000","message":"We should just go ahead and remove this function entirely.","commit_id":"ae1aca45c09e46b900ea4a643bce3b4b9ff37176"},{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"5e566577e1918849136dc774480e9522dfaebc84","unresolved":false,"context_lines":[{"line_number":1004,"context_line":"# For OVS troubleshooting needs:"},{"line_number":1005,"context_line":"#   http://www.yet.org/2014/09/openvswitch-troubleshooting/"},{"line_number":1006,"context_line":"#"},{"line_number":1007,"context_line":"function ovs_vxlan_bridge {"},{"line_number":1008,"context_line":"    local mtu\u003d1450"},{"line_number":1009,"context_line":"    local bridge_name\u003d$1"},{"line_number":1010,"context_line":"    local host_ip\u003d$2"}],"source_content_type":"text/x-sh","patch_set":29,"id":"7f287b81_76279266","line":1007,"in_reply_to":"7a25e98e_21033575","updated":"2017-08-22 21:13:55.000000000","message":"Done","commit_id":"ae1aca45c09e46b900ea4a643bce3b4b9ff37176"}],"playbooks/devstack_gate_vars.yaml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"33b8db3f5fce2f1705950a26d545dcb66ef82e09","unresolved":false,"context_lines":[{"line_number":4,"context_line":"PING_TIMES: 20"},{"line_number":5,"context_line":"HTTP_TIMES: 10"},{"line_number":6,"context_line":"PIP_CONFIG_FILE: \"{{ lookup(\u0027env\u0027, \u0027PIP_CONFIG_FILE\u0027)|default(\u0027/etc/pip.conf\u0027, true) }}\""},{"line_number":7,"context_line":"OVS_BRIDGE_MTU: 1450"},{"line_number":8,"context_line":"ADDITIONAL_VNI_OFFSET: 1000000"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"7a25e98e_81f22999","line":7,"updated":"2017-03-13 23:23:59.000000000","message":"The old code attempted to make this dynamic as \"physical\" link mtu - 50 (byte overhead for vxlan over ipv4, can\u0027t do vxlan over ipv6 so this could be hardcoded), but doesn\u0027t appears to have managed to get that done across the board.\n\nWill setting this value here as a default impact finishing up that work properly? maybe we should force people to supply it?","commit_id":"ae1aca45c09e46b900ea4a643bce3b4b9ff37176"},{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"7b80aa93b9af7917cd7f783a5694e6010a53b3af","unresolved":false,"context_lines":[{"line_number":4,"context_line":"PING_TIMES: 20"},{"line_number":5,"context_line":"HTTP_TIMES: 10"},{"line_number":6,"context_line":"PIP_CONFIG_FILE: \"{{ lookup(\u0027env\u0027, \u0027PIP_CONFIG_FILE\u0027)|default(\u0027/etc/pip.conf\u0027, true) }}\""},{"line_number":7,"context_line":"OVS_BRIDGE_MTU: 1450"},{"line_number":8,"context_line":"ADDITIONAL_VNI_OFFSET: 1000000"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"7f287b81_2b552351","line":7,"in_reply_to":"7a25e98e_81f22999","updated":"2017-08-22 20:54:16.000000000","message":"I don\u0027t see the dynamic part you mention, I see a default to 1450 [1] and that\u0027s it ? \n\nFWIW openshift-ansible does this \"MTU - 50\" thing too [2].\nThey default the MTU to 1450 if they can\u0027t find it in the host facts and then substract 50 from that number.\n\n[1]: http://git.openstack.org/cgit/openstack-infra/devstack-gate/tree/functions.sh?id\u003da79e66d2bb5de486d993a3270523237b767fbaa1#n1055\n[2]: https://github.com/openshift/openshift-ansible/blob/b107f677a3563f6db9a1ef17fe10518d321d495c/roles/openshift_facts/library/openshift_facts.py#L1035-L1046","commit_id":"ae1aca45c09e46b900ea4a643bce3b4b9ff37176"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"7f2e78acc6ac9deacabfef5a186699d2c9aa49a4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"PING_TIMES: 20"},{"line_number":5,"context_line":"HTTP_TIMES: 10"},{"line_number":6,"context_line":"PIP_CONFIG_FILE: \"{{ lookup(\u0027env\u0027, \u0027PIP_CONFIG_FILE\u0027)|default(\u0027/etc/pip.conf\u0027, true) }}\""},{"line_number":7,"context_line":"OVS_BRIDGE_MTU: 1450"},{"line_number":8,"context_line":"ADDITIONAL_VNI_OFFSET: 1000000"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"7f287b81_5ccb9452","line":7,"in_reply_to":"7f287b81_2b552351","updated":"2017-08-23 02:10:52.000000000","message":"You are right for the overlays its hardcoded, but I think when we tell neutron what mtu to use it is dynamic. So its fine to leave this as is for now we can work on making it smarter later as it won\u0027t be a regression.","commit_id":"ae1aca45c09e46b900ea4a643bce3b4b9ff37176"},{"author":{"_account_id":6589,"name":"Jesse Keating","email":"jkeating@j2solutions.net","username":"jesse-keating"},"change_message_id":"7ca9467e98529693ab37196b1d3e7f12cbc5d8be","unresolved":false,"context_lines":[{"line_number":5,"context_line":"HTTP_TIMES: 10"},{"line_number":6,"context_line":"MIRROR_INFO_FILE: \"{{ lookup(\u0027env\u0027, \u0027MIRROR_INFO_FILE\u0027)|default(\u0027/etc/ci/mirror_info.sh\u0027, true) }}\""},{"line_number":7,"context_line":"OVS_BRIDGE_MTU: 1450"},{"line_number":8,"context_line":"OFFSET_FILE: /tmp/offset"},{"line_number":9,"context_line":"STARTING_OFFSET: 1"},{"line_number":10,"context_line":"ADDITIONAL_VNI_OFFSET: 1000000"}],"source_content_type":"text/x-yaml","patch_set":36,"id":"7f287b81_b5146d4f","line":8,"updated":"2017-08-25 18:40:21.000000000","message":"Is this variable used any more?","commit_id":"79aab42505848b69ec189604bfc1aa8c2e4179c7"}],"playbooks/ovs_vxlan_bridge.yaml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"079787d78e6b7634fcafc3c773e313722f5071dc","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    - block:"},{"line_number":31,"context_line":"        - name: Load offset"},{"line_number":32,"context_line":"          set_fact:"},{"line_number":33,"context_line":"            offset: \"{{ lookup(\u0027file\u0027, \u0027/tmp/offset\u0027) | int }}\""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        - name: Increment offset"},{"line_number":36,"context_line":"          set_fact:"}],"source_content_type":"text/x-yaml","patch_set":33,"id":"7f287b81_d2ea7273","line":33,"updated":"2017-08-25 15:46:45.000000000","message":"Is the order of operations here correct? I can\u0027t find anything that writes /tmp/offset on the subnodes prior to this read.\n\nThe above section writes a 1 to the file on the primary node but here we are on the subnodes.","commit_id":"38fd7d82ea504d8db0987c5caf262af7ae0833c1"},{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"46fb363fc51acd411975880a0f9c29484a35b976","unresolved":false,"context_lines":[{"line_number":40,"context_line":"          copy:"},{"line_number":41,"context_line":"            dest: /tmp/offset"},{"line_number":42,"context_line":"            content: \"{{ offset }}\""},{"line_number":43,"context_line":"      delegate_to: primary"},{"line_number":44,"context_line":"  roles:"},{"line_number":45,"context_line":"    - ovs_vxlan_bridge_peers"}],"source_content_type":"text/x-yaml","patch_set":33,"id":"7f287b81_322ad68f","line":43,"range":{"start_line":43,"start_character":0,"end_line":43,"end_character":26},"updated":"2017-08-25 16:12:05.000000000","message":"These are delegated to primary -- so the offset persistence is done on the primary host. I\u0027ve moved the delegate_to directive at the top in patchset 34.","commit_id":"38fd7d82ea504d8db0987c5caf262af7ae0833c1"}],"playbooks/roles/ovs_vxlan_bridge_peers/tasks/main.yaml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"7ba2c3fec8f535dc6b55e4a3eace3b9f1cdd53f6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Increment offset"},{"line_number":3,"context_line":"  set_fact: offset\u003d\"{{ offset | int + 1 }}\""},{"line_number":4,"context_line":"- name: Add additional vni offset"},{"line_number":5,"context_line":"  set_fact: vni\u003d\"{{ offset | int + ADDITIONAL_VNI_OFFSET | int }}\""},{"line_number":6,"context_line":"- name: Add port to bridge on primary"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"7f287b81_34cf7fb1","line":3,"range":{"start_line":3,"start_character":2,"end_line":3,"end_character":43},"updated":"2017-08-24 19:44:41.000000000","message":"The way this works is that primary node has offset of 1, subnode_0 is offset of 2, subnode_1 is offset of 3 and so forth. This gives us unique IP addrs to use on the bridge and ensures that the VNI is unique for each primary:subnode pair.\n\nWill set_fact race if we have more than one subnode? eg is it possible that both subnode_0 and subnode_1 end up with offset of 2 rather than [2,3]?\n\nThis likely depends on how ansible processes the jinja2 and whether the global state is updated serially or if it can update it in parallel.","commit_id":"6e6ad592c26bd89ad70868b382324bbbad3540a2"},{"author":{"_account_id":6589,"name":"Jesse Keating","email":"jkeating@j2solutions.net","username":"jesse-keating"},"change_message_id":"986a89afb772390420ff17e495c7b27c683bbfba","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Increment offset"},{"line_number":3,"context_line":"  set_fact: offset\u003d\"{{ offset | int + 1 }}\""},{"line_number":4,"context_line":"- name: Add additional vni offset"},{"line_number":5,"context_line":"  set_fact: vni\u003d\"{{ offset | int + ADDITIONAL_VNI_OFFSET | int }}\""},{"line_number":6,"context_line":"- name: Add port to bridge on primary"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"7f287b81_9462b33d","line":3,"range":{"start_line":3,"start_character":2,"end_line":3,"end_character":43},"in_reply_to":"7f287b81_34cf7fb1","updated":"2017-08-24 20:04:30.000000000","message":"It depends on the number of hosts and forks, however this variable (offset) is actually a host specific variable, so each host is going to have it\u0027s own version of \"offset\" which may not work well for the intended purpose here. It may work better to iterate/update a specific host\u0027s variable.","commit_id":"6e6ad592c26bd89ad70868b382324bbbad3540a2"},{"author":{"_account_id":6589,"name":"Jesse Keating","email":"jkeating@j2solutions.net","username":"jesse-keating"},"change_message_id":"7d27a135d8c3edee613cfa22bda751cfe48bd901","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Increment offset"},{"line_number":3,"context_line":"  set_fact: offset\u003d\"{{ offset | int + 1 }}\""},{"line_number":4,"context_line":"- name: Add additional vni offset"},{"line_number":5,"context_line":"  set_fact: vni\u003d\"{{ offset | int + ADDITIONAL_VNI_OFFSET | int }}\""},{"line_number":6,"context_line":"- name: Add port to bridge on primary"},{"line_number":7,"context_line":"  command: |"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"7f287b81_fbcb2a47","line":4,"updated":"2017-08-24 18:34:26.000000000","message":"These playbooks are much more readable if you have a new line between each task.","commit_id":"6e6ad592c26bd89ad70868b382324bbbad3540a2"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"0650e17317519de8d14def6871620a757c1563a8","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# This dynamically configures a unique offset for this peer"},{"line_number":3,"context_line":"- name: Set offset"},{"line_number":4,"context_line":"  set_fact:"},{"line_number":5,"context_line":"    offset: \"{{ starting_offset | int + 1 + groups[\u0027all\u0027].index(inventory_hostname) }}\""},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- name: Add additional vni offset"},{"line_number":8,"context_line":"  set_fact:"}],"source_content_type":"text/x-yaml","patch_set":37,"id":"7f287b81_2e814a90","line":5,"range":{"start_line":5,"start_character":16,"end_line":5,"end_character":31},"updated":"2017-08-25 20:42:31.000000000","message":"Isn\u0027t this ovs_starting_offset?\n\nAlso will this make primary .1 and then first subnode .3 instead of .2? I don\u0027t think it really matters and we can tweak it later.","commit_id":"116ce2eb7a6623ab5ae01874bba37a2f6cfdf72e"},{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"28bbb4ad6f42161fa24db9bf305e8df5a69b9061","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# This dynamically configures a unique offset for this peer"},{"line_number":3,"context_line":"- name: Set offset"},{"line_number":4,"context_line":"  set_fact:"},{"line_number":5,"context_line":"    offset: \"{{ starting_offset | int + 1 + groups[\u0027all\u0027].index(inventory_hostname) }}\""},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- name: Add additional vni offset"},{"line_number":8,"context_line":"  set_fact:"}],"source_content_type":"text/x-yaml","patch_set":37,"id":"7f287b81_64d1b1fb","line":5,"range":{"start_line":5,"start_character":16,"end_line":5,"end_character":31},"in_reply_to":"7f287b81_2e814a90","updated":"2017-08-25 22:19:39.000000000","message":"Done","commit_id":"116ce2eb7a6623ab5ae01874bba37a2f6cfdf72e"},{"author":{"_account_id":6589,"name":"Jesse Keating","email":"jkeating@j2solutions.net","username":"jesse-keating"},"change_message_id":"bfdad5afc52f58740e08147b2f76118a4a946d06","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    options:local_ip\u003d{{ nodepool[\u0027private_ipv4\u0027] }}"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"- when: set_ips"},{"line_number":41,"context_line":"  block:"},{"line_number":42,"context_line":"    - name: Verify if the bridge address is set"},{"line_number":43,"context_line":"      shell: ip addr show dev {{ bridge_name }} | grep -q {{ pub_addr_prefix }}.{{ offset }}/{{ pub_addr_mask }}"},{"line_number":44,"context_line":"      register: ip_addr_var"}],"source_content_type":"text/x-yaml","patch_set":44,"id":"7f287b81_2575c464","line":41,"updated":"2017-08-28 16:57:31.000000000","message":"This syntax seems weird. If it works, okay, but doesn\u0027t look great. Usually the block gets the dash, not the conditional.","commit_id":"fa3272d5f95a03623b2a734c99b225978d643c15"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"1962c12958c988d0c5b6d4fb97db7b6f63b0c5be","unresolved":false,"context_lines":[{"line_number":16,"context_line":"- name: Add port to bridge on primary"},{"line_number":17,"context_line":"  shell: \u003e-"},{"line_number":18,"context_line":"    ovs-vsctl --may-exist add-port {{ bridge_name }}"},{"line_number":19,"context_line":"    {{ bridge_name }}_{{ primary_private_ip }}"},{"line_number":20,"context_line":"    -- set interface {{ bridge_name}}_{{ primary_private_ip }}"},{"line_number":21,"context_line":"    type\u003dvxlan options:remote_ip\u003d{{ primary_private_ip }} options:key\u003d{{ vni }}"},{"line_number":22,"context_line":"    options:local_ip\u003d{{ primary_private_ip }}"}],"source_content_type":"text/x-yaml","patch_set":48,"id":"7f287b81_3ce021cd","line":19,"range":{"start_line":19,"start_character":25,"end_line":19,"end_character":43},"updated":"2017-08-29 17:37:24.000000000","message":"This needs to be the remotes private ip. We use {{ nodepool[\u0027private_ipv4\u0027] }} below for this value.","commit_id":"0525913ead24abaea7664fb644646961e5a16591"},{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"8a6a23aa3c6667c73d1a993bf9f780ea98cd18f3","unresolved":false,"context_lines":[{"line_number":16,"context_line":"- name: Add port to bridge on primary"},{"line_number":17,"context_line":"  shell: \u003e-"},{"line_number":18,"context_line":"    ovs-vsctl --may-exist add-port {{ bridge_name }}"},{"line_number":19,"context_line":"    {{ bridge_name }}_{{ primary_private_ip }}"},{"line_number":20,"context_line":"    -- set interface {{ bridge_name}}_{{ primary_private_ip }}"},{"line_number":21,"context_line":"    type\u003dvxlan options:remote_ip\u003d{{ primary_private_ip }} options:key\u003d{{ vni }}"},{"line_number":22,"context_line":"    options:local_ip\u003d{{ primary_private_ip }}"}],"source_content_type":"text/x-yaml","patch_set":48,"id":"7f287b81_6a8b7767","line":19,"range":{"start_line":19,"start_character":25,"end_line":19,"end_character":43},"in_reply_to":"7f287b81_3ce021cd","updated":"2017-08-29 18:48:35.000000000","message":"Done","commit_id":"0525913ead24abaea7664fb644646961e5a16591"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"1962c12958c988d0c5b6d4fb97db7b6f63b0c5be","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  shell: \u003e-"},{"line_number":18,"context_line":"    ovs-vsctl --may-exist add-port {{ bridge_name }}"},{"line_number":19,"context_line":"    {{ bridge_name }}_{{ primary_private_ip }}"},{"line_number":20,"context_line":"    -- set interface {{ bridge_name}}_{{ primary_private_ip }}"},{"line_number":21,"context_line":"    type\u003dvxlan options:remote_ip\u003d{{ primary_private_ip }} options:key\u003d{{ vni }}"},{"line_number":22,"context_line":"    options:local_ip\u003d{{ primary_private_ip }}"},{"line_number":23,"context_line":"  delegate_to: \"{{ groups[\u0027primary\u0027][0] }}\""}],"source_content_type":"text/x-yaml","patch_set":48,"id":"7f287b81_1ce325db","line":20,"range":{"start_line":20,"start_character":41,"end_line":20,"end_character":59},"updated":"2017-08-29 17:37:24.000000000","message":"See above.","commit_id":"0525913ead24abaea7664fb644646961e5a16591"},{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"8a6a23aa3c6667c73d1a993bf9f780ea98cd18f3","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  shell: \u003e-"},{"line_number":18,"context_line":"    ovs-vsctl --may-exist add-port {{ bridge_name }}"},{"line_number":19,"context_line":"    {{ bridge_name }}_{{ primary_private_ip }}"},{"line_number":20,"context_line":"    -- set interface {{ bridge_name}}_{{ primary_private_ip }}"},{"line_number":21,"context_line":"    type\u003dvxlan options:remote_ip\u003d{{ primary_private_ip }} options:key\u003d{{ vni }}"},{"line_number":22,"context_line":"    options:local_ip\u003d{{ primary_private_ip }}"},{"line_number":23,"context_line":"  delegate_to: \"{{ groups[\u0027primary\u0027][0] }}\""}],"source_content_type":"text/x-yaml","patch_set":48,"id":"7f287b81_4aec3b29","line":20,"range":{"start_line":20,"start_character":41,"end_line":20,"end_character":59},"in_reply_to":"7f287b81_1ce325db","updated":"2017-08-29 18:48:35.000000000","message":"Done","commit_id":"0525913ead24abaea7664fb644646961e5a16591"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"1962c12958c988d0c5b6d4fb97db7b6f63b0c5be","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    ovs-vsctl --may-exist add-port {{ bridge_name }}"},{"line_number":19,"context_line":"    {{ bridge_name }}_{{ primary_private_ip }}"},{"line_number":20,"context_line":"    -- set interface {{ bridge_name}}_{{ primary_private_ip }}"},{"line_number":21,"context_line":"    type\u003dvxlan options:remote_ip\u003d{{ primary_private_ip }} options:key\u003d{{ vni }}"},{"line_number":22,"context_line":"    options:local_ip\u003d{{ primary_private_ip }}"},{"line_number":23,"context_line":"  delegate_to: \"{{ groups[\u0027primary\u0027][0] }}\""},{"line_number":24,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":48,"id":"7f287b81_fce5f9dc","line":21,"range":{"start_line":21,"start_character":36,"end_line":21,"end_character":54},"updated":"2017-08-29 17:37:24.000000000","message":"See above.","commit_id":"0525913ead24abaea7664fb644646961e5a16591"},{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"8a6a23aa3c6667c73d1a993bf9f780ea98cd18f3","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    ovs-vsctl --may-exist add-port {{ bridge_name }}"},{"line_number":19,"context_line":"    {{ bridge_name }}_{{ primary_private_ip }}"},{"line_number":20,"context_line":"    -- set interface {{ bridge_name}}_{{ primary_private_ip }}"},{"line_number":21,"context_line":"    type\u003dvxlan options:remote_ip\u003d{{ primary_private_ip }} options:key\u003d{{ vni }}"},{"line_number":22,"context_line":"    options:local_ip\u003d{{ primary_private_ip }}"},{"line_number":23,"context_line":"  delegate_to: \"{{ groups[\u0027primary\u0027][0] }}\""},{"line_number":24,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":48,"id":"7f287b81_2aefaf1e","line":21,"range":{"start_line":21,"start_character":36,"end_line":21,"end_character":54},"in_reply_to":"7f287b81_fce5f9dc","updated":"2017-08-29 18:48:35.000000000","message":"Done","commit_id":"0525913ead24abaea7664fb644646961e5a16591"}],"playbooks/roles/ovs_vxlan_bridge_primary/tasks/main.yaml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"0650e17317519de8d14def6871620a757c1563a8","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"- block:"},{"line_number":9,"context_line":"    - name: Verify if the bridge address is set"},{"line_number":10,"context_line":"      shell: ip addr show dev {{ bridge_name }} | grep -q {{ pub_addr_prefix }}.{{ starting_offset }}/{{ pub_addr_mask }}"},{"line_number":11,"context_line":"      register: ip_addr_var"},{"line_number":12,"context_line":"      failed_when: False"},{"line_number":13,"context_line":"      changed_when: False"}],"source_content_type":"text/x-yaml","patch_set":37,"id":"7f287b81_4eadb62f","line":10,"range":{"start_line":10,"start_character":83,"end_line":10,"end_character":98},"updated":"2017-08-25 20:42:31.000000000","message":"Isn\u0027t this ovs_starting_offset?","commit_id":"116ce2eb7a6623ab5ae01874bba37a2f6cfdf72e"},{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"28bbb4ad6f42161fa24db9bf305e8df5a69b9061","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"- block:"},{"line_number":9,"context_line":"    - name: Verify if the bridge address is set"},{"line_number":10,"context_line":"      shell: ip addr show dev {{ bridge_name }} | grep -q {{ pub_addr_prefix }}.{{ starting_offset }}/{{ pub_addr_mask }}"},{"line_number":11,"context_line":"      register: ip_addr_var"},{"line_number":12,"context_line":"      failed_when: False"},{"line_number":13,"context_line":"      changed_when: False"}],"source_content_type":"text/x-yaml","patch_set":37,"id":"7f287b81_44cc7560","line":10,"range":{"start_line":10,"start_character":83,"end_line":10,"end_character":98},"in_reply_to":"7f287b81_4eadb62f","updated":"2017-08-25 22:19:39.000000000","message":"Done","commit_id":"116ce2eb7a6623ab5ae01874bba37a2f6cfdf72e"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"0650e17317519de8d14def6871620a757c1563a8","unresolved":false,"context_lines":[{"line_number":13,"context_line":"      changed_when: False"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    - name: Set the bridge address"},{"line_number":16,"context_line":"      command: ip addr add {{ pub_addr_prefix }}.{{ starting_offset }}/{{ pub_addr_mask }} dev {{ bridge_name }}"},{"line_number":17,"context_line":"      become: yes"},{"line_number":18,"context_line":"      when: ip_addr_var.rc \u003d\u003d 0"},{"line_number":19,"context_line":"  when: set_ips"}],"source_content_type":"text/x-yaml","patch_set":37,"id":"7f287b81_ae6d3a05","line":16,"range":{"start_line":16,"start_character":52,"end_line":16,"end_character":67},"updated":"2017-08-25 20:42:31.000000000","message":"See above.","commit_id":"116ce2eb7a6623ab5ae01874bba37a2f6cfdf72e"},{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"28bbb4ad6f42161fa24db9bf305e8df5a69b9061","unresolved":false,"context_lines":[{"line_number":13,"context_line":"      changed_when: False"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    - name: Set the bridge address"},{"line_number":16,"context_line":"      command: ip addr add {{ pub_addr_prefix }}.{{ starting_offset }}/{{ pub_addr_mask }} dev {{ bridge_name }}"},{"line_number":17,"context_line":"      become: yes"},{"line_number":18,"context_line":"      when: ip_addr_var.rc \u003d\u003d 0"},{"line_number":19,"context_line":"  when: set_ips"}],"source_content_type":"text/x-yaml","patch_set":37,"id":"7f287b81_24dba91b","line":16,"range":{"start_line":16,"start_character":52,"end_line":16,"end_character":67},"in_reply_to":"7f287b81_ae6d3a05","updated":"2017-08-25 22:19:39.000000000","message":"Done","commit_id":"116ce2eb7a6623ab5ae01874bba37a2f6cfdf72e"}]}