)]}'
{"devstack-vm-gate.sh":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"0273e0c3242190a79f8f27d2daf4f60959ab0eed","unresolved":false,"context_lines":[{"line_number":583,"context_line":"        else"},{"line_number":584,"context_line":"            if [[ -n \"$DEVSTACK_LOCAL_CONFIG\" ]]; then"},{"line_number":585,"context_line":"                echo \"[[local|localrc]]\" \u003e /tmp/ds-localrc"},{"line_number":586,"context_line":"                echo $DEVSTACK_SUBNODE_CONFIG \u003e\u003e /tmp/ds-localrc"},{"line_number":587,"context_line":"                $DSCONF merge_lc \"$localrc_file\" /tmp/ds-localrc"},{"line_number":588,"context_line":"            fi"},{"line_number":589,"context_line":"        fi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"da36d5c6_1a38f29f","line":586,"updated":"2017-02-22 16:06:44.000000000","message":"This should be DEVSTACK_LOCAL_CONFIG not DEVSTACK_SUBNODE_CONFIG.\n\nAnd maybe we collapse this block and the one below it by doing:\n\n  if role \u003d sub and subnode_config; then\n    do subnode-localrc\n  else if devstack local config; then\n    do local_config\n  fi","commit_id":"d0c23254f50c33cd9a2c0cee93adae23b10cf7ec"},{"author":{"_account_id":7979,"name":"Mikhail S Medvedev","email":"mihailmed@gmail.com","username":"msmedved"},"change_message_id":"3cbb5d01ed8c907ac7b8d3d9873e6c616627716c","unresolved":false,"context_lines":[{"line_number":577,"context_line":"        # If we are in a multinode environment, we may want to specify 2"},{"line_number":578,"context_line":"        # different sets of plugins"},{"line_number":579,"context_line":"        if [[ -n \"$DEVSTACK_SUBNODE_CONFIG\" ]]; then"},{"line_number":580,"context_line":"            echo \"[[local|localrc]]\" \u003e /tmp/ds-subnode-localrc"},{"line_number":581,"context_line":"            echo $DEVSTACK_SUBNODE_CONFIG \u003e\u003e /tmp/ds-subnode-localrc"},{"line_number":582,"context_line":"            $DSCONF merge_lc \"$localrc_file\" /tmp/ds-subnode-localrc"},{"line_number":583,"context_line":"        else"},{"line_number":584,"context_line":"            if [[ -n \"$DEVSTACK_LOCAL_CONFIG\" ]]; then"},{"line_number":585,"context_line":"                echo \"[[local|localrc]]\" \u003e /tmp/ds-localrc"}],"source_content_type":"text/x-sh","patch_set":2,"id":"da36d5c6_d3f3a59c","line":582,"range":{"start_line":580,"start_character":0,"end_line":582,"end_character":68},"updated":"2017-02-22 17:30:18.000000000","message":"Can also use `setlc_raw` here and below.\n\n  $DSCONF setlc_raw \"$localrc_fle\" \"$DEVSTACK_SUBNODE_CONFIG\"","commit_id":"1c0fa5aecc771ba292a913d9e9737f22bd11348c"},{"author":{"_account_id":7979,"name":"Mikhail S Medvedev","email":"mihailmed@gmail.com","username":"msmedved"},"change_message_id":"993989f4df5cc5de10e65193fbfe105fb306dcfb","unresolved":false,"context_lines":[{"line_number":577,"context_line":"        # If we are in a multinode environment, we may want to specify 2"},{"line_number":578,"context_line":"        # different sets of plugins"},{"line_number":579,"context_line":"        if [[ -n \"$DEVSTACK_SUBNODE_CONFIG\" ]]; then"},{"line_number":580,"context_line":"            echo \"[[local|localrc]]\" \u003e /tmp/ds-subnode-localrc"},{"line_number":581,"context_line":"            echo $DEVSTACK_SUBNODE_CONFIG \u003e\u003e /tmp/ds-subnode-localrc"},{"line_number":582,"context_line":"            $DSCONF merge_lc \"$localrc_file\" /tmp/ds-subnode-localrc"},{"line_number":583,"context_line":"        else"},{"line_number":584,"context_line":"            if [[ -n \"$DEVSTACK_LOCAL_CONFIG\" ]]; then"},{"line_number":585,"context_line":"                echo \"[[local|localrc]]\" \u003e /tmp/ds-localrc"}],"source_content_type":"text/x-sh","patch_set":2,"id":"da36d5c6_4945426e","line":582,"range":{"start_line":580,"start_character":0,"end_line":582,"end_character":68},"in_reply_to":"da36d5c6_2ef2d46f","updated":"2017-02-22 18:40:16.000000000","message":"I tested it, the newlines are kept as expected if you wrap it in \"\". Can simplify later to be on the safe side, I guess.","commit_id":"1c0fa5aecc771ba292a913d9e9737f22bd11348c"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"38e39f44f8f687dbbc9b45176046c50eade3a7ab","unresolved":false,"context_lines":[{"line_number":577,"context_line":"        # If we are in a multinode environment, we may want to specify 2"},{"line_number":578,"context_line":"        # different sets of plugins"},{"line_number":579,"context_line":"        if [[ -n \"$DEVSTACK_SUBNODE_CONFIG\" ]]; then"},{"line_number":580,"context_line":"            echo \"[[local|localrc]]\" \u003e /tmp/ds-subnode-localrc"},{"line_number":581,"context_line":"            echo $DEVSTACK_SUBNODE_CONFIG \u003e\u003e /tmp/ds-subnode-localrc"},{"line_number":582,"context_line":"            $DSCONF merge_lc \"$localrc_file\" /tmp/ds-subnode-localrc"},{"line_number":583,"context_line":"        else"},{"line_number":584,"context_line":"            if [[ -n \"$DEVSTACK_LOCAL_CONFIG\" ]]; then"},{"line_number":585,"context_line":"                echo \"[[local|localrc]]\" \u003e /tmp/ds-localrc"}],"source_content_type":"text/x-sh","patch_set":2,"id":"da36d5c6_ed1b5d71","line":582,"range":{"start_line":580,"start_character":0,"end_line":582,"end_character":68},"in_reply_to":"da36d5c6_4945426e","updated":"2017-02-22 19:39:22.000000000","message":"@mikhail could you push a new unit test to devstack-tools with that? We can then trust it after it is in place.","commit_id":"1c0fa5aecc771ba292a913d9e9737f22bd11348c"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"e92b771d8ac0880ef55fbbd03af5a7d0d83c4143","unresolved":false,"context_lines":[{"line_number":577,"context_line":"        # If we are in a multinode environment, we may want to specify 2"},{"line_number":578,"context_line":"        # different sets of plugins"},{"line_number":579,"context_line":"        if [[ -n \"$DEVSTACK_SUBNODE_CONFIG\" ]]; then"},{"line_number":580,"context_line":"            echo \"[[local|localrc]]\" \u003e /tmp/ds-subnode-localrc"},{"line_number":581,"context_line":"            echo $DEVSTACK_SUBNODE_CONFIG \u003e\u003e /tmp/ds-subnode-localrc"},{"line_number":582,"context_line":"            $DSCONF merge_lc \"$localrc_file\" /tmp/ds-subnode-localrc"},{"line_number":583,"context_line":"        else"},{"line_number":584,"context_line":"            if [[ -n \"$DEVSTACK_LOCAL_CONFIG\" ]]; then"},{"line_number":585,"context_line":"                echo \"[[local|localrc]]\" \u003e /tmp/ds-localrc"}],"source_content_type":"text/x-sh","patch_set":2,"id":"da36d5c6_2ef2d46f","line":582,"range":{"start_line":580,"start_character":0,"end_line":582,"end_character":68},"in_reply_to":"da36d5c6_d3f3a59c","updated":"2017-02-22 18:06:17.000000000","message":"we could, the merge is probably a little better at this point because I\u0027m not sure I trust the newline insert on setlc_raw (it\u0027s definitely not tested)\u003e","commit_id":"1c0fa5aecc771ba292a913d9e9737f22bd11348c"},{"author":{"_account_id":7979,"name":"Mikhail S Medvedev","email":"mihailmed@gmail.com","username":"msmedved"},"change_message_id":"b6477e9002c67c2b42547704a7bf9a7e7260210e","unresolved":false,"context_lines":[{"line_number":577,"context_line":"        # If we are in a multinode environment, we may want to specify 2"},{"line_number":578,"context_line":"        # different sets of plugins"},{"line_number":579,"context_line":"        if [[ -n \"$DEVSTACK_SUBNODE_CONFIG\" ]]; then"},{"line_number":580,"context_line":"            echo \"[[local|localrc]]\" \u003e /tmp/ds-subnode-localrc"},{"line_number":581,"context_line":"            echo $DEVSTACK_SUBNODE_CONFIG \u003e\u003e /tmp/ds-subnode-localrc"},{"line_number":582,"context_line":"            $DSCONF merge_lc \"$localrc_file\" /tmp/ds-subnode-localrc"},{"line_number":583,"context_line":"        else"},{"line_number":584,"context_line":"            if [[ -n \"$DEVSTACK_LOCAL_CONFIG\" ]]; then"},{"line_number":585,"context_line":"                echo \"[[local|localrc]]\" \u003e /tmp/ds-localrc"}],"source_content_type":"text/x-sh","patch_set":2,"id":"da36d5c6_a25b2ff5","line":582,"range":{"start_line":580,"start_character":0,"end_line":582,"end_character":68},"in_reply_to":"da36d5c6_ed1b5d71","updated":"2017-02-22 21:10:14.000000000","message":"pushed in I21bd78fa6169002a70fa9074d56d985bfc0b833f","commit_id":"1c0fa5aecc771ba292a913d9e9737f22bd11348c"}]}