)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"9c4ec2d06f0322d8f238e321991f7cd6e0e78846","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This changes how we manipulate the local.conf for the subnodes so that"},{"line_number":10,"context_line":"HOST_IP happens first not last in the local stanza."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I7f0d9bfe53d769e3168ca36d04983f1cd68d9e6d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a1ced50_65069887","line":11,"updated":"2017-03-21 13:01:29.000000000","message":"nit: \"closes-bug: #1669468\"","commit_id":"873e8e5ea0b1b0a1f1544586c08741dee0f672d0"}],"devstack-vm-gate.sh":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"bec790e2a0a13db5d1bee60d034ce43a42ddbed7","unresolved":false,"context_lines":[{"line_number":200,"context_line":"    for NODE in $sub_nodes; do"},{"line_number":201,"context_line":"        remote_copy_file /tmp/tmp_hosts $NODE:/tmp/tmp_hosts"},{"line_number":202,"context_line":"        remote_command $NODE \"cat /tmp/tmp_hosts | sudo tee --append /etc/hosts \u003e /dev/null\""},{"line_number":203,"context_line":"        rm -f /tmp/tmp_sub_localconf"},{"line_number":204,"context_line":"        # Build a custom local.conf for the subnode that has HOST_IP"},{"line_number":205,"context_line":"        # encoded. We do the HOST_IP add early so that it\u0027s a variable"},{"line_number":206,"context_line":"        # that can be used by other stanzas later."}],"source_content_type":"text/x-sh","patch_set":1,"id":"1a1ced50_ee70a0de","line":203,"updated":"2017-03-21 15:33:43.000000000","message":"Apparently -f makes this not fail if the file doesn\u0027t exist. The more you know.","commit_id":"873e8e5ea0b1b0a1f1544586c08741dee0f672d0"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"0e56f1c33d9f6035fda495bf7d8d679829fd04f5","unresolved":false,"context_lines":[{"line_number":200,"context_line":"    for NODE in $sub_nodes; do"},{"line_number":201,"context_line":"        remote_copy_file /tmp/tmp_hosts $NODE:/tmp/tmp_hosts"},{"line_number":202,"context_line":"        remote_command $NODE \"cat /tmp/tmp_hosts | sudo tee --append /etc/hosts \u003e /dev/null\""},{"line_number":203,"context_line":"        rm -f /tmp/tmp_sub_localconf"},{"line_number":204,"context_line":"        # Build a custom local.conf for the subnode that has HOST_IP"},{"line_number":205,"context_line":"        # encoded. We do the HOST_IP add early so that it\u0027s a variable"},{"line_number":206,"context_line":"        # that can be used by other stanzas later."}],"source_content_type":"text/x-sh","patch_set":1,"id":"1a1ced50_6e02f00c","line":203,"in_reply_to":"1a1ced50_ee70a0de","updated":"2017-03-21 15:35:00.000000000","message":"yes","commit_id":"873e8e5ea0b1b0a1f1544586c08741dee0f672d0"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ba9973c40b36de815f324702df9b6e21f019ec24","unresolved":false,"context_lines":[{"line_number":204,"context_line":"        # Build a custom local.conf for the subnode that has HOST_IP"},{"line_number":205,"context_line":"        # encoded. We do the HOST_IP add early so that it\u0027s a variable"},{"line_number":206,"context_line":"        # that can be used by other stanzas later."},{"line_number":207,"context_line":"        $DSCONF setlc /tmp/tmp_sub_localconf \"HOST_IP\" \"$NODE\""},{"line_number":208,"context_line":"        $DSCONF merge_lc /tmp/tmp_sub_localconf \"$sub_localconf\""},{"line_number":209,"context_line":"        remote_copy_file /tmp/tmp_sub_localconf $NODE:$devstack_dir/local.conf"},{"line_number":210,"context_line":"    done"}],"source_content_type":"text/x-sh","patch_set":1,"id":"1a1ced50_a5333061","line":207,"updated":"2017-03-21 13:02:39.000000000","message":"This seems to be just what \"localrc_set\" does, so why do you change it?","commit_id":"873e8e5ea0b1b0a1f1544586c08741dee0f672d0"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"63f535431ae4e8d43ba2f24b52201868947c8f76","unresolved":false,"context_lines":[{"line_number":204,"context_line":"        # Build a custom local.conf for the subnode that has HOST_IP"},{"line_number":205,"context_line":"        # encoded. We do the HOST_IP add early so that it\u0027s a variable"},{"line_number":206,"context_line":"        # that can be used by other stanzas later."},{"line_number":207,"context_line":"        $DSCONF setlc /tmp/tmp_sub_localconf \"HOST_IP\" \"$NODE\""},{"line_number":208,"context_line":"        $DSCONF merge_lc /tmp/tmp_sub_localconf \"$sub_localconf\""},{"line_number":209,"context_line":"        remote_copy_file /tmp/tmp_sub_localconf $NODE:$devstack_dir/local.conf"},{"line_number":210,"context_line":"    done"}],"source_content_type":"text/x-sh","patch_set":1,"id":"1a1ced50_87b8efc9","line":207,"in_reply_to":"1a1ced50_2e2558c0","updated":"2017-03-21 16:14:23.000000000","message":"Ah, o.k., thanks for explaining.","commit_id":"873e8e5ea0b1b0a1f1544586c08741dee0f672d0"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"bec790e2a0a13db5d1bee60d034ce43a42ddbed7","unresolved":false,"context_lines":[{"line_number":204,"context_line":"        # Build a custom local.conf for the subnode that has HOST_IP"},{"line_number":205,"context_line":"        # encoded. We do the HOST_IP add early so that it\u0027s a variable"},{"line_number":206,"context_line":"        # that can be used by other stanzas later."},{"line_number":207,"context_line":"        $DSCONF setlc /tmp/tmp_sub_localconf \"HOST_IP\" \"$NODE\""},{"line_number":208,"context_line":"        $DSCONF merge_lc /tmp/tmp_sub_localconf \"$sub_localconf\""},{"line_number":209,"context_line":"        remote_copy_file /tmp/tmp_sub_localconf $NODE:$devstack_dir/local.conf"},{"line_number":210,"context_line":"    done"}],"source_content_type":"text/x-sh","patch_set":1,"id":"1a1ced50_eed420be","line":207,"in_reply_to":"1a1ced50_a5333061","updated":"2017-03-21 15:33:43.000000000","message":"I think the localrc_set function was to have a compat layer with the new devstack tools commands, so over time we should move to the direct calls like this one.","commit_id":"873e8e5ea0b1b0a1f1544586c08741dee0f672d0"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"83d9ddeb2e68c55aed24320fa00778584ebab534","unresolved":false,"context_lines":[{"line_number":204,"context_line":"        # Build a custom local.conf for the subnode that has HOST_IP"},{"line_number":205,"context_line":"        # encoded. We do the HOST_IP add early so that it\u0027s a variable"},{"line_number":206,"context_line":"        # that can be used by other stanzas later."},{"line_number":207,"context_line":"        $DSCONF setlc /tmp/tmp_sub_localconf \"HOST_IP\" \"$NODE\""},{"line_number":208,"context_line":"        $DSCONF merge_lc /tmp/tmp_sub_localconf \"$sub_localconf\""},{"line_number":209,"context_line":"        remote_copy_file /tmp/tmp_sub_localconf $NODE:$devstack_dir/local.conf"},{"line_number":210,"context_line":"    done"}],"source_content_type":"text/x-sh","patch_set":1,"id":"1a1ced50_2e2558c0","line":207,"in_reply_to":"1a1ced50_a5333061","updated":"2017-03-21 15:34:37.000000000","message":"it is the same, given that localrc_set confused some folks previously that thought it was coming from devstack includes, doing it directly seemed fine.","commit_id":"873e8e5ea0b1b0a1f1544586c08741dee0f672d0"}]}