)]}'
{"id":"openstack%2Fdevstack-gate~47043","triplet_id":"openstack%2Fdevstack-gate~master~I1e972127b0e8d6053f6581a586c7b27279f296c9","project":"openstack/devstack-gate","branch":"master","topic":"docker","hashtags":[],"change_id":"I1e972127b0e8d6053f6581a586c7b27279f296c9","subject":"Add docker support","status":"ABANDONED","created":"2013-09-17 21:59:46.000000000","updated":"2013-09-28 06:03:04.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"ec495418d95dc5988085ae6714f0e86ab8a69287","_number":47043,"virtual_id_number":47043,"owner":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},{"value":1,"date":"2013-09-17 22:30:36.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"all":[{"value":-1,"date":"2013-09-20 15:46:55.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2013-09-20 15:50:08.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"date":"2013-09-20 15:46:55.000000000","_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-09-17 22:30:36.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2013-09-20 15:46:55.000000000","updated_by":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"reviewer":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"state":"REVIEWER"}],"messages":[{"id":"11f05570b0af3d458cf2c98fb537b18bf4b8f47a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-09-17 22:30:36.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- gate-tempest-devstack-vm-full http://logs.openstack.org/43/47043/1/check/gate-tempest-devstack-vm-full/abf5909 : SUCCESS in 30m 05s\n- gate-tempest-devstack-vm-postgres-full http://logs.openstack.org/43/47043/1/check/gate-tempest-devstack-vm-postgres-full/d53f790 : SUCCESS in 30m 48s\n- gate-tempest-devstack-vm-neutron http://logs.openstack.org/43/47043/1/check/gate-tempest-devstack-vm-neutron/970e249 : SUCCESS in 17m 30s\n- gate-grenade-devstack-vm http://logs.openstack.org/43/47043/1/check/gate-grenade-devstack-vm/6944d70 : SUCCESS in 27m 17s\n- gate-swift-devstack-vm-functional http://logs.openstack.org/43/47043/1/check/gate-swift-devstack-vm-functional/e77aeba : SUCCESS in 11m 50s\n","accounts_in_message":[],"_revision_number":1},{"id":"ce552b72457924f20640d27af383c9b09b021ad5","author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"date":"2013-09-20 15:46:55.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\nI have a few concerns:\n\n* Docker support requires a 3rd-party apt archive; I want to make sure we\u0027re okay with that (to date we have tried to stick to distro-supplied packages).\n\n* The install script has external network dependencies.  We try to avoid those in the devstack-gate scripts because at the rate that we run tests, network issues show up all the time (and also sometimes it looks like we are running a DDoS on sites if the gate is busy).\n\nHere http://git.openstack.org/cgit/openstack-dev/devstack/tree/tools/docker/install_docker.sh#n37 is where it adds the apt repo and installs packages from it.  If we wanted to use this repo, I think we\u0027d want to have it added during the image creation step and ensure that the .deb files are cached (also during the image creation step).  Devstack would need to be updated to support testing wether the repo and key have already been added.  And ideally, devstack would add something to the \u0027apts\u0027 directory so that the needed packages would be automatically cached (that\u0027s where the image pre-cache script looks).\n\nAlso here http://git.openstack.org/cgit/openstack-dev/devstack/tree/tools/docker/install_docker.sh#n60 an image is downloaded.  That is defined in the hypervisor-docker file, but not in stackrc.  Compare that to openvz whose custom image _is_ defined in stackrc: http://git.openstack.org/cgit/openstack-dev/devstack/tree/stackrc#n246\n\nIf the docker image were set up similarly, it would be automatically picked up by the pre-cache scripts.  If that\u0027s not possible, we may need to special case it in the devstack image creation.\n\nTo summarize:\n\n1) Let\u0027s get some consensus on the appropriateness of the docker apt repo.\n\n2) Let\u0027s see if the docker construction in devstack can more closely follow the openvz model.\n\n3) Anything in devstack we still can\u0027t normalize will need to be added to the image creation scripts (which are here, btw: http://git.openstack.org/cgit/openstack-infra/config/tree/modules/openstack_project/files/nodepool/scripts )","accounts_in_message":[],"_revision_number":1},{"id":"8d55f7dfa5c68271d7aeb51b34a40372a65e93ed","author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"date":"2013-09-20 15:50:08.000000000","message":"Patch Set 1:\n\nOne more complexity to consider with this is that docker requires kernel 3.8 or above: http://docs.docker.io/en/latest/installation/kernel/\n\nThat\u0027s not included in the precise image used today.  There is a newer kernel in the official ubuntu repo (linux-generic-lts-raring) that would work, in theory.  It would require using a different image for docker testing, or updating the image that everything uses.","accounts_in_message":[],"_revision_number":1},{"id":"f312e453f055cc3e159855438c0e9e03769ca357","author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"date":"2013-09-20 15:50:12.000000000","message":"Patch Set 1: Work In Progress","accounts_in_message":[],"_revision_number":1},{"id":"ce8a108900c909b5aabdfbc74c1f3080d9e99a82","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2013-09-28 06:03:04.000000000","message":"Patch Set 1: Abandoned\n\ncode review expired after 1 week of no activity after a negative review, it can be restored using the `Restore Change` button under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":1},{"id":"69b50c457db354c3758263fdeb0e231803d53fde","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2013-09-28 06:03:04.000000000","message":"Patch Set 1:\n\ncode review expired after 1 week of no activity after a negative review, it can be restored using the `Restore Change` button under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"1f6871636e89a0150fa450672eca1a43b913fcf5","revisions":{"1f6871636e89a0150fa450672eca1a43b913fcf5":{"kind":"REWORK","_number":1,"created":"2013-09-17 21:59:46.000000000","uploader":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"ref":"refs/changes/43/47043/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack-gate","ref":"refs/changes/43/47043/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack-gate refs/changes/43/47043/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack-gate refs/changes/43/47043/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack-gate refs/changes/43/47043/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack-gate refs/changes/43/47043/1"}}},"commit":{"parents":[{"commit":"e1e925e1632f6b9ad65f31fb6c88c5a4b3388352","subject":"Merge \"Log pre and post test hooks to file and stdout.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-gate/commit/e1e925e1632f6b9ad65f31fb6c88c5a4b3388352"}]}],"author":{"name":"Russell Bryant","email":"rbryant@redhat.com","date":"2013-09-17 21:57:54.000000000","tz":-240},"committer":{"name":"Russell Bryant","email":"rbryant@redhat.com","date":"2013-09-17 21:57:54.000000000","tz":-240},"subject":"Add docker support","message":"Add docker support\n\nThe Havana release of Nova includes a new compute driver for docker.\nThis driver should be easy for us to test in the existing CI setup.\nSupport was added to devstack.  This adds a devstack-gate hook for\nturning on docker.  The instructions say that you just have to put\nVIRT_DRIVER\u003ddocker in your localrc and run the docker install script\nbefore running stack.sh.\n\nChange-Id: I1e972127b0e8d6053f6581a586c7b27279f296c9\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-gate/commit/1f6871636e89a0150fa450672eca1a43b913fcf5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-gate/commit/1f6871636e89a0150fa450672eca1a43b913fcf5"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}