)]}'
{"functions.sh":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"f7deb2a254c68221003294577992258242f8991a","unresolved":false,"context_lines":[{"line_number":784,"context_line":"        local name\u003d\"\""},{"line_number":785,"context_line":"        for u in `sudo systemctl list-unit-files | grep devstack | awk \u0027{print $1}\u0027`; do"},{"line_number":786,"context_line":"            name\u003d$(echo $u | sed \u0027s/devstack@/screen-/\u0027 | sed \u0027s/\\.service//\u0027)"},{"line_number":787,"context_line":"            eval $log_since_ts \\"},{"line_number":788,"context_line":"                 -o short-precise --unit $u | sudo tee $BASE/logs/$name.txt \u003e /dev/null"},{"line_number":789,"context_line":"        done"},{"line_number":790,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"ff346bd7_fee451ae","line":787,"updated":"2017-07-25 03:58:30.000000000","message":"why do you have these evals here?\n\ni\u0027d save start_time to a var if we\u0027re using it several times, then just do\n\nsudo journalctl --since\u003d${start_time} ...\n\nin each of these to keep it clear what\u0027s happening","commit_id":"37d0d028d903e492adec8146f5250f838e10b3b7"},{"author":{"_account_id":14624,"name":"Sam Wan","email":"sam.wan@emc.com","username":"samwan"},"change_message_id":"ee67506a2e935086526df140b04a8fe30d525354","unresolved":false,"context_lines":[{"line_number":784,"context_line":"        local name\u003d\"\""},{"line_number":785,"context_line":"        for u in `sudo systemctl list-unit-files | grep devstack | awk \u0027{print $1}\u0027`; do"},{"line_number":786,"context_line":"            name\u003d$(echo $u | sed \u0027s/devstack@/screen-/\u0027 | sed \u0027s/\\.service//\u0027)"},{"line_number":787,"context_line":"            eval $log_since_ts \\"},{"line_number":788,"context_line":"                 -o short-precise --unit $u | sudo tee $BASE/logs/$name.txt \u003e /dev/null"},{"line_number":789,"context_line":"        done"},{"line_number":790,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"ff346bd7_dc44ce1d","line":787,"in_reply_to":"ff346bd7_ac232305","updated":"2017-07-26 01:36:24.000000000","message":"ok, changed for readability","commit_id":"37d0d028d903e492adec8146f5250f838e10b3b7"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"73d51ffa6fbe0cbe489ec9fd434691e472d1f8c8","unresolved":false,"context_lines":[{"line_number":784,"context_line":"        local name\u003d\"\""},{"line_number":785,"context_line":"        for u in `sudo systemctl list-unit-files | grep devstack | awk \u0027{print $1}\u0027`; do"},{"line_number":786,"context_line":"            name\u003d$(echo $u | sed \u0027s/devstack@/screen-/\u0027 | sed \u0027s/\\.service//\u0027)"},{"line_number":787,"context_line":"            eval $log_since_ts \\"},{"line_number":788,"context_line":"                 -o short-precise --unit $u | sudo tee $BASE/logs/$name.txt \u003e /dev/null"},{"line_number":789,"context_line":"        done"},{"line_number":790,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"ff346bd7_ac232305","line":787,"in_reply_to":"ff346bd7_c1f07ecc","updated":"2017-07-25 18:42:46.000000000","message":"I agree with Ian that being a bit more explicit here would be nice for readability. Also avoiding use of eval is always nice.","commit_id":"37d0d028d903e492adec8146f5250f838e10b3b7"},{"author":{"_account_id":14624,"name":"Sam Wan","email":"sam.wan@emc.com","username":"samwan"},"change_message_id":"6c73a43f8cead8a3050683470df011d102295e25","unresolved":false,"context_lines":[{"line_number":784,"context_line":"        local name\u003d\"\""},{"line_number":785,"context_line":"        for u in `sudo systemctl list-unit-files | grep devstack | awk \u0027{print $1}\u0027`; do"},{"line_number":786,"context_line":"            name\u003d$(echo $u | sed \u0027s/devstack@/screen-/\u0027 | sed \u0027s/\\.service//\u0027)"},{"line_number":787,"context_line":"            eval $log_since_ts \\"},{"line_number":788,"context_line":"                 -o short-precise --unit $u | sudo tee $BASE/logs/$name.txt \u003e /dev/null"},{"line_number":789,"context_line":"        done"},{"line_number":790,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"ff346bd7_c1f07ecc","line":787,"in_reply_to":"ff346bd7_fee451ae","updated":"2017-07-25 12:19:15.000000000","message":"well, I just wanted to shorten the line. of course we can use \u0027sudo journalctl --since\u003d$(start_time)\u0027 for each run, it\u0027s just repeated.","commit_id":"37d0d028d903e492adec8146f5250f838e10b3b7"}]}