)]}'
{"devstack-vm-gate-process-env.sh":[{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"0269065e7a2b033f002b38c203385110f15c9326","unresolved":false,"context_lines":[{"line_number":441,"context_line":"fi"},{"line_number":442,"context_line":""},{"line_number":443,"context_line":"# This is in brackets for avoiding inheriting a huge environment variable"},{"line_number":444,"context_line":"(export PROJECTS; export \u003e \"$WORKSPACE/test_env.sh\")"}],"source_content_type":"text/x-sh","patch_set":1,"id":"7f287b81_a235b8f9","line":444,"range":{"start_line":444,"start_character":0,"end_line":444,"end_character":52},"updated":"2017-08-22 19:06:46.000000000","message":"Not sure I understand why we just couldn\u0027t source this file ? Is it used elsewhere and we don\u0027t want to compute the variables more than once ?","commit_id":"1cd90de300a1a8910eb006150a3870903cbfdd21"}],"devstack-vm-gate-wrap.sh":[{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"0269065e7a2b033f002b38c203385110f15c9326","unresolved":false,"context_lines":[{"line_number":23,"context_line":"# easily redirect their stdout / stderr to log files."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"$WORKSPACE/devstack-gate/devstack-vm-gate-process-env.sh"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"source $WORKSPACE/test_env.sh"},{"line_number":29,"context_line":"source $WORKSPACE/devstack-gate/functions.sh"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"start_timer"}],"source_content_type":"text/x-sh","patch_set":1,"id":"7f287b81_8521a6a2","line":28,"range":{"start_line":26,"start_character":0,"end_line":28,"end_character":29},"updated":"2017-08-22 19:06:46.000000000","message":"We have no visibility in what\u0027s happening in there -- would it be worthwhile to add a \"set -x\" ?","commit_id":"1cd90de300a1a8910eb006150a3870903cbfdd21"},{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"0269065e7a2b033f002b38c203385110f15c9326","unresolved":false,"context_lines":[{"line_number":26,"context_line":"$WORKSPACE/devstack-gate/devstack-vm-gate-process-env.sh"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"source $WORKSPACE/test_env.sh"},{"line_number":29,"context_line":"source $WORKSPACE/devstack-gate/functions.sh"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"start_timer"},{"line_number":32,"context_line":"enable_netconsole"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"if ! function_exists \"gate_hook\"; then"}],"source_content_type":"text/x-sh","patch_set":1,"id":"7f287b81_826cfc08","line":31,"range":{"start_line":29,"start_character":0,"end_line":31,"end_character":11},"updated":"2017-08-22 19:06:46.000000000","message":"Should move this at the top before sourcing the env variables.","commit_id":"1cd90de300a1a8910eb006150a3870903cbfdd21"},{"author":{"_account_id":6589,"name":"Jesse Keating","email":"jkeating@j2solutions.net","username":"jesse-keating"},"change_message_id":"605259f6b1f7f8bbda5497f83ad9832693059e83","unresolved":false,"context_lines":[{"line_number":49,"context_line":"# We\u0027re using enough ansible specific features that it\u0027s extremely"},{"line_number":50,"context_line":"# possible that new ansible releases can break us. As such we should"},{"line_number":51,"context_line":"# be very deliberate about which ansible we use."},{"line_number":52,"context_line":"ANSIBLE_VERSION\u003d${ANSIBLE_VERSION:-2.2.0.0}"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"# Install ansible"},{"line_number":55,"context_line":"sudo -H pip install virtualenv"}],"source_content_type":"text/x-sh","patch_set":1,"id":"7f287b81_5e222ca6","line":52,"updated":"2017-08-24 18:47:37.000000000","message":"Seems like an unrelated change.","commit_id":"1cd90de300a1a8910eb006150a3870903cbfdd21"}]}