)]}'
{"roles/fetch-devstack-log-dir/defaults/main.yaml":[{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"54299996d8c58bf3af79f9c86c397fb45b98744b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"devstack_base_dir: /opt/stack"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7f287b81_d918a8d4","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":29},"updated":"2017-08-23 12:22:13.000000000","message":"Technically, this isn\u0027t necessary as variables defined in one role are available to other roles. Since you\u0027ve defined this in the setup-devstack-log-dir role, you can omit this.","commit_id":"7df0cd97913f623e4e12c0df259c73e0443c3527"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"d335c19c087f56f74677f4d3a20fd2bd47ffc9c9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"devstack_base_dir: /opt/stack"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7f287b81_2347714e","line":1,"updated":"2017-08-23 14:54:22.000000000","message":"Thanks, I wasn\u0027t sure about that, but now that I do understand, I think I want to continue with being explicit about role variables for now.  I anticipate that these roles may shuffle around a lot, and possibly be combined, and doing so will make that easier.","commit_id":"7df0cd97913f623e4e12c0df259c73e0443c3527"}],"roles/fetch-devstack-log-dir/tasks/main.yaml":[{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"679d5ad5148ec2c0a7747ad5d4cab8c604b1e084","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- name: Create logs directory"},{"line_number":2,"context_line":"  file: path\u003d{{ devstack_base_dir }}/logs state\u003ddirectory"},{"line_number":3,"context_line":"  become: yes"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"- name: Collect devstack logs"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7f287b81_b9884a71","line":2,"range":{"start_line":2,"start_character":8,"end_line":2,"end_character":57},"updated":"2017-08-23 00:29:56.000000000","message":"Can we use consistent syntax across our roles ?\n\nSometimes this format is used:\n\n    - name: Create logs directory\n      file: path\u003d{{ devstack_base_dir }}/logs state\u003ddirectory\n      become: yes\n\nother times this format:\n\n    - name: Create logs directory\n      file:\n        path: \"{{ devstack_base_dir }}/logs\"\n        state: directory\n      become: yes\n\nBoth work but I have a personal preference for the second format but it\u0027s probably something we should agree on.","commit_id":"7df0cd97913f623e4e12c0df259c73e0443c3527"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"d335c19c087f56f74677f4d3a20fd2bd47ffc9c9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- name: Create logs directory"},{"line_number":2,"context_line":"  file: path\u003d{{ devstack_base_dir }}/logs state\u003ddirectory"},{"line_number":3,"context_line":"  become: yes"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"- name: Collect devstack logs"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7f287b81_0376b5a5","line":2,"updated":"2017-08-23 14:54:22.000000000","message":"I like the second format too, so I\u0027m happy to shift in that direction.","commit_id":"7df0cd97913f623e4e12c0df259c73e0443c3527"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"d335c19c087f56f74677f4d3a20fd2bd47ffc9c9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- name: Create logs directory"},{"line_number":2,"context_line":"  file: path\u003d{{ devstack_base_dir }}/logs state\u003ddirectory"},{"line_number":3,"context_line":"  become: yes"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"- name: Collect devstack logs"},{"line_number":6,"context_line":"  synchronize:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7f287b81_e37a8986","line":3,"updated":"2017-08-23 14:54:22.000000000","message":"Excellent point.","commit_id":"7df0cd97913f623e4e12c0df259c73e0443c3527"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"27605c6abdfcadd48a7a5a492a8549e7017ba8ed","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- name: Create logs directory"},{"line_number":2,"context_line":"  file: path\u003d{{ devstack_base_dir }}/logs state\u003ddirectory"},{"line_number":3,"context_line":"  become: yes"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"- name: Collect devstack logs"},{"line_number":6,"context_line":"  synchronize:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7f287b81_67e46cad","line":3,"range":{"start_line":1,"start_character":0,"end_line":3,"end_character":13},"updated":"2017-08-23 12:06:20.000000000","message":"This is not necessary as this work is done in the setup-devstack-log-dir role.","commit_id":"7df0cd97913f623e4e12c0df259c73e0443c3527"}]}