)]}'
{"playbooks/roles/fix_disk_layout/tasks/main.yaml":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"97b8d6dc468099afdccb3e86d098ab8cafa7b864","unresolved":false,"context_lines":[{"line_number":46,"context_line":"            # all devices fails on the RAX configdrive, which is a raw"},{"line_number":47,"context_line":"            # iso9660 partition; hence keep the ${DEV} here for now"},{"line_number":48,"context_line":"            partprobe ${DEV}"},{"line_number":49,"context_line":"            # The device might not show up immediately, retry for a while"},{"line_number":50,"context_line":"            retries\u003d0"},{"line_number":51,"context_line":"            while [ ! -b ${DEV}1 ]; do"},{"line_number":52,"context_line":"              if [ \"$retries\" -gt \"5\" ]; then"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7f287b81_a47f4864","line":49,"updated":"2017-08-30 03:59:34.000000000","message":"One thing that we\u0027ve had in dib, and I\u0027ve never been sure if it actually helps or not, is a \"udevadm settle\".  I\u0027d really like to figure that out for real if we can.\n\nSo I started pulling apart \"kpartx -s\" code ... and that goes deep.  It passes through cookies to the kernel that then get checked by udev libraries (see dmsetup udevcreatecookie) and has semaphores, etc\n\nBut ... based on a preliminary understanding of that, I think it might be the right thing to do.\n\nWhat I\u0027d like to determine is if it\u0027s just a proxy for a sleep().  I think we could do that here by logging \"udevadm settle --timeout\u003d0\" which it says checks if the queue is empty?\n\nIf we see the queue is *not* empty (and we haven\u0027t seen the device), then I think we have a red flag that we really are racing udev here.  In that case, probably a \"udevadm settle --exit-if-exists ${DEV}\" is the correct thing to do.\n\nIf the queue is empty, and we can\u0027t see the device anyway, well then I\u0027m about out of ideas (for now :)","commit_id":"3b7613ea7eec9561875d43f526769b30e2908d71"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"660e1f5287e9ba03fcb75b6b077c73a2d3cd3e59","unresolved":false,"context_lines":[{"line_number":46,"context_line":"            # all devices fails on the RAX configdrive, which is a raw"},{"line_number":47,"context_line":"            # iso9660 partition; hence keep the ${DEV} here for now"},{"line_number":48,"context_line":"            partprobe ${DEV}"},{"line_number":49,"context_line":"            # The device might not show up immediately, retry for a while"},{"line_number":50,"context_line":"            retries\u003d0"},{"line_number":51,"context_line":"            while [ ! -b ${DEV}1 ]; do"},{"line_number":52,"context_line":"              if [ \"$retries\" -gt \"5\" ]; then"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7f287b81_95158d42","line":49,"in_reply_to":"7f287b81_a47f4864","updated":"2017-08-30 14:45:42.000000000","message":"Slight nit, should be --exit-if-exists ${DEV}1 as $DEV already exists and was partitioned.","commit_id":"3b7613ea7eec9561875d43f526769b30e2908d71"},{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"3fbd46b456e3c3b49bd99767c321137fe22e5df0","unresolved":false,"context_lines":[{"line_number":46,"context_line":"            # all devices fails on the RAX configdrive, which is a raw"},{"line_number":47,"context_line":"            # iso9660 partition; hence keep the ${DEV} here for now"},{"line_number":48,"context_line":"            partprobe ${DEV}"},{"line_number":49,"context_line":"            # The device might not show up immediately, retry for a while"},{"line_number":50,"context_line":"            retries\u003d0"},{"line_number":51,"context_line":"            while [ ! -b ${DEV}1 ]; do"},{"line_number":52,"context_line":"              if [ \"$retries\" -gt \"5\" ]; then"},{"line_number":53,"context_line":"                echo \"${DEV}1 is still missing. Giving up.\""},{"line_number":54,"context_line":"                exit 1"},{"line_number":55,"context_line":"              fi"},{"line_number":56,"context_line":"              retries\u003d$((retries+1))"},{"line_number":57,"context_line":"              echo \"${DEV}1 is missing, retrying...\""},{"line_number":58,"context_line":"              sleep 2"},{"line_number":59,"context_line":"            done"},{"line_number":60,"context_line":"            mkswap ${DEV}1"},{"line_number":61,"context_line":"            mkfs.ext4 ${DEV}2"},{"line_number":62,"context_line":"            swapon ${DEV}1"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7f287b81_248b5868","line":59,"range":{"start_line":49,"start_character":0,"end_line":59,"end_character":16},"updated":"2017-08-30 03:58:33.000000000","message":"Attempt #1:\n- 4 jobs landed on RAX\n- 6 nodes\n- 6 retries (6 success)\n\n- http://logs.openstack.org/07/499007/1/check/gate-grenade-dsvm-neutron-multinode-ubuntu-xenial/a8850c0/logs/ara/result/20552c3f-4d22-4b92-a5ca-09987ac5e4ea/\n- http://logs.openstack.org/07/499007/1/check/gate-grenade-dsvm-neutron-multinode-ubuntu-xenial/a8850c0/logs/ara/result/4e3d1efb-e886-4f3b-9213-8ce3026dd58c/\n- http://logs.openstack.org/07/499007/1/check/gate-grenade-dsvm-neutron-dvr-multinode-ubuntu-xenial-nv/94f2d49/logs/ara/result/2f0247b0-35f3-43f5-9461-84e4e78dc78a/\n- http://logs.openstack.org/07/499007/1/check/gate-grenade-dsvm-neutron-dvr-multinode-ubuntu-xenial-nv/94f2d49/logs/ara/result/b8c181c0-6995-4558-8d5a-1c2c715212b6/\n- http://logs.openstack.org/07/499007/1/check/gate-neutron-dsvm-functional-ubuntu-xenial-nv/691174c/logs/ara/result/15c27ce0-6aaa-44b1-8b60-d131472899e1/\n- http://logs.openstack.org/07/499007/1/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial-ocata-nv/8f52eeb/logs/ara/result/810ac1e7-e7c6-4c48-a56e-0199a274da4e/","commit_id":"3b7613ea7eec9561875d43f526769b30e2908d71"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"769a0575a687be572b1c2ec4da41643f23b48fb9","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    sed -i \u0027/vm.swappiness/d\u0027 /etc/sysctl.conf"},{"line_number":100,"context_line":"    # This sets swappiness low; we really don\u0027t want to be relying on"},{"line_number":101,"context_line":"    # cloud I/O based swap during our runs"},{"line_number":102,"context_line":"    sysctl -w vm.swappiness\u003d30"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7f287b81_4971c975","line":102,"updated":"2017-08-30 18:48:56.000000000","message":"As a followup  - should we actually write this to a sysctl file instead of just doing it here? v3 should actually allow us to reboot nodes during tests, and we\u0027d lose this setting if anyone did that.","commit_id":"e21308a4cf6920f2431bc5b77819b073490f957d"},{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"7eef40f83b80a9e69339c0837e62b9e0196a3725","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    sed -i \u0027/vm.swappiness/d\u0027 /etc/sysctl.conf"},{"line_number":100,"context_line":"    # This sets swappiness low; we really don\u0027t want to be relying on"},{"line_number":101,"context_line":"    # cloud I/O based swap during our runs"},{"line_number":102,"context_line":"    sysctl -w vm.swappiness\u003d30"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7f287b81_6927e5cb","line":102,"in_reply_to":"7f287b81_4971c975","updated":"2017-08-30 19:16:54.000000000","message":"Yes, this will be free when ansibilizing the script because ansible\u0027s sysctl persists the changes.","commit_id":"e21308a4cf6920f2431bc5b77819b073490f957d"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"ad3d3ef9373da52a22857bdd8a131c72824fcec0","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"            # The device partitions might not show up immediately, make sure"},{"line_number":46,"context_line":"            # they are ready and available for use"},{"line_number":47,"context_line":"            udevadm settle --timeout\u003d0 || echo \"Block device not ready yet. Waiting for up to 10 seconds for it to be ready\""},{"line_number":48,"context_line":"            udevadm settle --timeout\u003d10 --exit-if-exists\u003d${DEV}1"},{"line_number":49,"context_line":"            udevadm settle --timeout\u003d10 --exit-if-exists\u003d${DEV}2"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7f287b81_647f0766","line":47,"updated":"2017-08-30 21:10:28.000000000","message":"if we see this appearing in logstash, then i think that indicates that we\u0027ve done the right thing here.","commit_id":"1d80845e5e95286182aedf50988e0de4de00b50d"},{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"f3595b9b04721d96a4b4852ec3f3a5a68ddec29a","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"            # The device partitions might not show up immediately, make sure"},{"line_number":46,"context_line":"            # they are ready and available for use"},{"line_number":47,"context_line":"            udevadm settle --timeout\u003d0 || echo \"Block device not ready yet. Waiting for up to 10 seconds for it to be ready\""},{"line_number":48,"context_line":"            udevadm settle --timeout\u003d10 --exit-if-exists\u003d${DEV}1"},{"line_number":49,"context_line":"            udevadm settle --timeout\u003d10 --exit-if-exists\u003d${DEV}2"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7f287b81_55cef762","line":47,"in_reply_to":"7f287b81_647f0766","updated":"2017-08-30 23:41:35.000000000","message":"10 jobs on RAX\n15 nodes spanning CentOS, Ubuntu and OpenSUSE\n\nhttp://logstash.openstack.org/#dashboard/file/logstash.json?query\u003dmessage%3A%5C%22Block%20device%20not%20ready%20yet.%20Waiting%20for%20up%20to%2010%20seconds%20for%20it%20to%20be%20ready%5C%22%20AND%20build_change%3A%5C%22499314%5C%22\n\n- http://logs.openstack.org/07/499007/6/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/41f8378/logs/ara/result/0112e6e8-ca37-4578-ba0a-c2c0e86e1cd4/\n- http://logs.openstack.org/07/499007/6/check/gate-grenade-dsvm-neutron-ubuntu-xenial/baed3a2/logs/ara/result/583dec9f-4570-4677-8bbc-9f1e495ca73e/\n- http://logs.openstack.org/07/499007/6/check/gate-grenade-dsvm-neutron-multinode-ubuntu-xenial/6c4a4f3/logs/ara/result/63b83f13-029c-4f1d-b492-688182fcb93f/\n- http://logs.openstack.org/07/499007/6/check/gate-grenade-dsvm-neutron-multinode-ubuntu-xenial/6c4a4f3/logs/ara/result/ae1193be-23b5-4d5c-8f33-dc3c41c51b8b/\n- http://logs.openstack.org/07/499007/6/check/gate-grenade-dsvm-neutron-dvr-multinode-ubuntu-xenial-nv/383c153/logs/ara/result/98bb050f-3f5b-4a99-8774-7ba50bd7d6f7/\n- http://logs.openstack.org/07/499007/6/check/gate-grenade-dsvm-neutron-dvr-multinode-ubuntu-xenial-nv/383c153/logs/ara/result/e7435379-7027-4a2c-bad4-bfb4d9f63ac8/\n- http://logs.openstack.org/07/499007/6/check/gate-swift-dsvm-functional-ubuntu-xenial-nv/50271b0/logs/ara/result/2ace2df0-cd10-4108-8dcb-b79a7d85ffa8/\n- http://logs.openstack.org/07/499007/6/check/gate-tempest-dsvm-neutron-full-centos-7-nv/66a43ac/logs/ara/result/c55d8e92-71c6-407b-b549-d7354bd89f30/\n- http://logs.openstack.org/07/499007/6/check/gate-tempest-dsvm-multinode-full-ubuntu-xenial-nv/1924024/logs/ara/result/ab06c18b-00e7-4b23-a4c5-db93aed6b949/\n- http://logs.openstack.org/07/499007/6/check/gate-tempest-dsvm-multinode-full-ubuntu-xenial-nv/1924024/logs/ara/result/4d456bdc-b1f1-4a50-8041-588edd08c12c/\n- http://logs.openstack.org/07/499007/6/check/gate-tempest-dsvm-neutron-multinode-full-ubuntu-xenial-nv/eda8784/logs/ara/result/8d5c69a2-42be-481a-89c4-a5c4ceee0f14/\n- http://logs.openstack.org/07/499007/6/check/gate-tempest-dsvm-neutron-multinode-full-ubuntu-xenial-nv/eda8784/logs/ara/result/94619b02-124b-4ce3-9493-76d468cea684/\n- http://logs.openstack.org/07/499007/6/check/gate-tempest-dsvm-neutron-full-opensuse-423-nv/dc56bd9/logs/ara/result/ff76283a-955d-4b7a-a737-ad0f888994fe/\n- http://logs.openstack.org/07/499007/6/check/gate-tripleo-ci-centos-7-containers-multinode-nv/438bb17/logs/ara/result/a5fac4c5-d159-4f7d-ab43-42f540375adf/\n- http://logs.openstack.org/07/499007/6/check/gate-tripleo-ci-centos-7-containers-multinode-nv/438bb17/logs/ara/result/ac3faf7f-34fa-463d-8625-d3f95319f748/","commit_id":"1d80845e5e95286182aedf50988e0de4de00b50d"}]}