)]}'
{".zuul.yaml":[{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"7a3464321c3b6d6f83186b6a26ea7b6c7d19496a","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    timeout: 7200"},{"line_number":61,"context_line":"    vars:"},{"line_number":62,"context_line":"      devstack_services:"},{"line_number":63,"context_line":"        horizon: False"},{"line_number":64,"context_line":"        tempest: True"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"- job:"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"7f515b1d_20c64f69","line":63,"updated":"2017-09-23 14:01:01.000000000","message":"You don\u0027t have to copy horizon: False here. vars dicts are merged - so you can just set the thing you care about. #notaminusone","commit_id":"3e61a1b7084aa43a842369559ef6c6315404ee48"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"72c77e5ddeaca32a20e927204909ed0e8fd8397f","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    timeout: 7200"},{"line_number":61,"context_line":"    vars:"},{"line_number":62,"context_line":"      devstack_services:"},{"line_number":63,"context_line":"        horizon: False"},{"line_number":64,"context_line":"        tempest: True"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"- job:"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"7f515b1d_3b07a41f","line":63,"in_reply_to":"7f515b1d_20c64f69","updated":"2017-09-23 19:14:17.000000000","message":"Nice - good to know :)","commit_id":"3e61a1b7084aa43a842369559ef6c6315404ee48"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"4bf3c72d20d56faddc1a68d4a2da1c19a63d370d","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    name: openstack-infra/devstack-gate"},{"line_number":81,"context_line":"    check:"},{"line_number":82,"context_line":"      jobs:"},{"line_number":83,"context_line":"        - devstack-tempest:"},{"line_number":84,"context_line":"            files:"},{"line_number":85,"context_line":"              - ^playbooks/pre"},{"line_number":86,"context_line":"              - ^playbooks/post"},{"line_number":87,"context_line":"              - ^playbooks/devstack"},{"line_number":88,"context_line":"              - ^roles/"},{"line_number":89,"context_line":"        - devstack:"},{"line_number":90,"context_line":"            files:"},{"line_number":91,"context_line":"              - ^playbooks/pre"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"7f515b1d_16327df2","line":88,"range":{"start_line":83,"start_character":0,"end_line":88,"end_character":23},"updated":"2017-09-23 19:24:55.000000000","message":"Do we actually need both devstack-tempest and devstack, or would be it ok to run devstack-tempest for all changes here? I think it would make sense since devstack-tempest runs devstack as well, and we want to make we don\u0027t break tempest run by altering devstack roles.","commit_id":"3e61a1b7084aa43a842369559ef6c6315404ee48"}],"roles/acl-devstack-files/tasks/main.yaml":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"51b3072710130fb772b8bb63aac623c144990d1d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- name: Grant global read access to devstack files"},{"line_number":2,"context_line":"  file:"},{"line_number":3,"context_line":"    path: \"{{devstack_data_dir}}/files\""},{"line_number":4,"context_line":"    mode: \"o+rx\""},{"line_number":5,"context_line":"    recurse: yes"},{"line_number":6,"context_line":"  become: yes"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"7f515b1d_c0ff7b65","line":3,"updated":"2017-09-23 14:30:36.000000000","message":"Given that this probably isn\u0027t working right now, are we sure this role is necessary?  I would think that this dir should already be world-readable.","commit_id":"3e61a1b7084aa43a842369559ef6c6315404ee48"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"7a3464321c3b6d6f83186b6a26ea7b6c7d19496a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- name: Grant global read access to devstack files"},{"line_number":2,"context_line":"  file:"},{"line_number":3,"context_line":"    path: \"{{devstack_data_dir}}/files\""},{"line_number":4,"context_line":"    mode: \"o+rx\""},{"line_number":5,"context_line":"    recurse: yes"},{"line_number":6,"context_line":"  become: yes"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"7f515b1d_8094e345","line":3,"updated":"2017-09-23 14:01:01.000000000","message":"I think you mean devstack_base_dir","commit_id":"3e61a1b7084aa43a842369559ef6c6315404ee48"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"72c77e5ddeaca32a20e927204909ed0e8fd8397f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- name: Grant global read access to devstack files"},{"line_number":2,"context_line":"  file:"},{"line_number":3,"context_line":"    path: \"{{devstack_data_dir}}/files\""},{"line_number":4,"context_line":"    mode: \"o+rx\""},{"line_number":5,"context_line":"    recurse: yes"},{"line_number":6,"context_line":"  become: yes"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"7f515b1d_b6084928","line":3,"in_reply_to":"7f515b1d_8094e345","updated":"2017-09-23 19:14:17.000000000","message":"I actually meant data_dir, since the idea is to make sure the tempest user can access things under /opt/stack/data. The default for this role is wrong though.","commit_id":"3e61a1b7084aa43a842369559ef6c6315404ee48"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"72c77e5ddeaca32a20e927204909ed0e8fd8397f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- name: Grant global read access to devstack files"},{"line_number":2,"context_line":"  file:"},{"line_number":3,"context_line":"    path: \"{{devstack_data_dir}}/files\""},{"line_number":4,"context_line":"    mode: \"o+rx\""},{"line_number":5,"context_line":"    recurse: yes"},{"line_number":6,"context_line":"  become: yes"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"7f515b1d_560fd52d","line":3,"in_reply_to":"7f515b1d_c0ff7b65","updated":"2017-09-23 19:14:17.000000000","message":"This seem to be working now, looking at ARA it\u0027s working on the right folder: http://logs.openstack.org/46/504246/20/check/devstack-tempest/a1ed616/ara/result/b474705b-457b-43fb-93be-3cb1883a85c9/ \n\nI\u0027m not sure if this is strictly needed - but since Tempest needs files from there, I think it makes the tempest role more self contained if we keep it.","commit_id":"3e61a1b7084aa43a842369559ef6c6315404ee48"}]}
