)]}'
{"id":"openstack%2Fdevstack-gate~509885","triplet_id":"openstack%2Fdevstack-gate~master~If33d7aea9142e650b57c0f58c14e2a4434e30bf0","project":"openstack/devstack-gate","branch":"master","topic":"equivalence","hashtags":[],"change_id":"If33d7aea9142e650b57c0f58c14e2a4434e30bf0","subject":"Use \u003d for string comparisons","status":"MERGED","created":"2017-10-05 19:36:42.000000000","updated":"2017-11-29 03:34:07.000000000","submitted":"2017-11-29 03:34:07.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"509885-1511926447005-75eacdef","meta_rev_id":"bce03f6d8d352b669b13bccff5b48fb1e26ca51a","_number":509885,"virtual_id_number":509885,"owner":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2017-10-05 22:42:55.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},{"value":2,"date":"2017-11-29 03:34:06.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"date":"2017-10-27 17:18:19.000000000","_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"recommended":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2017-10-12 02:31:32.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2017-11-21 04:23:01.000000000","_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},{"value":2,"date":"2017-10-27 05:13:56.000000000","_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},{"value":1,"date":"2017-11-29 01:56:27.000000000","_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-10-05 22:42:55.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2017-10-12 02:31:32.000000000","updated_by":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"reviewer":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"state":"REVIEWER"},{"updated":"2017-11-21 04:23:01.000000000","updated_by":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"reviewer":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"state":"REVIEWER"},{"updated":"2017-11-29 01:56:27.000000000","updated_by":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"reviewer":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"state":"REVIEWER"},{"updated":"2017-11-29 03:34:06.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"da6e039ec758e56cc607c621d6f78800ff1d8a26","author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"date":"2017-10-05 19:36:42.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3c6fe34cb517b891cb301dd94e60bf824c2f5337","author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"date":"2017-10-05 19:38:02.000000000","message":"Topic changed from zuulv3-jobs to equivalence","accounts_in_message":[],"_revision_number":1},{"id":"b0ab6ff35b03eb9daa36413ebddcb6f62d852408","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-10-05 22:42:55.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-tempest-dsvm-neutron-full-ubuntu-xenial http://logs.openstack.org/85/509885/1/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/5b78c53/ : SUCCESS in 1h 20m 54s\n- gate-grenade-dsvm-neutron-ubuntu-xenial http://logs.openstack.org/85/509885/1/check/gate-grenade-dsvm-neutron-ubuntu-xenial/3c109f2/ : SUCCESS in 1h 07m 13s\n- gate-tempest-dsvm-py35-ubuntu-xenial http://logs.openstack.org/85/509885/1/check/gate-tempest-dsvm-py35-ubuntu-xenial/16ed4f5/ : SUCCESS in 1h 18m 06s\n- gate-devstack-gate-tox-run-tests-ubuntu-xenial http://logs.openstack.org/85/509885/1/check/gate-devstack-gate-tox-run-tests-ubuntu-xenial/89b60ae/ : SUCCESS in 4m 06s\n- gate-devstack-gate-tox-py3-run-tests-ubuntu-xenial http://logs.openstack.org/85/509885/1/check/gate-devstack-gate-tox-py3-run-tests-ubuntu-xenial/8f6dfe0/ : SUCCESS in 3m 09s\n- gate-devstack-gate-bashate http://logs.openstack.org/85/509885/1/check/gate-devstack-gate-bashate/0d2f230/ : SUCCESS in 2m 46s\n- gate-dg-hooks-dsvm http://logs.openstack.org/85/509885/1/check/gate-dg-hooks-dsvm/ea03973/ : SUCCESS in 11m 02s\n- gate-grenade-dsvm-neutron-multinode-ubuntu-xenial http://logs.openstack.org/85/509885/1/check/gate-grenade-dsvm-neutron-multinode-ubuntu-xenial/d19b105/ : SUCCESS in 1h 03m 20s\n- gate-grenade-dsvm-neutron-dvr-multinode-ubuntu-xenial-nv http://logs.openstack.org/85/509885/1/check/gate-grenade-dsvm-neutron-dvr-multinode-ubuntu-xenial-nv/6ff846e/ : SUCCESS in 1h 09m 45s (non-voting)\n- gate-neutron-dsvm-functional-ubuntu-xenial-nv http://logs.openstack.org/85/509885/1/check/gate-neutron-dsvm-functional-ubuntu-xenial-nv/da48f4d/ : SUCCESS in 31m 42s (non-voting)\n- gate-neutron-dsvm-api-ubuntu-xenial-nv http://logs.openstack.org/85/509885/1/check/gate-neutron-dsvm-api-ubuntu-xenial-nv/335b84d/ : SUCCESS in 47m 29s (non-voting)\n- gate-swift-dsvm-functional-ubuntu-xenial-nv http://logs.openstack.org/85/509885/1/check/gate-swift-dsvm-functional-ubuntu-xenial-nv/e9ff484/ : SUCCESS in 27m 48s (non-voting)\n- gate-tempest-dsvm-neutron-full-ubuntu-xenial-newton-nv http://logs.openstack.org/85/509885/1/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial-newton-nv/dd0ec07/ : SUCCESS in 1h 30m 49s (non-voting)\n- gate-tempest-dsvm-neutron-full-ubuntu-xenial-ocata-nv http://logs.openstack.org/85/509885/1/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial-ocata-nv/c930217/ : FAILURE in 1h 22m 31s (non-voting)\n- gate-tempest-dsvm-neutron-full-ubuntu-xenial-pike-nv http://logs.openstack.org/85/509885/1/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial-pike-nv/7074cd8/ : SUCCESS in 1h 47m 36s (non-voting)\n- gate-tempest-dsvm-neutron-full-centos-7-nv http://logs.openstack.org/85/509885/1/check/gate-tempest-dsvm-neutron-full-centos-7-nv/f526f10/ : SUCCESS in 1h 28m 43s (non-voting)\n- gate-tempest-dsvm-multinode-full-ubuntu-xenial-nv http://logs.openstack.org/85/509885/1/check/gate-tempest-dsvm-multinode-full-ubuntu-xenial-nv/f259505/ : SUCCESS in 1h 35m 45s (non-voting)\n- gate-tempest-dsvm-neutron-multinode-full-ubuntu-xenial-nv http://logs.openstack.org/85/509885/1/check/gate-tempest-dsvm-neutron-multinode-full-ubuntu-xenial-nv/3506da3/ : FAILURE in 1h 32m 07s (non-voting)\n- gate-tempest-dsvm-neutron-full-opensuse-423-nv http://logs.openstack.org/85/509885/1/check/gate-tempest-dsvm-neutron-full-opensuse-423-nv/ea0755c/ : FAILURE in 1h 15m 31s (non-voting)\n- gate-tripleo-ci-centos-7-containers-multinode-nv http://logs.openstack.org/85/509885/1/check/gate-tripleo-ci-centos-7-containers-multinode-nv/dfd0bd3/ : SUCCESS in 1h 53m 26s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"7dad9aedd9815525cb7d23bc7f436c620d1f0ffa","author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"date":"2017-10-12 02:31:32.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"75f8b1c0942cbfe5bb0622a11351a27a13c222a2","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2017-10-27 05:13:56.000000000","message":"Patch Set 1: Code-Review+2\n\nwell if you\u0027re using [[ you\u0027re not posix, and \"\u003d\u003d\" works anywhere under bash so i prefer it because \u003d is so ambiguous","accounts_in_message":[],"_revision_number":1},{"id":"5e0f60698a1f0783b42b1f39e8df425c04e6cb46","author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"date":"2017-10-27 17:18:19.000000000","message":"Patch Set 1:\n\nI\u0027m fine changing it to \u003d\u003d since this is [[]] instead of just [] (which under some shells could end up using the /bin/[ symlink to /bin/test or what have you), but regardless -eq is entirely incorrect in this context.","accounts_in_message":[],"_revision_number":1},{"id":"f40a71d38aa40437f7f5c1da71176a01983c632b","author":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"date":"2017-11-21 04:23:01.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"b23bd678c6d1e2550db0603808ee0815e6af866a","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2017-11-29 01:56:27.000000000","message":"Patch Set 1: Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"020b12b1d20377a6c87c038393cdcab81b062243","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-11-29 01:56:52.000000000","message":"Patch Set 1:\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"e49babed5274c4d14efa154f98c9b3bbd2747c3b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-11-29 03:34:06.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- legacy-tempest-dsvm-py35 http://logs.openstack.org/85/509885/1/gate/legacy-tempest-dsvm-py35/74c0f39/ : SUCCESS in 1h 22m 07s\n- legacy-devstack-gate-tox-run-tests http://logs.openstack.org/85/509885/1/gate/legacy-devstack-gate-tox-run-tests/0e620f3/ : SUCCESS in 5m 04s\n- legacy-devstack-gate-tox-py3-run-tests http://logs.openstack.org/85/509885/1/gate/legacy-devstack-gate-tox-py3-run-tests/717120c/ : SUCCESS in 2m 58s\n- legacy-grenade-dsvm-neutron http://logs.openstack.org/85/509885/1/gate/legacy-grenade-dsvm-neutron/3064bc1/ : SUCCESS in 51m 56s\n- legacy-grenade-dsvm-neutron-multinode http://logs.openstack.org/85/509885/1/gate/legacy-grenade-dsvm-neutron-multinode/031055e/ : SUCCESS in 1h 00m 18s\n- legacy-tempest-dsvm-neutron-full http://logs.openstack.org/85/509885/1/gate/legacy-tempest-dsvm-neutron-full/5dad1fb/ : SUCCESS in 1h 30m 31s","accounts_in_message":[],"_revision_number":1},{"id":"bce03f6d8d352b669b13bccff5b48fb1e26ca51a","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-11-29 03:34:07.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"9d7be09fa9fcf3960c79faac30aaa2b0707c6007","revisions":{"9d7be09fa9fcf3960c79faac30aaa2b0707c6007":{"kind":"REWORK","_number":1,"created":"2017-10-05 19:36:42.000000000","uploader":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"ref":"refs/changes/85/509885/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack-gate","ref":"refs/changes/85/509885/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack-gate refs/changes/85/509885/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack-gate refs/changes/85/509885/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack-gate refs/changes/85/509885/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack-gate refs/changes/85/509885/1"}}},"commit":{"parents":[{"commit":"e473fdec13445191d1acf1c77d19c87bbda512c8","subject":"Work around cffi install error","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-gate/commit/e473fdec13445191d1acf1c77d19c87bbda512c8"}]}],"author":{"name":"Jeremy Stanley","email":"fungi@yuggoth.org","date":"2017-10-05 19:32:31.000000000","tz":0},"committer":{"name":"Jeremy Stanley","email":"fungi@yuggoth.org","date":"2017-10-05 19:32:31.000000000","tz":0},"subject":"Use \u003d for string comparisons","message":"Use \u003d for string comparisons\n\nChange I384e4c376076051e7a4a8b2d704107cbe3ac08ad introduced\ncomparisons of $DEVSTACK_PROJECT_FROM_GIT against a couple of\nhardcoded string values in a bash [[ ]] expression, but incorrectly\nused the -eq integer comparison operator. This seems to work under\nnormal circumstances, but actually breaks if the string value of the\nvariable contains a \".\" since the equivalence test tries to fail\nearly if it detects what it thinks is a float value (because it\u0027s\nintended only for integers). Instead of -eq use \u003d for string\ncomparisons here, because that\u0027s what the POSIX test(1) utility\nmandates.\n\nChange-Id: If33d7aea9142e650b57c0f58c14e2a4434e30bf0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-gate/commit/9d7be09fa9fcf3960c79faac30aaa2b0707c6007"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-gate/commit/9d7be09fa9fcf3960c79faac30aaa2b0707c6007"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}