)]}'
{"functions.sh":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"5e179193e2238c0017df47008666f2a9668a5c92","unresolved":false,"context_lines":[{"line_number":442,"context_line":"    # Use hardlinks to save space."},{"line_number":443,"context_line":"    # Protect with if [ -d $cache_dir ] in case there are 3rd parties using"},{"line_number":444,"context_line":"    # devstack-gate without cache dirs"},{"line_number":445,"context_line":"    if [ -d $cache_dir ]; then"},{"line_number":446,"context_line":"        find $cache_dir -mindepth 1 -maxdepth 1 -exec cp -l {} $DEST/devstack/files/ \\;"},{"line_number":447,"context_line":"    fi"},{"line_number":448,"context_line":""}],"source_content_type":"text/x-sh","patch_set":3,"id":"5f4e5783_820f30e0","line":445,"updated":"2017-10-11 19:20:27.000000000","message":"Chown should go in this block to make sure dir exists.","commit_id":"b2b864f6ea00fc8e301fc337473a38f8f2c63105"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"4559c860311ee7e7437b0bd6c6b5263bab17dddf","unresolved":false,"context_lines":[{"line_number":443,"context_line":"        # in the cache dir."},{"line_number":444,"context_line":"        sudo chown -R $USER:$USER $cache_dir"},{"line_number":445,"context_line":""},{"line_number":446,"context_line":"        find $cache_dir -mindepth 1 -maxdepth 1 -exec cp -l {} $DEST/devstack/files/ \\;"},{"line_number":447,"context_line":"    fi"},{"line_number":448,"context_line":""},{"line_number":449,"context_line":"    # Disable detailed logging as we return to the main script"}],"source_content_type":"text/x-sh","patch_set":4,"id":"5f4e5783_9984460e","line":446,"updated":"2017-10-11 20:51:10.000000000","message":"Wait ... what\u0027s the guarantee that $DEST is now the same file system as $cache_dir (i.e., /opt)?\n\nShades of yesterday\u0027s zuul cloner bug Ic5fdc899d70c67ddcfc19994c254a8efcd0fd3d6 ?","commit_id":"396ea933780287317d70a5055080f4c3788ea0f9"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"99fa6366aa3a9a5e789bf657db2f12e0cf37fd30","unresolved":false,"context_lines":[{"line_number":443,"context_line":"        # in the cache dir."},{"line_number":444,"context_line":"        sudo chown -R $USER:$USER $cache_dir"},{"line_number":445,"context_line":""},{"line_number":446,"context_line":"        find $cache_dir -mindepth 1 -maxdepth 1 -exec cp -l {} $DEST/devstack/files/ \\;"},{"line_number":447,"context_line":"    fi"},{"line_number":448,"context_line":""},{"line_number":449,"context_line":"    # Disable detailed logging as we return to the main script"}],"source_content_type":"text/x-sh","patch_set":4,"id":"5f4e5783_8f46347c","line":446,"in_reply_to":"5f4e5783_9984460e","updated":"2017-10-11 22:40:58.000000000","message":"so previously it was \n\n- if /home/jenkins/cache/files then move it to $BASE/cache/files\n- if $BASE/cache/files, then link contents into the devstack checkout at $DEST/devstack/files\n\nBASE\u003d/opt/stack, DEST\u003d/opt/stack/new for the most part\n\nWhy are we even doing that first bit?  I think this has just carried along ever since 25ba5c9bce825106b25cf4d8a64f76a1e604a92c.  The old snapshot method was putting cache files into ~/cache/files -- but that stopped when we started using dib images.  however, to keep this bit happy, we put a link ~/cache/files -\u003e /opt/cache/files [1]\n\nnow it\u0027s\n\n- check for /opt/cache/files\n- hardlink it into $DEST/devstack/files\n\ni think i\u0027m convinced ... \n\n[1] https://review.openstack.org/#/c/509116/1/nodepool/elements/jenkins-slave/install.d/20-jenkins-slave","commit_id":"396ea933780287317d70a5055080f4c3788ea0f9"}]}