)]}'
{"functions.sh":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"ad31e5e9220ae39cc4440b2c877da5706e64548c","unresolved":false,"context_lines":[{"line_number":516,"context_line":"            sudo cat .stestr/tmp* \u003e\u003e $WORKSPACE/tempest.subunit"},{"line_number":517,"context_line":"            archive_test_artifact $WORKSPACE/tempest.subunit"},{"line_number":518,"context_line":"        elif [ -f \".stestr/0\" ] ; then"},{"line_number":519,"context_line":"            sudo stestr last --subunit \u003e ./tempest.subunit"},{"line_number":520,"context_line":"        fi"},{"line_number":521,"context_line":"    else"},{"line_number":522,"context_line":"        if [ ! -d \".testrepository\" ] ; then"}],"source_content_type":"text/x-sh","patch_set":1,"id":"df87a7cf_32640322","line":519,"updated":"2017-12-19 08:42:38.000000000","message":"This should be $WORKSPACE/tempest.subunit ?","commit_id":"7afa8349bbc7db381e1fef9c93c85d1ee603e4b0"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"31eaad5a5057429525a96c3475787df66c7732e3","unresolved":false,"context_lines":[{"line_number":516,"context_line":"            sudo cat .stestr/tmp* \u003e\u003e $WORKSPACE/tempest.subunit"},{"line_number":517,"context_line":"            archive_test_artifact $WORKSPACE/tempest.subunit"},{"line_number":518,"context_line":"        elif [ -f \".stestr/0\" ] ; then"},{"line_number":519,"context_line":"            sudo stestr last --subunit \u003e ./tempest.subunit"},{"line_number":520,"context_line":"        fi"},{"line_number":521,"context_line":"    else"},{"line_number":522,"context_line":"        if [ ! -d \".testrepository\" ] ; then"}],"source_content_type":"text/x-sh","patch_set":1,"id":"df87a7cf_d6d021fa","line":519,"in_reply_to":"df87a7cf_32640322","updated":"2017-12-19 15:21:10.000000000","message":"Yep, good catch","commit_id":"7afa8349bbc7db381e1fef9c93c85d1ee603e4b0"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"611eeac228694a1d9fb0ec2153952d9a2a585993","unresolved":false,"context_lines":[{"line_number":526,"context_line":"        # Check for an interrupted run first because 0 will always exist"},{"line_number":527,"context_line":"        if [ -f .testrepository/tmp* ]; then"},{"line_number":528,"context_line":"            # If testr timed out, collect temp file from testr"},{"line_number":529,"context_line":"            sudo cat .stestr/tmp* \u003e\u003e $WORKSPACE/tempest.subunit"},{"line_number":530,"context_line":"            archive_test_artifact $WORKSPACE/tempest.subunit"},{"line_number":531,"context_line":"        elif [ -f \".testrepository/0\" ] ; then"},{"line_number":532,"context_line":"            sudo testr last --subunit \u003e $WORKSPACE/tempest.subunit"}],"source_content_type":"text/x-sh","patch_set":1,"id":"df87a7cf_8db92e16","line":529,"updated":"2017-12-19 09:03:14.000000000","message":"This seems also to be mixed up, we are in .testrepository case here.","commit_id":"7afa8349bbc7db381e1fef9c93c85d1ee603e4b0"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"31eaad5a5057429525a96c3475787df66c7732e3","unresolved":false,"context_lines":[{"line_number":526,"context_line":"        # Check for an interrupted run first because 0 will always exist"},{"line_number":527,"context_line":"        if [ -f .testrepository/tmp* ]; then"},{"line_number":528,"context_line":"            # If testr timed out, collect temp file from testr"},{"line_number":529,"context_line":"            sudo cat .stestr/tmp* \u003e\u003e $WORKSPACE/tempest.subunit"},{"line_number":530,"context_line":"            archive_test_artifact $WORKSPACE/tempest.subunit"},{"line_number":531,"context_line":"        elif [ -f \".testrepository/0\" ] ; then"},{"line_number":532,"context_line":"            sudo testr last --subunit \u003e $WORKSPACE/tempest.subunit"}],"source_content_type":"text/x-sh","patch_set":1,"id":"df87a7cf_76bd95b5","line":529,"in_reply_to":"df87a7cf_8db92e16","updated":"2017-12-19 15:21:10.000000000","message":"Oops, yep this was sloppy copy and paste.","commit_id":"7afa8349bbc7db381e1fef9c93c85d1ee603e4b0"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"ad31e5e9220ae39cc4440b2c877da5706e64548c","unresolved":false,"context_lines":[{"line_number":539,"context_line":"            sudo cat $WORKSPACE/tempest.subunit \\"},{"line_number":540,"context_line":"                | sudo tee -a $log_path/testrepository.subunit \u003e /dev/null"},{"line_number":541,"context_line":"        fi"},{"line_number":542,"context_line":"        sudo /usr/os-testr-env/bin/subunit2html \\"},{"line_number":543,"context_line":"            $log_path/testrepository.subunit $log_path/testr_results.html"},{"line_number":544,"context_line":"        archive_test_artifact $log_path/testrepository.subunit"},{"line_number":545,"context_line":"        archive_test_artifact $log_path/testr_results.html"}],"source_content_type":"text/x-sh","patch_set":1,"id":"df87a7cf_526987f6","line":542,"updated":"2017-12-19 08:42:38.000000000","message":"We may need to fork or re-implement subunit2html command if we obsolute os-testr?","commit_id":"7afa8349bbc7db381e1fef9c93c85d1ee603e4b0"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"9b6e845c33412ebc33a237405df766e576cef652","unresolved":false,"context_lines":[{"line_number":539,"context_line":"            sudo cat $WORKSPACE/tempest.subunit \\"},{"line_number":540,"context_line":"                | sudo tee -a $log_path/testrepository.subunit \u003e /dev/null"},{"line_number":541,"context_line":"        fi"},{"line_number":542,"context_line":"        sudo /usr/os-testr-env/bin/subunit2html \\"},{"line_number":543,"context_line":"            $log_path/testrepository.subunit $log_path/testr_results.html"},{"line_number":544,"context_line":"        archive_test_artifact $log_path/testrepository.subunit"},{"line_number":545,"context_line":"        archive_test_artifact $log_path/testr_results.html"}],"source_content_type":"text/x-sh","patch_set":1,"id":"df87a7cf_a4475a77","line":542,"in_reply_to":"df87a7cf_16952932","updated":"2017-12-20 01:20:11.000000000","message":"Currently, no problem.\nBut I was thinking that os-testr might be going to be deprecated in the future. Because stestr can replace os-testr except subunit2html (or the other commands). Am I misunderstanding?","commit_id":"7afa8349bbc7db381e1fef9c93c85d1ee603e4b0"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"31eaad5a5057429525a96c3475787df66c7732e3","unresolved":false,"context_lines":[{"line_number":539,"context_line":"            sudo cat $WORKSPACE/tempest.subunit \\"},{"line_number":540,"context_line":"                | sudo tee -a $log_path/testrepository.subunit \u003e /dev/null"},{"line_number":541,"context_line":"        fi"},{"line_number":542,"context_line":"        sudo /usr/os-testr-env/bin/subunit2html \\"},{"line_number":543,"context_line":"            $log_path/testrepository.subunit $log_path/testr_results.html"},{"line_number":544,"context_line":"        archive_test_artifact $log_path/testrepository.subunit"},{"line_number":545,"context_line":"        archive_test_artifact $log_path/testr_results.html"}],"source_content_type":"text/x-sh","patch_set":1,"id":"df87a7cf_16952932","line":542,"in_reply_to":"df87a7cf_526987f6","updated":"2017-12-19 15:21:10.000000000","message":"os-testr (and this venv) gets installed on the image by nodepool: http://git.openstack.org/cgit/openstack-infra/project-config/tree/nodepool/elements/nodepool-base/install.d/91-venv-os-testr there isn\u0027t any reason we need to do anything else. What is going to change here?","commit_id":"7afa8349bbc7db381e1fef9c93c85d1ee603e4b0"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"4e37a5aaa5dda74e835ebb5461881fe2d57a3398","unresolved":false,"context_lines":[{"line_number":539,"context_line":"            sudo cat $WORKSPACE/tempest.subunit \\"},{"line_number":540,"context_line":"                | sudo tee -a $log_path/testrepository.subunit \u003e /dev/null"},{"line_number":541,"context_line":"        fi"},{"line_number":542,"context_line":"        sudo /usr/os-testr-env/bin/subunit2html \\"},{"line_number":543,"context_line":"            $log_path/testrepository.subunit $log_path/testr_results.html"},{"line_number":544,"context_line":"        archive_test_artifact $log_path/testrepository.subunit"},{"line_number":545,"context_line":"        archive_test_artifact $log_path/testr_results.html"}],"source_content_type":"text/x-sh","patch_set":1,"id":"df87a7cf_8fa6ef0e","line":542,"in_reply_to":"df87a7cf_a4475a77","updated":"2017-12-20 01:28:19.000000000","message":"os-testr will always be around. What we\u0027ve discussed deprecating is the ostestr command, which is only one of the binaries packaged in the os-testr package. I suck at naming things :/","commit_id":"7afa8349bbc7db381e1fef9c93c85d1ee603e4b0"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"3d4f0d93d239b2fb03669b6b087dcc9d57883e67","unresolved":false,"context_lines":[{"line_number":571,"context_line":"    cp -r $stackviz_path/share/stackviz-html $log_path/stackviz"},{"line_number":572,"context_line":""},{"line_number":573,"context_line":"    pushd $project_path"},{"line_number":574,"context_line":"    if [ -f $log_path/dstat-csv_log.txt ]; then"},{"line_number":575,"context_line":"        sudo testr last --subunit | $stackviz_path/bin/stackviz-export \\"},{"line_number":576,"context_line":"            --dstat $log_path/dstat-csv_log.txt \\"},{"line_number":577,"context_line":"            --env --stdin \\"},{"line_number":578,"context_line":"            $log_path/stackviz/data"},{"line_number":579,"context_line":"    else"},{"line_number":580,"context_line":"        sudo testr last --subunit | $stackviz_path/bin/stackviz-export \\"},{"line_number":581,"context_line":"            --env --stdin \\"},{"line_number":582,"context_line":"            $log_path/stackviz/data"},{"line_number":583,"context_line":"    fi"},{"line_number":584,"context_line":"    sudo chown -R $USER:$USER $log_path/stackviz"},{"line_number":585,"context_line":"    # Compress the stackviz data as it is quite large."},{"line_number":586,"context_line":"    sudo find $log_path/stackviz -iname \u0027*.json\u0027 -execdir gzip -9 {} \\+"}],"source_content_type":"text/x-sh","patch_set":2,"id":"df87a7cf_50c96856","line":583,"range":{"start_line":574,"start_character":0,"end_line":583,"end_character":6},"updated":"2017-12-20 05:21:44.000000000","message":"I think we need to change to handle a stestr repo here, too.","commit_id":"8f4de759a33ff6848218e18ccafffcc875140b4d"}]}