)]}'
{"devstack-vm-gate-wrap.sh":[{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"e0b7e8b3a6946975228593820a0dd6c0b58e9e9d","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    fi"},{"line_number":69,"context_line":"}"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"function setup_project {"},{"line_number":72,"context_line":"    local project\u003d$1"},{"line_number":73,"context_line":"    local branch\u003d$2"},{"line_number":74,"context_line":"    local short_project\u003d`basename $project`"}],"source_content_type":"text/x-sh","patch_set":1,"id":"AAAATn%2F%2Feyo%3D","line":71,"updated":"2013-11-05 02:06:39.000000000","message":"I think a comment here would be useful - docstring like, giving definitions of the domain of the parameters.","commit_id":"38b7f283fbbdbb86fde9edbcf3fd43ba36b9c3ef"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"e0b7e8b3a6946975228593820a0dd6c0b58e9e9d","unresolved":false,"context_lines":[{"line_number":134,"context_line":"          # We\u0027re ignoring Zuul refs"},{"line_number":135,"context_line":"        git_checkout $branch"},{"line_number":136,"context_line":"    fi"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"}"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"function setup_workspace {"}],"source_content_type":"text/x-sh","patch_set":1,"id":"AAAATn%2F%2Fey0%3D","line":137,"updated":"2013-11-05 02:06:39.000000000","message":"Trailing VWS same as your other patch.","commit_id":"38b7f283fbbdbb86fde9edbcf3fd43ba36b9c3ef"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"e0b7e8b3a6946975228593820a0dd6c0b58e9e9d","unresolved":false,"context_lines":[{"line_number":161,"context_line":"    for PROJECT in $PROJECTS; do"},{"line_number":162,"context_line":"        cd $DEST"},{"line_number":163,"context_line":"        setup_project $PROJECT $base_branch"},{"line_number":164,"context_line":"        cd $DEST"},{"line_number":165,"context_line":"    done"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    # The vm template update job should cache some images in ~/files."}],"source_content_type":"text/x-sh","patch_set":1,"id":"AAAATn%2F%2Feys%3D","line":164,"updated":"2013-11-05 02:06:39.000000000","message":"This second cd could be put outside the loop (or the first one could be put outside the loop.\n\nActually though, I suggest that the setup_project function do a cd $DEST (or take $DEST as a parameter), and cd $DEST be done after loop. This will make reusing setup_project safer, as it won\u0027t have this hidden dependency.","commit_id":"38b7f283fbbdbb86fde9edbcf3fd43ba36b9c3ef"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"33a03117f35821a335aea8f01b1560a1cdd2c253","unresolved":false,"context_lines":[{"line_number":72,"context_line":"#"},{"line_number":73,"context_line":"# The basic logic flow is as follows:"},{"line_number":74,"context_line":"#   if we have ``branch`` for project, check that out"},{"line_number":75,"context_line":"#   if we don\u0027t have ``branch`` for project, changed ``branch`` to master"},{"line_number":76,"context_line":"#     and check that out"},{"line_number":77,"context_line":"#   if the global ZUUL_BRANCH matches ``branch``, then also look for a"},{"line_number":78,"context_line":"#     valid ZUUL_REF, and use that instead of the HEAD of the branch"}],"source_content_type":"text/x-sh","patch_set":2,"id":"AAAATn%2F%2FUrs%3D","line":75,"updated":"2013-11-10 22:59:06.000000000","message":"changed-\u003echange, I think.","commit_id":"eb66b1d771e74640fc7f653c27e2e23c08175a65"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"7fa0c0dc66f0569cbd4e52cb5ec96af5e9cbf5d2","unresolved":false,"context_lines":[{"line_number":72,"context_line":"#"},{"line_number":73,"context_line":"# The basic logic flow is as follows:"},{"line_number":74,"context_line":"#   if we have ``branch`` for project, check that out"},{"line_number":75,"context_line":"#   if we don\u0027t have ``branch`` for project, changed ``branch`` to master"},{"line_number":76,"context_line":"#     and check that out"},{"line_number":77,"context_line":"#   if the global ZUUL_BRANCH matches ``branch``, then also look for a"},{"line_number":78,"context_line":"#     valid ZUUL_REF, and use that instead of the HEAD of the branch"}],"source_content_type":"text/x-sh","patch_set":2,"id":"AAAATn%2F%2FUlM%3D","line":75,"in_reply_to":"AAAATn%2F%2FUrs%3D","updated":"2013-11-11 00:10:21.000000000","message":"Done","commit_id":"eb66b1d771e74640fc7f653c27e2e23c08175a65"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"33a03117f35821a335aea8f01b1560a1cdd2c253","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        cd $DEST"},{"line_number":172,"context_line":"        setup_project $PROJECT $base_branch"},{"line_number":173,"context_line":"    done"},{"line_number":174,"context_line":"    # it\u0027s imporant we are back at DEST for the rest of the script"},{"line_number":175,"context_line":"    cd $DEST"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    # The vm template update job should cache some images in ~/files."}],"source_content_type":"text/x-sh","patch_set":2,"id":"AAAATn%2F%2FUro%3D","line":174,"updated":"2013-11-10 22:59:06.000000000","message":"s/imporant/important/. My inner grammar nazi also wants it\u0027s -\u003e It\u0027s.","commit_id":"eb66b1d771e74640fc7f653c27e2e23c08175a65"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"7fa0c0dc66f0569cbd4e52cb5ec96af5e9cbf5d2","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        cd $DEST"},{"line_number":172,"context_line":"        setup_project $PROJECT $base_branch"},{"line_number":173,"context_line":"    done"},{"line_number":174,"context_line":"    # it\u0027s imporant we are back at DEST for the rest of the script"},{"line_number":175,"context_line":"    cd $DEST"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    # The vm template update job should cache some images in ~/files."}],"source_content_type":"text/x-sh","patch_set":2,"id":"AAAATn%2F%2FUlI%3D","line":174,"in_reply_to":"AAAATn%2F%2FUro%3D","updated":"2013-11-11 00:10:21.000000000","message":"Done","commit_id":"eb66b1d771e74640fc7f653c27e2e23c08175a65"}]}