)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"1184bc35825cdc50a328b31e7d696b1fd39f1688","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Arx Cruz \u003capcruz@br.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-11-12 23:16:53 -0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adding support to Fedora and Red Hat"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If you\u0027re using Fedora or Red Hat in your jenkins server,"},{"line_number":10,"context_line":"It will always fail when check the database, because"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAATn%2F%2BwgY%3D","line":7,"updated":"2013-11-20 15:49:50.000000000","message":"I might suggest the commit subject be:\n\nFedora/RHEL DB updates for devstack_gate.sh\n\nI couldn\u0027t easily distinguish this from some other reviews ATM...","commit_id":"fc326f0e8f60f6c2a7725eec12f9135f07494aef"}],"devstack-vm-gate.sh":[{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"78670dd7bb7c14bcb0ea67267d14cacb402cee3a","unresolved":false,"context_lines":[{"line_number":233,"context_line":""},{"line_number":234,"context_line":"    # provide a check that the right db was running"},{"line_number":235,"context_line":"    # provide a check that the right db was running"},{"line_number":236,"context_line":"\t# the path are different for fedora and red hat."},{"line_number":237,"context_line":"\tif which yum \u0026\u003e /dev/null; then"},{"line_number":238,"context_line":"        if [ \"$DEVSTACK_GATE_POSTGRES\" -eq \"1\" ]; then"},{"line_number":239,"context_line":"            if [ ! -d /var/lib/pgsql ]; then"}],"source_content_type":"text/x-sh","patch_set":1,"id":"AAAATn%2F%2FTUI%3D","line":236,"updated":"2013-11-11 12:26:37.000000000","message":"tabs/spaces","commit_id":"ffac98fbd28fbe07f24d6df558eab95d8e6a6d1d"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"78670dd7bb7c14bcb0ea67267d14cacb402cee3a","unresolved":false,"context_lines":[{"line_number":236,"context_line":"\t# the path are different for fedora and red hat."},{"line_number":237,"context_line":"\tif which yum \u0026\u003e /dev/null; then"},{"line_number":238,"context_line":"        if [ \"$DEVSTACK_GATE_POSTGRES\" -eq \"1\" ]; then"},{"line_number":239,"context_line":"            if [ ! -d /var/lib/pgsql ]; then"},{"line_number":240,"context_line":"                echo \"Postgresql should have been used, but there are no logs\""},{"line_number":241,"context_line":"                exit 1"},{"line_number":242,"context_line":"            fi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"AAAATn%2F%2FTTo%3D","line":239,"updated":"2013-11-11 12:26:37.000000000","message":"fedora puts its logs into /var/lib? Shame on them.","commit_id":"ffac98fbd28fbe07f24d6df558eab95d8e6a6d1d"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"dd227d987a035860f27dc17a351a4fc4e6f0c93d","unresolved":false,"context_lines":[{"line_number":232,"context_line":"    sudo -H -u stack ./stack.sh"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"    # provide a check that the right db was running"},{"line_number":235,"context_line":"\t# the path are different for fedora and red hat."},{"line_number":236,"context_line":"    if which yum \u0026\u003e /dev/null; then"},{"line_number":237,"context_line":"        POSTGRES_LOG_PATH\u003d\"-d /var/lib/pgsql\""},{"line_number":238,"context_line":"        MYSQL_LOG_PATH\u003d\"-f /var/lib/mysqld.log\""}],"source_content_type":"text/x-sh","patch_set":2,"id":"AAAATn%2F%2FM3w%3D","line":235,"updated":"2013-11-13 01:04:58.000000000","message":"You have a tab rather than spaces here.","commit_id":"d9978c2fe8274cde590789cd4e656af4a53d0b89"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"dd227d987a035860f27dc17a351a4fc4e6f0c93d","unresolved":false,"context_lines":[{"line_number":236,"context_line":"    if which yum \u0026\u003e /dev/null; then"},{"line_number":237,"context_line":"        POSTGRES_LOG_PATH\u003d\"-d /var/lib/pgsql\""},{"line_number":238,"context_line":"        MYSQL_LOG_PATH\u003d\"-f /var/lib/mysqld.log\""},{"line_number":239,"context_line":"\telse"},{"line_number":240,"context_line":"        POSTGRES_LOG_PATH\u003d\"-d /var/log/postgresql\""},{"line_number":241,"context_line":"        MYSQL_LOG_PATH\u003d\"-d /var/log/mysql\""},{"line_number":242,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":2,"id":"AAAATn%2F%2FM3s%3D","line":239,"updated":"2013-11-13 01:04:58.000000000","message":"And here.","commit_id":"d9978c2fe8274cde590789cd4e656af4a53d0b89"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"1184bc35825cdc50a328b31e7d696b1fd39f1688","unresolved":false,"context_lines":[{"line_number":233,"context_line":""},{"line_number":234,"context_line":"    # provide a check that the right db was running"},{"line_number":235,"context_line":"    # the path are different for fedora and red hat."},{"line_number":236,"context_line":"    if which yum \u0026\u003e /dev/null; then"},{"line_number":237,"context_line":"        POSTGRES_LOG_PATH\u003d\"-d /var/lib/pgsql\""},{"line_number":238,"context_line":"        MYSQL_LOG_PATH\u003d\"-f /var/lib/mysqld.log\""},{"line_number":239,"context_line":"    else"}],"source_content_type":"text/x-sh","patch_set":3,"id":"AAAATn%2F%2Bwhg%3D","line":236,"updated":"2013-11-20 15:49:50.000000000","message":"I\u0027m not the biggest fan of using \u0027which\u0027 here. Mainly because which is an extra package that has to be installed, etc. It usually is but why depend on it when you can do it w/ native bash. Can we just use something like:\n\nif [ -f /usr/bin/rpm]; then\n\ninstead?","commit_id":"fc326f0e8f60f6c2a7725eec12f9135f07494aef"}]}