)]}'
{"devstack-vm-gate.sh":[{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"b05e65bcfa37ffb99697de70b1a60dc973152b8e","unresolved":false,"context_lines":[{"line_number":146,"context_line":"disable_service rabbit"},{"line_number":147,"context_line":"enable_service qpid"},{"line_number":148,"context_line":"EOF"},{"line_number":149,"context_line":"    fi"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    if [ \"$DEVSTACK_GATE_VIRT_DRIVER\" \u003d\u003d \"openvz\" ]; then"},{"line_number":152,"context_line":"        echo \"SKIP_EXERCISES\u003d${SKIP_EXERCISES},volumes\" \u003e\u003elocalrc"}],"source_content_type":"text/x-sh","patch_set":1,"id":"AAAATn%2F%2FRb4%3D","line":149,"updated":"2013-11-11 23:09:54.000000000","message":"This is the wrong approach - see the DEVSTACK_GATE_VIRT_DRIVER pattern instead. The ZEROMQ check doesn\u0027t scale beyond one binary check. So this needs to be two patches:\n\n - add DEVSTACK_GATE_MQ_DRIVER with support for rabbit and zeromq, keeping DEVSTACK_GATE_ZEROMQ for backwards compat\n\n - then add qpid support to that","commit_id":"419e82e0414f3d223267addf19f59a34a6f9c3f0"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"25c868d228c701508a8fa60253a91fb6557be04a","unresolved":false,"context_lines":[{"line_number":134,"context_line":"EOF"},{"line_number":135,"context_line":"    fi"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    if [ \"$DEVSTACK_GATE_ZEROMQ\" -eq \"1\" ]; then"},{"line_number":138,"context_line":"        cat \u003c\u003c\\EOF \u003e\u003elocalrc"},{"line_number":139,"context_line":"disable_service rabbit"},{"line_number":140,"context_line":"enable_service zeromq"}],"source_content_type":"text/x-sh","patch_set":2,"id":"AAAATn%2F%2FM4A%3D","line":137,"updated":"2013-11-13 01:03:38.000000000","message":"how about setting DEVSTACK_GATE_MQ_DRIVER\u003d\"zeromq\" here.","commit_id":"055222585a7e1487f3cdb47a9dbc64d2bc89aa2b"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"25c868d228c701508a8fa60253a91fb6557be04a","unresolved":false,"context_lines":[{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    if [ \"$DEVSTACK_GATE_MQ_DRIVER\" \u003d\u003d \"zeromq\" ]; then"},{"line_number":145,"context_line":"        # Do nothing if DEVSTACK_GATE_ZEROMQ is set"},{"line_number":146,"context_line":"        if [ ! \"$DEVSTACK_GATE_ZEROMQ\" -eq \"1\" ]; then"},{"line_number":147,"context_line":"            echo \"disable_service rabbit\" \u003e\u003elocalrc"},{"line_number":148,"context_line":"            echo \"enable_service qpid\" \u003e\u003elocalrc"},{"line_number":149,"context_line":"        fi"}],"source_content_type":"text/x-sh","patch_set":2,"id":"AAAATn%2F%2FM38%3D","line":146,"updated":"2013-11-13 01:03:38.000000000","message":"And then we don\u0027t need this extra if test.","commit_id":"055222585a7e1487f3cdb47a9dbc64d2bc89aa2b"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"ba01a8282613181d36434c497a4c085875a48ddd","unresolved":false,"context_lines":[{"line_number":134,"context_line":"EOF"},{"line_number":135,"context_line":"    fi"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    # We are replacing DEVSTACK_GATE_ZEROMQ for "},{"line_number":138,"context_line":"    # DEVSTACL_GATE_MQ_DRIVER in order to have more"},{"line_number":139,"context_line":"    # flexibility in choosing a MQ driver."},{"line_number":140,"context_line":"    # After this change, in Jenkins Job Builder you"}],"source_content_type":"text/x-sh","patch_set":7,"id":"AAAATn%2F9rCM%3D","line":137,"updated":"2013-12-08 21:15:58.000000000","message":"Trailing whitespace.","commit_id":"53263d24e92098f8ae1d888f76111d6f9513762d"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"ba01a8282613181d36434c497a4c085875a48ddd","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    fi"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    # We are replacing DEVSTACK_GATE_ZEROMQ for "},{"line_number":138,"context_line":"    # DEVSTACL_GATE_MQ_DRIVER in order to have more"},{"line_number":139,"context_line":"    # flexibility in choosing a MQ driver."},{"line_number":140,"context_line":"    # After this change, in Jenkins Job Builder you"},{"line_number":141,"context_line":"    # no longer set 1 to DEVSTACK_GATE_ZEROMQ, instead"}],"source_content_type":"text/x-sh","patch_set":7,"id":"AAAATn%2F9rCI%3D","line":138,"updated":"2013-12-08 21:15:58.000000000","message":"Typo L instead of K.","commit_id":"53263d24e92098f8ae1d888f76111d6f9513762d"}]}