)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"98e7660f3c24d8d90d02029d4f341caa43faeb4f","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This would act as a fail-safe mecanism that avoid creation"},{"line_number":10,"context_line":"of conflicts when doing pip install. It would prevent"},{"line_number":11,"context_line":"running broken builds that fail in random places for reasons like"},{"line_number":12,"context_line":"downgrading ansible to a version that is not supported by"},{"line_number":13,"context_line":"other components (exampel tripleo)."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Pip check was added in pip 10.0 so we asure that we have a recent"},{"line_number":16,"context_line":"version before running check command."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_23205bf7","line":13,"range":{"start_line":11,"start_character":53,"end_line":13,"end_character":34},"updated":"2018-09-03 18:17:49.000000000","message":"Note the virtualenv used by devstack-gate here is intended for use only by devstack gate and should not affect tripleo or anyone else\u0027s use of ansible.","commit_id":"57b7f7e6aa65d3ecddf954f3d00a3c7053f1b7a4"}],"devstack-vm-gate-wrap.sh":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"98e7660f3c24d8d90d02029d4f341caa43faeb4f","unresolved":false,"context_lines":[{"line_number":472,"context_line":"virtualenv /tmp/ansible"},{"line_number":473,"context_line":"# Explicitly install pbr first as this will use pip rather than"},{"line_number":474,"context_line":"# easy_install. Hope is this is generally more reliable."},{"line_number":475,"context_line":"/tmp/ansible/bin/pip install pbr \u0027pip\u003e\u003d10.0\u0027"},{"line_number":476,"context_line":"/tmp/ansible/bin/pip install ansible\u003d\u003d$ANSIBLE_VERSION \\"},{"line_number":477,"context_line":"                     devstack-tools\u003d\u003d$DSTOOLS_VERSION ara \u0027cmd2\u003c0.9.0\u0027"},{"line_number":478,"context_line":"# fail-fast if pip install introduced package conflicts to prevent regressions"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3f79a3b5_e377c307","line":475,"range":{"start_line":475,"start_character":33,"end_line":475,"end_character":44},"updated":"2018-09-03 18:17:49.000000000","message":"This is redundant as virtualenv /tmp/ansible above will install the latest pip by default.","commit_id":"57b7f7e6aa65d3ecddf954f3d00a3c7053f1b7a4"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"98e7660f3c24d8d90d02029d4f341caa43faeb4f","unresolved":false,"context_lines":[{"line_number":476,"context_line":"/tmp/ansible/bin/pip install ansible\u003d\u003d$ANSIBLE_VERSION \\"},{"line_number":477,"context_line":"                     devstack-tools\u003d\u003d$DSTOOLS_VERSION ara \u0027cmd2\u003c0.9.0\u0027"},{"line_number":478,"context_line":"# fail-fast if pip install introduced package conflicts to prevent regressions"},{"line_number":479,"context_line":"/tmp/ansible/bin/pip check"},{"line_number":480,"context_line":"export ANSIBLE\u003d/tmp/ansible/bin/ansible"},{"line_number":481,"context_line":"export ANSIBLE_PLAYBOOK\u003d/tmp/ansible/bin/ansible-playbook"},{"line_number":482,"context_line":"export ANSIBLE_CONFIG\u003d\"$WORKSPACE/ansible.cfg\""}],"source_content_type":"text/x-sh","patch_set":2,"id":"3f79a3b5_c38407d6","line":479,"updated":"2018-09-03 18:17:49.000000000","message":"Isn\u0027t this redundant too? The only pip install is pbr and then ansibe, devstack-tools, and ara.\n\nPBR has no dependencies and is independent and backward compatible. The other packages are installed together so any conflicts would be found when they are installed.","commit_id":"57b7f7e6aa65d3ecddf954f3d00a3c7053f1b7a4"}]}