)]}'
{"devstack-vm-gate.sh":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"fdc63c05311c2e676096a7161e46c4956706e188","unresolved":false,"context_lines":[{"line_number":333,"context_line":"       [[ \"$DEVSTACK_GATE_TEMPEST_STRESS\" -eq \"1\" ]] ; then"},{"line_number":334,"context_line":"      exit $res"},{"line_number":335,"context_line":"    else"},{"line_number":336,"context_line":"      tools/check_logs.py -d $BASE/new/screen-logs \u0026\u0026 $res"},{"line_number":337,"context_line":"    fi"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"else"}],"source_content_type":"text/x-sh","patch_set":1,"id":"AAAATn%2F9TAU%3D","line":336,"updated":"2013-12-12 22:21:14.000000000","message":"Instead of \u0026\u0026 $res here you should remove exit $res above, make that condition a noop then put exit $res after this if else block.\n\nThe tests were failing in the check pipeline because $res is an exit code, not a command.","commit_id":"3e73a60f42c8ac033f4ab7e0402fce9fa117853b"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"34ec0e20dfb7cf5d6ae0921610fda310fe67d953","unresolved":false,"context_lines":[{"line_number":333,"context_line":"       [[ \"$DEVSTACK_GATE_TEMPEST_STRESS\" -eq \"1\" ]] ; then"},{"line_number":334,"context_line":"      exit $res"},{"line_number":335,"context_line":"    else"},{"line_number":336,"context_line":"      tools/check_logs.py -d $BASE/new/screen-logs \u0026\u0026 $res"},{"line_number":337,"context_line":"    fi"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"else"}],"source_content_type":"text/x-sh","patch_set":1,"id":"AAAATn%2F9S4g%3D","line":336,"in_reply_to":"AAAATn%2F9TAU%3D","updated":"2013-12-12 22:52:21.000000000","message":"Replace this if else block with:\n\n  if [[ \"$LOCALRC_BRANCH\" !\u003d \"stable/grizzly\" ]] || \\\n     [[ \"$DEVSTACK_GATE_TEMPEST_STRESS\" !\u003d\"1\" ]] ; then\n    tools/check_logs.py -d $BASE/new/screen-logs\n  fi\n  exit $res","commit_id":"3e73a60f42c8ac033f4ab7e0402fce9fa117853b"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"5418b737c48d50f2f4f2e44e0c49efd177ac2fc1","unresolved":false,"context_lines":[{"line_number":331,"context_line":""},{"line_number":332,"context_line":"    if [[ \"$LOCALRC_BRANCH\" !\u003d \"stable/grizzly\" ]] || \\"},{"line_number":333,"context_line":"       [[ \"$DEVSTACK_GATE_TEMPEST_STRESS\" !\u003d \"1\" ]] ; then"},{"line_number":334,"context_line":"      tools/check_logs.py -d $BASE/new/screen-logs"},{"line_number":335,"context_line":"    fi"},{"line_number":336,"context_line":"    exit $res"},{"line_number":337,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"AAAATn%2F9Szs%3D","line":334,"updated":"2013-12-12 23:14:43.000000000","message":"res2\u003d$? here","commit_id":"c5f1b84f26660165215688e7e36505e9d539f372"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"5418b737c48d50f2f4f2e44e0c49efd177ac2fc1","unresolved":false,"context_lines":[{"line_number":333,"context_line":"       [[ \"$DEVSTACK_GATE_TEMPEST_STRESS\" !\u003d \"1\" ]] ; then"},{"line_number":334,"context_line":"      tools/check_logs.py -d $BASE/new/screen-logs"},{"line_number":335,"context_line":"    fi"},{"line_number":336,"context_line":"    exit $res"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"else"},{"line_number":339,"context_line":"    # Jenkins expects at least one nosetests file.  If we\u0027re not running"}],"source_content_type":"text/x-sh","patch_set":2,"id":"AAAATn%2F9Szk%3D","line":336,"updated":"2013-12-12 23:14:43.000000000","message":"[ \"$res\" -eq \"0\" ] \u0026\u0026 [ \"$res2\" -eq \"0\" ]\nexit $?\nhere","commit_id":"c5f1b84f26660165215688e7e36505e9d539f372"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"ec6db2da5672283e5b684fdcc393b6600dc9617a","unresolved":false,"context_lines":[{"line_number":340,"context_line":"    else"},{"line_number":341,"context_line":"        exit $res"},{"line_number":342,"context_line":"    fi"},{"line_number":343,"context_line":"fi"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"else"},{"line_number":346,"context_line":"    # Jenkins expects at least one nosetests file.  If we\u0027re not running"}],"source_content_type":"text/x-sh","patch_set":3,"id":"AAAATn%2F9Gkw%3D","line":343,"updated":"2013-12-16 19:16:12.000000000","message":"It looks like you\u0027re adding a \u0027fi\u0027 here.","commit_id":"640df8009163d13c8eba82a147cffdebf7d975d4"}]}