)]}'
{"functions.sh":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"2849f8822894b66745142698043597b5b0204349","unresolved":false,"context_lines":[{"line_number":488,"context_line":"    cd $DEST"},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"    # Copy the cache files to where devstack expects."},{"line_number":491,"context_line":"    # Use hardlinks to save space."},{"line_number":492,"context_line":"    # Protect with if [ -d $cache_dir ] in case there are 3rd parties using"},{"line_number":493,"context_line":"    # devstack-gate without cache dirs"},{"line_number":494,"context_line":"    if [ -d $cache_dir ]; then"}],"source_content_type":"text/x-sh","patch_set":1,"id":"dfd5e7cf_9ca2044b","line":491,"range":{"start_line":491,"start_character":6,"end_line":491,"end_character":34},"updated":"2019-01-09 19:30:22.000000000","message":"This comment is not accurate.","commit_id":"9f1bccb2a6304061f22c5ad0f71085aa71613ea4"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"4916b2cbd72e3596cb638f5e04b2cf37938d2655","unresolved":false,"context_lines":[{"line_number":488,"context_line":"    cd $DEST"},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"    # Copy the cache files to where devstack expects."},{"line_number":491,"context_line":"    # Use hardlinks to save space."},{"line_number":492,"context_line":"    # Protect with if [ -d $cache_dir ] in case there are 3rd parties using"},{"line_number":493,"context_line":"    # devstack-gate without cache dirs"},{"line_number":494,"context_line":"    if [ -d $cache_dir ]; then"}],"source_content_type":"text/x-sh","patch_set":1,"id":"9fdfeff1_a706c31f","line":491,"range":{"start_line":491,"start_character":6,"end_line":491,"end_character":34},"in_reply_to":"dfd5e7cf_9ca2044b","updated":"2019-02-08 17:53:16.000000000","message":"Done","commit_id":"9f1bccb2a6304061f22c5ad0f71085aa71613ea4"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"2849f8822894b66745142698043597b5b0204349","unresolved":false,"context_lines":[{"line_number":492,"context_line":"    # Protect with if [ -d $cache_dir ] in case there are 3rd parties using"},{"line_number":493,"context_line":"    # devstack-gate without cache dirs"},{"line_number":494,"context_line":"    if [ -d $cache_dir ]; then"},{"line_number":495,"context_line":"        # We\u0027re making hardlinks - so we need to be able to write to the files"},{"line_number":496,"context_line":"        # in the cache dir."},{"line_number":497,"context_line":"        sudo chown -R $USER:$USER $cache_dir"},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"        find $cache_dir -mindepth 1 -maxdepth 1 -exec cp --reflink\u003dauto {} $DEST/devstack/files/ \\;"},{"line_number":500,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"dfd5e7cf_1c8e14d0","line":497,"range":{"start_line":495,"start_character":8,"end_line":497,"end_character":44},"updated":"2019-01-09 19:30:22.000000000","message":"Is this still necessary with --reflink\u003dauto? At the very least I think the comment is wrong. The cp should only need read perms for reflinking?\n\nI think we should update the comment if we still need the chown for read perms and remove this entirely if we don\u0027t need the chown.","commit_id":"9f1bccb2a6304061f22c5ad0f71085aa71613ea4"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"4916b2cbd72e3596cb638f5e04b2cf37938d2655","unresolved":false,"context_lines":[{"line_number":492,"context_line":"    # Protect with if [ -d $cache_dir ] in case there are 3rd parties using"},{"line_number":493,"context_line":"    # devstack-gate without cache dirs"},{"line_number":494,"context_line":"    if [ -d $cache_dir ]; then"},{"line_number":495,"context_line":"        # We\u0027re making hardlinks - so we need to be able to write to the files"},{"line_number":496,"context_line":"        # in the cache dir."},{"line_number":497,"context_line":"        sudo chown -R $USER:$USER $cache_dir"},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"        find $cache_dir -mindepth 1 -maxdepth 1 -exec cp --reflink\u003dauto {} $DEST/devstack/files/ \\;"},{"line_number":500,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"9fdfeff1_43026a0b","line":497,"range":{"start_line":495,"start_character":8,"end_line":497,"end_character":44},"in_reply_to":"dfd5e7cf_1c8e14d0","updated":"2019-02-08 17:53:16.000000000","message":"Done","commit_id":"9f1bccb2a6304061f22c5ad0f71085aa71613ea4"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"0e0e872eb24dee4e5c29104c852d0d7556ed514a","unresolved":false,"context_lines":[{"line_number":493,"context_line":"    if [ -d $cache_dir ]; then"},{"line_number":494,"context_line":"        # so we need to be able to write to the files in the cache dir."},{"line_number":495,"context_line":"        sudo chown -R $USER:$USER $cache_dir"},{"line_number":496,"context_line":"        find $cache_dir -mindepth 1 -maxdepth 1 -exec cp --reflink\u003dauto {} $DEST/devstack/files/ \\;"},{"line_number":497,"context_line":"    fi"},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"    # Disable detailed logging as we return to the main script"}],"source_content_type":"text/x-sh","patch_set":2,"id":"9fdfeff1_5677793b","line":496,"updated":"2019-02-11 03:05:56.000000000","message":"I mentioned this on Ib42e08a2656ccbee780d15948a0390d9ab4ffc89  but reflink doesn\u0027t do anything on ext4.  this is now copying the entire openstack repo cache, which is what the hardlink was avoiding","commit_id":"9f3ac998702951c0b4f3f32b026a2b189ecbcc9e"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"abba8182707292abc7dfb589fa34cc0f0e8b6723","unresolved":false,"context_lines":[{"line_number":493,"context_line":"    if [ -d $cache_dir ]; then"},{"line_number":494,"context_line":"        # so we need to be able to write to the files in the cache dir."},{"line_number":495,"context_line":"        sudo chown -R $USER:$USER $cache_dir"},{"line_number":496,"context_line":"        find $cache_dir -mindepth 1 -maxdepth 1 -exec cp --reflink\u003dauto {} $DEST/devstack/files/ \\;"},{"line_number":497,"context_line":"    fi"},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"    # Disable detailed logging as we return to the main script"}],"source_content_type":"text/x-sh","patch_set":2,"id":"9fdfeff1_3ee407ac","line":496,"in_reply_to":"9fdfeff1_5677793b","updated":"2019-02-11 12:44:56.000000000","message":"I agree with you on that aspect. Someone suggested me somethign like \u0027cp --reflink\u003dalways | cp -l\u0027 approach.\n\nStill, due to the presence of find could make this ugly.\n\nMaybe you know a way to detect of reflink woudl work before running find so we can use reflink when is available and hardlinking when not?","commit_id":"9f3ac998702951c0b4f3f32b026a2b189ecbcc9e"}]}