)]}'
{"devstack-vm-gate-wrap.sh":[{"author":{"_account_id":6786,"name":"Sergey Lukjanov","email":"me@slukjanov.name","username":"slukjanov"},"change_message_id":"a80ba3087be1b3571392dbce4d619fd12c5b71ce","unresolved":false,"context_lines":[{"line_number":337,"context_line":"    df -h\u003e $WORKSPACE/logs/df.txt"},{"line_number":338,"context_line":"    if [ `command -v dpkg` ]; then"},{"line_number":339,"context_line":"      dpkg -l\u003e $WORKSPACE/logs/dpkg-l.txt"},{"line_number":340,"context_line":"    fi"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"    pip freeze \u003e $WORKSPACE/logs/pip-freeze.txt"},{"line_number":343,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"AAAATn%2F8nnE%3D","line":340,"updated":"2013-12-24 09:01:50.000000000","message":"I think that \u0027sudo rpm -qa\u0027 could be easily added in the same manner to cover other distribs we are working with. It\u0027ll make this patch more consistent.\n\nhttp://www.cyberciti.biz/faq/howto-list-installed-rpm-package/","commit_id":"5dd6e2b30a82cc3e560a613d8e1f5580e4b84dd0"},{"author":{"_account_id":6786,"name":"Sergey Lukjanov","email":"me@slukjanov.name","username":"slukjanov"},"change_message_id":"b57c97dfc8fe6e3630d0cc19f6cb9c9d28427b04","unresolved":false,"context_lines":[{"line_number":337,"context_line":"    df -h\u003e $WORKSPACE/logs/df.txt"},{"line_number":338,"context_line":"    if [ `command -v dpkg` ]; then"},{"line_number":339,"context_line":"      dpkg -l\u003e $WORKSPACE/logs/dpkg-l.txt"},{"line_number":340,"context_line":"    fi"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"    pip freeze \u003e $WORKSPACE/logs/pip-freeze.txt"},{"line_number":343,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"AAAAT3%2F%2F%2FXc%3D","line":340,"in_reply_to":"AAAATn%2F8mGA%3D","updated":"2013-12-26 15:10:49.000000000","message":"ok, sounds reasonable","commit_id":"5dd6e2b30a82cc3e560a613d8e1f5580e4b84dd0"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"9115e56d118bc48c3c10679d00263f704cf7331c","unresolved":false,"context_lines":[{"line_number":337,"context_line":"    df -h\u003e $WORKSPACE/logs/df.txt"},{"line_number":338,"context_line":"    if [ `command -v dpkg` ]; then"},{"line_number":339,"context_line":"      dpkg -l\u003e $WORKSPACE/logs/dpkg-l.txt"},{"line_number":340,"context_line":"    fi"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"    pip freeze \u003e $WORKSPACE/logs/pip-freeze.txt"},{"line_number":343,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"AAAATn%2F8mGA%3D","line":340,"in_reply_to":"AAAATn%2F8nnE%3D","updated":"2013-12-24 16:08:18.000000000","message":"perhaps, but why? is anyone running this on rpm based systems?  Also checking if dpkg is installed isn\u0027t really enough anyway, see what devstack does.  This just makes sure things don\u0027t crash if dpkg isn\u0027t installed.  Adding in rpm logic when we don\u0027t run or test anything on rpm based systems seems a bit premature.","commit_id":"5dd6e2b30a82cc3e560a613d8e1f5580e4b84dd0"}],"functions.sh":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"f6f5987ab46c8ce80d1a9cfcad18457d78294481","unresolved":false,"context_lines":[{"line_number":369,"context_line":""},{"line_number":370,"context_line":"    sudo iptables-save \u003e $WORKSPACE/logs/iptables.txt"},{"line_number":371,"context_line":"    df -h\u003e $WORKSPACE/logs/df.txt"},{"line_number":372,"context_line":"    if [ `command -v dpkg` ]; then"},{"line_number":373,"context_line":"      dpkg -l\u003e $WORKSPACE/logs/dpkg-l.txt"},{"line_number":374,"context_line":"      gzip -9 dpkg-l.txt"},{"line_number":375,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":3,"id":"AAAAT3%2F%2F7cM%3D","line":372,"updated":"2013-12-26 22:26:34.000000000","message":"I have a slight preference for `which` instead of `command` as which should be more portable. Also, can you add an elif that checks for yum and does the equivalent command for yum outputting to a generic package list file then gzip that file?","commit_id":"fc5166db84475c276830d7adfe3f6c4a69be1f5d"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"ba87b660b595ed6638eefa9e613ad251ce7dfe0d","unresolved":false,"context_lines":[{"line_number":369,"context_line":""},{"line_number":370,"context_line":"    sudo iptables-save \u003e $WORKSPACE/logs/iptables.txt"},{"line_number":371,"context_line":"    df -h\u003e $WORKSPACE/logs/df.txt"},{"line_number":372,"context_line":"    if [ `command -v dpkg` ]; then"},{"line_number":373,"context_line":"      dpkg -l\u003e $WORKSPACE/logs/dpkg-l.txt"},{"line_number":374,"context_line":"      gzip -9 dpkg-l.txt"},{"line_number":375,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":3,"id":"AAAAT3%2F%2FzzM%3D","line":372,"in_reply_to":"AAAAT3%2F%2F1bI%3D","updated":"2013-12-31 03:09:07.000000000","message":"my bash foo is weak, is it safe to assume the dpkg path? also why is that better then command -v? I ask out of ignorance.","commit_id":"fc5166db84475c276830d7adfe3f6c4a69be1f5d"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"78ea5379b19f305a92e1ce7cce4e7a36af407537","unresolved":false,"context_lines":[{"line_number":369,"context_line":""},{"line_number":370,"context_line":"    sudo iptables-save \u003e $WORKSPACE/logs/iptables.txt"},{"line_number":371,"context_line":"    df -h\u003e $WORKSPACE/logs/df.txt"},{"line_number":372,"context_line":"    if [ `command -v dpkg` ]; then"},{"line_number":373,"context_line":"      dpkg -l\u003e $WORKSPACE/logs/dpkg-l.txt"},{"line_number":374,"context_line":"      gzip -9 dpkg-l.txt"},{"line_number":375,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":3,"id":"AAAAT3%2F%2F1bI%3D","line":372,"in_reply_to":"AAAAT3%2F%2F7Yg%3D","updated":"2013-12-30 13:46:10.000000000","message":"rpm -qa \u003e $WORKSPACE/logs/rpm-qa.txt solve the package problem.\n\nAlso, it would be better have something like if [ -f /usr/bin/dpkg ]; instead of command -v, since this is more generic and can be ported.","commit_id":"fc5166db84475c276830d7adfe3f6c4a69be1f5d"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"e21f2093160f1ff3314c376d17984a04031bfa98","unresolved":false,"context_lines":[{"line_number":369,"context_line":""},{"line_number":370,"context_line":"    sudo iptables-save \u003e $WORKSPACE/logs/iptables.txt"},{"line_number":371,"context_line":"    df -h\u003e $WORKSPACE/logs/df.txt"},{"line_number":372,"context_line":"    if [ `command -v dpkg` ]; then"},{"line_number":373,"context_line":"      dpkg -l\u003e $WORKSPACE/logs/dpkg-l.txt"},{"line_number":374,"context_line":"      gzip -9 dpkg-l.txt"},{"line_number":375,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":3,"id":"AAAAT3%2F%2F7aM%3D","line":372,"in_reply_to":"AAAAT3%2F%2F7a8%3D","updated":"2013-12-26 22:44:47.000000000","message":"For the first part I have been educated. On the second part there is active work to get fedora d-g slaves so we should support both with new platform specific code.","commit_id":"fc5166db84475c276830d7adfe3f6c4a69be1f5d"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"002747aee51a20cb67668171ac88fd194dfe74c9","unresolved":false,"context_lines":[{"line_number":369,"context_line":""},{"line_number":370,"context_line":"    sudo iptables-save \u003e $WORKSPACE/logs/iptables.txt"},{"line_number":371,"context_line":"    df -h\u003e $WORKSPACE/logs/df.txt"},{"line_number":372,"context_line":"    if [ `command -v dpkg` ]; then"},{"line_number":373,"context_line":"      dpkg -l\u003e $WORKSPACE/logs/dpkg-l.txt"},{"line_number":374,"context_line":"      gzip -9 dpkg-l.txt"},{"line_number":375,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":3,"id":"AAAAT3%2F%2F7Yg%3D","line":372,"in_reply_to":"AAAAT3%2F%2F7aM%3D","updated":"2013-12-26 23:14:05.000000000","message":"ahh didn\u0027t know that, in that case I need the specific yum command to run, as I haven\u0027t touched yum in many years","commit_id":"fc5166db84475c276830d7adfe3f6c4a69be1f5d"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"e9c1fa986928f9c08eb68b86d7b95afb32af8728","unresolved":false,"context_lines":[{"line_number":369,"context_line":""},{"line_number":370,"context_line":"    sudo iptables-save \u003e $WORKSPACE/logs/iptables.txt"},{"line_number":371,"context_line":"    df -h\u003e $WORKSPACE/logs/df.txt"},{"line_number":372,"context_line":"    if [ `command -v dpkg` ]; then"},{"line_number":373,"context_line":"      dpkg -l\u003e $WORKSPACE/logs/dpkg-l.txt"},{"line_number":374,"context_line":"      gzip -9 dpkg-l.txt"},{"line_number":375,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":3,"id":"AAAAT3%2F%2F7a8%3D","line":372,"in_reply_to":"AAAAT3%2F%2F7cM%3D","updated":"2013-12-26 22:34:54.000000000","message":"To the first part: http://stackoverflow.com/questions/592620/how-to-check-if-a-program-exists-from-a-bash-script\n\n\nTo the second part:  See my previous comments.","commit_id":"fc5166db84475c276830d7adfe3f6c4a69be1f5d"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"498a91b0bedc357f13b480f84d8df425d5cbd4de","unresolved":false,"context_lines":[{"line_number":375,"context_line":"    if [ `command -v dpkg` ]; then"},{"line_number":376,"context_line":"      dpkg -l\u003e $WORKSPACE/dpkg-l.txt"},{"line_number":377,"context_line":"      gzip -9 dpkg-l.txt"},{"line_number":378,"context_line":"      sudo mv $WORKSPACE/dpkg-l.txt $BASE/logs/"},{"line_number":379,"context_line":"    fi"},{"line_number":380,"context_line":"    if [ `command -v rpm` ]; then"},{"line_number":381,"context_line":"      rpm -qa \u003e $WORKSPACE/rpm-qa.txt"}],"source_content_type":"text/x-sh","patch_set":5,"id":"AAAAUH%2F%2BWUc%3D","line":378,"updated":"2014-01-27 19:57:32.000000000","message":"Pretty sure the gzip -9 will rename the .txt file then the mv will fail. Same issue below.","commit_id":"0a7328c406297ae90dae4c02a707788525fee826"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"6ed47c09344fdad56b9c85ff311e879d3f43a8a2","unresolved":false,"context_lines":[{"line_number":375,"context_line":"    if [ `command -v dpkg` ]; then"},{"line_number":376,"context_line":"      dpkg -l\u003e $WORKSPACE/dpkg-l.txt"},{"line_number":377,"context_line":"      gzip -9 dpkg-l.txt"},{"line_number":378,"context_line":"      sudo mv $WORKSPACE/dpkg-l.txt $BASE/logs/"},{"line_number":379,"context_line":"    fi"},{"line_number":380,"context_line":"    if [ `command -v rpm` ]; then"},{"line_number":381,"context_line":"      rpm -qa \u003e $WORKSPACE/rpm-qa.txt"}],"source_content_type":"text/x-sh","patch_set":5,"id":"AAAAUH%2F%2BWPw%3D","line":378,"in_reply_to":"AAAAUH%2F%2BWUc%3D","updated":"2014-01-27 20:09:00.000000000","message":"just confirmed.","commit_id":"0a7328c406297ae90dae4c02a707788525fee826"}]}