)]}'
{"functions.sh":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"0f8c66f6e8c59f7fa732b203b1ca13d8367d4eaf","unresolved":false,"context_lines":[{"line_number":603,"context_line":"            $log_path/stackviz/data"},{"line_number":604,"context_line":"    fi"},{"line_number":605,"context_line":"    sudo chown -R $USER:$USER $log_path/stackviz"},{"line_number":606,"context_line":"    # Compress the stackviz data as it is quite large."},{"line_number":607,"context_line":"    # sudo find $log_path/stackviz -iname \u0027*.json\u0027 -execdir gzip -9 {} \\+"},{"line_number":608,"context_line":"    popd"},{"line_number":609,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3fa7e38b_1cc5e909","line":606,"range":{"start_line":606,"start_character":19,"end_line":606,"end_character":54},"updated":"2020-02-01 09:08:02.000000000","message":"I\u0027ve removed this: as far as I see the stackviz data is unusable (in browser) if it is compressed. If we leave it uncompressed, then it shows statistics as it meant to be.","commit_id":"e682e4aedcf6c18f792e232d4677040c54573cd3"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"0f8c66f6e8c59f7fa732b203b1ca13d8367d4eaf","unresolved":false,"context_lines":[{"line_number":936,"context_line":"    ps -eo user,pid,ppid,lwp,%cpu,%mem,size,rss,cmd \u003e $BASE/logs/ps.txt"},{"line_number":937,"context_line":""},{"line_number":938,"context_line":"    # Compress all text logs"},{"line_number":939,"context_line":"    # sudo find $BASE/logs -iname \u0027*.txt\u0027 -execdir gzip -9 {} \\+"},{"line_number":940,"context_line":"    # sudo find $BASE/logs -iname \u0027*.dat\u0027 -execdir gzip -9 {} \\+"},{"line_number":941,"context_line":"    # sudo find $BASE/logs -iname \u0027*.conf\u0027 -execdir gzip -9 {} \\+"},{"line_number":942,"context_line":"    # sudo find $BASE/logs -iname \u0027*.journal\u0027 -execdir xz --threads\u003d0 {} \\+"},{"line_number":943,"context_line":""},{"line_number":944,"context_line":"    # Disable detailed logging as we return to the main script"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3fa7e38b_9cd0f9c8","line":941,"range":{"start_line":939,"start_character":0,"end_line":941,"end_character":65},"updated":"2020-02-01 09:08:02.000000000","message":"These are the main point: these all should remain browsable, so let\u0027s remove the gziping.","commit_id":"e682e4aedcf6c18f792e232d4677040c54573cd3"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"0f8c66f6e8c59f7fa732b203b1ca13d8367d4eaf","unresolved":false,"context_lines":[{"line_number":939,"context_line":"    # sudo find $BASE/logs -iname \u0027*.txt\u0027 -execdir gzip -9 {} \\+"},{"line_number":940,"context_line":"    # sudo find $BASE/logs -iname \u0027*.dat\u0027 -execdir gzip -9 {} \\+"},{"line_number":941,"context_line":"    # sudo find $BASE/logs -iname \u0027*.conf\u0027 -execdir gzip -9 {} \\+"},{"line_number":942,"context_line":"    # sudo find $BASE/logs -iname \u0027*.journal\u0027 -execdir xz --threads\u003d0 {} \\+"},{"line_number":943,"context_line":""},{"line_number":944,"context_line":"    # Disable detailed logging as we return to the main script"},{"line_number":945,"context_line":"    $xtrace"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3fa7e38b_3cdd45de","line":942,"range":{"start_line":942,"start_character":4,"end_line":942,"end_character":75},"updated":"2020-02-01 09:08:02.000000000","message":"I\u0027ve removed this as well, maybe this can be kept... However seems unnecessary to me, since devstack.journal is already compressed with xz above.","commit_id":"e682e4aedcf6c18f792e232d4677040c54573cd3"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b2b855606b52b614bdd73507eef67ff98e399d6e","unresolved":false,"context_lines":[{"line_number":603,"context_line":"    fi"},{"line_number":604,"context_line":"    sudo chown -R $USER:$USER $log_path/stackviz"},{"line_number":605,"context_line":"    # Compress the stackviz data as it is quite large."},{"line_number":606,"context_line":"    sudo find $log_path/stackviz -iname \u0027*.json\u0027 -execdir gzip -9 {} \\+"},{"line_number":607,"context_line":"    popd"},{"line_number":608,"context_line":"}"},{"line_number":609,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"3fa7e38b_e46fe8f8","side":"PARENT","line":606,"updated":"2020-02-05 08:52:35.000000000","message":"Does it also means that we will store big chunks of data uncompressed on our log servers? Or does swift do an automatic compression for us in the background?\n\nDoes it also means that when I want to download this file then I have to download it in its uncompressed format incurring a lot of extra bandwidth consumption?","commit_id":"a9b0d5ddb12493ff725048c84406a2f086b111dd"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"7cde1837688fdcd5ae503814776ef08bc9fe262e","unresolved":false,"context_lines":[{"line_number":603,"context_line":"    fi"},{"line_number":604,"context_line":"    sudo chown -R $USER:$USER $log_path/stackviz"},{"line_number":605,"context_line":"    # Compress the stackviz data as it is quite large."},{"line_number":606,"context_line":"    sudo find $log_path/stackviz -iname \u0027*.json\u0027 -execdir gzip -9 {} \\+"},{"line_number":607,"context_line":"    popd"},{"line_number":608,"context_line":"}"},{"line_number":609,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"3fa7e38b_144bd285","side":"PARENT","line":606,"in_reply_to":"3fa7e38b_e46fe8f8","updated":"2020-02-13 05:58:40.000000000","message":"Swift does automatic compression, so this should be fine from the transfer size.\n\nAlso you usually don\u0027t download these explicitly, but view them by navigating to the stackviz dir in your browser, which will then execute the html+js prepared above. This works fine for me for the job results of this patch, but fails with \"no data found\" without it, so I think this is correct indeed.","commit_id":"a9b0d5ddb12493ff725048c84406a2f086b111dd"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"7cde1837688fdcd5ae503814776ef08bc9fe262e","unresolved":false,"context_lines":[{"line_number":937,"context_line":"    sudo find $BASE/logs -iname \u0027*.txt\u0027 -execdir gzip -9 {} \\+"},{"line_number":938,"context_line":"    sudo find $BASE/logs -iname \u0027*.dat\u0027 -execdir gzip -9 {} \\+"},{"line_number":939,"context_line":"    sudo find $BASE/logs -iname \u0027*.conf\u0027 -execdir gzip -9 {} \\+"},{"line_number":940,"context_line":"    sudo find $BASE/logs -iname \u0027*.journal\u0027 -execdir xz --threads\u003d0 {} \\+"},{"line_number":941,"context_line":""},{"line_number":942,"context_line":"    # Disable detailed logging as we return to the main script"},{"line_number":943,"context_line":"    $xtrace"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3fa7e38b_d440da60","side":"PARENT","line":940,"range":{"start_line":940,"start_character":4,"end_line":940,"end_character":73},"updated":"2020-02-13 05:58:40.000000000","message":"I\u0027d leave the latter compression because .journal likely doesn\u0027t qualify as text log anyway.","commit_id":"a9b0d5ddb12493ff725048c84406a2f086b111dd"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"03fe73aab37d337dc05dc7a35610d14b9b50f180","unresolved":false,"context_lines":[{"line_number":937,"context_line":"    sudo find $BASE/logs -iname \u0027*.txt\u0027 -execdir gzip -9 {} \\+"},{"line_number":938,"context_line":"    sudo find $BASE/logs -iname \u0027*.dat\u0027 -execdir gzip -9 {} \\+"},{"line_number":939,"context_line":"    sudo find $BASE/logs -iname \u0027*.conf\u0027 -execdir gzip -9 {} \\+"},{"line_number":940,"context_line":"    sudo find $BASE/logs -iname \u0027*.journal\u0027 -execdir xz --threads\u003d0 {} \\+"},{"line_number":941,"context_line":""},{"line_number":942,"context_line":"    # Disable detailed logging as we return to the main script"},{"line_number":943,"context_line":"    $xtrace"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3fa7e38b_5d796d2d","side":"PARENT","line":940,"range":{"start_line":940,"start_character":4,"end_line":940,"end_character":73},"in_reply_to":"3fa7e38b_d440da60","updated":"2020-02-13 09:56:45.000000000","message":"Yes, I was hesitant about this, so thanks for the suggestion! Done.","commit_id":"a9b0d5ddb12493ff725048c84406a2f086b111dd"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"0f8c66f6e8c59f7fa732b203b1ca13d8367d4eaf","unresolved":false,"context_lines":[{"line_number":503,"context_line":"    $xtrace"},{"line_number":504,"context_line":"}"},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"function archive_test_artifact {"},{"line_number":507,"context_line":"    local filename\u003d$1"},{"line_number":508,"context_line":""},{"line_number":509,"context_line":"    sudo gzip -9 $filename"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3fa7e38b_fcbfad76","line":506,"range":{"start_line":506,"start_character":9,"end_line":506,"end_character":30},"updated":"2020-02-01 09:08:02.000000000","message":"This is used for compressing .subunit files and testr_results.html. I\u0027ve kept this to still compress subunit, but removed the one occurrence of archiving testr_results.html as that is better to be browsable.","commit_id":"08e0aab31e15e03d63139f61d30191fcd9a5b1f9"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"0f8c66f6e8c59f7fa732b203b1ca13d8367d4eaf","unresolved":false,"context_lines":[{"line_number":777,"context_line":"        # format locally using systemd-journal-remote. This makes a class of"},{"line_number":778,"context_line":"        # debugging much easier. We don\u0027t do the native conversion here as"},{"line_number":779,"context_line":"        # some distros do not package that tooling."},{"line_number":780,"context_line":"        sudo journalctl -u \u0027devstack@*\u0027 -o export | \\"},{"line_number":781,"context_line":"            xz --threads\u003d0 - \u003e $BASE/logs/devstack.journal.xz"},{"line_number":782,"context_line":""},{"line_number":783,"context_line":"        # The journal contains everything running under systemd, we\u0027ll"},{"line_number":784,"context_line":"        # build an old school version of the syslog with just the"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3fa7e38b_1cee498a","line":781,"range":{"start_line":780,"start_character":0,"end_line":781,"end_character":61},"updated":"2020-02-01 09:08:02.000000000","message":"Another place where journal is compressed with xz. It makes sense to keep the compression maybe.","commit_id":"08e0aab31e15e03d63139f61d30191fcd9a5b1f9"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"0f8c66f6e8c59f7fa732b203b1ca13d8367d4eaf","unresolved":false,"context_lines":[{"line_number":862,"context_line":"    save_file /etc/glusterfs/glusterd.vol glusterd.vol"},{"line_number":863,"context_line":""},{"line_number":864,"context_line":"    # gzip and save any coredumps in /var/core"},{"line_number":865,"context_line":"    if [ -d /var/core ]; then"},{"line_number":866,"context_line":"        sudo gzip -r /var/core"},{"line_number":867,"context_line":"        sudo cp -r /var/core $BASE/logs/"},{"line_number":868,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3fa7e38b_bcc93525","line":865,"updated":"2020-02-01 09:08:02.000000000","message":"IMO core dumps can be left compressed.","commit_id":"08e0aab31e15e03d63139f61d30191fcd9a5b1f9"}]}
