)]}'
{"functions.sh":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"7c04d149bbdcbc790e6c780e25f61bb05e382563","unresolved":false,"context_lines":[{"line_number":186,"context_line":"# for grenade, or an alternate branch to test client library"},{"line_number":187,"context_line":"# compatibility, then supply that as the argument instead.  This"},{"line_number":188,"context_line":"# function will try to check out the following (in order):"},{"line_number":189,"context_line":"#"},{"line_number":190,"context_line":"#   The zuul ref for the indicated branch"},{"line_number":191,"context_line":"#   The zuul ref for the master branch"},{"line_number":192,"context_line":"#   The tip of the project specific OVERRIDE_$PROJECT_BRANCH if specified"}],"source_content_type":"text/x-sh","patch_set":7,"id":"AAAAWH%2F9Nis%3D","line":189,"updated":"2014-04-07 22:30:32.000000000","message":"This should be added to the top of the list, if I\u0027m following:\n\n  The zuul ref for the project specific OVERRIDE_$PROJECT_BRANCH if specified","commit_id":"10b711e6fa795c2b8311d55b3d8685806e0afee3"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"7c04d149bbdcbc790e6c780e25f61bb05e382563","unresolved":false,"context_lines":[{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    git_remote_set_url origin https://git.openstack.org/$project"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    # allow for possible project branch override"},{"line_number":207,"context_line":"    local uc_project\u003d`echo $short_project | tr [:lower:] [:upper:] | tr \u0027-\u0027 \u0027_\u0027 | sed \u0027s/[^A-Z_]//\u0027`"},{"line_number":208,"context_line":"    local project_branch_var\u003d\"\\$OVERRIDE_${uc_project}_BRANCH\""},{"line_number":209,"context_line":"    local project_branch\u003d`eval echo ${project_branch_var}`"}],"source_content_type":"text/x-sh","patch_set":7,"id":"AAAAWH%2F9NcE%3D","line":206,"updated":"2014-04-07 22:30:32.000000000","message":"I can\u0027t believe we didn\u0027t notice this earlier, but this will collide with the already existing \"OVERRIDE_ZUUL_BRANCH\" if we ever use this script (or a derivative thereof) with Zuul itself.  We may want to find another name -- OVERRIDE_foo_PROJECT_BRANCH?","commit_id":"10b711e6fa795c2b8311d55b3d8685806e0afee3"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"cd03353d64362a50bc9e5c598c12b1ae87b3cb3e","unresolved":false,"context_lines":[{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    git_remote_set_url origin https://git.openstack.org/$project"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    # allow for possible project branch override"},{"line_number":207,"context_line":"    local uc_project\u003d`echo $short_project | tr [:lower:] [:upper:] | tr \u0027-\u0027 \u0027_\u0027 | sed \u0027s/[^A-Z_]//\u0027`"},{"line_number":208,"context_line":"    local project_branch_var\u003d\"\\$OVERRIDE_${uc_project}_BRANCH\""},{"line_number":209,"context_line":"    local project_branch\u003d`eval echo ${project_branch_var}`"}],"source_content_type":"text/x-sh","patch_set":7,"id":"AAAAWn%2F%2F%2FhA%3D","line":206,"in_reply_to":"AAAAWH%2F9NcE%3D","updated":"2014-04-08 02:37:59.000000000","message":"Oh, yikes, this is undeniably true.","commit_id":"10b711e6fa795c2b8311d55b3d8685806e0afee3"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"ca7dae2813d42f82ca6064b3cb3ab58eeb6c727f","unresolved":false,"context_lines":[{"line_number":186,"context_line":"# for grenade, or an alternate branch to test client library"},{"line_number":187,"context_line":"# compatibility, then supply that as the argument instead.  This"},{"line_number":188,"context_line":"# function will try to check out the following (in order):"},{"line_number":189,"context_line":"#"},{"line_number":190,"context_line":"#   The zuul ref for the indicated branch"},{"line_number":191,"context_line":"#   The zuul ref for the master branch"},{"line_number":192,"context_line":"#   The tip of the project specific OVERRIDE_$PROJECT_BRANCH if specified"}],"source_content_type":"text/x-sh","patch_set":8,"id":"AAAAW3%2F%2F724%3D","line":189,"updated":"2014-04-09 11:40:15.000000000","message":"Add doc here.","commit_id":"80af4fda94528a837ce23cb360540ff9d71e977b"}],"test-functions.sh":[{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"c09ec109b6dc699090610e4a04b35e97046c28e7","unresolved":false,"context_lines":[{"line_number":164,"context_line":"    # glance               stable/havana"},{"line_number":165,"context_line":"    # tempest              master"},{"line_number":166,"context_line":"    # python-glanceclient  master         ZC"},{"line_number":167,"context_line":"    # oslo.config        master"},{"line_number":168,"context_line":"    echo \"\u003d\u003d Test multi branch project override\""},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    declare -A TEST_GIT_CHECKOUTS"}],"source_content_type":"text/x-sh","patch_set":6,"id":"AAAAWH%2F9PN8%3D","line":167,"updated":"2014-04-07 18:40:26.000000000","message":"The comments here don\u0027t really line up with the way the other tests are constructed, making me think maybe this isn\u0027t testing quite what you intended to test... the usual scenario we describe is a series of changes in a Zuul dependent pipeline, listed in order by their project, target branch and position in the queue. In this case it\u0027s unclear to me which queue positions correspond to the changes for glance:stable/havana, tempest:master and oslo.config:master.","commit_id":"e2ddc91367f2c382e632de5cbec7c092c36eaaa3"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"899b50cc8a838765742a08a2e1f3d353a32e151b","unresolved":false,"context_lines":[{"line_number":164,"context_line":"    # glance               stable/havana"},{"line_number":165,"context_line":"    # tempest              master"},{"line_number":166,"context_line":"    # python-glanceclient  master         ZC"},{"line_number":167,"context_line":"    # oslo.config        master"},{"line_number":168,"context_line":"    echo \"\u003d\u003d Test multi branch project override\""},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    declare -A TEST_GIT_CHECKOUTS"}],"source_content_type":"text/x-sh","patch_set":6,"id":"AAAAWH%2F9OTA%3D","line":167,"in_reply_to":"AAAAWH%2F9Oro%3D","updated":"2014-04-07 20:47:34.000000000","message":"Right, that\u0027s what the next test below this one means with, for example, \"python-glanceclient not in queue\". So I would rewrite this as:\n\n    # Globally override branches to stable/havana but individually set\n    # nova and tempest to use master.\n    #\n    # devstack-gate        master         ZA\n    # devstack-gate        master         ZB\n    # python-glanceclient  master         ZC\n    # glance not in queue\n    # oslo.config not in queue\n    # tempest not in queue","commit_id":"e2ddc91367f2c382e632de5cbec7c092c36eaaa3"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"2a15ef50d66a783684fc0c84e1c7ceba4942184e","unresolved":false,"context_lines":[{"line_number":164,"context_line":"    # glance               stable/havana"},{"line_number":165,"context_line":"    # tempest              master"},{"line_number":166,"context_line":"    # python-glanceclient  master         ZC"},{"line_number":167,"context_line":"    # oslo.config        master"},{"line_number":168,"context_line":"    echo \"\u003d\u003d Test multi branch project override\""},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    declare -A TEST_GIT_CHECKOUTS"}],"source_content_type":"text/x-sh","patch_set":6,"id":"AAAAWH%2F9Oro%3D","line":167,"in_reply_to":"AAAAWH%2F9PN8%3D","updated":"2014-04-07 19:51:22.000000000","message":"no, they aren\u0027t queue positions, they are additional projects checked out. The point was to ensure that other targets check out at valid branches.","commit_id":"e2ddc91367f2c382e632de5cbec7c092c36eaaa3"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"7c04d149bbdcbc790e6c780e25f61bb05e382563","unresolved":false,"context_lines":[{"line_number":172,"context_line":"    declare -A TEST_GIT_CHECKOUTS"},{"line_number":173,"context_line":"    declare -A TEST_ZUUL_REFS"},{"line_number":174,"context_line":"    ZUUL_PROJECT\u003d\u0027openstack/python-glanceclient\u0027"},{"line_number":175,"context_line":"    ZUUL_BRANCH\u003d\u0027stable/havana\u0027"},{"line_number":176,"context_line":"    local OVERRIDE_TEMPEST_BRANCH\u003d\u0027master\u0027"},{"line_number":177,"context_line":"    local OVERRIDE_NOVA_BRANCH\u003d\u0027master\u0027"},{"line_number":178,"context_line":"    ZUUL_REF\u003d\u0027refs/zuul/master/ZC\u0027"}],"source_content_type":"text/x-sh","patch_set":7,"id":"AAAAWH%2F9Nf8%3D","line":175,"updated":"2014-04-07 22:30:32.000000000","message":"I don\u0027t think this test is realistic -- since the change being tested (the last in the list -- ZC) is on the master branch, ZUUL_BRANCH should be \u0027master\u0027.  You may want to put in a change for a non-master branch, or set OVERRIDE_ZUUL_BRANCH to stable/havana.  Or both.","commit_id":"10b711e6fa795c2b8311d55b3d8685806e0afee3"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"cd03353d64362a50bc9e5c598c12b1ae87b3cb3e","unresolved":false,"context_lines":[{"line_number":172,"context_line":"    declare -A TEST_GIT_CHECKOUTS"},{"line_number":173,"context_line":"    declare -A TEST_ZUUL_REFS"},{"line_number":174,"context_line":"    ZUUL_PROJECT\u003d\u0027openstack/python-glanceclient\u0027"},{"line_number":175,"context_line":"    ZUUL_BRANCH\u003d\u0027stable/havana\u0027"},{"line_number":176,"context_line":"    local OVERRIDE_TEMPEST_BRANCH\u003d\u0027master\u0027"},{"line_number":177,"context_line":"    local OVERRIDE_NOVA_BRANCH\u003d\u0027master\u0027"},{"line_number":178,"context_line":"    ZUUL_REF\u003d\u0027refs/zuul/master/ZC\u0027"}],"source_content_type":"text/x-sh","patch_set":7,"id":"AAAAWn%2F%2F%2FgU%3D","line":175,"in_reply_to":"AAAAWH%2F9Nf8%3D","updated":"2014-04-08 02:37:59.000000000","message":"Yeah, this is what I was getting at with my comments on the earlier patchset. The goal with these unit tests is to construct a scenario (series of hypothetical changes in a Zuul queue) setting variables in the ways we might set them in an actual job, and then check to see that the branches/refs we expect are actually checked out for those projects.","commit_id":"10b711e6fa795c2b8311d55b3d8685806e0afee3"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"99d910978625482eb106f2012dd84d55f2d01a44","unresolved":false,"context_lines":[{"line_number":172,"context_line":"    declare -A TEST_GIT_CHECKOUTS"},{"line_number":173,"context_line":"    declare -A TEST_ZUUL_REFS"},{"line_number":174,"context_line":"    ZUUL_PROJECT\u003d\u0027openstack/python-glanceclient\u0027"},{"line_number":175,"context_line":"    ZUUL_BRANCH\u003d\u0027stable/havana\u0027"},{"line_number":176,"context_line":"    local OVERRIDE_TEMPEST_BRANCH\u003d\u0027master\u0027"},{"line_number":177,"context_line":"    local OVERRIDE_NOVA_BRANCH\u003d\u0027master\u0027"},{"line_number":178,"context_line":"    ZUUL_REF\u003d\u0027refs/zuul/master/ZC\u0027"}],"source_content_type":"text/x-sh","patch_set":7,"id":"AAAAWn%2F%2F8vQ%3D","line":175,"in_reply_to":"AAAAWn%2F%2F%2FgU%3D","updated":"2014-04-08 09:55:41.000000000","message":"ok, I guess I\u0027m at a loss on the right test then.\n\nThe point of this test to me was to ensure that OVERRIDE worked where it should, and not in other places where it should not. Suggestions on the right matrix would be appreciated, as I\u0027m definitely not getting it via trial and error. :)","commit_id":"10b711e6fa795c2b8311d55b3d8685806e0afee3"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"ca7dae2813d42f82ca6064b3cb3ab58eeb6c727f","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            case $project in"},{"line_number":64,"context_line":"                openstack/glance) return 0 ;;"},{"line_number":65,"context_line":"                openstack/swift) return 0 ;;"},{"line_number":66,"context_line":"                openstack/nova) return 0 ;;"},{"line_number":67,"context_line":"                openstack/keystone) return 0 ;;"},{"line_number":68,"context_line":"            esac"},{"line_number":69,"context_line":"    esac"}],"source_content_type":"text/x-sh","patch_set":8,"id":"AAAAW3%2F%2F73Q%3D","line":66,"updated":"2014-04-09 11:40:15.000000000","message":"Tempest needs to be added here.","commit_id":"80af4fda94528a837ce23cb360540ff9d71e977b"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"6eb0d7295a5c445186a841f68643457d40f0090b","unresolved":false,"context_lines":[{"line_number":161,"context_line":""},{"line_number":162,"context_line":"function test_multi_branch_project_override {"},{"line_number":163,"context_line":"    # main branch is stable/havana"},{"line_number":164,"context_line":"    # devstack-gate        master         ZA"},{"line_number":165,"context_line":"    # devstack-gate        master         ZB"},{"line_number":166,"context_line":"    # python-glanceclient  master         ZC"},{"line_number":167,"context_line":"    # glance               stable/havana  ZD"}],"source_content_type":"text/x-sh","patch_set":8,"id":"AAAAWn%2F%2F5fo%3D","line":164,"updated":"2014-04-08 16:39:35.000000000","message":"This additional d-g change doesn\u0027t really bring anything to the table, so you could actually get the same results below with just three changes in the queue instead of four...","commit_id":"80af4fda94528a837ce23cb360540ff9d71e977b"}]}